D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

2019-02-04 Thread Chris Rizzitello
rizzitello added a comment. I think it looks better slightly off the edge of the item and I agree that if its on the item its looks much better with the shaded bar under it. To improve the contrast we could make the button our highlight color when hovered. REPOSITORY R296 KDeclarative RE

D17977: Improve reliability and semantic correctless of dupe test

2019-01-18 Thread Chris Rizzitello
rizzitello added a comment. Seams to function correctly. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17977 To: ngraham, #breeze, ndavis, GB_2 Cc: rizzitello, tcanabrava, kde-frameworks-devel, michaelh, ngraham, bruns

D16951: Add mouse button icons

2018-11-17 Thread Chris Rizzitello
rizzitello added a comment. I think the Mouse itself needs a bit more curve with less box. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16951 To: ndavis, #vdg Cc: rizzitello, nicolasfella, kde-frameworks-devel, michaelh, ngraham, bruns

D16395: Update the "About KDE" text

2018-10-24 Thread Chris Rizzitello
rizzitello added a comment. Why does this dialog not say anything about the version of KDE. I think here the KF5 version and maybe the Qt Version should be shown here. I always found it kinda odd that the "About Application" dialog contains this and not the About KDE dialog. REPOSITORY R2

D15213: Provide icons for 2x scaling

2018-09-06 Thread Chris Rizzitello
rizzitello closed this revision. rizzitello added a comment. landed: https://cgit.kde.org/breeze-icons.git/commit/?id=2dcc2b712a88e726f31f3a4732ba2c39c01a2bce REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D15213 To: rizzitello, #vdg, #plasma, broulik, ngraham

D15213: Provide icons for 2x scaling

2018-09-06 Thread Chris Rizzitello
rizzitello added a comment. In D15213#321121 , @ngraham wrote: > Does this mean that every new 16px, 22px, 24px, and 32px monochrome icon will need an `@2x` symlink? There will be no need for that since I have simlinked the folders using

D15213: Provide icons for 2x scaling

2018-09-03 Thread Chris Rizzitello
rizzitello retitled this revision from "Link 16px icon folders to 16@2" to "Provide icons for 2x scaling". rizzitello edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D15213 To: rizzitello, #vdg, #plasma Cc: broulik, kde-framework

D15213: Link 16px icon folders to 16@2

2018-09-03 Thread Chris Rizzitello
rizzitello updated this revision to Diff 40942. rizzitello added a comment. - Link 24 to 24@2x - Link actions/32 to actions/32@2x REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15213?vs=40941&id=40942 BRANCH 2xIcons REVISION DETAIL https://phab

D15213: Link 16px icon folders to 16@2

2018-09-03 Thread Chris Rizzitello
rizzitello updated this revision to Diff 40941. rizzitello added a comment. - Add 22@2x links REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15213?vs=40934&id=40941 BRANCH 2xIcons REVISION DETAIL https://phabricator.kde.org/D15213 AFFECTED FILES

D15213: Link 16px icon folders to 16@2

2018-09-03 Thread Chris Rizzitello
rizzitello updated this revision to Diff 40934. rizzitello added a comment. - 16@2x icons - icon.theme updated REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15213?vs=40840&id=40934 BRANCH 16@2x REVISION DETAIL https://phabricator.kde.org/D1521

D15213: Link 16px icon folders to 16@2

2018-09-02 Thread Chris Rizzitello
rizzitello added a comment. In D15213#319039 , @broulik wrote: > I think the suffix should be `@2x`, not just `@2`. Also, I don't think it's neccessary for the `animation` folder. > Anyway, without the `ScalableIcons` entry in `index.theme` te

D15213: Link 16px icon folders to 16@2

2018-09-01 Thread Chris Rizzitello
rizzitello retitled this revision from "link 16 to 16@2" to "Link 16px icon folders to 16@2". rizzitello added reviewers: VDG, Plasma. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D15213 To: rizzitello, #vdg, #plasma Cc: kde-frameworks-devel, michaelh, ngraham, b

D15213: link 16 to 16@2

2018-09-01 Thread Chris Rizzitello
rizzitello created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. rizzitello requested review of this revision. REVISION SUMMARY Create simlinks for all size 16 folders to 16@2 See D6313 Todo : add info

D15212: Create links for 16@2 icons

2018-09-01 Thread Chris Rizzitello
rizzitello abandoned this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D15212 To: rizzitello, #vdg, #plasma Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15212: Create links for 16@2 icons

2018-09-01 Thread Chris Rizzitello
rizzitello edited the summary of this revision. rizzitello added reviewers: VDG, Plasma. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D15212 To: rizzitello, #vdg, #plasma Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15212: Create links for 16@2 icons

2018-09-01 Thread Chris Rizzitello
rizzitello created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. rizzitello requested review of this revision. REVISION SUMMARY Signed-off-by: Chris Rizzitello REPOSITORY R266 Breeze Icons BRANCH 2xScaleLinks REVISION DETAIL https

D10362: Swap reveal password button logic

2018-08-01 Thread Chris Rizzitello
rizzitello added a comment. Restricted Application edited subscribers, added: kde-frameworks-devel; removed: Frameworks. In D10362#202592 , @elvisangelaccio wrote: > Would it be possible to implement this feature like in the Windows 10 lock scr

D11767: Remove Recently Saved This Month and Recently Saved Last Month entries by default

2018-03-28 Thread Chris Rizzitello
rizzitello added a comment. In D11767#235994 , @abetts wrote: > Can we just call all of those entries just "Recent" or "Recently Used" independent of when it happened? I feel that would be more clear without having to remove the feature.

D11767: Remove Recently Saved This Month and Recently Saved Last Month entries by default

2018-03-28 Thread Chris Rizzitello
rizzitello added a comment. Perhaps remove the yesterday entry and just show recently created with a link to timeline:/ ? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11767 To: ngraham, #dolphin, #gwenview, #frameworks, #vdg Cc: rizzitello, michaelh, ngraham