Re: Review Request 125289: Use Q_SLOTS/Q_SIGNALS instead of slots/signals in all headers from include dir

> On Set. 17, 2015, 4:13 p.m., Andrea Scarpino wrote: > > Inviala! And in Choqok too, thanks! (please do not consider my "Ship It" :-) - Andrea --- This is an automatically generated e-mail. To

Re: Review Request 125289: Use Q_SLOTS/Q_SIGNALS instead of slots/signals in all headers from include dir

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125289/#review85579 --- Ship it! Inviala! - Andrea Scarpino On Set. 17, 2015, 2

Re: Review Request 115620: Fix build when CMAKE_SOURCE_DIR contains spaces in its path

, Andrea Scarpino ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 115620: Fix build when CMAKE_SOURCE_DIR contains spaces in its path

: kapidox Description --- = subject Diffs - CMakeLists.txt b2e9876bb05eef29b6451d00905b331da8e7e5aa Diff: https://git.reviewboard.kde.org/r/115620/diff/ Testing --- It builds. Thanks, Andrea Scarpino ___ Kde-frameworks-devel mailing

Re: Review Request 114260: Port mouse dataengine

/dataengines/mouse/CMakeLists.txt 29cab878bd1fb514d7ac025134fbfb58a5a1376e plasma/generic/dataengines/mouse/cursornotificationhandler.h 3b571f8f5ffe6db4efeef7827acf003911bcd5dc Diff: https://git.reviewboard.kde.org/r/114260/diff/ Testing --- Builds Thanks, Andrea Scarpino

Re: Review Request 114260: Port mouse dataengine

his is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114260/#review45349 ------- On Dec. 3, 2013, 10:51 a.m., Andrea Scarpino wrote: > > ---

Re: Review Request 114253: Port favicons dataengine to KF5

ae673 Diff: http://git.reviewboard.kde.org/r/114253/diff/ Testing --- Builds. Thanks, Andrea Scarpino ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 114263: Port share dataengine to KF5

es/share/shareservice.cpp b789439 Diff: http://git.reviewboard.kde.org/r/114263/diff/ Testing (updated) --- Doesn't build. Looks like an issue with the K_EXPORT_PLASMA_PACKAGE macro. Thanks, Andrea Scarpino ___ Kde-frameworks-devel mailing list K

Re: Review Request 114253: Port favicons dataengine to KF5

Diff: http://git.reviewboard.kde.org/r/114253/diff/ Testing --- Builds. Thanks, Andrea Scarpino ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 114260: Port mouse dataengine

/cursornotificationhandler.cpp 3cb9add plasma/generic/dataengines/mouse/cursornotificationhandler.h 3b571f8 plasma/generic/dataengines/mouse/CMakeLists.txt 29cab87 plasma/generic/dataengines/CMakeLists.txt 3e94325 Diff: http://git.reviewboard.kde.org/r/114260/diff/ Testing --- Builds Thanks, Andrea

Re: Review Request 112325: Complete the migration to Q_GLOBAL_STATIC

: http://git.reviewboard.kde.org/r/112325/diff/ Testing --- Builds. Thanks, Andrea Scarpino ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112325: Complete the migration to Q_GLOBAL_STATIC

Scarpino On Aug. 31, 2013, 8:57 a.m., Andrea Scarpino wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Review Request 112325: Complete the migration to Q_GLOBAL_STATIC

migration to Q_GLOBAL_STATIC. Also, fix the build with UDisks2 enabled. Diffs - solid/solid/networking_win.cpp 4b6f498 tier1/solid/src/solid/backends/udisks2/udisksopticaldisc.cpp 5dc68a6 Diff: http://git.reviewboard.kde.org/r/112325/diff/ Testing --- Builds. Thanks, Andrea

Re: Review Request 111702: Move K4AboutData and KComponentData to kde4support

9bc246f kdecore/kernel/kcomponentdata_p.h khtml/CMakeLists.txt 157ec69 kio/misc/ksendbugmail/main.cpp cf17f00 staging/kde4support/src/CMakeLists.txt 24bcff3 Diff: http://git.reviewboard.kde.org/r/111702/diff/ Testing --- Builds. Thanks, Andrea Scarpino

Re: Review Request 111702: Move K4AboutData and KComponentData to kde4support

kdecore/kernel/kcomponentdata_p.h khtml/CMakeLists.txt 157ec69 kio/misc/ksendbugmail/CMakeLists.txt 4a16b16 staging/kde4support/src/CMakeLists.txt 24bcff3 Diff: http://git.reviewboard.kde.org/r/111702/diff/ Testing --- Builds. Thanks, Andrea Scarpino

Re: Review Request 111702: Move K4AboutData and KComponentData to kde4support

/kcomponentdata.cpp 9bc246f kdecore/kernel/kcomponentdata_p.h staging/kde4support/src/CMakeLists.txt 24bcff3 Diff: http://git.reviewboard.kde.org/r/111702/diff/ Testing --- Builds. Thanks, Andrea Scarpino ___ Kde-frameworks-devel mailing list Kde

Re: Review Request 111702: Move K4AboutData and KComponentData to kde4support

kdecore/kernel/kcomponentdata_p.h staging/kde4support/src/CMakeLists.txt 24bcff3 Diff: http://git.reviewboard.kde.org/r/111702/diff/ Testing --- Builds. Thanks, Andrea Scarpino ___ Kde-frameworks-devel mailing list Kde-frameworks

Review Request 111702: Move K4AboutData and KComponentData to kde4support

Diff: http://git.reviewboard.kde.org/r/111702/diff/ Testing --- Builds. Thanks, Andrea Scarpino ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 111651: Move KCModule to KConfigWidgets

erywhere then, or I'm wrong? - Andrea --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111651/#review36407 --- On July 23, 2013, 1

Re: Review Request 111653: Move KDEUI tests in their modules

skipped - knotificationrestrictionstest: works - krulertest: works Thanks, Andrea Scarpino ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 111653: Move KDEUI tests in their modules

- knotificationrestrictionstest: works - krulertest: works Thanks, Andrea Scarpino ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 111653: Move KDEUI tests in their modules

: - knotificationrestrictionstest: works - krulertest: works Thanks, Andrea Scarpino ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 111651: Move KCModule to KConfigWidgets

- kdeui/CMakeLists.txt ded44e3 kdeui/widgets/kcmodule.h 0d29267 kdeui/widgets/kcmodule.cpp 78e0ae5 staging/kconfigwidgets/src/CMakeLists.txt 52168ab Diff: http://git.reviewboard.kde.org/r/111651/diff/ Testing --- Builds. Thanks, Andrea Scarpino

Re: Review Request 111424: Move KRichTextWidget to KTextWidgets

/CMakeLists.txt f6d9fd2 staging/ktextwidgets/src/CMakeLists.txt d3cabb1 staging/xmlgui/tests/CMakeLists.txt b3b5667 Diff: http://git.reviewboard.kde.org/r/111424/diff/ Testing (updated) --- Builds. KRichTextEditTest pass, krichtexteditor works. Thanks, Andrea Scarpino

Re: Review Request 111080: Macro*.cmake changes

://git.reviewboard.kde.org/r/111080/diff/ Testing (updated) --- Builds. Thanks, Andrea Scarpino ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 111080: Macro*.cmake changes

33aa9df Diff: http://git.reviewboard.kde.org/r/111080/diff/ Testing --- Thanks, Andrea Scarpino ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 111424: Move KRichTextWidget to KTextWidgets

lts. Thanks, Andrea Scarpino ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 111424: Move KRichTextWidget to KTextWidgets

. KRichTextEditTest pass, krichtexteditor segfaults. Thanks, Andrea Scarpino ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 111424: Move KRichTextWidget to KTextWidgets

segfaults. Thanks, Andrea Scarpino ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 111210: Move the XMLGUI technology to xmlgui/

* tests/kwindowtest segfaults * tests/kxmlguiwindowtest segfaults * autotests/kglobalshortcuttest, 5 failed Thanks, Andrea Scarpino ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 111210: Move the XMLGUI technology to xmlgui/

Builds. * autotests/ktoolbar_unittest, 1 failed, core dumped * autotests/kxmlgui_unittest, 35 failed, core dumped * tests/kwindowtest segfaults * tests/kxmlguiwindowtest segfaults * autotests/kglobalshortcuttest, 5 failed Thanks, Andrea Scarpino ___

Re: Review Request 111210: Move the XMLGUI technology to xmlgui/

Several {auto,}tests segfaults. Thanks, Andrea Scarpino ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 111210: Move the XMLGUI technology to xmlgui/

Several {auto,}tests segfaults. Thanks, Andrea Scarpino ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 111210: Move the XMLGUI technology to xmlgui/

Several {auto,}tests segfaults. Thanks, Andrea Scarpino ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 111424: Move KRichTextWidget to KTextWidgets

/nestedlisthelper.cpp 5d2295d staging/ktextwidgets/autotests/CMakeLists.txt f6d9fd2 staging/ktextwidgets/src/CMakeLists.txt 6b3c09f staging/xmlgui/tests/CMakeLists.txt dce637f Diff: http://git.reviewboard.kde.org/r/111424/diff/ Testing --- Thanks, Andrea Scarpino

Review Request 111422: Add addActions(QList) to KActionCollection

collection now. This method simplify things by allowing to add them all with a single call. Diffs - kdeui/actions/kactioncollection.h 8ca6845 kdeui/actions/kactioncollection.cpp 7dc2987 Diff: http://git.reviewboard.kde.org/r/111422/diff/ Testing --- Thanks, Andrea Scarpino

Re: Review Request 111210: Move the XMLGUI technology to xmlgui/

avaiable and this caused the build to fail. Then I thought the "correct way" was switching to Q_D. - Andrea --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111210/#review35640 --

Re: Review Request 111210: Move the XMLGUI technology to xmlgui/

210/diff/ Testing --- Builds. Several {auto,}tests segfaults. Thanks, Andrea Scarpino ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 111210: Move the XMLGUI technology to xmlgui/

ff: http://git.reviewboard.kde.org/r/111210/diff/ Testing --- Builds. Several {auto,}tests segfaults. Thanks, Andrea Scarpino ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 111210: Move the XMLGUI technology to xmlgui/

a506ab0 staging/xmlgui/src/config-xmlgui.h.cmake 58949d8 staging/xmlgui/tests/CMakeLists.txt dce637f staging/xmlgui/tests/kxmlguitest.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/111210/diff/ Testing --- Builds. Several {auto,}tests segfaults. Thanks, Andrea

Re: Review Request 111210: Move the XMLGUI technology to xmlgui/

lgui/src/CMakeLists.txt a506ab0 staging/xmlgui/src/config-xmlgui.h.cmake 58949d8 staging/xmlgui/tests/CMakeLists.txt dce637f staging/xmlgui/tests/kxmlguitest.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/111210/diff/ Testing --- Builds. Several {auto,}tests segfaults. Thanks,

Re: Review Request 111210: Move the XMLGUI technology to xmlgui/

staging/xmlgui/src/config-xmlgui.h.cmake 58949d8 staging/xmlgui/tests/CMakeLists.txt dce637f staging/xmlgui/tests/kxmlguitest.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/111210/diff/ Testing --- Builds. Several {auto,}tests segfaults. Thanks, Andrea

Re: Review Request 111210: Move the XMLGUI technology to xmlgui/

ff: http://git.reviewboard.kde.org/r/111210/diff/ Testing --- Builds. Several {auto,}tests segfaults. Thanks, Andrea Scarpino ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 111183: Move KLanguageButton to KWidgets

/klanguagebutton.h feb2b5b kdeui/widgets/klanguagebutton.cpp c5d8e4b staging/kwidgets/src/CMakeLists.txt e337b81 staging/kwidgets/tests/CMakeLists.txt f173b80 Diff: http://git.reviewboard.kde.org/r/83/diff/ Testing --- Builds. Thanks, Andrea Scarpino

Re: Review Request 111183: Move KLanguageButton to KWidgets

://git.reviewboard.kde.org/r/83/diff/ Testing --- Builds. Thanks, Andrea Scarpino ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 111191: Move KTextEdit to KTextWidgets

src/CMakeLists.txt PRE-CREATION staging/ktextwidgets/tests/CMakeLists.txt PRE-CREATION Diff: http://git.reviewboard.kde.org/r/91/diff/ Testing --- Builds and tests passed. kreplacetest segfaults. Thanks, Andrea Scarpino ___ Kde-framewo

Re: Review Request 111183: Move KLanguageButton to KWidgets

ets/klanguagebutton.cpp c5d8e4b kdeui/widgets/klanguagebutton.h feb2b5b kdeui/CMakeLists.txt d8b9b53 Diff: http://git.reviewboard.kde.org/r/83/diff/ Testing --- Builds. Thanks, Andrea Scarpino ___ Kde-frameworks-devel mailing list

Re: Review Request 111210: Move KHelpMenu and friends to XmlGui

210/diff/ Testing --- Builds. Several {auto,}tests segfaults. Thanks, Andrea Scarpino ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 111191: Move KTextEdit to KTextWidgets

/ktextwidgets/src/CMakeLists.txt PRE-CREATION staging/ktextwidgets/tests/CMakeLists.txt PRE-CREATION Diff: http://git.reviewboard.kde.org/r/91/diff/ Testing --- Builds and tests passed. kreplacetest segfaults. Thanks, Andrea Scarpino

Re: Review Request 111183: Move KLanguageButton to KWidgets

c5d8e4b staging/kwidgets/src/CMakeLists.txt e337b81 Diff: http://git.reviewboard.kde.org/r/83/diff/ Testing --- Builds. Thanks, Andrea Scarpino ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org

Re: Review Request 111183: Move KLanguageButton to KWidgets

/klanguagebutton.h feb2b5b kdeui/CMakeLists.txt d8b9b53 staging/kwidgets/src/widgets/klanguagebutton.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/83/diff/ Testing --- Builds. Thanks, Andrea Scarpino ___ Kde-frameworks-devel

Re: Review Request 111210: Move KHelpMenu and friends to XmlGui

ui/tests/kxmlguiwindowtestui.rc PRE-CREATION Diff: http://git.reviewboard.kde.org/r/111210/diff/ Testing --- Builds. Several {auto,}tests segfaults. Thanks, Andrea Scarpino ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org

Re: Review Request 111080: Macro*.cmake changes

/diff/ Testing --- Thanks, Andrea Scarpino ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 111191: Move KTextEdit to KTextWidgets

/ktextedit.cpp PRE-CREATION staging/ktextwidgets/tests/CMakeLists.txt PRE-CREATION staging/ktextwidgets/tests/ktextedittest.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/91/diff/ Testing --- Builds and tests passed. kreplacetest segfaults. Thanks, Andrea Scarpino

Re: Review Request 111183: Move KLanguageButton to KWidgets

agebutton.h PRE-CREATION staging/kwidgets/src/widgets/klanguagebutton.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/83/diff/ Testing --- Builds. Thanks, Andrea Scarpino ___ Kde-frameworks-devel mailing list Kde-frameworks-deve

Review Request 111210: Move KHelpMenu and friends to XmlGui

o,}tests segfaults. Thanks, Andrea Scarpino ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 111191: Move KTextEdit to KTextWidgets

s passed. kreplacetest segfaults. Thanks, Andrea Scarpino ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 111191: Move KTextEdit to KTextWidgets

ed by KMessageWidget, so it looks as a candidate to KWidgetsAddons to me. This way all dependencies are solved as KTextWidgets already uses KWidgetsAddons. - Andrea Scarpino On June 23, 2013, 10:39 a.m., Andrea Scarpino wrote: > > --- &

Review Request 111191: Move KTextEdit to KTextWidgets

/ktextedittest.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/91/diff/ Testing --- Builds and tests passed. kreplacetest segfaults. Thanks, Andrea Scarpino ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https

Re: Review Request 111183: Move KLanguageButton to KWidgets

ets/src/widgets/klanguagebutton.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/83/diff/ Testing --- Builds. Thanks, Andrea Scarpino ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailm