Re: RFC: Erroring out if the platform you're building the Framework is not supported

On Wednesday, February 16, 2022 9:42:18 AM EST Albert Astals Cid wrote: > Supported == listed in metainfo.yaml > > https://invent.kde.org/frameworks/extra-cmake-modules/-/merge_requests/245 > > What do you think? > > I know parsing yaml like that isn't great but it seems to work for something >

D29223: Update Taiwanese holidays

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R175:b1291acbfc09: Update Taiwanese holidays (authored by nhiga, committed by winterz). REPOSITORY R175 KHolidays CHANGE

D29575: holidayregion.cpp - provide translatable strings for the German regions.

This revision was automatically updated to reflect the committed changes. Closed by commit R175:7f7533260efc: holidayregion.cpp - provide translatable strings for the German regions. (authored by winterz). REPOSITORY R175 KHolidays CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29575

D29223: Update Taiwanese holidays

winterz added a comment. all opposed to this patch please speak up soon REVISION DETAIL https://phabricator.kde.org/D29223 To: nhiga, winterz, cgiboudeaux, shrapnel Cc: weisi, #kde_pim, kde-frameworks-devel, shrapnel, LeGast00n, cblack, fbampaloukas, michaelh, ngraham, bruns, dvasin, rodse

D29575: holidayregion.cpp - provide translatable strings for the German regions.

winterz updated this revision to Diff 82442. winterz added a comment. QLatin1-ify REPOSITORY R175 KHolidays CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29575?vs=82398&id=82442 BRANCH master REVISION DETAIL https://phabricator.kde.org/D29575 AFFECTED FILES src/holidayre

D29575: holidayregion.cpp - provide translatable strings for the German regions.

winterz updated this revision to Diff 82398. winterz added a comment. don't try to provide translatable string for unknown subdivisions REPOSITORY R175 KHolidays CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29575?vs=82396&id=82398 BRANCH master REVISION DETAIL https://phab

D29575: holidayregion.cpp - provide translatable strings for the German regions.

winterz added a comment. I'm guessing it's ok to depend on K5I18N ? REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D29575 To: winterz, vkrause Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29575: holidayregion.cpp - provide translatable strings for the German regions.

winterz created this revision. winterz added a reviewer: vkrause. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. winterz requested review of this revision. REVISION SUMMARY The German holiday files now all have a proper country and name since commits 4bdc6

D29374: UK, Scotland: Fix syntax error by adding category of Early May Bank Holiday

winterz added a comment. I committed this one for Weisi Dai REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D29374 To: weisi, winterz, davidedmundson Cc: jriddell, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29374: UK, Scotland: Fix syntax error by adding category of Early May Bank Holiday

This revision was automatically updated to reflect the committed changes. Closed by commit R175:682b18f75ca7: holidays/plan2/holiday_gb-sct_en-gb (authored by weisi, committed by winterz). REPOSITORY R175 KHolidays CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29374?vs=81773&id=8195

D29374: UK, Scotland: Fix syntax error by adding category of Early May Bank Holiday

winterz accepted this revision. winterz added a comment. do you need me to commit this for you? my fault. I should have run the test that looks for the syntax errors .. I don't recall doing that. REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D29374 To: weis

D29415: Add holiday file for DE-BE (Germany/Berlin)

winterz accepted this revision. winterz added a comment. This revision is now accepted and ready to land. I don't know German and I don't know the Berlin holidays. but the tests pass and in general things look fine. REPOSITORY R175 KHolidays BRANCH master REVISION DETAIL https://phab

Re: Information regarding upcoming Gitlab Migration: clarifications

On Thursday, April 30, 2020 5:15:43 PM EDT Albert Astals Cid wrote: > El dijous, 30 d’abril de 2020, a les 21:31:02 CEST, Ben Cooksley va escriure: > > On Fri, May 1, 2020 at 6:04 AM Ivan Čukić wrote: > > > > > > > We have made a big fuss in the past about having different projects > > > > that do

D28874: Taiwanese holidays

winterz added a comment. In D28874#650661 , @ngraham wrote: > Do you not have commit access? I thought you were the maintainer based on the repo's history! Yes of course. I'm asking for assistance at this time. REPOSITORY R175 KHolid

D28891: Nicaragua Holidays

winterz accepted this revision. winterz added a comment. This revision is now accepted and ready to land. other than the indentation in the .qrc file this is good to go.. tests pass would appreciate if someone would commit this for us. (after fixing the indentation) REPOSITORY R175 KH

D28874: Taiwanese holidays

winterz accepted this revision. winterz added a comment. This revision is now accepted and ready to land. looks good. all tests pass. could someone commit this for us? REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D28874 To: shrapnel, #vdg, Zren, winterz Cc:

D28874: Taiwanese holidays

winterz added a comment. remove holidays/0001-added-holiday_tw_zh-and-updated-holiday.qrc.patch REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D28874 To: shrapnel, #vdg, Zren, winterz Cc: winterz, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28891: Nicaragua Holidays

winterz added inline comments. INLINE COMMENTS > holidays.qrc:101 > plan2/holiday_mx_es > -plan2/holiday_na_en-gb > + plan2/holiday_na_en-gb > plan2/holiday_nc_fr realign the indentation > holidays.qrc:103 > plan2/holiday_nc_fr > + plan2/holida

D28874: Taiwanese holidays

winterz added a comment. problems: - "religous" should be "religious" - missing ':' at the start of Constitution Day - missing ':' at the start of Christmas Day REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D28874 To: shrapnel, #vdg, Zren, winterz Cc: w

D28874: Taiwanese holidays

winterz requested changes to this revision. winterz added a comment. This revision now requires changes to proceed. testing fails. don't know why yet. REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D28874 To: shrapnel, #vdg, Zren, winterz Cc: winterz, kde-framewor

D28874: Taiwanese holidays

winterz added a comment. you need to add the change to holidays.qrc to this patch REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D28874 To: shrapnel, #vdg, Zren Cc: winterz, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28850: Updated Romanian holidays

winterz accepted this revision. winterz added a comment. This revision is now accepted and ready to land. looks fine. I tested it. can someone commit this please? REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D28850 To: sionescu, winterz Cc: winterz, kde-fra

D28834: Add metadata properties to calendar

winterz added a comment. I don't know how things are done in frameworks but it seems to me that the KF5_VERSION (see top of kcalendarcore/CMakeLists.txt) needs to become 5.70.0 now REPOSITORY R172 KCalendar Core BRANCH props REVISION DETAIL https://phabricator.kde.org/D28834 To: nico

D28834: Add metadata properties to calendar

winterz accepted this revision. This revision is now accepted and ready to land. REPOSITORY R172 KCalendar Core BRANCH props REVISION DETAIL https://phabricator.kde.org/D28834 To: nicolasfella, #frameworks, #kde_pim, vkrause, winterz Cc: winterz, kde-pim, fbampaloukas, dcaliste, dvasin, r

D28834: Add metadata properties to calendar

winterz added a comment. looks good. nice touch using Q_EMIT. INLINE COMMENTS > calendar_p.h:81 > +QString mIcon; > +CalendarType mType; > }; CalendarType mType = ReadWrite ? REPOSITORY R172 KCalendar Core REVISION DETAIL https://phabricator.kde.org/D28834 To: nicolasfella,

D27363: KHolidays: Convert license statements to SPDX expressions

winterz accepted this revision. This revision is now accepted and ready to land. REPOSITORY R175 KHolidays BRANCH spdx REVISION DETAIL https://phabricator.kde.org/D27363 To: cordlandwehr, winterz Cc: cgiboudeaux, winterz, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham,

Re: Banning QNetworkAccessManager

On Wednesday, February 19, 2020 6:09:02 PM EST Albert Astals Cid wrote: > El dimecres, 19 de febrer de 2020, a les 9:28:22 CET, Volker Krause va > escriure: > > Additionally, improved documentation, a possible KNAM and/or driving the > > QNAM > > changes upstream can still be done alongside this

D27419: Update Japanese holidays

This revision was automatically updated to reflect the committed changes. Closed by commit R175:1f9332f8f322: Update Japanese holidays (authored by winterz). REPOSITORY R175 KHolidays CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27419?vs=75732&id=75777 REVISION DETAIL https://ph

D27419: Update Japanese holidays

winterz accepted this revision. winterz added a comment. I tested these changes locally. works do you have commit access? REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D27419 To: nhiga, dvratil, winterz, cgiboudeaux Cc: #kde_pim, kde-frameworks-devel, LeGast

D27363: KHolidays: Convert license statements to SPDX expressions

winterz added a comment. looks ok to me. INLINE COMMENTS > cgiboudeaux wrote in lunarphase.cpp:6 > This looks suspicious > > @winterz ? no, it's fine. REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D27363 To: cordlandwehr Cc: cgiboudeaux, winterz, kde-framework

D26167: Update holidays and add flagdays and namedays for Sweden

winterz accepted this revision. winterz added a comment. This revision is now accepted and ready to land. looks fine. I also tested and the changes don't break anything. REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D26167 To: riiga, #kde_pim, winterz Cc: ltosca

D25753: EBN extra-cmake-modules transport cleanup

winterz added a comment. please send me a list of urls that don't have https: and I'll add them to the whitelist REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D25753 To: jhayes, apol, cgiboudeaux Cc: winterz, cgiboudeaux, kde-frameworks-devel, kde-buil

D25106: Also allow invoking session restoration logic when apps are manually launched

winterz added a comment. yay! REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D25106 To: ngraham, davidedmundson, #frameworks, dfaure, vkrause Cc: winterz, lbeltrame, mlaurent, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D19996: WIP Add a global test for insecure http: URLs used in code or documentation

winterz added a comment. FYI: Today I added a Krazy checker to do this. Should see results on the EBN in a day or 2. Although I am skipping the .htignore's, there will still be lots of false positives especially in the test programs. Let's see what happens. -Allen REPOSITORY R24

D24826: Enforce 100 chars line width

winterz added a comment. I am a long-time advocate of columnLimits; however, in our modern world of programming I think 100 is too short. 240 may be a bit too long: in my personal coding style scripts I try to limit to 120. even 120 is hard to achieve sometimes. I feel that 240 is a

D23930: Set XCB to required if building the X backend

winterz added a comment. +1 will fix the problem I reported. REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D23930 To: davidedmundson, zzag Cc: winterz, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

Re: KCalendarCore plugins/datasources?

On Monday, August 12, 2019 6:49:48 AM EDT Daniel Vrátil wrote: > On Sunday, 11 August 2019 12:12:10 CEST Bhushan Shah wrote: > > [I am not subscribed to kde-pim list, please keep me or k-f-d in CC] > > > > Hello, > > Hi Bhushan, > > > > > So yesterday I was discussing this with the Volker in #k

Re: New framework: KCalCore

On Thursday, July 18, 2019 12:18:36 PM EDT Volker Krause wrote: > On Wednesday, 17 July 2019 01:51:42 CEST Aleix Pol wrote: > > On Tue, Jul 16, 2019 at 6:10 PM Volker Krause wrote: > > > On Monday, 15 July 2019 18:43:42 CEST Aleix Pol wrote: > > > > On Fri, Jul 12

Re: New framework: KCalCore

On Friday, July 12, 2019 12:23:58 PM EDT Volker Krause wrote: > With the 19.08 release approaching (and thus the deadline for incompatible > changes if we go ahead with this plan), I'd like to raise this again for > getting to a decision :) > > Summary of what happened in the past weeks: > - the

Re: New framework: KCalCore

Clazy is complaining about missing assign operators. Do we care? If so, I can take a look at adding them or if anyone else wants to do that. -Allen ./src/calendar.cpp line 305: for (it = vals.constBegin(); it != vals.constEnd(); ++it) { => Using assign operator but class QTypedArrayData

Re: New framework: KCalCore

On Sunday, April 14, 2019 7:31:41 AM EDT David Faure wrote: > On dimanche 7 avril 2019 14:45:09 CEST Volker Krause wrote: > > Hi, > > > > I'd like to propose KCalCore for review to move from KDE PIM to KF5. > > > > KCalCore is an implementation of the iCalendar standard based on libical, > > I w

D19092: Add bison minimum version of 2.4.1 due to %code

winterz accepted this revision. winterz added a comment. This revision is now accepted and ready to land. I'm for this. I never created such a patch because I wasn't sure what minimum version was needed. On Mac, what I do is install the homebrew bison and export PATH=/usr/local/opt/bis

D19996: WIP Add a global test for insecure http: URLs used in code or documentation

winterz added a comment. this would be a nice addition to Krazy. on my todo list. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D19996 To: vkrause Cc: winterz, knauss, cgiboudeaux, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D16300: Remove double underscore (__) from header include guards

winterz added a comment. fyi, krazy in strict mode will check for leading and trailing underscores on the include guards. I don't run krazy in strict mode on the EBN, however. I could make this a standard check if we want so the EBN would pick it up too. REPOSITORY R39 KTextEditor R

D14524: Fix compiler warning -Wimplicit-fallthrough

winterz added a comment. agree that Q_FALLTHROUGH(); is a better idea. it doesn't duplicate code and it informs the reader that the fallthrough is intentional REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14524 To: dhaumann, vkrause Cc: winterz, aaci

D14154: Add

This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit R175:8c49f9b3dfe2: more Japanese holiday updates from phanect (authored by winterz). REPOSITORY R175 PIM: KHolidays CH

D13828: Revert "updated Japanese holidays (in Japanese and English)"

winterz added a comment. please close this REPOSITORY R175 PIM: KHolidays REVISION DETAIL https://phabricator.kde.org/D13828 To: phanect, #kde_pim, #frameworks, winterz, mlaurent Cc: mlaurent, winterz, kde-pim, dvasin, rodsevich, vkrause, knauss, dvratil

D13812: Revert "updated Japanese holidays (in Japanese and English)"

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R175:1c2ecfbf9570: holiday_jp_ja, holiday_jp-en_us - updated Thanks for the patch phanect (authored by winterz). REPOSITOR

D7415: kconfig: kcfg.xsd do not require a kcfgfile

This revision was automatically updated to reflect the committed changes. Closed by commit R237:dba6d83ee412: kcfg.xsd - do not require a kcfgfile element (authored by winterz). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7415?vs=18394&id=33780 REVISION DE

D7415: kconfig: kcfg.xsd do not require a kcfgfile

winterz added a comment. ping. this is still relevant. some kconfigxt files don't set the kcfgfile element. to name a few: mailcommon/src/settings/mailcommon.kcfg kdepim-runtime/agents/newmailnotifier/newmailnotifieragentsettings.kcfg pim-data-exporter/gui/settings/pimsettingexpo

Re: Changes to networkmanager-qt - breakage in plasma-workspace

krop already fixed that On Thursday, March 29, 2018 6:21:41 PM EDT Ben Cooksley wrote: > Hi Jan, > > It seems that as part of your recent changes to networkmanager-qt to > increase the dependency to 1.0.0 you've made some other changes which > mean the appropriate include paths are no longer bein

Re: KHolidays as Framework (redux)

able since August > 2015 from what I can see. > > Regards, > Volker > > > PS: please also inform distributi...@kde.org, if the switch has a fixed > > date. > > On Sonntag, 14. Januar 2018 15:59:46 CET Allen Winter wrote: > > > I don't object to

Re: KHolidays as Framework (redux)

I don't object to making KHolidays a framework. I kinda object to the short timeline. I wanted to finish up some BIC cleaning. No API changes planned at this time. I'll try to hurry. On Sunday, January 14, 2018 4:20:38 AM EST Volker Krause wrote: > On Tuesday, 6 September 2016 12:03:15 CET Vol

Commit Notifications

I still get email notifications on commits to a few repos. How do I unsubscribe from the ones I no longer care about? How do I subscribe to new repos I'm currently interested in? searching the wiki isn't helping. I see mention of CommitFilter, but that's dead. I tried watching github mirrors, but

D7415: kconfig: kcfg.xsd do not require a kcfgfile

winterz added a comment. comments? thoughts? REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D7415 To: winterz Cc: #frameworks

Re: Review Request 129381: kconfig fix kconfigskeletontest

--- before some of the tests fail and now they all pass. Thanks, Allen Winter

D7415: kconfig: kcfg.xsd do not require a kcfgfile

winterz reclaimed this revision. winterz added a comment. un-abandon. I retested and it does work as intended REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D7415 To: winterz Cc: #frameworks

D7415: kconfig: kcfg.xsd do not require a kcfgfile

winterz abandoned this revision. winterz added a comment. not good. ignore. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D7415 To: winterz Cc: #frameworks

D7415: kconfig: kcfg.xsd do not require a kcfgfile

winterz created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY I'm seeing quite a few kconfigxt files that don't set the kcfgfile element. This patch changes the xsd so such files will validate. no

D6936: ECMGeneratePriFile - mac os x framework builds of Qt

winterz abandoned this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D6936 To: winterz, dfaure Cc: #frameworks, #build_system

D6936: ECMGeneratePriFile - mac os x framework builds of Qt

winterz created this revision. Restricted Application added projects: Frameworks, Build System. Restricted Application added subscribers: Build System, Frameworks. REVISION SUMMARY on mac os x framework builds of Qt, QT/include is not added to the list of include path,. this patch looks up one

D6762: ECM: KDECompilerSettings LINKER_FLAGS on Cygwin

winterz closed this revision. winterz added a comment. see https://phabricator.kde.org/R240:db46fb7c2fdcfbff5f8a0445e4d055cf4388ead8 REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D6762 To: winterz, skelly, #build_system, #windows, kfunk Cc: nalvarez, #fr

D6762: ECM: KDECompilerSettings LINKER_FLAGS on Cygwin

winterz added a comment. In https://phabricator.kde.org/D6762#126463, @nalvarez wrote: > Looks reasonable – although I wonder why on earth you're building KDE stuff on Cygwin... fun. as an experiment. i'm curious. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://

D6762: ECM: KDECompilerSettings LINKER_FLAGS on Cygwin

winterz added reviewers: skelly, Build System. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D6762 To: winterz, skelly, #build_system Cc: #frameworks, #build_system

D6762: ECM: KDECompilerSettings LINKER_FLAGS on Cygwin

winterz created this revision. Restricted Application added projects: Frameworks, Build System. Restricted Application added subscribers: Build System, Frameworks. REVISION SUMMARY Cygwin systems aren't ELF based so don't try to pass --enable-new-dtags to 'ld' else you get /usr/lib/gcc/x86_6

D5828: fix plasma-frameworks build without kwayland

winterz closed this revision. winterz added a comment. committed https://phabricator.kde.org/R242:6c03c15c08a4b585bc3f320865858e4c2832f70b REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D5828 To: winterz, mart, davidedmundson, bshah, #plasma Cc:

D5975: breeze-icons: don't look for bash on Windows

winterz closed this revision. winterz added a comment. committed in https://phabricator.kde.org/R266:09291a2b3ecf03577b93c6d4cedc28927668e571 REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D5975 To: winterz, aacid Cc: aacid, #frameworks

D5975: breeze-icons: don't look for bash on Windows

winterz edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D5975 To: winterz Cc: aacid, #frameworks

D5975: breeze-icons: don't look for bash on Windows

winterz added a comment. Because Hannah told me the script doesn't work on Windows. let's look at validate-svg.sh. you need a working unix 'find' command (not the WIndows find command) as well as xmllint for the bash script to work. REPOSITORY R266 Breeze Icons REVISION DETAIL htt

D5975: breeze-icons: don't look for bash on Windows

winterz created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY The GoW package on Windows has bash. We don't want to find bash on Windows. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabr

D5828: fix plasma-frameworks build without kwayland

winterz created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY fixes the compile errors in plasmaquick/dialog.cpp if you don't have kwayland TEST PLAN compile it REPOSITORY R242 Plasma Framework (Li

D5646: Solve problem with microphone-sensitivity-medium

winterz added a comment. my commit was a hack to get the validator to pass. this patch is far more extensive. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D5646 To: patrickelectric, #kate, andreaska Cc: ltoscano, winterz, #frameworks

D5456: KDoctools: build on Mac with docbook from homebrew

winterz closed this revision. winterz added a comment. committed in https://phabricator.kde.org/R238:5c5bfc2d838993f7d4be1885dff822e3794c529f REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D5456 To: winterz, ltoscano, kfunk Cc: kfunk, #frameworks, #documentation,

D5456: KDoctools: build on Mac with docbook from homebrew

winterz updated this revision to Diff 13520. winterz added a comment. I added comments. REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5456?vs=13448&id=13520 REVISION DETAIL https://phabricator.kde.org/D5456 AFFECTED FILES cmake/FindDocBookXML4.cmak

D5456: KDoctools: build on Mac with docbook from homebrew

winterz created this revision. Restricted Application added projects: Frameworks, Documentation. Restricted Application added subscribers: Documentation, Frameworks. REVISION SUMMARY On Mac, homebrew installs the docbook-xml and docbook-xls files under /usr/local/opt so add searchpaths accord

Re: kwin requires qt5.7.0

On Sunday, February 26, 2017 06:05:13 PM Luigi Toscano wrote: > Allen Winter ha scritto: > > I thought Qt5.6 was the minimum required? > > Just asking. I don't care that much but I need to install Qt5.7 , which of > > course I can do. > > Well, that's a que

kwin requires qt5.7.0

I thought Qt5.6 was the minimum required? Just asking. I don't care that much but I need to install Qt5.7 , which of course I can do. when running CMake on kwin I get: CMake Error at CMakeLists.txt:20 (find_package): Could not find a configuration file for package "Qt5" that is compatible wi

EBN News: SVN Projects Removed

[resending with my kde address] Howdy, On the EBN we are no longer checking-out projects from subversion. This means if you have a project hanging around in SVN you will no longer see its apidox, Krazy reports, etc. -Allen

[Differential] [Closed] D4684: fix compile with Qt5.6

winterz closed this revision. winterz added a comment. c4b01b015554f52577507506d18c9bcb4e7ac5b6committed in REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4684 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: w

[Differential] [Commented On] D4684: fix compile with Qt5.6

winterz added a comment. btw, not related to this patch but I just noticed.. on line 534 of containmentinterface.cpp, do you want to delete 'choices' or 'choice'? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4684 EMAIL PREFERENCES https://p

[Differential] [Request, 26 lines] D4684: fix compile with Qt5.6

winterz created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY in Qt5.6 the QAction creators need a parent object passed as a parameter. unfortunately they don't have a default for the parent as nullptr

[Differential] [Accepted] D4558: Fail the build early if xmllint is not available

winterz accepted this revision. winterz added a comment. This revision is now accepted and ready to land. ok REPOSITORY R238 KDocTools BRANCH check-xmllint REVISION DETAIL https://phabricator.kde.org/D4558 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences

[Differential] [Updated] D4558: Fail the build early if xmllint is not available

winterz added a comment. guess this is the best you can do given that FindLibXml2 sets LibXml2_FOUND even if xmllint is not found. REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D4558 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

Re: Enabling Clang's -Wdocumentation in Frameworks...?

On Thursday, January 05, 2017 08:01:53 PM Kevin Funk wrote: > Heya, > > we all like up-to-date apidocs, right. > I would like to point out that the EBN has been providing pretty reports for doxygen problems for many years already. Or had been, before the frameworks days. One such example from K

Re: Review Request 129385: kwindowsystem add overrides

, Allen Winter

Review Request 129385: kwindowsystem add overrides

/129385/diff/ Testing --- all warnings for -Wsuggest-override are gone make test passes on the same tests as previously. fyi: a handful of the same autotests fail for me with or without this patch. Thanks, Allen Winter

Re: Review Request 129381: kconfig fix kconfigskeletontest

/git.reviewboard.kde.org/r/129381/#review100796 ------- On Nov. 11, 2016, 10:14 p.m., Allen Winter wrote: > > --- > This is an automatically generated e-mail. To

Re: Review Request 129382: kconfig_compiler - generate code with overrides

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit b66da09e586dda28ca43c6566904a0f62a787863 by Allen Winter to branch master. Repository: kconfig Description --- With this patch kconfig_compiler will add and override to usrSave method in the

Review Request 129382: kconfig_compiler - generate code with overrides

src/kconfig_compiler/kconfig_compiler.cpp 4494e45 Diff: https://git.reviewboard.kde.org/r/129382/diff/ Testing --- make test works. notice this patch contains a fix for a reference file in the test suite Thanks, Allen Winter

Review Request 129381: kconfig fix kconfigskeletontest

for dirtyness 3) fix testSaveRead() Diffs - autotests/kconfigskeletontest.h 5cdcc9d autotests/kconfigskeletontest.cpp 898366c Diff: https://git.reviewboard.kde.org/r/129381/diff/ Testing --- before some of the tests fail and now they all pass. Thanks, Allen Winter

Re: Review Request 129374: ktexteditor add overrides

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 8c39eaec1574d1a4f9d022b43ef3374ab710fb79 by Allen Winter to branch master. Repository: ktexteditor Description --- Add Q_DECL_OVERRIDES as suggested by -Wsuggest-override Diffs - src

Review Request 129374: ktexteditor add overrides

/129374/diff/ Testing --- Thanks, Allen Winter

Re: Review Request 129374: ktexteditor add overrides

Diff: https://git.reviewboard.kde.org/r/129374/diff/ Testing (updated) --- all warnings for -Wsuggest-override are gone make test still passes Thanks, Allen Winter

Re: Review Request 129361: Add library path so utempter binary is found in Ubuntu 16.10

build kpty. - Allen Winter On Nov. 7, 2016, 11:02 p.m., Albert Astals Cid wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.review

Re: Jenkins-kde-ci: kdesignerplugin master stable-kf5-qt5 » Linux, gcc - Build # 78 - Unstable!

oject: PLATFORM=Linux,compiler=gcc > Date of build: Mon, 07 Nov 2016 12:48:31 + > Build duration: 1 min 20 sec > > CHANGE SET > Revision 606352070ae07bd5c7fe6e2702628632b8245c9b by Allen Winter: > (src/kgendesignerplugin.cpp - add overrides to generated code REVIEW:) >

Re: Review Request 129356: kdesignerplugin - add overrides to the generated source

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 606352070ae07bd5c7fe6e2702628632b8245c9b by Allen Winter to branch master. Repository: kdesignerplugin Description --- add Q_DECL_OVERRIDE to the kgendesignerplugin.cpp generated code so

Re: Review Request 129355: kparts add overrides

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit fd8693fba950010b64b4d7ae2e6ca84e68562e61 by Allen Winter to branch master. Repository: kparts Description --- Add Q_DECL_OVERRIDES as suggested by -Wsuggest-override Diffs - src

Re: Review Request 129354: kunitconversion - add overrides

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 8bf303250a58ae4bb682851a97549f6d040b9acd by Allen Winter to branch master. Repository: kunitconversion Description --- Add Q_DECL_OVERRIDES as suggested by -Wsuggest-override Diffs

Review Request 129356: kdesignerplugin - add overrides to the generated source

ggest-overrides without complaining. make test passes also removed tabs from the generated source code Thanks, Allen Winter

Review Request 129355: kparts add overrides

--- Add Q_DECL_OVERRIDES as suggested by -Wsuggest-override Diffs - src/scriptableextension_p.h c8e58be Diff: https://git.reviewboard.kde.org/r/129355/diff/ Testing --- all warnings for -Wsuggest-override are gone make test still passes Thanks, Allen Winter

  1   2   >