Re: MegaRelease Freezes - Re: Release schedule proposal for the February MegaRelease

2023-10-02 Thread Aleix Pol
On Tue, Sep 26, 2023 at 12:29 AM Albert Astals Cid wrote: > > El dimarts, 26 de setembre de 2023, a les 0:28:15 (CEST), Albert Astals Cid va > escriure: > > https://community.kde.org/Schedules/February_2024_MegaRelease > > > > Beta 1 is during Qt World Summit that is not ideal but I guess doable?

Re: KUserFeedback as framework for KF6

2023-07-23 Thread Aleix Pol
+1 On Sat, Jul 15, 2023 at 10:39 PM wrote: > > Hi, > > several of our projects use it, like Plasma and Kate. > > Can we make it a framework for KF6? > > Then we have finally regular releases that include bug fixes. > > Is there some opposition to do that? > I asked in the past but there was just

Re: kf6 vs. kf5 conflict report

2023-03-08 Thread Aleix Pol
On Wed, Mar 8, 2023 at 3:13 PM Nicolas Fella wrote: > > On 3/8/23 14:02, Harald Sitter wrote: > > with kf6 progressing nicely here's a first conflict report of files > > that appear in both kf6 and kf5 under the same name. this largely > > affects translations and docs it seems. this list may not

Re: Splitting KGlobalAccel interface and runtime

2023-02-14 Thread Aleix Pol
On Tue, Feb 14, 2023 at 10:13 AM Kevin Ottens wrote: > > Hello, > > On Monday, 13 February 2023 21:25:54 CET Vlad Zahorodnii wrote: > > On 2/13/23 22:05, Nicolas Fella wrote: > > > Hi, > > > > > > the kglobalaccel framework currently contains two pieces: kglobalacceld, > > > the runtime component

On ECMDeprecationSettings

2022-06-28 Thread Aleix Pol
Hi Frederik, I wonder if it would make sense to have the ECMDeprecationSettings calls in KDEFrameworkCompilerSettings rather than in each separate framework in a copy-paste manner. As is we need to merge a ton of MRs with copy-pasted contents anyway. Aleix

Re: KF6 meeting notes 2022-04-12

2022-04-13 Thread Aleix Pol
Hi Volker, Thanks a lot for the notes! It makes it easier to follow the work even if I'm unable to join lately. One question, how does co-installability affect flatpak? If anything, the environment is much more controlled so it shouldn't matter that much (?). Aleix On Tue, Apr 12, 2022 at 9:24 P

Re: RFC: Frameworks headers install location

2022-04-11 Thread Aleix Pol
Back when we did KF5, what we tried to do was mainly to make sure kde4 code still compiled after the big split. I think that stanradrising how they're placed within submodules of include/KF6 is a good idea. The fact that headers from some repositories can be included using the project name is mor

Re: portal drag and drop helpers and where to put them

2022-04-11 Thread Aleix Pol
Maybe the alternative would be to use the kdbusaddons for this? It seems to me like there's no kcoreaddons things being done. To make it more weird and complex, if we think of K*Addons frameworks an extension to their Qt* counterpart, I guess it should be abstracted behind something in QtGui, alth

Re: Critical Denial of Service bugs in Discover

2022-03-06 Thread Aleix Pol
On Sat, Mar 5, 2022 at 8:36 AM Ben Cooksley wrote: > On Fri, Mar 4, 2022 at 12:49 AM Aleix Pol wrote: > >> I'd say wireshark is too low level for what the problem is here. We are >> talking about having too many HTTP requests for specific URLs. >> > > Cor

Re: Critical Denial of Service bugs in Discover

2022-03-03 Thread Aleix Pol
we have in a specific day in the services we care about. - Offer plots to see how queries by UserAgent evolve over the last couple of months (or couple of years). Aleix On Thu, Mar 3, 2022 at 9:59 AM Ben Cooksley wrote: > On Thu, Mar 3, 2022 at 8:41 AM Aleix Pol wrote: > >> (dro

Re: Critical Denial of Service bugs in Discover

2022-03-02 Thread Aleix Pol
(dropping the distros list) @sysadmin have you been able to look into any tools we devs can have to make sure this situation doesn't repeat in the future? Aleix On Thu, Feb 10, 2022 at 1:10 PM Aleix Pol wrote: > On Thu, Feb 10, 2022 at 11:05 AM Ben Cooksley wrote: > > > >

Re: Critical Denial of Service bugs in Discover

2022-02-10 Thread Aleix Pol
On Thu, Feb 10, 2022 at 11:05 AM Ben Cooksley wrote: > > > > On Thu, Feb 10, 2022 at 8:20 AM Aleix Pol wrote: >> >> [Snip] >> >> We still haven't discussed here is how to prevent this problem from >> happening again. >> >> If we do

Releasing knewstuff 5.91.1

2022-02-09 Thread Aleix Pol
Hi David Faure, As you might have seen, there has been some changes to mitigate a problem with how some applications are accessing our servers. https://invent.kde.org/frameworks/knewstuff/-/commit/c8165b7a0d622e318b3353ccf257a8f229dd12c9 https://invent.kde.org/frameworks/knewstuff/-/commit/e1c6f2b

Re: Critical Denial of Service bugs in Discover

2022-02-09 Thread Aleix Pol
On Tue, Feb 8, 2022 at 7:00 PM Ben Cooksley wrote: > > On Tue, Feb 8, 2022 at 4:24 AM Aleix Pol wrote: >> >> On Sat, Feb 5, 2022 at 10:16 PM Ben Cooksley wrote: >> > >> > Hi all, >> > >> > Over the past week or so Sysadmin has been dealing w

Re: Critical Denial of Service bugs in Discover

2022-02-07 Thread Aleix Pol
On Sat, Feb 5, 2022 at 10:16 PM Ben Cooksley wrote: > > Hi all, > > Over the past week or so Sysadmin has been dealing with an extremely high > volume of traffic directed towards both download.kde.org and > distribute.kde.org. > > This traffic volume is curious in so far that it is directed at t

Re: KF6 meeting notes 2022-01-18

2022-01-19 Thread Aleix Pol
> anyone wants to approve that? :) Done On Tue, Jan 18, 2022 at 5:44 PM Volker Krause wrote: > > https://invent.kde.org/frameworks/extra-cmake-modules/-/merge_requests/223 > - so https://invent.kde.org/frameworks/extra-cmake-modules/-/merge_requests/ > 222 instead after all? > - anyone wants to

KF6 tasks for SoK

2021-12-02 Thread Aleix Pol
Hey, I was thinking that maybe it would be a good opportunity to put some KF6 tasks for SoK. It could be a good way to get people integrated since the tasks are fairly well laid out and we'd be offering a mentor so newcomers can join and know they won't be on their own. What do you think? https://

Re: KDE CI: Plasma » plasma-framework » kf5-qt5 FreeBSDQt5.15 - Build # 644 - Still Failing!

2021-10-18 Thread Aleix Pol
Does anyone know why we are having this problem all of a sudden? I cannot reproduce on my system. Plasma Workspace is failing the same: https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20SUSEQt5.15/1800/ Aleix On Mon, Oct 18, 2021 at 1:18 PM CI System wrote: > *BUILD FAILURE* >

Re: OCS Providers File - High Numbers of Requests

2021-09-26 Thread Aleix Pol
On Fri, Sep 24, 2021 at 8:26 PM Ben Cooksley wrote: > > On Sat, Sep 25, 2021 at 12:34 AM Aleix Pol wrote: >> >> On Fri, Sep 24, 2021 at 1:32 AM Nicolás Alvarez >> wrote: >> > >> > El jue, 23 de sep. de 2021 a la(s) 19:31, Aleix Pol (aleix...@kde.org) &

Re: OCS Providers File - High Numbers of Requests

2021-09-24 Thread Aleix Pol
On Fri, Sep 24, 2021 at 1:32 AM Nicolás Alvarez wrote: > > El jue, 23 de sep. de 2021 a la(s) 19:31, Aleix Pol (aleix...@kde.org) > escribió: > > > > On Thu, Sep 23, 2021 at 10:12 PM Nicolás Alvarez > > wrote: > > > > > > El jue, 23 de sep. de 20

Re: OCS Providers File - High Numbers of Requests

2021-09-23 Thread Aleix Pol
On Thu, Sep 23, 2021 at 10:12 PM Nicolás Alvarez wrote: > > El jue, 23 de sep. de 2021 a la(s) 08:55, Aleix Pol (aleix...@kde.org) > escribió: > > > > On Thu, Sep 23, 2021 at 11:52 AM Ben Cooksley wrote: > > > > > > Hi all, > > > > > >

Re: OCS Providers File - High Numbers of Requests

2021-09-23 Thread Aleix Pol
On Thu, Sep 23, 2021 at 1:54 PM Aleix Pol wrote: > > On Thu, Sep 23, 2021 at 11:52 AM Ben Cooksley wrote: > > > > Hi all, > > > > It has recently come to our attention that the number of queries being > > handled for the endpoint https://autoconfig.kde.org/oc

Re: OCS Providers File - High Numbers of Requests

2021-09-23 Thread Aleix Pol
On Thu, Sep 23, 2021 at 11:52 AM Ben Cooksley wrote: > > Hi all, > > It has recently come to our attention that the number of queries being > handled for the endpoint https://autoconfig.kde.org/ocs/providers.xml on a > day to day basis has gotten to the point where it is causing issues with > s

Re: Raising KF5 version a bit earlier

2021-07-24 Thread Aleix Pol
Ah, no. I thought it was still pending. Seems like it worked for everyone after all. All good, sorry for the noise. 👍 Aleix On Sat, Jul 24, 2021 at 2:30 PM Friedrich W. H. Kossebau wrote: > Am Samstag, 24. Juli 2021, 13:58:56 CEST schrieb Aleix Pol: > > Hi, > > Would it be poss

Raising KF5 version a bit earlier

2021-07-24 Thread Aleix Pol
Hi, Would it be possible to get the version bump in master a bit earlier in this cycle? https://invent.kde.org/frameworks/extra-cmake-modules/-/commit/2a39f0b235c242592ae6658f33e7fc7b547f8c6d This change made it so the setting will only be used when the version is actually 5.85 and I think it woul

Re: Problem with ksycoca not being regenerated under flatpak

2021-06-20 Thread Aleix Pol
On Sun, Jun 20, 2021 at 11:29 AM Albert Astals Cid wrote: > > El diumenge, 13 de desembre de 2020, a les 22:15:26 (CEST), Albert Astals Cid > va escriure: > > El dissabte, 12 de desembre de 2020, a les 22:59:58 CET, David Faure va > > escriure: > > > Time flies, sorry for the delay. > > > > > >

Re: Respin request for KIO

2021-06-12 Thread Aleix Pol
Merci beaucoup, David! :) On Sat, Jun 12, 2021 at 10:26 AM David Faure wrote: > > On vendredi 11 juin 2021 20:50:12 CEST Aleix Pol wrote: > > Hi David, > > It would be good that > > https://invent.kde.org/frameworks/kio/-/commit/3bc92c23dd3456bb18efd44968fab > >

Respin request for KIO

2021-06-11 Thread Aleix Pol
Hi David, It would be good that https://invent.kde.org/frameworks/kio/-/commit/3bc92c23dd3456bb18efd44968fabf32dd9c3402 was included since 9c9c8df545ab5bd2362e7c01467d3875d79f30ce is also inside and it fixes a regression. Sorry for the inconvenience and thank you very much! Aleix

Re: KGlobalAccel on non-Plasma systems

2021-04-06 Thread Aleix Pol
On Tue, Apr 6, 2021 at 5:30 PM Nicolas Fella wrote: > > Hi, > > we received a few reports [1] [2] from people using non-Plasma systems > that the kglobalaccel5 process was started, leading to clashes with the > native global shortcut system. > > This seems to happen when apps call some API of KGlo

Plasma Wayland Protocols 1.2.0

2021-03-27 Thread Aleix Pol
Hello everyone, We have just released a new 1.2 version that includes some extra interfaces that will be necessary in the next KF5 release as well as Plasma 5.22. You can find it here: https://download.kde.org/stable/plasma-wayland-protocols/plasma-wayland-protocols-1.2.0.tar.xz.mirrorlist Thanks

Re: KDE Frameworks 6 - Virtual Sprint setup

2021-01-31 Thread Aleix Pol
On Fri, Jan 29, 2021 at 5:24 PM Adam Szopa wrote: > > Hello, > > I've been talking with David Faure about setting up a Sprint focused on KF6 > work. Some of the topics would include: > > - Reviewing the KF6 board (https://phabricator.kde.org/project/board/310/[1]): > > -- Clean up > > -- Tagging

Re: KACL from KIO isn't really POSIX-compliant

2020-12-11 Thread Aleix Pol
On Wed, Dec 2, 2020 at 10:47 AM Gleb Popov <6year...@gmail.com> wrote: > > Hello everyone. > > I tried compiling kio/src/core/kacl.cpp on FreeBSD, which does support POSIX > ACLs, and failed. This is because KACL's code uses non-standard > Linux-specific acl_* functions. I tried implementing them

Re: Would distributions have an issue if KF 5.77+ would require Qt >= 5.14 (instead of >= 5.13 as of now)?

2020-12-02 Thread Aleix Pol
On Tue, Dec 1, 2020 at 1:30 PM Jonathan Riddell wrote: > > Not from KDE neon of course, we're on 5.15. And not from the KDE snaps build > either. But I suppose there's more than just Linux distros to consider as we > ship apps using KDE frameworks on Flatpak, Android, Windows, even Mac to > p

Re: Stepping down as KRunner maintainer

2020-10-09 Thread Aleix Pol
Thanks to the both of you for the work done! :) Updated the metainfo file of the krunner framework: https://invent.kde.org/frameworks/krunner/commit/621ca6e3b2e518a546c1ac8651cfb2cfd4c25122 Aleix On Thu, Oct 8, 2020 at 10:32 PM Nicolas Fella wrote: > > Thanks for all your work Kai and congratul

D29872: Provide methods to register SecretAgent to NetworkManager with capabilities, specifically with NM_SECRET_AGENT_CAPABILITY_VPN_HINTS

2020-08-02 Thread Aleix Pol Gonzalez
apol abandoned this revision. apol added a comment. https://invent.kde.org/frameworks/networkmanager-qt/-/merge_requests/2 REPOSITORY R282 NetworkManagerQt REVISION DETAIL https://phabricator.kde.org/D29872 To: apol, jgrulich, enriquem Cc: ngraham, apol, kde-frameworks-devel, LeGast00n,

D29872: Provide methods to register SecretAgent to NetworkManager with capabilities, specifically with NM_SECRET_AGENT_CAPABILITY_VPN_HINTS

2020-08-02 Thread Aleix Pol Gonzalez
apol commandeered this revision. apol added a reviewer: enriquem. REPOSITORY R282 NetworkManagerQt REVISION DETAIL https://phabricator.kde.org/D29872 To: apol, jgrulich, enriquem Cc: ngraham, apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D29872: Provide methods to register SecretAgent to NetworkManager with capabilities, specifically with NM_SECRET_AGENT_CAPABILITY_VPN_HINTS

2020-08-01 Thread Aleix Pol Gonzalez
apol added a comment. We have moved to gitlab, now patches should be uploaded here: https://invent.kde.org/frameworks/networkmanager-qt Sorry for the change (@jgrulich can still review it, but it's better to have everything in the new infrastructure). The patch itself looks okay to

Re: Dropping the moderation by default flag

2020-07-21 Thread Aleix Pol
El dt., 21 de jul. 2020, 21:16, Albert Astals Cid va escriure: > Hi, this list has an unusual setting [for kde mailing lists] inherited > from kde-core-devel that is that even subscribed people get moderated, and > then the list moderator can decide to clear the moderate flag for each > person on

Re: Frameworks support for Qt 5.12

2020-07-15 Thread Aleix Pol
On Wed, Jul 15, 2020 at 6:13 PM Nicolas Fella wrote: > > Hi, > > I received a question on how long KF5 will continue to support Qt 5.12. > > Given that 5.12 is an LTS release according to our policy it would be > supported "until the next Qt release after the next Qt release", which > would be 5.1

Re: Deprecate KRandomSequence ?

2020-06-29 Thread Aleix Pol
On Mon, Jun 29, 2020 at 10:27 PM Albert Astals Cid wrote: > > QRandomGenerator is very similar in which you can give it a seed and get > randomness out of it. > > Things that QRandomGenerator doesn't have: > * getBool(); -> should be easy enough to port to bounded(2) == 1 > * randomize(QList) -

D27338: Provide an initial implementation for input-method-unstable-v1

2020-06-26 Thread Aleix Pol Gonzalez
apol abandoned this revision. apol added a comment. https://invent.kde.org/plasma/kwayland-server/-/merge_requests/31 REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D27338 To: apol, #kwin, #frameworks Cc: davidedmundson, zzag, kde-frameworks-devel, LeGast00n, cblack

D22362: Port keystates to use QtWayland's generator

2020-06-26 Thread Aleix Pol Gonzalez
apol abandoned this revision. apol added a comment. Moved to invent for kwayland-server REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D22362 To: apol, #kwin Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

Re: KEmoticons, emoticons kcm

2020-05-24 Thread Aleix Pol
On Sun, May 24, 2020 at 3:09 AM Sandro Knauß wrote: > Hi, > > > Now while I know why this exists, it feels like it's more of a thing > > of the past from when people wrote :) instead of 🙂. > > Okay now I feeling old :-) - I don't even know how to create a unicode > smiley, that's why I always cr

Re: New Framework Review: KDAV

2020-05-24 Thread Aleix Pol
On Sun, May 24, 2020 at 8:52 AM Volker Krause wrote: > > The remaining issues that didn't change ABI anymore (movable value types, hide > private methods/slots inside the private classes, etc) have long since been > addressed. > > I think there's two possible time slots to actually execute the mov

KEmoticons, emoticons kcm

2020-05-22 Thread Aleix Pol
Hi, I was looking through some Plasma code and I saw that we have some fairly old emoticons KCM using KF5Emoticons. Now while I know why this exists, it feels like it's more of a thing of the past from when people wrote :) instead of 🙂. While keeping it around for the few apps that might still use

D28235: Add a simpler example

2020-05-22 Thread Aleix Pol Gonzalez
apol closed this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D28235 To: apol, vkrause, cullmann Cc: cullmann, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, domson, michaelh, ngraham, bruns, demsking, sars, dhaumann

D26524: configmodule: Make sure the kcm information is loaded when the qml is created

2020-05-22 Thread Aleix Pol Gonzalez
apol added a comment. hmmm. Ping @mart. :) what do you suggest we do? REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D26524 To: apol, #plasma, #frameworks Cc: mart, davidedmundson, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28235: Add a simpler example

2020-05-22 Thread Aleix Pol Gonzalez
apol added a comment. Should I understand this is not desired and that I should abandon it? I know it's not going to make a big difference to the project but it was hard for me to adopt it in the first place. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kd

D29540: plasmawindowmodel: Expose the internal id to the model

2020-05-19 Thread Aleix Pol Gonzalez
apol abandoned this revision. apol added a comment. Will move to gitlab REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D29540 To: apol Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29810: Don't use setenv after fork

2020-05-17 Thread Aleix Pol Gonzalez
apol added inline comments. INLINE COMMENTS > kcrash.cpp:823 > +char** environ_end; > +for(environ_end = environ; *environ_end; ++environ_end); > + Use {} instead of ; for readability. REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D29810 To: jpalecek, #framewo

D29802: Require out-of-source builds

2020-05-17 Thread Aleix Pol Gonzalez
apol accepted this revision. REPOSITORY R266 Breeze Icons BRANCH require-in-source-build (branched from master) REVISION DETAIL https://phabricator.kde.org/D29802 To: ngraham, #frameworks, #vdg, ognarb, davidre, apol Cc: ltoscano, davidre, kde-frameworks-devel, LeGast00n, cblack, michaelh

D29745: look for kded as runtime dep

2020-05-14 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH kded REVISION DETAIL https://phabricator.kde.org/D29745 To: sitter, dfaure, apol Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29631: [android] Allow specifying APK install location

2020-05-11 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH androinstall REVISION DETAIL https://phabricator.kde.org/D29631 To: nicolasfella, #frameworks, #android, apol, vkrause Cc: kde-frameworks-devel, kde-buildsystem, LeGast

D29600: Fix build with KF set to EXCLUDE_DEPRECATED_BEFORE_AND_AT=CURRENT

2020-05-11 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH fixbuildwithoutdeprecated REVISION DETAIL https://phabricator.kde.org/D29600 To: kossebau, #plasma, mart, apol Cc: kde-frameworks-devel, LeGast00n, cblack, micha

D29631: [android] Allow specifying APK install location

2020-05-11 Thread Aleix Pol Gonzalez
apol added a comment. +1 overall, good idea. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D29631 To: nicolasfella, #frameworks, #android, apol, vkrause Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, bencreasy, michaelh, ngraham, bruns

D29631: [android] Allow specifying APK install location

2020-05-11 Thread Aleix Pol Gonzalez
apol added inline comments. INLINE COMMENTS > Android.cmake:93 > # > -# The APK would then be found in ``myapp_build_apk/bin`` in the build > directory. > +# You can specify the APK output directory by setting > ANDROID_APK_INSTALL_DIR. > +# Otherwise the APK can be found in ``myapp_build_apk/

D29511: Label: Add ping-pong logic

2020-05-10 Thread Aleix Pol Gonzalez
apol added a comment. I feel like this could break Labels unknowingly. Maybe it would make sense to have an extra scrollToFit (?) property or even another separate component to do that. Seeing things bouncing without the author intending could be worse than having the text cut off. REP

Re: RFC: relative executables in desktop files

2020-05-10 Thread Aleix Pol
On Sun, Apr 26, 2020 at 1:36 PM David Faure wrote: > > During the review of https://phabricator.kde.org/D29170 the following > question surfaced again: should it be possible for a desktop file to refer to > an executable that is in the "current directory", for some definition of that > term. At

D28882: Create protocol to manage video feeds

2020-05-08 Thread Aleix Pol Gonzalez
apol added a comment. Moving to kwayland-server REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D28882 To: apol, #kwin, jgrulich, davidedmundson, zzag Cc: meven, davidedmundson, romangg, zzag, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28882: Create protocol to manage video feeds

2020-05-08 Thread Aleix Pol Gonzalez
apol abandoned this revision. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D28882 To: apol, #kwin, jgrulich, davidedmundson, zzag Cc: meven, davidedmundson, romangg, zzag, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29540: plasmawindowmodel: Expose the internal id to the model

2020-05-08 Thread Aleix Pol Gonzalez
apol created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY It allows to use this class together with the screencast protocol. It's public API on the window anyway so it should probabl

D29445: [KOpenWithDialog] When pointing at a non-executable file print more meaningful error

2020-05-05 Thread Aleix Pol Gonzalez
apol added inline comments. INLINE COMMENTS > kopenwithdialog.cpp:1006 > // Ensure that the typed binary name actually exists (#81190) > if (QStandardPaths::findExecutable(binaryName).isEmpty()) { > +// Maybe it exists but isn't executable This patch D29170

D29406: Add X-KDE-Original-Executable to Applications properties

2020-05-04 Thread Aleix Pol Gonzalez
apol added a comment. > If I understand correctly, it is necessary to use dbus spectacle in this case, so that dbus can manage the application instance and make sure we end up with only one, whether we launch the app, use a shortcut or launch from command line. I don't think that's a go

D29405: [PoC] Make notifications work without a notifyrc file

2020-05-04 Thread Aleix Pol Gonzalez
apol added a comment. What's the advantage? Won't this make it harder to put together the notifications kcm? REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D29405 To: nicolasfella, #frameworks, broulik, vkrause Cc: apol, kde-frameworks-devel, LeGast00n, cbla

D29406: Add X-KDE-Original-Executable to Applications properties

2020-05-04 Thread Aleix Pol Gonzalez
apol added a comment. This should be documented somewhere, as is it's really confusing. I'm not sure it wouldn't be better to have spectacle launched again there instead of going through dbus (which is a change I admittedly don't understand very well). REPOSITORY R309 KService REVISI

D29396: Suppress find_package_handle_standard_args package name mismatch warning.

2020-05-03 Thread Aleix Pol Gonzalez
apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. This will make our configure steps readable again. Thanks! REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D29396 To: xuetianweng, #framewo

D29201: KCMUtils: Add option to append service file to list of arguments

2020-05-03 Thread Aleix Pol Gonzalez
apol added a comment. I have the feeling there's a missing piece here. Would it make sense to always pass it? Would it regress in any way? At the very least, on the API documentation, explain why one would want that. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.k

D29361: KCrash: remove debug output which breaks unittests from using ~/.qttest/config for categorized logging

2020-05-03 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R285 KCrash BRANCH master REVISION DETAIL https://phabricator.kde.org/D29361 To: dfaure, kossebau, davidedmundson, apol Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

Re: Information regarding upcoming Gitlab Migration: clarifications

2020-05-01 Thread Aleix Pol
On Fri, May 1, 2020 at 7:18 AM Ben Cooksley wrote: > > On Fri, May 1, 2020 at 4:38 PM Nate Graham wrote: > > > > > > > > On 4/30/20 5:59 PM, Aleix Pol wrote: > > > El jue., 30 de abr. de 2020 a la(s) 18:15, Albert Astals Cid > > >> Am I the

Re: Information regarding upcoming Gitlab Migration: clarifications

2020-04-30 Thread Aleix Pol
On Fri, May 1, 2020 at 1:08 AM Nicolás Alvarez wrote: > > El jue., 30 de abr. de 2020 a la(s) 18:15, Albert Astals Cid > (aa...@kde.org) escribió: > > > > El dijous, 30 d’abril de 2020, a les 21:31:02 CEST, Ben Cooksley va > > escriure: > > > On Fri, May 1, 2020 at 6:04 AM Ivan Čukić wrote: > >

2 new repositories: plasma-wayland-protocols and kwayland-server

2020-04-30 Thread Aleix Pol
Hi everyone, After long discussions, we have broken kwayland into 3 pieces so we can work and improve kwin_wayland without having to extend our stable framework constantly. This of course comes together with an updated policy with regards to where things should be developed with the goal of only ad

Re: Information regarding upcoming Gitlab Migration: clarifications

2020-04-30 Thread Aleix Pol
On Wed, Apr 29, 2020 at 12:25 PM Bhushan Shah wrote: > > Good afternoon, > > [Please keep sysad...@kde.org list or bs...@kde.org in the CC for > replies] > > I want to clarify some bits for which we have gotten a questions about, > > - Non unique naming: There's some teams which prefer if we dropp

D29278: Port KWin to KWaylandServer

2020-04-30 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes. Closed by commit R108:3a9d7a6e9d75: Port KWin to KWaylandServer (authored by apol). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D29278?vs=81574&id=81575#toc REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE htt

D29278: Port KWin to KWaylandServer

2020-04-30 Thread Aleix Pol Gonzalez
apol updated this revision to Diff 81574. apol added a comment. Address @zzag's comments REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29278?vs=81521&id=81574 BRANCH master REVISION DETAIL https://phabricator.kde.org/D29278 AFFECTED FILES CMakeLists.

D29278: Port KWin to KWaylandServer

2020-04-30 Thread Aleix Pol Gonzalez
apol marked an inline comment as done. REPOSITORY R108 KWin BRANCH master REVISION DETAIL https://phabricator.kde.org/D29278 To: apol, #kwin, #plasma, #frameworks, davidedmundson Cc: zzag, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, mkulinsk

D29278: Port KWin to KWaylandServer

2020-04-29 Thread Aleix Pol Gonzalez
apol created this revision. apol added reviewers: KWin, Plasma, Frameworks. Herald added a project: KWin. Herald added a subscriber: kwin. apol requested review of this revision. REVISION SUMMARY Away from KWayland::Server and KF5WaylandServer. TEST PLAN Builds, ran nested session REPOSITORY

D29256: [server] Introduce mapped() signal

2020-04-29 Thread Aleix Pol Gonzalez
apol accepted this revision. REPOSITORY R127 KWayland BRANCH introduce-mapped-signal REVISION DETAIL https://phabricator.kde.org/D29256 To: zzag, #kwin, davidedmundson, apol Cc: apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29079: android: include the architecture on the apk name

2020-04-28 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes. Closed by commit R240:fca97c036c8d: android: include the architecture on the apk name (authored by apol). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29079?vs=80829&id=814

D29256: [server] Introduce mapped() signal

2020-04-28 Thread Aleix Pol Gonzalez
apol added inline comments. INLINE COMMENTS > zzag wrote in surface_interface.cpp:333 > We can't use != because mapped() will be emitted each time a new buffer is > attached to the surface. I don't understand, ^ and != are logically equivalent, ^ is the bitwise counterpart. Am I missing somet

D29256: [server] Introduce mapped() signal

2020-04-28 Thread Aleix Pol Gonzalez
apol added a comment. +1 INLINE COMMENTS > surface_interface.cpp:333 > const bool childrenChanged = source->childrenChanged; > +const bool visibilityChanged = bool(source->buffer) ^ > bool(target->buffer); > bool sizeChanged = false; Using != would probably be more readable an

Re: Splitting KWayland

2020-04-28 Thread Aleix Pol
On Mon, Apr 27, 2020 at 2:57 PM Aleix Pol wrote: > > Hi, > As discussed in the meeting last week, I've been looking into the split. > > Here's what I was thinking of, please tell me if there's something > massively important I'm missing. > > The idea wo

D29231: [WIP] Add keyboard_shortcuts_inhibit protocol

2020-04-27 Thread Aleix Pol Gonzalez
apol added inline comments. INLINE COMMENTS > keyboard_shortcuts_inhibit_interface.cpp:144 > +QPair key(surface, seat); > +if (m_inhibitors.contains(key)) { > +return m_inhibitors[key]; Just `return m_inhibitors.value({ surface, seat })` to save a look-up and a few lines of code

D28882: Create protocol to manage video feeds

2020-04-27 Thread Aleix Pol Gonzalez
apol added a comment. > In future, it might be faster to put up just the interface xml for review first. @davidedmundson @zzag I don't really see how it would have made a difference, you only decided to review it 7 to 10 days after I first submitted it. 🤷 > What about using existi

D29231: [WIP] Add keyboard_shortcuts_inhibit protocol

2020-04-27 Thread Aleix Pol Gonzalez
apol added a comment. Code looks good overall, I'd say you'll get to polish the weird bits when developing the kwin side. In fact, this probably could be implemented within kwin considering what we discussed last week. We could remove the weirdness we have to keep its ABI. INLINE COMMEN

D28882: Create protocol to manage video feeds

2020-04-27 Thread Aleix Pol Gonzalez
apol updated this revision to Diff 81341. apol added a comment. Address review comments REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28882?vs=81113&id=81341 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28882 AFFECTED FILES autotest

D28882: Create protocol to manage video feeds

2020-04-27 Thread Aleix Pol Gonzalez
apol marked 2 inline comments as done. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D28882 To: apol, #kwin, jgrulich, davidedmundson Cc: meven, davidedmundson, romangg, zzag, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

Splitting KWayland

2020-04-27 Thread Aleix Pol
Hi, As discussed in the meeting last week, I've been looking into the split. Here's what I was thinking of, please tell me if there's something massively important I'm missing. The idea would be to start working on it after kwayland and other kf5 have been tagged next week (?). Something I was w

Re: Information regarding upcoming Gitlab Migration

2020-04-27 Thread Aleix Pol
On Mon, Apr 27, 2020 at 12:55 PM Ben Cooksley wrote: > > On Mon, Apr 27, 2020 at 10:39 PM Aleix Pol wrote: > > > > On Mon, Apr 27, 2020 at 3:41 AM Bhushan Shah wrote: > > > > > > [Please keep sysad...@kde.org list or bs...@kde.org in the CC for > > >

Re: Information regarding upcoming Gitlab Migration

2020-04-27 Thread Aleix Pol
On Mon, Apr 27, 2020 at 3:41 AM Bhushan Shah wrote: > > [Please keep sysad...@kde.org list or bs...@kde.org in the CC for > replies] > > Hello Community members, > > In view of upcoming Gitlab migration, we sysadmin team wants to share > the recommended structuring for the repositories on Gitlab.

D29216: Remove dead code since KF5.0: mount/umount devices in their contextmenu

2020-04-26 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH 2020_04_remove_dead_solid_code REVISION DETAIL https://phabricator.kde.org/D29216 To: dfaure, apol, broulik Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29181: Use KFileMetaData for XAttr support instead of private reimplementation

2020-04-25 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D29181 To: bruns, #baloo, ngraham, apol Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, domson, ashaposhnikov, mi

D28882: Create protocol to manage video feeds

2020-04-24 Thread Aleix Pol Gonzalez
apol updated this revision to Diff 81113. apol added a comment. Refactor the protocol as suggested by David and Vlad REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28882?vs=80984&id=81113 BRANCH master REVISION DETAIL https://phabricator.kde.org/D288

D28882: Create protocol to manage video feeds

2020-04-24 Thread Aleix Pol Gonzalez
apol marked an inline comment as done. apol added inline comments. INLINE COMMENTS > davidedmundson wrote in screencast.xml:31 > this is racey with create. Any suggestion on how to do it better? REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D28882 To: apol, #kwin, j

D28882: Create protocol to manage video feeds

2020-04-23 Thread Aleix Pol Gonzalez
apol updated this revision to Diff 80984. apol added a comment. Also propagate the buffer size, it's important for the client to know what buffer size it will have. REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28882?vs=80801&id=80984 BRANCH master R

D29102: Prefer QIcon::pixmap(QWindow*, ...) overload

2020-04-22 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes. Closed by commit R242:25ce2b90dab1: Prefer QIcon::pixmap(QWindow*, ...) overload (authored by apol). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29102?vs=80908&id=8

D29102: Prefer QIcon::pixmap(QWindow*, ...) overload

2020-04-22 Thread Aleix Pol Gonzalez
apol created this revision. apol added reviewers: Plasma, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY It takes into account the dpi of the screen we're rendering to. Other overloads as

D29097: Adapt FindKF5 to stricter checks in newer find_package_handle_standard_args

2020-04-22 Thread Aleix Pol Gonzalez
apol added a comment. +1 makes sense REPOSITORY R240 Extra CMake Modules BRANCH avoidnewwarningsinfindkf5 REVISION DETAIL https://phabricator.kde.org/D29097 To: kossebau, #frameworks, #build_system, cgiboudeaux Cc: apol, kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, bencre

D29063: Fix testpackage-appstream: XDG_DATA_DIRS needs to be explicitly extended

2020-04-21 Thread Aleix Pol Gonzalez
apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Looks like an improvement REPOSITORY R290 KPackage BRANCH fixXDG_DATA_DIRSextending REVISION DETAIL https://phabricator.kde.org/D29063 To: kossebau, #frameworks, mart, apol, sitter, bco

D29079: android: include the architecture on the apk name

2020-04-21 Thread Aleix Pol Gonzalez
apol created this revision. apol added reviewers: Android, Frameworks. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY Makes them easier to use afterwards. TEST PLAN Test

D29062: Port KToolInvocation::kdeinitExecWait to QProcess

2020-04-21 Thread Aleix Pol Gonzalez
apol accepted this revision. apol added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > kded.cpp:67 > > static void runKonfUpdate() > { The function has a typo, should be `runKConfUpdate`, no? REPOSITORY R297 KDED REVISION DETAIL https://phabricator.

  1   2   3   4   5   6   7   8   9   10   >