KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.14 - Build # 151 - Still Unstable!

2021-03-02 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.14/151/ Project: kf5-qt5 SUSEQt5.14 Date of build: Tue, 02 Mar 2021 19:01:13 + Build duration: 7 min 25 sec and counting BUILD ARTIFACTS abi-compa

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.15 - Build # 245 - Still Unstable!

2021-03-02 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.15/245/ Project: kf5-qt5 SUSEQt5.15 Date of build: Tue, 02 Mar 2021 18:55:13 + Build duration: 7 min 23 sec and counting BUILD ARTIFACTS abi-compa

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.14 - Build # 150 - Still Unstable!

2021-03-02 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.14/150/ Project: kf5-qt5 SUSEQt5.14 Date of build: Tue, 02 Mar 2021 18:34:29 + Build duration: 26 min and counting BUILD ARTIFACTS abi-compatibili

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.15 - Build # 244 - Still Unstable!

2021-03-02 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.15/244/ Project: kf5-qt5 SUSEQt5.15 Date of build: Tue, 02 Mar 2021 18:34:29 + Build duration: 20 min and counting BUILD ARTIFACTS abi-compatibili

D17816: Support for xattrs on kio copy/move

2021-03-02 Thread Kamil Dudka
kdudka added a comment. I am fine with kio implementing things differently as long as the basic functionality keeps working. I used to use Krusader to get images out of my camera and it simply stopped working for me with no obvious indication of what went wrong. This code tries to implemen

D17816: Support for xattrs on kio copy/move

2021-03-02 Thread Stefan Brüns
bruns added a comment. In D17816#677455 , @kdudka wrote: > @bruns I find your attitude unnecessarily hostile. If you think that the code is perfect as it is, feel free to patch it case by case until it eventually works for everybody. That is y

D17816: Support for xattrs on kio copy/move

2021-03-02 Thread Kamil Dudka
kdudka added a comment. @bruns I find your attitude unnecessarily hostile. If you think that the code is perfect as it is, feel free to patch it case by case until it eventually works for everybody. That is your choice. Anyway, strace of `cp --preserve=xattr` on the same device looks l

D17816: Support for xattrs on kio copy/move

2021-03-02 Thread Stefan Brüns
bruns added a comment. In D17816#677453 , @kdudka wrote: > I do not think we have to. Please have a look at how attr_copy_fd() from is implemented: http://git.savannah.nongnu.org/cgit/attr.git/tree/libattr/attr_copy_fd.c?id=a4187bec#n111 Thi

D17816: Support for xattrs on kio copy/move

2021-03-02 Thread Kamil Dudka
kdudka added a comment. I do not think we have to. Please have a look at how attr_copy_fd() from is implemented: http://git.savannah.nongnu.org/cgit/attr.git/tree/libattr/attr_copy_fd.c?id=a4187bec#n111 This code is quite mature and it is used by cp(1) on GNU/Linux for instance. I do no

D17816: Support for xattrs on kio copy/move

2021-03-02 Thread Stefan Brüns
bruns added a comment. In D17816#677451 , @kdudka wrote: > The man page says that one has to check return value of the second call. It does not say that the function needs to be called in a loop indefinitely until it succeeds. And if th

D17816: Support for xattrs on kio copy/move

2021-03-02 Thread Kamil Dudka
kdudka added a comment. The man page says that one has to check return value of the second call. It does not say that the function needs to be called in a loop indefinitely until it succeeds. REVISION DETAIL https://phabricator.kde.org/D17816 To: arrowd, dfaure, chinmoyr, bruns, #framewo

D17816: Support for xattrs on kio copy/move

2021-03-02 Thread Stefan Brüns
bruns added a comment. In D17816#677449 , @kdudka wrote: > Even after applying the proposed patch, the code still looks problematic to me. I would prefer to have it explained first. When fgetxattr(..., 0) returns -1/ERANGE, what is the point o

D17816: Support for xattrs on kio copy/move

2021-03-02 Thread Kamil Dudka
kdudka added a comment. Even after applying the proposed patch, the code still looks problematic to me. I would prefer to have it explained first. When fgetxattr(..., 0) returns -1/ERANGE, what is the point of calling fgetxattr(..., 0) again? It is still going to busy-loop indefinitely in

D17816: Support for xattrs on kio copy/move

2021-03-02 Thread Gleb Popov
arrowd added a comment. In D17816#677446 , @kdudka wrote: > I was wondering why copying files in Krusader or Dolphin from a vfat-formatted memory card stopped working for me after update. After copying the first file, the transfer stopped progr

Re: KCGroups in KDEreview

2021-03-02 Thread Kevin Ottens
Hello, On Tuesday, 2 March 2021 12:06:51 CET David Edmundson wrote: > > > (where 1000 is of course dynamic) > > > > Ditto, what enum names could we give to those? > > / -> All > /system.slice -> System > user.slice/user-1000.slice/user@1000.service -> User > user.slice/user-1000.slice/user@1000.

Re: KCGroups in KDEreview

2021-03-02 Thread David Edmundson
> > (where 1000 is of course dynamic) > > Ditto, what enum names could we give to those? / -> All /system.slice -> System user.slice/user-1000.slice/user@1000.service -> User user.slice/user-1000.slice/user@1000.service/app.slice -> UserApps user.slice/user-1000.slice/user@1000.service/session.sli