KDE CI: Frameworks » kirigami » kf5-qt5 FreeBSDQt5.15 - Build # 232 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20FreeBSDQt5.15/232/ Project: kf5-qt5 FreeBSDQt5.15 Date of build: Tue, 24 Nov 2020 15:12:58 + Build duration: 51 sec and counting JUnit Tests Name: projectroo

D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

vonreth added a comment. In D25119#676781 , @cullmann wrote: > Hmm, I don't think you need a theme chooser, we just need to watch for the palette change signal and then trigger again the theme name setting based on the background palette. > T

D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

cullmann added a comment. Hmm, I don't think you need a theme chooser, we just need to watch for the palette change signal and then trigger again the theme name setting based on the background palette. That would be enough to detect bright/dark mode. REPOSITORY R266 Breeze Icons REVISIO

D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

brute4s99 added subscribers: nicolasfella, brute4s99. brute4s99 added a comment. +1 to adding the breeze icons support for other OSes. (Thanks @nicolasfella for linking me to this diff). I have hit the same problem with the KDE Connect Windows port. Thank you for working on it! REPOSITO

D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

vonreth added a comment. And change those during runtime REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D25119 To: cullmann, #frameworks, vonreth, dfaure, rempt, ndavis, mart, alex-l Cc: aboyer, sars, wrobelda, davidedmundson, broulik, rempt, kde-frameworks

D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

vonreth added a comment. Yea my idea didn't make much sense. Reading your comment I realized that we should probably implement a theme chooser in a kf5 and provide the themes as plugins, that way we could also provide other themes, not just breeze. REPOSITORY R266 Breeze Icons REVISION