D26448: Add KRecentFilesMenu to replace KRecentFileAction

nicolasfella marked an inline comment as done. nicolasfella added inline comments. INLINE COMMENTS > dfaure wrote in krecentfilesmenu.cpp:150 > Depending on QtConcurrent is just fine. However QtConcurrent::filtered is for > CPU-intensive operations, not for I/O operations. 1) you don't want to p

D26448: Add KRecentFilesMenu to replace KRecentFileAction

nicolasfella updated this revision to Diff 83338. nicolasfella marked an inline comment as done. nicolasfella added a comment. - Fix @since - Add underscore to filename - Reserve vector CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26448?vs=83337&id=83338 BRANCH recentfilemen

D26448: Add KRecentFilesMenu to replace KRecentFileAction

nicolasfella marked 6 inline comments as done. REVISION DETAIL https://phabricator.kde.org/D26448 To: nicolasfella, #frameworks, dfaure Cc: broulik, elvisangelaccio, cfeck, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D26448: Add KRecentFilesMenu to replace KRecentFileAction

nicolasfella updated this revision to Diff 83337. nicolasfella marked an inline comment as done. nicolasfella added a comment. - Make findEntry return non-const iterator - Use std::vector - Truncate entries when setting maximum CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26448

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.15 - Build # 54 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.15/54/ Project: kf5-qt5 SUSEQt5.15 Date of build: Mon, 03 Aug 2020 15:52:14 + Build duration: 2 min 10 sec and counting BUILD ARTIFACTS abi-compatibi

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.12 - Build # 558 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.12/558/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 03 Aug 2020 15:51:18 + Build duration: 35 sec and counting CONSOLE OUTPUT [...truncated 240 li

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.15 - Build # 53 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.15/53/ Project: kf5-qt5 SUSEQt5.15 Date of build: Mon, 03 Aug 2020 15:50:21 + Build duration: 1 min 51 sec and counting BUILD ARTIFACTS abi-compatibi

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.12 - Build # 557 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.12/557/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 03 Aug 2020 15:50:21 + Build duration: 55 sec and counting CONSOLE OUTPUT [...truncated 231 li

KDE CI: Frameworks » kirigami » kf5-qt5 FreeBSDQt5.15 - Build # 50 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20FreeBSDQt5.15/50/ Project: kf5-qt5 FreeBSDQt5.15 Date of build: Mon, 03 Aug 2020 15:50:21 + Build duration: 1 min 2 sec and counting JUnit Tests Name: projec

KDE CI: Frameworks » kirigami » kf5-qt5 WindowsMSVCQt5.14 - Build # 236 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20WindowsMSVCQt5.14/236/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Mon, 03 Aug 2020 15:50:21 + Build duration: 38 sec and counting CONSOLE OUTPUT [...tr

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.15 - Build # 29 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.15/29/ Project: kf5-qt5 FreeBSDQt5.15 Date of build: Mon, 03 Aug 2020 14:41:52 + Build duration: 1 min 41 sec and counting JUnit Tests Name: pr

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.15 - Build # 28 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.15/28/ Project: kf5-qt5 FreeBSDQt5.15 Date of build: Mon, 03 Aug 2020 14:40:11 + Build duration: 1 min 39 sec and counting JUnit Tests Name: pr

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 762 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/762/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 03 Aug 2020 12:42:22 + Build duration: 5 min 6 sec and counting BUILD ARTIFACTS acc/KF5KIO-5.73.0.x

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 761 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/761/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 03 Aug 2020 12:34:34 + Build duration: 7 min 46 sec and counting BUILD ARTIFACTS acc/KF5KIO-5.73.0

Re: Policy on forward declarations for things from external libraries

On Fri, Jul 31, 2020 at 5:56 PM Vlad Zahorodnii wrote: > > Howdy, > > From time to time, I find myself in a situation where a code reviewer > suggests to replace #include with the corresponding class > forward declaration. Such discussions usually get us nowhere because > neither the code review

Re: kwayland's testRemoteAccess still flaky

Urgh, let me just remove that test. No-one will even use that protocol soon anyway.

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.15 - Build # 61 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.15/61/ Project: kf5-qt5 FreeBSDQt5.15 Date of build: Mon, 03 Aug 2020 08:21:37 + Build duration: 2 min 48 sec and counting JUnit Tests Nam