D29003: Use Q_EMIT and build with QT_NO_KEYWORDS

junghans added a comment. Thank you for committing! Although I recently gained push rights, I did not have time yet to dig into the details of how to create/push commit respecting the KDE standards etc. Next time, I'll try on my own :) REPOSITORY R275 KItemModels REVISION DETAIL https:/

D17816: Support for xattrs on kio copy/move

bruns added inline comments. INLINE COMMENTS > jobtest.cpp:502 > +// arguments 0:"-n" 1:"name" 2:"-v", 3:"value" 4:src > +arguments = QStringList {"-n", "", "-v", "", "-h", src}; > +keyIndex = 1; `std::function m_setXattrFormatArgs;` ... m_setXattrFormatArgs = [](con

D29397: KPreviewJob : Support for DeviceRatioPixel

ngraham added a comment. Here's where the spec lives, FWIW: https://gitlab.freedesktop.org/xdg/xdg-specs Expanding it is mostly just a matter of writing up a reasonable proposal in the form of a merge request and getting enough people to agree. Discussing on the mailing list first can h

D29832: Fix Endianness issue during wallet decryption

ngraham added a reviewer: aacid. ngraham added a comment. Thanks for the patch! FWIW we have moved patch review to GitLab; consider abandoning this and re-submitting it as a merge request at https://invent.kde.org/frameworks/kwallet/-/merge_requests Here's some documentation: https://com

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.14 - Build # 21 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.14/21/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Tue, 26 May 2020 00:26:58 + Build duration: 3 min 55 sec and counting JUnit Tests Name: pr

D29832: Fix Endianness issue during wallet decryption

chriscz added a comment. This stack overflow answer has a more exhaustive approach to determining endianness. It may be worth extracting this code into a more appropriate header file though. Also here's the issue on the bugzilla tracker

D29832: Fix Endianness issue during wallet decryption

chriscz created this revision. chriscz added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. chriscz requested review of this revision. REVISION SUMMARY Correctly determine endianness on the specific platform using `endian.h' header avail

D29003: Use Q_EMIT and build with QT_NO_KEYWORDS

kossebau closed this revision. REPOSITORY R275 KItemModels REVISION DETAIL https://phabricator.kde.org/D29003 To: junghans, kossebau, dfaure, apol Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29003: Use Q_EMIT and build with QT_NO_KEYWORDS

kossebau added a comment. Looking at D28915 , seems you are only collecting to earn push rights so far :), so going to push for you with the author info taken from there. REPOSITORY R275 KItemModels REVISION DETAIL https://phabricator.kde.org/D29003

D25814: [KColorScheme] Add SeparatorColor

ndavis added a comment. How would we add the separator role to color scheme files if separator color was added to upstream Qt? Wouldn't we still need to add a separator role to KColorScheme so that we could map the color in the color scheme file to the equivalent QPalette ColorRole? REPOSIT

KDE CI: Frameworks » krunner » kf5-qt5 SUSEQt5.12 - Build # 95 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/krunner/job/kf5-qt5%20SUSEQt5.12/95/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 25 May 2020 16:36:26 + Build duration: 2 min 33 sec and counting BUILD ARTIFACTS abi-compatibil

KDE CI: Frameworks » krunner » kf5-qt5 SUSEQt5.14 - Build # 18 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/krunner/job/kf5-qt5%20SUSEQt5.14/18/ Project: kf5-qt5 SUSEQt5.14 Date of build: Mon, 25 May 2020 16:36:25 + Build duration: 2 min 59 sec and counting BUILD ARTIFACTS abi-compatibil

KDE CI: Frameworks » krunner » kf5-qt5 FreeBSDQt5.14 - Build # 19 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/krunner/job/kf5-qt5%20FreeBSDQt5.14/19/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Mon, 25 May 2020 16:36:26 + Build duration: 1 min 21 sec and counting JUnit Tests Name: projec

D29397: KPreviewJob : Support for DeviceRatioPixel

kossebau added a comment. In D29397#673830 , @ngraham wrote: > The approach makes sense then. I agree that making high DPI a part of the FDO spec would be nice, but IMO that shouldn't block this. The approach currently taken is logical and it co

D29397: KPreviewJob : Support for DeviceRatioPixel

meven added inline comments. INLINE COMMENTS > ngraham wrote in previewjob.cpp:401 > What about if I'm using a 250% scale factor? Maybe there should be an `@3x` > folder too. or just trunate devicePixelRatio to int REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D29397 To

D29397: KPreviewJob : Support for DeviceRatioPixel

ngraham added a comment. The approach makes sense then. I agree that making high DPI a part of the FDO spec would be nice, but IMO that shouldn't block this. The approach currently taken is logical and it could be submitted as an extension to the spec later. INLINE COMMENTS > ngraham wrote

D29815: Fix blurry icons in titlebar appmenu by adding UseHighDpiPixmaps flag

anthonyfieroni added a comment. Wait @davidedmundson to accept it. REPOSITORY R297 KDED REVISION DETAIL https://phabricator.kde.org/D29815 To: mthw, #frameworks, davidedmundson Cc: anthonyfieroni, broulik, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

Re: KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.14 - Build # 19 - Still Unstable!

On 2020-05-25 16:29, David Faure wrote: Isn't this fixed by https://codereview.qt-project.org/c/qt/qtdeclarative/+/300911 ? (This fix happened because I reported this ktexteditor CI ASAN failure to Simon Haussman, who fixed qtdeclarative) IIUC all that's missing is a backport of the fix to 5.

D29815: Fix blurry icons in titlebar appmenu by adding UseHighDpiPixmaps flag

mthw added a comment. Do I need to change anything or is this acceptable? REPOSITORY R297 KDED REVISION DETAIL https://phabricator.kde.org/D29815 To: mthw, #frameworks, davidedmundson Cc: anthonyfieroni, broulik, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

Re: KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.14 - Build # 19 - Still Unstable!

Isn't this fixed by https://codereview.qt-project.org/c/qt/qtdeclarative/+/300911 ? (This fix happened because I reported this ktexteditor CI ASAN failure to Simon Haussman, who fixed qtdeclarative) IIUC all that's missing is a backport of the fix to 5.14.x, right? I just left a note in the abov

D29397: KPreviewJob : Support for DeviceRatioPixel

kossebau added a comment. @meven Have you already got in contact with the other users/maintainers of he thumnbail cache spec about the idea to extend it with support for high dpi? If not, please consider to do so, so things will also work cross-toolkit/platforms in the future there, by being

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.14 - Build # 52 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.14/52/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Mon, 25 May 2020 09:17:20 + Build duration: 1 min 39 sec and counting JUnit Tests Name

D28590: Add a QString Solid::Device::displayName, used in Fstab Device for network mounts

ervin added inline comments. INLINE COMMENTS > meven wrote in device.h:99 > Well I have to make this virtual it seems so this call is dynamically > dispatched by `return_SOLID_CALL(Ifaces::Device *, d->backendObject(), > QString(), displayName());` > I assumed this would work based on my review