D29084: Make the HTML file template more useful

gszymaszek created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. gszymaszek requested review of this revision. REVISION SUMMARY This commit removes the empty meta tag and adds the following: - a DOCTYPE declaration, - an html[lang] att

D29083: correct vscode icon name

guoyunhe created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. guoyunhe requested review of this revision. REVISION SUMMARY `com.visualstudio.code.svg` and `com.visualstudio.code.oss.svg` REPOSITORY R266 Breeze Icons BRANCH master REVI

D29083: correct vscode icon name

guoyunhe added a reviewer: Breeze. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D29083 To: guoyunhe, #breeze Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29072: Optimize SVG

guoyunhe added a comment. I do try scour but the result is disappointing. I get 16 times the following error: hge difference of 123 in ./icons-dark/apps/48/hwinfo.svg which means 16 icons are unacceptable after scour optimization REPOSITORY R266 Breeze Icons REVISION DETAIL

D29054: [Wayland] Add to PlasmaWindowManagement protocol windows stacking order

zzag added inline comments. INLINE COMMENTS > plasmawindowmanagement.cpp:242 > > +void PlasmaWindowManagement::Private::stackingOrderCallback(void *data, > org_kde_plasma_window_management *interface, wl_array *ids) { > +auto wm = reinterpret_cast(data); The opening brace must be on a new

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.14 - Build # 5 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.14/5/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Wed, 22 Apr 2020 04:20:44 + Build duration: 34 min and counting JUnit Tests Name: proje

D29072: Optimize SVG

ngraham added a comment. In D29072#654216 , @ndavis wrote: > If we're going to actually use the optimization script, we should use `scour` instead of SVGO. Scour is the SVG optimizer that is least likely to screw up and SVG. These days, the purp

D29063: Fix testpackage-appstream: XDG_DATA_DIRS needs to be explicitly extended

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Looks like an improvement REPOSITORY R290 KPackage BRANCH fixXDG_DATA_DIRSextending REVISION DETAIL https://phabricator.kde.org/D29063 To: kossebau, #frameworks, mart, apol, sitter, bco

D29079: android: include the architecture on the apk name

apol created this revision. apol added reviewers: Android, Frameworks. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY Makes them easier to use afterwards. TEST PLAN Test

D29062: Port KToolInvocation::kdeinitExecWait to QProcess

apol accepted this revision. apol added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > kded.cpp:67 > > static void runKonfUpdate() > { The function has a typo, should be `runKConfUpdate`, no? REPOSITORY R297 KDED REVISION DETAIL https://phabricator.

D29072: Optimize SVG

ndavis added a comment. The Scour settings I recommend are `--set-precision=8 --enable-viewboxing --enable-comment-stripping --remove-descriptive-elements --create-groups --strip-xml-space --strip-xml-prolog --nindent=4` REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.k

D29070: add alligator icon

ndavis accepted this revision. REPOSITORY R266 Breeze Icons BRANCH alligator (branched from master) REVISION DETAIL https://phabricator.kde.org/D29070 To: mbruchert, tfella, #vdg, ndavis Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D29072: Optimize SVG

ndavis added a comment. If we're going to actually use the optimization script, we should use `scour` instead of SVGO. Scour is the SVG optimizer that is least likely to screw up and SVG. These days, the purpose of SVG optimization is to make the code readable. REPOSITORY R266 Breeze Icon

D29072: Optimize SVG

ndavis added a comment. > You can check pixel diff in Git Cola. How do I do this? I was not aware of that feature. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D29072 To: guoyunhe, #breeze, ndavis, #vdg Cc: kde-frameworks-devel, LeGast00n, cblack, michael

D29072: Optimize SVG

ngraham added reviewers: ndavis, VDG. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D29072 To: guoyunhe, #breeze, ndavis, #vdg Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29069: Falkon icon - Removing circle & adding outline

ngraham added a comment. I have to agree. This icon isn't my favorite one ever because of the lavender color, but I really like the background circle that the head is slightly escaping from. I think it's a pretty good composition. REPOSITORY R266 Breeze Icons REVISION DETAIL https://pha

D29032: Add 16px Vvave icon

ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH vvave16px (branched from master) REVISION DETAIL https://phabricator.kde.org/D29032 To: manueljlin, #vdg, ndavis Cc: ndavis, kde-frameworks-devel, LeGast00n, cblack, michael

D29049: add telephant icon

ndavis accepted this revision. REPOSITORY R266 Breeze Icons BRANCH telephant (branched from master) REVISION DETAIL https://phabricator.kde.org/D29049 To: mbruchert, muesli, #vdg, ndavis Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D29069: Falkon icon - Removing circle & adding outline

ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. I don't think this is necessary. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D29069 To: saligari, #vdg, abetts, #falkon, ndavis Cc: ndavis, kde-f

D28590: Add a QString Solid::Device::displayName, used in Fstab Device for network mounts

bruns requested changes to this revision. bruns added a comment. This revision now requires changes to proceed. Do not create m_storageAccess in the constructor REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D28590 To: meven, #frameworks, bruns, sitter Cc: kde-framewor

D29068: [NetworkManager-qt] replace foreach (deprecated) with range-for, first pass

This revision was automatically updated to reflect the committed changes. Closed by commit R282:7fdf493b041a: [NetworkManager-qt] replace foreach (deprecated) with range-for, first pass (authored by ahmadsamir). REPOSITORY R282 NetworkManagerQt CHANGES SINCE LAST UPDATE https://phabricator.k

D29072: Optimize SVG

guoyunhe updated this revision to Diff 80811. guoyunhe added a comment. - Merge some paths REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29072?vs=80810&id=80811 BRANCH master REVISION DETAIL https://phabricator.kde.org/D29072 AFFECTED FILES i

D29070: add alligator icon

tfella edited the summary of this revision. REPOSITORY R266 Breeze Icons BRANCH alligator (branched from master) REVISION DETAIL https://phabricator.kde.org/D29070 To: mbruchert, tfella, #vdg Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D29072: Optimize SVG

guoyunhe edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D29072 To: guoyunhe, #breeze Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29072: Optimize SVG

guoyunhe added a reviewer: Breeze. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D29072 To: guoyunhe, #breeze Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29070: add alligator icon

ngraham added a comment. This is my favorite icon in a very long time. REPOSITORY R266 Breeze Icons BRANCH alligator (branched from master) REVISION DETAIL https://phabricator.kde.org/D29070 To: mbruchert, tfella, #vdg Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, br

D29072: Optimize SVG

guoyunhe created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. guoyunhe requested review of this revision. REVISION SUMMARY Updated optimize-svg.sh script and optimize SVG files. REPOSITORY R266 Breeze Icons BRANCH master REVISION DETA

D29069: Falkon icon - Removing circle & adding outline

ngraham added reviewers: abetts, Falkon. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D29069 To: saligari, #vdg, abetts, #falkon Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29070: add alligator icon

mbruchert added a comment. In D29070#654088 , @tfella wrote: > I love the idea with the teeth 👍 Thank you :) REPOSITORY R266 Breeze Icons BRANCH alligator (branched from master) REVISION DETAIL https://phabricator.kde.org/D29070

D28460: Add KCModuleData as base class for plugin

bport retitled this revision from "Add KCModuleDada as base class for plugin" to "Add KCModuleData as base class for plugin". REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D28460 To: bport, #plasma, ervin Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, michaelh,

D29069: Falkon icon - Removing circle & adding outline

saligari added a comment. F8252134: diff.png Uploaded in 128x128 the old (left) and new (right) icon next to each other. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D29069 To: saligari, #vdg Cc: kde-frameworks-devel

D29069: Falkon icon - Removing circle & adding outline

tfella added a reviewer: VDG. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D29069 To: saligari, #vdg Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29070: add alligator icon

tfella accepted this revision. tfella added a comment. This revision is now accepted and ready to land. I love the idea with the teeth 👍 REPOSITORY R266 Breeze Icons BRANCH alligator (branched from master) REVISION DETAIL https://phabricator.kde.org/D29070 To: mbruchert, tfella, #vdg

D29070: add alligator icon

mbruchert added reviewers: tfella, VDG. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D29070 To: mbruchert, tfella, #vdg Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29068: [NetworkManager-qt] replace foreach (deprecated) with range-for, first pass

jgrulich accepted this revision. This revision is now accepted and ready to land. REPOSITORY R282 NetworkManagerQt BRANCH l-foreach-1 (branched from master) REVISION DETAIL https://phabricator.kde.org/D29068 To: ahmadsamir, #frameworks, jgrulich Cc: kde-frameworks-devel, LeGast00n, cblack

D29069: Falkon icon - Removing circle & adding outline

saligari retitled this revision from "Removed the purple gradient circle that surrounded the falkon, added it as an outline - made some crude adjustments, I'm not proud of. But I did this because, a) I didn't like the circle and b) there is no good reason I can think to have it, this..." to "Fal

D29070: add alligator icon

mbruchert created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mbruchert requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH alligator (branched from master) REVISION DETAIL https://phabricator.kde.org/D29070 AFFECT

D29070: add alligator icon

mbruchert added a comment. F8252116: grafik.png REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D29070 To: mbruchert Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29069: Removed the purple gradient circle that surrounded the falkon, added it as an outline - made some crude adjustments, I'm not proud of. But I did this because, a) I didn't like the circle and b

saligari created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. saligari requested review of this revision. REVISION SUMMARY ...way it has a distinct shape. REPOSITORY R266 Breeze Icons BRANCH falkon-icon-patch (branched from master) RE

D29068: [NetworkManager-qt] replace foreach (deprecated) with range-for, first pass

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, jgrulich. Herald added a project: Frameworks. Herald added 1 blocking reviewer(s): jgrulich. ahmadsamir requested review of this revision. TEST PLAN make && ctest REPOSITORY R282 NetworkManagerQt BRANCH l-foreach-1 (

D28701: Add KPackage support to KNewStuffCore

leinir added a comment. In D28701#653954 , @ngraham wrote: > I mean, GHNS basically *is* a userspace package manager, and things like dependency management and removal of stale files are why package managers exist. :) > > If it needs to be f

D28882: Create protocol to manage video feeds

apol updated this revision to Diff 80801. apol added a comment. Hopefully fix the build for Jan REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28882?vs=80798&id=80801 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28882 AFFECTED FILES

D29049: add telephant icon

muesli accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH telephant (branched from master) REVISION DETAIL https://phabricator.kde.org/D29049 To: mbruchert, muesli, #vdg Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michael

D28460: Add KCModuleDada as base class for plugin

ervin accepted this revision. ervin added a comment. This revision is now accepted and ready to land. Please fix the typo in the commit title before pushing, otherwise looks fine to me. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D28460 To: bport, #plasma, ervin

D29049: add telephant icon

mbruchert added a comment. In D29049#653807 , @muesli wrote: > Gets my approval! I assume those symlinks from 'com.fribbledom.telephant.svg' are intentional to match the appstream ID? could you officially approve it? REPOSITORY R266 Br

D29049: add telephant icon

mbruchert added a comment. In D29049#653807 , @muesli wrote: > Gets my approval! I assume those symlinks from 'com.fribbledom.telephant.svg' are intentional to match the appstream ID? yes they are REPOSITORY R266 Breeze Icons REVISION

D28882: Create protocol to manage video feeds

apol updated this revision to Diff 80798. apol added a comment. - Test Cleanup - When a resource is destroyed, emit to close all its streams REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28882?vs=80677&id=80798 BRANCH master REVISION DETAIL https:

D28701: Add KPackage support to KNewStuffCore

ngraham added a comment. I mean, GHNS basically *is* a userspace package manager, and things like dependency management and removal of stale files are why package managers exist. :) If it needs to be fixed/implemented in other patches, that's okay. REPOSITORY R304 KNewStuff REVISION

D29049: add telephant icon

ngraham added a comment. It's so cute! REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D29049 To: mbruchert, muesli, #vdg Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D29037: Add preferences-desktop-tablet and preferences-desktop-touchpad icons

This revision was automatically updated to reflect the committed changes. Closed by commit R266:27fb93d84c2c: Add preferences-desktop-tablet and preferences-desktop-touchpad icons (authored by Guo Yunhe ). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phab

D29065: [KFontChooser] Add a DisplayFlag to allow not showing fixedOnly checkbox

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, cfeck, bport. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY This is useful for apps that only want users to select monospaced fonts, and apps that embed KFontC

D29037: Add preferences-desktop-tablet and preferences-desktop-touchpad icons

broulik added a comment. At first glance I thought that drawing tablet icon was about the scroll bar REPOSITORY R266 Breeze Icons BRANCH master REVISION DETAIL https://phabricator.kde.org/D29037 To: guoyunhe, #breeze, ngraham Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, micha

D29037: Add preferences-desktop-tablet and preferences-desktop-touchpad icons

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH master REVISION DETAIL https://phabricator.kde.org/D29037 To: guoyunhe, #breeze, ngraham Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29063: Fix testpackage-appstream: XDG_DATA_DIRS needs to be explicitly extended

sitter added a comment. Looks reasonable. @apol thoughts? REPOSITORY R290 KPackage REVISION DETAIL https://phabricator.kde.org/D29063 To: kossebau, #frameworks, mart, apol, sitter, bcooksley Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29063: Fix testpackage-appstream: XDG_DATA_DIRS needs to be explicitly extended

kossebau added a comment. Small disadvantage of the current code is that this binds things to the value of XDG_DATA_DIRS at "cmake" runtime, not "make test" runtime. That would need the move of the env var setting into kpackagetoolappstreamtest.cmake I guess. Tell if you think that is import

D29063: Fix testpackage-appstream: XDG_DATA_DIRS needs to be explicitly extended

kossebau created this revision. kossebau added reviewers: Frameworks, mart, apol, sitter, bcooksley. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Setting XDG_DATA_DIRS in the ENVIRONMENT property

D29062: Port KToolInvocation::kdeinitExecWait to QProcess

broulik created this revision. broulik added reviewers: davidedmundson, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. TEST PLAN Part of T12185 Verified it's callin

D29054: [Wayland] Add to PlasmaWindowManagement protocol windows stacking order

bport updated this revision to Diff 80784. bport marked 4 inline comments as done. bport added a comment. - Send stack order on bind - Check ressource have good protocol version REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29054?vs=80772&id=80784 REVI

D29037: Add preferences-desktop-tablet and preferences-desktop-touchpad icons

ngraham added a dependent revision: D29040: Use colorful icon instead of monochrome icon for touchpad kcm. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D29037 To: guoyunhe, #breeze Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29037: Add preferences-desktop-tablet and preferences-desktop-touchpad icons

ngraham removed a dependency: D29040: Use colorful icon instead of monochrome icon for touchpad kcm. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D29037 To: guoyunhe, #breeze Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29032: Add 16px Vvave icon

manueljlin edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D29032 To: manueljlin, #vdg Cc: ndavis, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29061: [KCharSelect] Minor code optimisation

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, cfeck, dfaure. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY - Replace one last foreach with range-for, and set -DQT_NO_FOREACH - More const and static where appropria

D29054: [Wayland] Add to PlasmaWindowManagement protocol windows stacking order

davidedmundson added inline comments. INLINE COMMENTS > plasma-window-management.xml:77 > + > +This event will be sent when stacking order changed > + we also need to send it on bind > plasma-window-management.xml:83 > > > Can we change them all at once. > plas

D29049: add telephant icon

muesli added a comment. Gets my approval! I assume those symlinks from 'com.fribbledom.telephant.svg' are intentional to match the appstream ID? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D29049 To: mbruchert, muesli, #vdg Cc: kde-frameworks-devel, LeGast00

D29051: Add ecm_generate_dbus_service_file

broulik updated this revision to Diff 80776. broulik added a comment. Add docs rst REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29051?vs=80775&id=80776 REVISION DETAIL https://phabricator.kde.org/D29051 AFFECTED FILES docs/module/ECMGene

D29051: Add ecm_generate_dbus_service_file

broulik updated this revision to Diff 80775. broulik added a comment. - Improve docs - Add `DESTINATION` arg REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29051?vs=80766&id=80775 REVISION DETAIL https://phabricator.kde.org/D29051 AFFECTED

D29054: [Wayland] Add to PlasmaWindowManagement protocol windows stacking order

bport added a dependent revision: D29056: [libtaskmanager] add stacking order data for wayland. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D29054 To: bport, zzag, davidedmundson Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29054: [Wayland] Add to PlasmaWindowManagement protocol windows stacking order

bport created this revision. bport added reviewers: zzag, davidedmundson. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. bport requested review of this revision. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D29054 AFFECTED FILES

D29051: Add ecm_generate_dbus_service_file

kossebau added a comment. Some first quick comments, not yet looked at code itself. Misses also link file from doc/. INLINE COMMENTS > ECMGenerateDBusServiceFile.cmake:6 > +# This module provides the ``ecm_generate_dbus_service_file`` function for > +# generating a D-Bus service file. >

D29051: Add ecm_generate_dbus_service_file

broulik edited the summary of this revision. broulik edited the test plan for this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D29051 To: broulik, #frameworks, davidedmundson, kossebau, kfunk, habacker Cc: kde-frameworks-devel, kde-buildsystem, L

D29051: Add ecm_generate_dbus_service_file

broulik edited the test plan for this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D29051 To: broulik, #frameworks, davidedmundson, kossebau, kfunk, habacker Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, bencreasy, michaelh, ngrah

D29051: Add ecm_generate_dbus_service_file

broulik created this revision. broulik added reviewers: Frameworks, davidedmundson, kossebau, kfunk, habacker. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY It serves a

D29050: WIP KRunner: Fix Bug 420311

alex edited the summary of this revision. REPOSITORY R308 KRunner REVISION DETAIL https://phabricator.kde.org/D29050 To: alex, meven, ngraham, broulik Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29050: WIP KRunner: Fix Bug 420311

alex created this revision. alex added reviewers: meven, ngraham, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. alex requested review of this revision. REVISION SUMMARY BUG: 420311. Because the teardown was rquested and checked the prepped variab

D29032: Add 16px Vvave icon

manueljlin edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D29032 To: manueljlin, #vdg Cc: ndavis, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29032: Add 16px Vvave icon

manueljlin updated this revision to Diff 80763. manueljlin added a comment. - Add 16px Vvave icon - Update icon style REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29032?vs=80717&id=80763 BRANCH vvave16px (branched from master) REVISION DETAIL

D28856: Save disabling of desktop file components in kglobalshortcutsrc

meven requested changes to this revision. meven added a comment. This revision now requires changes to proceed. Just two qDebug to remove, seems fine otherwise INLINE COMMENTS > globalshortcutsregistry.cpp:95 > { > +qDebug() << component->uniqueName(); > if (_components.value(co

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.12 - Build # 96 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.12/96/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 21 Apr 2020 13:07:03 + Build duration: 2 min 13 sec and counting BUILD ARTIFACTS abi-compatibi

D29049: add telephant icon

mbruchert added a reviewer: VDG. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D29049 To: mbruchert, muesli, #vdg Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29049: add telephant icon

mbruchert added a comment. F8251544: grafik.png REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D29049 To: mbruchert, muesli Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29049: add telephant icon

ognarb added a reviewer: muesli. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D29049 To: mbruchert, muesli Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29049: add telephant icon

mbruchert created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mbruchert requested review of this revision. REVISION SUMMARY add link to appstream-ID REPOSITORY R266 Breeze Icons BRANCH telephant (branched from master) REVISION DETAIL

D29033: Remove duplicated code

apol abandoned this revision. apol added a comment. My bad, thanks! REPOSITORY R130 Frameworks integration plugin using KWayland REVISION DETAIL https://phabricator.kde.org/D29033 To: apol, #frameworks, zzag Cc: zzag, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, z

D29033: Remove duplicated code

zzag requested changes to this revision. zzag added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > waylandintegration.cpp:191 > [this] (PlasmaWindow *w) { > -emit KWindowSystem::self()->windowAdded(w->internalId()); > -

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.14 - Build # 30 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.14/30/ Project: kf5-qt5 SUSEQt5.14 Date of build: Tue, 21 Apr 2020 12:26:06 + Build duration: 3 min 23 sec and counting BUILD ARTIFACTS abi-compatibil

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.12 - Build # 427 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.12/427/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 21 Apr 2020 12:26:06 + Build duration: 3 min 4 sec and counting BUILD ARTIFACTS abi-compatibil

D29034: Add systemd user service file for kded

broulik planned changes to this revision. REPOSITORY R297 KDED REVISION DETAIL https://phabricator.kde.org/D29034 To: broulik, #plasma, #frameworks Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D27158: Fix some compiler warnings

This revision was automatically updated to reflect the committed changes. Closed by commit R237:fb29718d3ac6: Fix some compiler warnings (authored by ahmadsamir). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27158?vs=80753&id=80754 REVISION DETAIL https:/

D27158: Fix some compiler warnings

ahmadsamir updated this revision to Diff 80753. ahmadsamir added a comment. Rebase REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27158?vs=75028&id=80753 BRANCH l-compiler-warnings (branched from master) REVISION DETAIL https://phabricator.kde.org/D27

D29035: Install service files for kwin

davidedmundson added a comment. I'm not sure why we set KillMode Though I'm favour of merging then tweaking some of this, the service files won't do anything till someone pulls them in. Don't push before relevant ECM and relevant p-w patch is in INLINE COMMENTS > plasma-kwin_x11.se

D28499: [LauncherJobs] Emit description

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28499 To: broulik, #frameworks, davidedmundson Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D28882: Create protocol to manage video feeds

jgrulich added a comment. In D28882#653483 , @jgrulich wrote: > Doesn't seem to build here: > > In file included from /home/jgrulich/development/projects/kde/kwayland/src/server/screencasting_interface.cpp:7: > /home/jgrulich/developme

D28244: GIT_SILENT minor code formatting

ahmadsamir abandoned this revision. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D28244 To: ahmadsamir, #frameworks Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28882: Create protocol to manage video feeds

jgrulich added a comment. Doesn't seem to build here: In file included from /home/jgrulich/development/projects/kde/kwayland/src/server/screencasting_interface.cpp:7: /home/jgrulich/development/projects/kde/kwayland/src/server/screencasting_interface.h:32:121: error: ‘std::functio

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.14 - Build # 10 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.14/10/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Tue, 21 Apr 2020 10:18:34 + Build duration: 1 min 34 sec and counting JUnit Tests Name: projectr

D28780: [FstabWatcher] Fix loosing of fstab watcher

This revision was automatically updated to reflect the committed changes. Closed by commit R245:5f97573881fe: [FstabWatcher] Fix loosing of fstab watcher (authored by bruns). REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28780?vs=79954&id=80741 REVISION DETAIL

D29018: Align description in metainfo.yaml with the one of README.md

This revision was automatically updated to reflect the committed changes. Closed by commit R174:82db5c4d8067: Align description in metainfo.yaml with the one of README.md (authored by kossebau). REPOSITORY R174 KContacts CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29018?vs=80674&i

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.14 - Build # 29 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.14/29/ Project: kf5-qt5 SUSEQt5.14 Date of build: Tue, 21 Apr 2020 10:07:06 + Build duration: 2 min 41 sec and counting BUILD ARTIFACTS abi-compatibi

KDE CI: Frameworks » kirigami » kf5-qt5 WindowsMSVCQt5.14 - Build # 104 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20WindowsMSVCQt5.14/104/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Tue, 21 Apr 2020 10:07:06 + Build duration: 2 min 19 sec and counting JUnit Tests Na

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.12 - Build # 426 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.12/426/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 21 Apr 2020 10:07:06 + Build duration: 2 min 38 sec and counting BUILD ARTIFACTS abi-compatib

  1   2   >