D28535: [KIO-MTP] Fix null pointer dereference

anthonyfieroni added a comment. Ok that's look good to me. We can move that code in constructor just before loop for storages, then use m_mtpdevice instead of raw device, but it looks like removed code is just a noise and it shouldn't present at all. +1 REPOSITORY R320 KIO Extras REV

D28128: Add force save behavior to KEntryMap

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D28128 To: bport, ervin, dfaure, meven, crossi, hchain Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28421: Add static method to check start condition

davidedmundson added inline comments. INLINE COMMENTS > dfaure wrote in kautostart.h:289 > This is new public API, it's missing @since 5.69 Added. https://commits.kde.org/kservice/ce83ae51bfc88be77573745ed8a4434393b2f9f1 REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/

D27455: FileWidgets: Ignore Return events from KDirOperator

dfaure accepted this revision. REPOSITORY R241 KIO BRANCH arcpatch-D27455 REVISION DETAIL https://phabricator.kde.org/D27455 To: meven, dfaure, ngraham, #frameworks Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28421: Add static method to check start condition

dfaure added inline comments. INLINE COMMENTS > kautostart.h:289 > + */ > +static bool isStartConditionMet(const QString &condition); > + This is new public API, it's missing @since 5.69 REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D28421 To: hchain, davide

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 30 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/30/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Fri, 03 Apr 2020 22:53:11 + Build duration: 7 min 40 sec and counting JUnit Tests Name: projectroot

D28515: [CommandLauncherJob] Add constructor taking an executable and argument list

dfaure added a comment. You could create a subdir of a QTemporaryDir with a fixed name like "abc def", copy `cp` or `copy.exe` in there, and then run that with an absolute path? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28515 To: broulik, #frameworks, dfaure Cc: k

D28535: [KIO-MTP] Fix null pointer dereference

feverfew added a comment. Ok so I've updated the code as can be seen. Mucked around with disconnecting/connecting, no issues on my side at least. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D28535 To: feverfew, akrutzler, dfaure, elvisangelaccio Cc: anthonyfie

D28535: [KIO-MTP] Fix null pointer dereference

feverfew updated this revision to Diff 79252. feverfew added a comment. - Don't try to release device in get method REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28535?vs=79198&id=79252 BRANCH fixNullPtr (branched from master) REVISION DETAIL http

D28542: Add 16px LibreOffice icons

This revision was automatically updated to reflect the committed changes. Closed by commit R266:4cdcd11c07da: Add 16px LibreOffice icons (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28542?vs=79232&id=79251 REVISION DETAIL https:

D28542: Add 16px LibreOffice icons

ndavis accepted this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28542 To: manueljlin, #vdg, ngraham, ndavis Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D28542: Add 16px LibreOffice icons

ngraham accepted this revision. ngraham added a subscriber: ndavis. ngraham added a comment. This revision is now accepted and ready to land. @ndavis, you good with this? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28542 To: manueljlin, #vdg, ngraham Cc: nda

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg, #plasma, cblack Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg, #plasma, cblack Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove edited the test plan for this revision. niccolove added a dependency: D27439: Replaced isDock check with !hasDecoration. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg, #plasma, cblack Cc: ngraham, cblack, kde-frame

D28372: Added a merged look to the plasmoidheading and remove roundedborders

ngraham added a comment. The second image definitely looks better than the first. However I wonder if we could even combine them into just one row. For toolbars with nothing but icons-only buttons, they kind of feel like they're screaming out to be integrated into the header. For toolba

D28295: Introduce KNotificationJobUiDelegate

ahmadsamir added inline comments. INLINE COMMENTS > dfaure wrote in knotificationjobuidelegate.cpp:24 > I don't remember any past discussion about this, but as I discovered in KIO > commit 3d2330968b > , > nested Privat

KDE CI: Frameworks » kirigami » kf5-qt5 FreeBSDQt5.14 - Build # 16 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20FreeBSDQt5.14/16/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Fri, 03 Apr 2020 17:07:10 + Build duration: 1 min 3 sec and counting JUnit Tests Name: project

D28513: smb: use prettyname.kio-discovery-wsd for hostname of wsdiscoveries

sitter updated this revision to Diff 79234. sitter added a comment. chop instead of convoluted remove REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28513?vs=79220&id=79234 BRANCH smb-lazy-resolve REVISION DETAIL https://phabricator.kde.org/D28513

D27504: smb faster copy to local

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R320:46b5fb425c14: smb: fast copy (authored by sitter). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://ph

D27504: smb faster copy to local

sitter edited the summary of this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D27504 To: sitter, ngraham, cfeck, #frameworks, #dolphin Cc: mmustac, meven, hallas, anthonyfieroni, asturmlechner, kde-frameworks-devel, kfm-devel, nikolaik, pberestov, iasens

D28542: Add 16px LibreOffice icons

manueljlin added a comment. Mainly in context menus and small panels. On most apps it isn't really needed, but the LibreOffice icons use 1px lines everywhere and that tends to look quite blurry F8213441: image.png I think it's a good idea to add more

D28542: Add 16px LibreOffice icons

ngraham added a comment. LGTM visually. What are these needed for though? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28542 To: manueljlin, #vdg Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

KDE CI: Frameworks » kirigami » kf5-qt5 FreeBSDQt5.14 - Build # 15 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20FreeBSDQt5.14/15/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Fri, 03 Apr 2020 16:15:24 + Build duration: 1 min 37 sec and counting JUnit Tests Name: proje

D28513: smb: use prettyname.kio-discovery-wsd for hostname of wsdiscoveries

sitter added inline comments. INLINE COMMENTS > kossebau wrote in kio_smb_browse.cpp:239 > `QString::remove()` operates on the object itself, no need to assign back to > host. > > Besides, why not use `QString::chop(wsdSuffix.size())` ? Mh. Good point indeed, I'll move to chop. Thanks! REPOSI

D28542: Add 16px LibreOffice icons

manueljlin retitled this revision from "Adds 16px LibreOffice icons" to "Add 16px LibreOffice icons". REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28542 To: manueljlin, #vdg Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28542: Adds 16px LibreOffice icons

manueljlin edited the summary of this revision. manueljlin added a reviewer: VDG. manueljlin set the repository for this revision to R266 Breeze Icons. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. REPOSITORY R266 Breeze Icons REVISION DETAIL https://pha

D28540: Fix layout in DownloadItemsSheet

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R304 KNewStuff BRANCH fix-downloaditemssheet-layout (branched from master) REVISION DETAIL https://phabricator.kde.org/D28540 To: leinir, #frameworks, bugseforuns, mart, #plasma, #knewstuff, ngraha

D28535: [KIO-MTP] Fix null pointer dereference

fvogt added a comment. I assume there is a reason why `MTPDevice::getDevice()` has code for handling this very specific case, so I wouldn't just remove it without figuring out why: ../https://i.redd.it/hfnl7xo8yovy.gif If not, that would indeed be the best option. REPOSITORY R320 KIO

D28397: Replace Vokoscreen with VokoscreenNG

ngraham accepted this revision. ngraham added a comment. Thanks! I will commit this tomorrow after branching as we don't typically change translated strings within two weeks of branding, so as to give the translators time to translate them. REPOSITORY R304 KNewStuff BRANCH update-vokosc

D28397: Replace Vokoscreen with VokoscreenNG

ngraham edited the summary of this revision. REPOSITORY R304 KNewStuff BRANCH update-vokoscreen-url (branched from master) REVISION DETAIL https://phabricator.kde.org/D28397 To: harogaston, #knewstuff, ngraham, leinir Cc: apol, pino, IlyaBizyaev, kde-frameworks-devel, LeGast00n, cblack, G

D28466: Added Page element

This revision was automatically updated to reflect the committed changes. Closed by commit R242:8b5e09314162: Added Page element (authored by niccolove). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28466?vs=79004&id=79227 REVISION DETAIL

D28540: Fix layout in DownloadItemsSheet

leinir edited the summary of this revision. leinir added reviewers: Frameworks, bugseforuns, mart, Plasma, KNewStuff. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D28540 To: leinir, #frameworks, bugseforuns, mart, #plasma, #knewstuff Cc: kde-frameworks-devel, LeGast0

D28540: Fix layout in DownloadItemsSheet

leinir created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. leinir requested review of this revision. REVISION SUMMARY The previous code was primarily there to work around misfeatures of OverlaySheet which no longer exist. Consequently, we

D28538: Use more UDSEntry::reserve() calls to avoid reallocs on multiple inserts

This revision was automatically updated to reflect the committed changes. Closed by commit R320:7e679b1366fc: Use more UDSEntry::reserve() calls to avoid reallocs on multiple inserts (authored by kossebau). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D285

D28538: Use more UDSEntry::reserve() calls to avoid reallocs on multiple inserts

meven accepted this revision. meven added a comment. This revision is now accepted and ready to land. Seems hard to miss cases like for `// +1 for UDS_DISPLAY_NAME` but I will trust you did enough review to be confident for all those cases. A missing one will just cause an allocation anyway

D28535: [KIO-MTP] Fix null pointer dereference

feverfew added a comment. In D28535#640703 , @anthonyfieroni wrote: > In D28535#640699 , @feverfew wrote: > > > So to be succinct, the only correct fix here is to change `getDevice()` to `return m_

D28513: smb: use prettyname.kio-discovery-wsd for hostname of wsdiscoveries

kossebau added inline comments. INLINE COMMENTS > kio_smb_browse.cpp:239 > +QString host = m_current_url.host(); > +host = host.remove(host.size() - wsdSuffix.size(), wsdSuffix.size()); > +const QString dnssd(host + ".local"); `QString::remove()` operates on the object it

D28538: Use more UDSEntry::reserve() calls to avoid reallocs on multiple inserts

kossebau created this revision. kossebau added reviewers: Frameworks, sitter, meven. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. kossebau requested review of this revision. REPOSITORY R320 KIO Extras BRANCH usemoreudsentryreserve REV

D28513: smb: use prettyname.kio-discovery-wsd for hostname of wsdiscoveries

sitter updated this revision to Diff 79220. sitter added a comment. reshuffle: instead of using .local directly use a fake .kio-disocvery-wsd suffix. look for that at listing time and redirect to name.local or name as appropriate this prevents dnssd results form incorrectly getting run t

D28513: smb: use prettyname.kio-discovery-wsd for hostname of wsdiscoveries

sitter retitled this revision from "smb: use prettyname.local for hostname of wsdiscoveries" to "smb: use prettyname.kio-discovery-wsd for hostname of wsdiscoveries". sitter edited the summary of this revision. REPOSITORY R320 KIO Extras BRANCH smb-lazy-resolve REVISION DETAIL https://ph

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 29 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/29/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Fri, 03 Apr 2020 13:36:59 + Build duration: 7 min 45 sec and counting JUnit Tests Name: projectroo

D28537: [krun] Removed no longer used internal method resolveURLs()

This revision was automatically updated to reflect the committed changes. Closed by commit R241:abf920c33ff6: [krun] Removed no longer used internal method resolveURLs() (authored by kossebau). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28537?vs=79213&id=79214

D28537: [krun] Removed no longer used internal method resolveURLs()

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH removeunusedresolveURLs REVISION DETAIL https://phabricator.kde.org/D28537 To: kossebau, #frameworks, davidedmundson, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2

D27451: Drop KToolInvocation support from KRun::runService

kossebau added inline comments. INLINE COMMENTS > krun.cpp:757 > -// Resolve urls if needed, depending on what the app supports > -const QList urls = resolveURLs(_urls, _service); > - Compiler now complains nothing uses `resolveURLS()`after this. Clean up proposed by D28537

D28537: [krun] Removed no longer used internal method resolveURLs()

kossebau created this revision. kossebau added reviewers: Frameworks, davidedmundson, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Follow-up to f7cf3b676a4ed491effde0e31fd18c09e913dfe5 <

D28535: [KIO-MTP] Fix null pointer dereference

anthonyfieroni added a comment. In D28535#640699 , @feverfew wrote: > So to be succinct, the only correct fix here is to change `getDevice()` to `return m_mtpdevice`? Yes, then check if it's crash, in all other place `LIBMTP_xxx` should t

D28528: UDSEntry: add constructor variant with std::initializer_list

kossebau updated this revision to Diff 79210. kossebau added a comment. Update to latest master REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28528?vs=79182&id=79210 BRANCH udsentryinitlistconstructor REVISION DETAIL https://phabricator.kde.org/D28528 A

D28535: [KIO-MTP] Fix null pointer dereference

feverfew added a comment. If you want to, feel free, I'm a bit tight on time. But I will say this. the whole `getDevice()` function confuses me. I'm not entirely sure why this `if` check is necessary at all. The lifetime of devices and its children (i.e storage) should be managed by the KMTP

D28521: Use more UDSEntry::reserve() calls to avoid reallocs on multiple inserts

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R241:b878cb30d36a: Use more UDSEntry::reserve() calls to avoid reallocs on multiple inserts (authored by kossebau). REPOSIT

D28520: Fix lifetime of slot in KIO-MTP

apol accepted this revision. REPOSITORY R320 KIO Extras BRANCH slotLifetime (branched from master) REVISION DETAIL https://phabricator.kde.org/D28520 To: feverfew, akrutzler, dfaure, elvisangelaccio, apol Cc: apol, kde-frameworks-devel, kfm-devel, fvogt, nikolaik, pberestov, iasensio, fp

D28521: Use more UDSEntry::reserve() calls to avoid reallocs on multiple inserts

apol added a comment. In D28521#640685 , @kossebau wrote: > @apol So okay if I land this one for now? > The initlist approach does not cover all cases anyway, and until that one is reviewed by enough experienced developers (e.g. who can tell i

D28510: [kprocessrunner] Escape hyphen characters in scope names

hchain added a comment. The full systemd escape code is here: https://github.com/systemd/systemd/blob/master/src/basic/unit-name.c#L294 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28510 To: davidedmundson, apol Cc: hchain, kde-frameworks-devel, LeGast00n, cblack, GB

D28535: [KIO-MTP] Fix null pointer dereference

anthonyfieroni added a comment. @feverfew are you gonna try what i'm writing about or i should do it? Just use cached device, do not reopen since it'll return nullptr. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D28535 To: feverfew, akrutzler, dfaure, elvisang

D28521: Use more UDSEntry::reserve() calls to avoid reallocs on multiple inserts

kossebau added a comment. @apol So okay if I land this one for now? The initlist approach does not cover all cases anyway, and until that one is reviewed by enough experienced developers (e.g. who can tell if alignment of data works as hoped), this here should save resources across the glob

D28535: [KIO-MTP] Fix null pointer dereference

fvogt added a comment. In D28535#640682 , @feverfew wrote: > In D28535#640674 , @fvogt wrote: > > > What you're suggesting is to change `MTPDevice::getDevice` to return the old device if reopening fa

D28535: [KIO-MTP] Fix null pointer dereference

feverfew added a comment. In D28535#640674 , @fvogt wrote: > What you're suggesting is to change `MTPDevice::getDevice` to return the old device if reopening fails - but reopening without releasing might not work. This seems to be a robus

D28498: [xdgoutput] Explicitly set version of server interface

davidedmundson added inline comments. INLINE COMMENTS > zzag wrote in display.h:297 > You can't introduce another createXdgOutputManager() because it's not > overloaded. You probably need to rename this method, e.g. > createXdgOutputManager2. As you've pasted, it is BC, which is what framework

D28535: [KIO-MTP] Fix null pointer dereference

fvogt added a comment. In D28535#640680 , @anthonyfieroni wrote: > I see we don't speak in same language :) > `LIBMTP_Open_Raw_Device_Uncached(&m_rawdevice);` > returns nullptr that's normal since device is inaccessible, i mean it does not

D28535: [KIO-MTP] Fix null pointer dereference

anthonyfieroni added a comment. I see we don't speak in same language :) `LIBMTP_Open_Raw_Device_Uncached(&m_rawdevice);` returns nullptr that's normal since device is inaccessible, i mean it does not need to call `LIBMTP_Release_Device` using `m_mtpdevice` is safe it's not nullptr, it's

D28033: Create ExpandableListItem

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Tagging is tomorrow, don't merge before then. INLINE COMMENTS > ExpandableListItem.qml:491 > +Item { > +height: actionsList.height > +width:

D28513: smb: use prettyname.local for hostname of wsdiscoveries

sitter added a comment. Stable was the plan, yes. I've thought of some complications with this approach though. Actually a combination of two 1. the .local match also applies to dnssd 2. all linux VMs I've checked wouldn't be able to resolve netbios names natively as the relevant

D28535: [KIO-MTP] Fix null pointer dereference

fvogt added a comment. There is no such thing as an "invalid device" at that point anymore. There's only nullptr. LIBMTP_mtpdevice_t *MTPDevice::getDevice() { if (!m_mtpdevice->storage) { qCDebug(LOG_KIOD_KMTPD) << "no storage found: reopen mtpdevice";

D28535: [KIO-MTP] Fix null pointer dereference

anthonyfieroni added a comment. In D28535#640672 , @fvogt wrote: > If `getDevice()` returns nullptr, this means that `MTPDevice::getDevice()` returns nullptr. This can only happen if `m_mtpdevice` is nullptr, which will crash in `MTPDevice::~MTP

D28535: [KIO-MTP] Fix null pointer dereference

fvogt added a comment. In D28535#640656 , @anthonyfieroni wrote: > You're right about bug report, but it can fail in any other place, just in particular version it happen in `updateStorageInfo` Can we cache `getDevice` in m_device (in construc

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 27 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/27/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Fri, 03 Apr 2020 11:25:34 + Build duration: 5 min 27 sec and counting JUnit Tests Name: projectroot

D28535: [KIO-MTP] Fix null pointer dereference

anthonyfieroni added a comment. You're right about bug report, but it can fail in any other place, just in particular version it happen in `updateStorageInfo` Can we cache `getDevice` in m_device (in constructor) then use it everywhere. I think libmtp has guard against disconnected device a

D28510: [kprocessrunner] Escape hyphen characters in scope names

This revision was automatically updated to reflect the committed changes. Closed by commit R241:6fba90325237: [kprocessrunner] Escape hyphen characters in scope names (authored by davidedmundson). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28510?vs=79125&id=79

D28535: [KIO-MTP] Fix null pointer dereference

feverfew created this revision. feverfew added reviewers: akrutzler, dfaure, elvisangelaccio. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. feverfew requested review of this revision. REVISION SUMMARY A null pointer can be returned from ge

D28520: Fix lifetime of slot in KIO-MTP

feverfew added a comment. @apol just found another one where this occurs, forgot about it but noticed it earlier as well. This doesn't affect KIOFuse as much though (as we don't listen to the processedSize() signal). I'll wait for another approval, or before 20.04 tagging, whichever come

D28520: Fix lifetime of slot in KIO-MTP

feverfew updated this revision to Diff 79196. feverfew added a comment. - Fix another slot lifetime REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28520?vs=79154&id=79196 BRANCH slotLifetime (branched from master) REVISION DETAIL https://phabricato

D28466: Added Page element

mart accepted this revision. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D28466 To: niccolove, #plasma, ngraham, mart Cc: ngraham, davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D28532: Introduce more user-visible error reporting for installations

leinir updated this revision to Diff 79195. leinir added a comment. - Address @pino's comment re i18n overload usage REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28532?vs=79191&id=79195 BRANCH more-installation-error-handling (branched from master)

D28532: Introduce more user-visible error reporting for installations

pino added a comment. Please fix the i18n() calls, as the values of placeholders are passed as parameter to it instead of using .arg(): i18n("foo %1").arg(foo) // WRONG i18n("foo %1", foo) // correct REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D2853

D28531: [KNotificationJobUiDelegate] Append "Failed" for error messages

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D28531 To: broulik, #frameworks, apol Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28532: Introduce more user-visible error reporting for installations

leinir edited the test plan for this revision. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D28532 To: leinir, #knewstuff, #plasma, ngraham, #frameworks Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28532: Introduce more user-visible error reporting for installations

leinir edited the summary of this revision. leinir added reviewers: KNewStuff, Plasma, ngraham, Frameworks. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D28532 To: leinir, #knewstuff, #plasma, ngraham, #frameworks Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, mi

D28532: Introduce more user-visible error reporting for installations

leinir created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. leinir requested review of this revision. REVISION SUMMARY Prior to this, we did have error reporting, but only in the way of writing errors out on the command line (through qCCri

D28531: [KNotificationJobUiDelegate] Append "Failed" for error messages

broulik retitled this revision from "[KNotificationJobUiDelegate] Prepend "Failed" for error messages" to "[KNotificationJobUiDelegate] Append "Failed" for error messages". REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D28531 To: broulik, #frameworks Cc: kde-fr

D28498: [xdgoutput] Explicitly set version of server interface

zzag added inline comments. INLINE COMMENTS > apol wrote in display.h:296 > Passing an enum as const& is wrong although it doesn't make much of a > difference in practice. > > `You can't introduce another createXdgOutputManager() because it's not > overloaded`. He's adding an overload, I don't

D27760: WIP | Added BatchMoveJob

emateli added inline comments. INLINE COMMENTS > batchmovejobtest.cpp:89 > +KIO::Job *job = KIO::batchMove(items); > + > KIO::FileUndoManager::self()->recordJob(KIO::FileUndoManager::CommandType::BatchMove, > QList{}, QUrl(), job); > +job->setUiDelegate(nullptr); @dfaure

D28499: [LauncherJobs] Emit description

broulik added a comment. Given we don't add elippsis after any other KIO Job (e.g. "Copying") probably shouldn't do it here either? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28499 To: broulik, #frameworks Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh

D28531: [KNotificationJobUiDelegate] Prepend "Failed" for error messages

broulik created this revision. broulik added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Makes the resulting error notification resemble one like a KJobTracker failure as

D28515: [CommandLauncherJob] Add constructor taking an executable and argument list

broulik added a comment. Not sure how I would test running a command with a space in it.. putting a shell script in running it through QFINDTESTDATA? Not sure how to make that sort of stuff work on Windows REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28515 To: broul

D28515: [CommandLauncherJob] Add constructor taking an executable and argument list

broulik updated this revision to Diff 79189. broulik edited the test plan for this revision. broulik added a comment. - Quote executable in commandline - Add unittest REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28515?vs=79136&id=79189 REVISION DETAIL ht

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.14 - Build # 16 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.14/16/ Project: kf5-qt5 SUSEQt5.14 Date of build: Fri, 03 Apr 2020 07:27:24 + Build duration: 4 min 32 sec and counting BUILD ARTIFACTS acc/KF5Baloo-5.69

KDE CI: Frameworks » baloo » kf5-qt5 FreeBSDQt5.14 - Build # 24 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20FreeBSDQt5.14/24/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Fri, 03 Apr 2020 07:27:23 + Build duration: 2 min 55 sec and counting JUnit Tests Name: projectro

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.12 - Build # 237 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.12/237/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 03 Apr 2020 07:27:23 + Build duration: 2 min 0 sec and counting BUILD ARTIFACTS acc/KF5Baloo-5.69

KDE CI: Frameworks » baloo » kf5-qt5 WindowsMSVCQt5.14 - Build # 51 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20WindowsMSVCQt5.14/51/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Fri, 03 Apr 2020 07:27:23 + Build duration: 55 sec and counting