D28114: Add call-incoming/missed/outgoing

ndavis edited the summary of this revision. ndavis edited the test plan for this revision. ndavis added a subscriber: bshah. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28114 To: ndavis, #vdg Cc: bshah, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ng

D28114: Add call-incoming/missed/outgoing

ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH call-history (branched from master) REVISION DETAIL https://phabric

D28112: [WIP] Expose application menu via KWindowInfo

cblack created this revision. cblack added reviewers: Plasma, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. cblack requested review of this revision. REVISION SUMMARY Application menu information is now available via KWindowInfo's APIs on X11.

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.12 - Build # 281 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/281/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 18 Mar 2020 01:22:54 + Build duration: 3 min 10 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.13 - Build # 167 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.13/167/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 18 Mar 2020 01:22:54 + Build duration: 2 min 9 sec and counting JUnit Tests Name: p

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.13 - Build # 174 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.13/174/ Project: kf5-qt5 SUSEQt5.13 Date of build: Wed, 18 Mar 2020 01:22:54 + Build duration: 2 min 26 sec and counting JUnit Tests Name: (root)

D25815: Transmission-Qt tray icon added

ndavis abandoned this revision. ndavis added a comment. This icon has been added to breeze-icons REVISION DETAIL https://phabricator.kde.org/D25815 To: ndavis, #vdg, ngraham, vinzenzv Cc: broulik, ndavis, ngraham, iasensio, kde-frameworks-devel, LeGast00n, cblack, fbampaloukas, GB_2, trick

D28111: Add transmission-tray-icon

This revision was automatically updated to reflect the committed changes. Closed by commit R266:9895e572d730: Add transmission-tray-icon (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28111?vs=77872&id=77873 REVISION DETAIL https:

D28111: Add transmission-tray-icon

cblack accepted this revision. cblack added a comment. This revision is now accepted and ready to land. LGTM. REPOSITORY R266 Breeze Icons BRANCH transmission (branched from master) REVISION DETAIL https://phabricator.kde.org/D28111 To: ndavis, #vdg, cblack Cc: cblack, kde-frameworks-

D28111: Add transmission-tray-icon

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28111 To: ndavis, #vdg Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28111: Add transmission-tray-icon

ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH transmission (branched from master) REVISION DETAIL https://phabric

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.13 - Build # 173 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.13/173/ Project: kf5-qt5 SUSEQt5.13 Date of build: Wed, 18 Mar 2020 00:37:23 + Build duration: 3 min 36 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.12 - Build # 280 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/280/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 18 Mar 2020 00:37:23 + Build duration: 3 min 27 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.13 - Build # 166 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.13/166/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 18 Mar 2020 00:37:23 + Build duration: 3 min 3 sec and counting JUnit Tests Name: p

KDE CI: Frameworks » kpeople » kf5-qt5 WindowsMSVCQt5.14 - Build # 13 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kpeople/job/kf5-qt5%20WindowsMSVCQt5.14/13/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Wed, 18 Mar 2020 00:31:39 + Build duration: 2 min 56 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kpeople » kf5-qt5 SUSEQt5.12 - Build # 93 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kpeople/job/kf5-qt5%20SUSEQt5.12/93/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 18 Mar 2020 00:31:40 + Build duration: 2 min 41 sec and counting BUILD ARTIFACTS abi-compatibili

KDE CI: Frameworks » kpeople » kf5-qt5 SUSEQt5.13 - Build # 72 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kpeople/job/kf5-qt5%20SUSEQt5.13/72/ Project: kf5-qt5 SUSEQt5.13 Date of build: Wed, 18 Mar 2020 00:31:40 + Build duration: 3 min 6 sec and counting BUILD ARTIFACTS abi-compatibilit

KDE CI: Frameworks » kpeople » kf5-qt5 FreeBSDQt5.13 - Build # 67 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kpeople/job/kf5-qt5%20FreeBSDQt5.13/67/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 18 Mar 2020 00:31:39 + Build duration: 1 min 33 sec and counting JUnit Tests Name: project

D28108: Handle busybox's sed like GNU sed

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH master REVISION DETAIL https://phabricator.kde.org/D28108 To: heikobecker, #frameworks, apol Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D17816: Support for xattrs on kio copy/move

bruns added inline comments. INLINE COMMENTS > file_unix.cpp:146 > +#elif HAVE_SYS_EXTATTR > +ssize_t listlen = extattr_list_file(src_fd, EXTATTR_NAMESPACE_USER, > nullptr, 0); > +#endif extattr_list_**fd**, here and everywhere else > file_unix.cpp:164 > +#endif > +QList m_keyList = ke

KDE CI: Frameworks » kpeople » kf5-qt5 SUSEQt5.12 - Build # 92 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpeople/job/kf5-qt5%20SUSEQt5.12/92/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 17 Mar 2020 23:31:42 + Build duration: 2 min 9 sec and counting BUILD ARTIFACTS abi-compatibili

KDE CI: Frameworks » kpeople » kf5-qt5 SUSEQt5.13 - Build # 71 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpeople/job/kf5-qt5%20SUSEQt5.13/71/ Project: kf5-qt5 SUSEQt5.13 Date of build: Tue, 17 Mar 2020 23:31:42 + Build duration: 2 min 12 sec and counting BUILD ARTIFACTS abi-compatibil

KDE CI: Frameworks » kpeople » kf5-qt5 WindowsMSVCQt5.14 - Build # 12 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpeople/job/kf5-qt5%20WindowsMSVCQt5.14/12/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Tue, 17 Mar 2020 23:31:42 + Build duration: 2 min 19 sec and counting JUnit Tests Name

KDE CI: Frameworks » kpeople » kf5-qt5 FreeBSDQt5.13 - Build # 66 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpeople/job/kf5-qt5%20FreeBSDQt5.13/66/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 17 Mar 2020 23:31:42 + Build duration: 1 min 8 sec and counting JUnit Tests Name: project

D28110: PersonsModel: Fix PersonVCardRole

This revision was automatically updated to reflect the committed changes. Closed by commit R307:b6b86f158254: PersonsModel: Fix PersonVCardRole (authored by jbbgameich). REPOSITORY R307 KPeople CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28110?vs=77869&id=77870 REVISION DETAIL

D28110: PersonsModel: Fix PersonVCardRole

nicolasfella accepted this revision. This revision is now accepted and ready to land. REPOSITORY R307 KPeople BRANCH fix-personsmodel-vcard (branched from master) REVISION DETAIL https://phabricator.kde.org/D28110 To: jbbgameich, apol, nicolasfella Cc: nicolasfella, kde-frameworks-devel,

D28110: PersonsModel: Fix PersonVCardRole

jbbgameich updated this revision to Diff 77869. jbbgameich added a comment. Use AbstractContact::VCardProperty REPOSITORY R307 KPeople CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28110?vs=77868&id=77869 BRANCH fix-personsmodel-vcard (branched from master) REVISION DETAIL

D28094: [breeze-icons] fix shadow in some user (applets/128) icons

ndavis added a comment. BTW, you can use this website to search for text in the code of all KDE software: https://lxr.kde.org/search REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28094 To: rocka, #vdg, ndavis Cc: ndavis, kde-frameworks-devel, LeGast00n, cblac

D17816: Support for xattrs on kio copy/move

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > jobtest.cpp:118 > +} else { > +qWarning() << "Xatr command not foud."; > +} typo in Xatr, and in "foud". I suggest:

D28110: PersonsModel: Fix PersonVCardRole

nicolasfella added inline comments. INLINE COMMENTS > personsmodel.cpp:186 > case PersonsModel::PersonVCardRole: > -return QVariant::fromValue(person); > +return person->customProperty(QStringLiteral("vcard")); > case PersonsModel::ContactsVCardRole: Use AbstractContact

D28110: PersonsModel: Fix PersonVCardRole

jbbgameich created this revision. jbbgameich added a reviewer: apol. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. jbbgameich requested review of this revision. REPOSITORY R307 KPeople BRANCH fix-personsmodel-vcard (branched from master) REVISION DETAIL

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.13 - Build # 165 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.13/165/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 17 Mar 2020 21:33:00 + Build duration: 3 min 9 sec and counting JUnit Tests Name: p

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.12 - Build # 279 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/279/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 17 Mar 2020 21:33:01 + Build duration: 2 min 33 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.13 - Build # 172 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.13/172/ Project: kf5-qt5 SUSEQt5.13 Date of build: Tue, 17 Mar 2020 21:33:00 + Build duration: 1 min 52 sec and counting JUnit Tests Name: (root)

D27617: [breeze-icons] Add telegram-desktop tray icons

ndavis added a comment. Unfortunately, it looks like I'll have to revert this patch because when people use a light colorscheme with a dark plasma theme, the icons turn black because the icon is rendered as a pixmap when it has the red counter badge. REPOSITORY R266 Breeze Icons REVISION

D27855: [Debug] Improve readability of positioninfo debug format

bruns added a comment. In D27855#629330 , @kossebau wrote: > For Qt <5.14 `Qt::hex` needs to be instead unnamespaced `hex`, same with `Qt::dec` -> `dec`. > Fixed with 28a534ccee9ffa22b2abb7188ab8abb98a099f99

D28108: Handle busybox's sed like GNU sed

heikobecker created this revision. heikobecker added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. heikobecker requested review of this revision. REVISION SUMMARY Otherwise it uses the POSIX-style and fails with "sed: : No such file

D27617: [breeze-icons] Add telegram-desktop tray icons

ndavis added a comment. In D27617#629023 , @IlyaBizyaev wrote: > This breaks for people using Breeze for apps and Breeze Dark for Plasma: > F8180783: image.png > > > pass environemnt variable TDESKTOP

D28094: [breeze-icons] fix shadow in some user (applets/128) icons

ndavis added a comment. In D28094#629427 , @rocka wrote: > Weird, I edited them in Inkscape … > > Aren't those icons used as default avatar in user manager? Nope. Those were actually kept in the user-manager repo until they were remov

D26858: Provide an implementation for the tablet interface

apol updated this revision to Diff 77861. apol added a comment. Fix tablet removal REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26858?vs=77839&id=77861 BRANCH arcpatch-D26858 REVISION DETAIL https://phabricator.kde.org/D26858 AFFECTED FILES CMak

D28094: [breeze-icons] fix shadow in some user (applets/128) icons

rocka added a comment. Weird, I edited them in Inkscape … Aren't those icons used as default avatar in user manager? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28094 To: rocka, #vdg, ndavis Cc: ndavis, kde-frameworks-devel, LeGast00n, cblack, GB_2, mic

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.12 - Build # 278 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/278/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 17 Mar 2020 18:11:30 + Build duration: 2 min 26 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.13 - Build # 171 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.13/171/ Project: kf5-qt5 SUSEQt5.13 Date of build: Tue, 17 Mar 2020 18:11:30 + Build duration: 1 min 55 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.13 - Build # 164 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.13/164/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 17 Mar 2020 18:11:30 + Build duration: 1 min 42 sec and counting JUnit Tests Name:

D27416: Add small icons for KeePassXC

This revision was automatically updated to reflect the committed changes. Closed by commit R266:036ba91a2bc3: Add small icons for KeePassXC (authored by wsdfhjxc, committed by ngraham). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27416?vs=77809&id=7785

D27416: Add small icons for KeePassXC

cblack accepted this revision. cblack added a comment. This revision is now accepted and ready to land. LGTM now. Good icon 👌 REPOSITORY R266 Breeze Icons BRANCH keepassxc-small REVISION DETAIL https://phabricator.kde.org/D27416 To: wsdfhjxc, #vdg, cblack, ndavis Cc: ndavis, cblack, k

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.13 - Build # 170 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.13/170/ Project: kf5-qt5 SUSEQt5.13 Date of build: Tue, 17 Mar 2020 17:48:50 + Build duration: 1 min 55 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.13 - Build # 163 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.13/163/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 17 Mar 2020 17:48:50 + Build duration: 1 min 45 sec and counting JUnit Tests Name:

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.12 - Build # 277 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/277/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 17 Mar 2020 17:48:50 + Build duration: 1 min 58 sec and counting JUnit Tests Name: (root)

D28093: [breeze-icons] add TeamViewer tray icons

This revision was automatically updated to reflect the committed changes. Closed by commit R266:cff8c406dd71: [breeze-icons] add TeamViewer tray icons (authored by rocka, committed by ngraham). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28093?vs=77810

D28094: [breeze-icons] fix shadow in some user (applets/128) icons

ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. Can you fix the files for inkscape? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28094 To: rocka, #vdg, ndavis Cc: ndavis, kde-frameworks-devel,

D28094: [breeze-icons] fix shadow in some user (applets/128) icons

ndavis added a comment. Hmm. The shadows no longer work correctly in Inkscape, but they work fine in the Qt SVG renderer, which is unusual since usually the Qt SVG renderer is the picky one. REPOSITORY R266 Breeze Icons BRANCH fix-user-icon-shadow (branched from master) REVISION DETAIL

D27540: KCModule: Indicate when a setting has been changed from the default or previous value

ervin added a comment. In D27540#629362 , @ndavis wrote: > Is it possible to align all of the reset buttons like a column? Why I'm not surprised. ;-) Honestly with enough code it might be possible, but that'd be expensive in term of

D28094: [breeze-icons] fix shadow in some user (applets/128) icons

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. I'm not sure if we actually use these anywhere, but the patch looks good to me. REPOSITORY R266 Breeze Icons BRANCH fix-user-icon-shadow (branched from master) REVISION DETAIL https

D27416: Add small icons for KeePassXC

ndavis accepted this revision. ndavis added a comment. LGTM REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27416 To: wsdfhjxc, #vdg, cblack, ndavis Cc: ndavis, cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D28093: [breeze-icons] add TeamViewer tray icons

ndavis accepted this revision. REPOSITORY R266 Breeze Icons BRANCH teamviewer-tray (branched from master) REVISION DETAIL https://phabricator.kde.org/D28093 To: rocka, #vdg, ngraham, ndavis Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D27540: KCModule: Indicate when a setting has been changed from the default or previous value

ndavis added a comment. Is it possible to align all of the reset buttons like a column? REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D27540 To: ervin, ngraham, davidedmundson, meven, crossi, bport, #vdg, ndavis Cc: alexde, ndavis, iasensio, davidre, kde-fram

D27840: Introduce SettingState* elements to ease KCM writing

ervin updated this revision to Diff 77848. ervin added a comment. Take feedback about the GUI into account REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27840?vs=76952&id=77848 REVISION DETAIL https://phabricator.kde.org/D27840 AFFECTED FILES sr

D27540: KCModule: Indicate when a setting has been changed from the default or previous value

ervin edited the test plan for this revision. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D27540 To: ervin, ngraham, davidedmundson, meven, crossi, bport, #vdg, ndavis Cc: alexde, ndavis, iasensio, davidre, kde-frameworks-devel, LeGast00n, cblack, GB_2, michae

D27540: KCModule: Indicate when a setting has been changed from the default or previous value

ervin edited the summary of this revision. ervin edited the test plan for this revision. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D27540 To: ervin, ngraham, davidedmundson, meven, crossi, bport, #vdg, ndavis Cc: alexde, ndavis, iasensio, davidre, kde-framewo

D27540: KCModule: Indicate when a setting has been changed from the default or previous value

ervin updated this revision to Diff 77847. ervin added a comment. Take feedback about the GUI into account REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27540?vs=76362&id=77847 REVISION DETAIL https://phabricator.kde.org/D27540 AFFECTED FILES

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.12 - Build # 215 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.12/215/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 17 Mar 2020 16:50:33 + Build duration: 4 min 25 sec and counting BUILD ARTIFACTS acc/KF5Baloo-5.6

KDE CI: Frameworks » baloo » kf5-qt5 FreeBSDQt5.13 - Build # 91 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20FreeBSDQt5.13/91/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 17 Mar 2020 16:50:33 + Build duration: 3 min 11 sec and counting JUnit Tests Name: projectro

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.13 - Build # 96 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.13/96/ Project: kf5-qt5 SUSEQt5.13 Date of build: Tue, 17 Mar 2020 16:50:33 + Build duration: 2 min 20 sec and counting BUILD ARTIFACTS acc/KF5Baloo-5.69

D27855: [Debug] Improve readability of positioninfo debug format

kossebau added a comment. For Qt <5.14 `Qt::hex` needs to be instead unnamespaced `hex`, same with `Qt::dec` -> `dec`. Fixed with 28a534ccee9ffa22b2abb7188ab8abb98a099f99 REPOSITORY R293 Baloo REVISION DETAIL

D28093: [breeze-icons] add TeamViewer tray icons

ngraham added subscribers: ndavis, ngraham. ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. LGTM. @ndavis? REPOSITORY R266 Breeze Icons BRANCH teamviewer-tray (branched from master) REVISION DETAIL https://phabricator.kde.org/D2

D27540: KCModule: Indicate when a setting has been changed from the default or previous value

ervin added a comment. In D27540#627618 , @ndavis wrote: > Some extra rules I thought of: > > - With the checkable label example in the mockup above, it should reset both the label and the checkbox. Just for the record, this will unli

D26858: Provide an implementation for the tablet interface

zzag added inline comments. INLINE COMMENTS > test_tablet_interface.cpp:1-19 > +/ > +Copyright 2020 Aleix Pol Gonzalez > + > +This library is free software; you can redistribute it and/or > +modify it under the terms of the GNU

D26858: Provide an implementation for the tablet interface

apol updated this revision to Diff 77839. apol added a comment. Address comment by David REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26858?vs=75564&id=77839 BRANCH arcpatch-D26858 REVISION DETAIL https://phabricator.kde.org/D26858 AFFECTED FILES

Re: KDE CI: Applications » kreversi » kf5-qt5 FreeBSDQt5.13 - Build # 26 - Still Failing!

Am Dienstag, 17. März 2020, 07:01:54 CET schrieb laurent Montel: > Le lundi 16 mars 2020, 15:43:29 CET Friedrich W. H. Kossebau a écrit : > > Laurent, > > could you do the favour to change all the usages of > > *DISABLE_DEPRECATED_BEFORE_AND_AT you introduced to a version matching to > > the latest

D26858: Provide an implementation for the tablet interface

davidedmundson added inline comments. INLINE COMMENTS > tablet_interface.cpp:346 > + > +TabletToolInterface *TabletSeatInterface::toolByHardwareId(quint64 serialId) > const > +{ We're mixing up hardwareId and hardwareSerial this method is called toolByHardwareId calls an internal method called

D27544: Fix update scenarios with no explicit downloadlink selected

leinir updated this revision to Diff 77818. leinir marked 4 inline comments as done. leinir added a comment. Address @ahiemstra's comments - thanks! - Turn on C++14 support - Fix some whitespace issues, a leak, and add a warning - Less magic numbers, with the power of enums REPOSITORY

D27544: Fix update scenarios with no explicit downloadlink selected

leinir marked 5 inline comments as done. leinir added a comment. Thanks for those, @ahiemstra, good stuff there :) INLINE COMMENTS > ahiemstra wrote in engine.cpp:614 > Code style: & attaches to the name, not the type. (Yes I hate it too). > > There's a few instances of this around. so nast

Re: Problems in KWayland causes by API and ABI compatibility promises

On Tue, Mar 17, 2020 at 11:27 AM David Edmundson wrote: > > There's definitely a problem, and I think it's a lot more than just > discussing location and protocol versions. > > My typical workflow is reading the wayland protocol in detail, and > kwayland is in that awkward position where I absolut

D27416: Add small icons for KeePassXC

wsdfhjxc added a comment. Is it any better now? @cblack @ndavis REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27416 To: wsdfhjxc, #vdg, cblack, ndavis Cc: ndavis, cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27416: Add small icons for KeePassXC

wsdfhjxc edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27416 To: wsdfhjxc, #vdg, cblack, ndavis Cc: ndavis, cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D28097: GIT_SILENT clang-format kpasswdserver.* plus some manual changes

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, apol. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY Braces around if blocks. TEST PLAN make && ctest REPOSITORY R241 KIO BRANCH l-kpasswdserver-clang-fo

Re: Problems in KWayland causes by API and ABI compatibility promises

There's definitely a problem, and I think it's a lot more than just discussing location and protocol versions. My typical workflow is reading the wayland protocol in detail, and kwayland is in that awkward position where I absolutely still need to read those underlying docs and the abstraction kwa

D28094: [breeze-icons] fix shadow in some user (applets/128) icons

rocka updated this revision to Diff 77814. rocka added a comment. remove svg metadata REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28094?vs=77811&id=77814 BRANCH fix-user-icon-shadow (branched from master) REVISION DETAIL https://phabricator.kd

D28095: Bump required version of KF5 to 5.69.0

This revision was automatically updated to reflect the committed changes. Closed by commit R871:ce461918868d: Bump required version of KF5 to 5.69.0 (authored by ahmadsamir). REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28095?vs=77812&id=77813 REVISION DETA

D28095: Bump required version of KF5 to 5.69.0

sitter accepted this revision. This revision is now accepted and ready to land. REPOSITORY R871 DrKonqi BRANCH l-kcrash (branched from master) REVISION DETAIL https://phabricator.kde.org/D28095 To: ahmadsamir, #frameworks, dfaure, apol, sitter Cc: kde-frameworks-devel, plasma-devel, Orage

D27544: Fix update scenarios with no explicit downloadlink selected

ahiemstra added inline comments. INLINE COMMENTS > engine.cpp:614 > +QString identifiedLink; > +const QString& payloadToIdentify = d->payloadToIdentify[entry]; > +const QStringList& payloads = d->payloads[entry]; Code style: & attaches to the name, not the typ

D27986: Allow providing an error message from the application

ahmadsamir added a comment. In D27986#628977 , @bcooksley wrote: > The following is notice that I intend to revert this change, along with the corresponding commits that make use of this functionality in Dr Konqi, as they cause a FTBFS on both

D28095: Bump required version of KF5 to 5.69.0

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, apol, sitter. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ahmadsamir requested review of this revision. REVISION SUMMARY KCrash::setErrorMessage() was introduced in 5.69.0. REPOSITORY

D28094: [breeze-icons] fix shadow in some user (applets/128) icons

rocka edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28094 To: rocka, #vdg Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28094: [breeze-icons] fix shadow in some user (applets/128) icons

rocka edited the test plan for this revision. rocka added a reviewer: VDG. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28094 To: rocka, #vdg Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28094: [breeze-icons] fix shadow in some user (applets/128) icons

rocka created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. rocka requested review of this revision. REVISION SUMMARY When executing `kdialog --geticon`, some errors would shown: $ kdialog --geticon qt.svg: /usr/share/icons/breeze-

D27617: [breeze-icons] Add telegram-desktop tray icons

IlyaBizyaev added a comment. This breaks for people using Breeze for apps and Breeze Dark for Plasma: F8180783: image.png > pass environemnt variable TDESKTOP_DISABLE_TRAY_COUNTER=1 to telegram-desktop also make it follows KDE color scheme Thi

D28093: [breeze-icons] add TeamViewer tray icons

rocka edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28093 To: rocka Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28093: [breeze-icons] add TeamViewer tray icons

rocka added a reviewer: VDG. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28093 To: rocka, #vdg Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28093: [breeze-icons] add TeamViewer tray icons

rocka created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. rocka requested review of this revision. REVISION SUMMARY Created TeamViewer tray icons following Breeze style. REPOSITORY R266 Breeze Icons BRANCH teamviewer-tray (branched fr

D27416: Add small icons for KeePassXC

wsdfhjxc edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27416 To: wsdfhjxc, #vdg, cblack, ndavis Cc: ndavis, cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27416: Add small icons for KeePassXC

wsdfhjxc updated this revision to Diff 77809. wsdfhjxc added a comment. Update small icons for KeePassXC REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27416?vs=75722&id=77809 BRANCH keepassxc-small REVISION DETAIL https://phabricator.kde.org/D27

D27840: Introduce SettingState* elements to ease KCM writing

bport accepted this revision. bport added a comment. This revision is now accepted and ready to land. From code POV this is ok, but neet to wait feedback from VDG to adapt state indicator REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D27840 To: ervin, crossi,

D28079: [keditfiletype] Prevent removing the "main" glob pattern for mime types

ahmadsamir added a comment. For background see: https://bugs.kde.org/show_bug.cgi?id=414742 I may be wrong, but personally I think QMimeDatabase is acting sensibly by not allowing to remove the "main" glob pattern of a mimetype. Also IIUC it seems other tools are sort of doing the sa

D27986: Allow providing an error message from the application

bcooksley added a comment. The following is notice that I intend to revert this change, along with the corresponding commits that make use of this functionality in Dr Konqi, as they cause a FTBFS on both FreeBSD and Windows which has not been addressed. This regression is over a week old at

D27855: [Debug] Improve readability of positioninfo debug format

bcooksley added a comment. One of the changes in this string of 4 revisions has unfortunately broken the build of Baloo on the CI system. Please see https://build.kde.org/view/Failing/job/Frameworks/job/baloo/job/kf5-qt5%20FreeBSDQt5.13/90/console REPOSITORY R293 Baloo REVISION DETAIL

D17816: Support for xattrs on kio copy/move

cochise added inline comments. INLINE COMMENTS > dfaure wrote in jobtest.cpp:638 > Was my comment ignored? Fixed on new commit. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17816 To: cochise, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta Cc: usta, scheirle, ant

D17816: Support for xattrs on kio copy/move

cochise added inline comments. INLINE COMMENTS > usta wrote in jobtest.cpp:573 > but you have written it as with single T , i think it must be double ( TT ) You are right. Sorry. Fixed. =] REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17816 To: cochise, dfaure, chinmoyr

D17816: Support for xattrs on kio copy/move

cochise updated this revision to Diff 77804. cochise added a comment. Refactored the tests: Plattform command configured on JobTest::initTestCase Removal duplicated code of functions [...]WithXattr Added check is filesystens supports users xattr: > Try to write xattr on sour

  1   2   >