ngraham added a reviewer: meven.
ngraham added a comment.
@emateli are you going to be able to finish this? Should someone take over?
It would be a shame for such great work to get stalled so close to the finish
line.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D1463
ngraham added a reviewer: Dolphin.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D14631
To: emateli, #frameworks, dfaure, mlaurent, meven, #dolphin
Cc: meven, anthonyfieroni, chinmoyr, mlaurent, asensi, rkflx, dfaure, aacid,
ngraham, kde-frameworks-devel, LeGast00n, cblack
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/111/
Project:
kf5-qt5 FreeBSDQt5.13
Date of build:
Fri, 28 Feb 2020 01:53:42 +
Build duration:
2 min 7 sec and counting
JUnit Tests
Name: pr
jpoelen created this revision.
jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann.
jpoelen added projects: Kate, Frameworks.
jpoelen requested review of this revision.
REPOSITORY
R216 Syntax Highlighting
BRANCH
cpp (branched from master)
REVISION DETAIL
https://pha
nicolasfella updated this revision to Diff 76587.
nicolasfella added a comment.
rebase
REPOSITORY
R294 KBookmarks
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D25654?vs=70674&id=76587
BRANCH
arcpatch-D25654
REVISION DETAIL
https://phabricator.kde.org/D25654
AFFECTED FILES
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R294:dddb013871ba: Rename actions to be consistent (authored
by nicolasfella).
REPOSITORY
R294 KBookmarks
CHANGES SINCE
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.
Hum. OK. Weird.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D27654
To: wbauer, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
nicolasfella retitled this revision from "Move job classes to kaccounts lib" to
"Move job classes to kaccounts lib and rename to *Job".
REPOSITORY
R155 KAccounts Integration
REVISION DETAIL
https://phabricator.kde.org/D27709
To: nicolasfella, #frameworks, bshah, leinir
nicolasfella updated this revision to Diff 76580.
nicolasfella added a comment.
- Rename to *Job
REPOSITORY
R155 KAccounts Integration
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D27709?vs=76573&id=76580
BRANCH
decl
REVISION DETAIL
https://phabricator.kde.org/D27709
AFFEC
nicolasfella accepted this revision.
nicolasfella added a comment.
This revision is now accepted and ready to land.
Let's get this in. Can you please give me your full name and email address so
I can merge this?
REPOSITORY
R289 KNotifications
BRANCH
adapt-action-numbering-in-android-as-i
nicolasfella created this revision.
nicolasfella added reviewers: Frameworks, bshah, leinir.
nicolasfella requested review of this revision.
REVISION SUMMARY
This makes including them from the qml plugin less weird and they might be
interesting to use from C++ too.
TEST PLAN
builds, kcm open
niccolove updated this revision to Diff 76572.
niccolove marked an inline comment as done.
niccolove added a comment.
Fixed margin
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D27695?vs=76534&id=76572
BRANCH
master
REVISION DETAIL
nicolasfella created this revision.
nicolasfella added reviewers: Frameworks, bshah, leinir.
nicolasfella requested review of this revision.
REVISION SUMMARY
Rename to emphasize it's a kded module plus some random cleanup
TEST PLAN
builds, kded5 starts
REPOSITORY
R155 KAccounts Integration
nicolasfella created this revision.
nicolasfella added reviewers: Frameworks, bshah, leinir.
nicolasfella requested review of this revision.
REPOSITORY
R155 KAccounts Integration
BRANCH
plug
REVISION DETAIL
https://phabricator.kde.org/D27707
AFFECTED FILES
src/daemon/CMakeLists.txt
sr
nicolasfella created this revision.
nicolasfella added reviewers: Frameworks, bshah, leinir.
nicolasfella requested review of this revision.
REVISION SUMMARY
Remove unneeded calls, make coding style a bit more consistent
TEST PLAN
builds
REPOSITORY
R155 KAccounts Integration
BRANCH
cmak
nicolasfella updated this revision to Diff 76566.
nicolasfella added a comment.
Remove unintended change
REPOSITORY
R155 KAccounts Integration
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D27705?vs=76565&id=76566
BRANCH
arcpatch-D27705
REVISION DETAIL
https://phabricator.kd
nicolasfella updated this revision to Diff 76565.
nicolasfella added a comment.
Remove unintended changes
REPOSITORY
R155 KAccounts Integration
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D27705?vs=76563&id=76565
BRANCH
arcpatch-D27705
REVISION DETAIL
https://phabricator.k
nicolasfella created this revision.
nicolasfella added reviewers: Frameworks, bshah, leinir.
nicolasfella requested review of this revision.
REVISION SUMMARY
Don't use naked strings
TEST PLAN
builds
REPOSITORY
R155 KAccounts Integration
BRANCH
qsl
REVISION DETAIL
https://phabricator.
niccolove updated this revision to Diff 76562.
niccolove added a comment.
Hardcoded colors
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D27444?vs=76378&id=76562
BRANCH
top_area (branched from master)
REVISION DETAIL
https://phabric
nicolasfella created this revision.
nicolasfella added reviewers: Frameworks, bshah, leinir.
nicolasfella requested review of this revision.
REVISION SUMMARY
no one is using it
REPOSITORY
R155 KAccounts Integration
BRANCH
cma
REVISION DETAIL
https://phabricator.kde.org/D27704
AFFECTED
ngraham added a dependent revision: D27697: WIP: Added top area to notification
header.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D27695
To: niccolove, mart
Cc: ahiemstra, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,
ngraham, bruns
This revision was automatically updated to reflect the committed changes.
Closed by commit R273:1275529bc2d5: [UrlHandler] Handle opening the online docs
for KCM modules (authored by ahmadsamir).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D27616?vs=76522&id=76555#toc
REPOSITORY
R273
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.13/217/
Project:
kf5-qt5 SUSEQt5.13
Date of build:
Thu, 27 Feb 2020 15:32:48 +
Build duration:
2 min 50 sec and counting
BUILD ARTIFACTS
abi-compatibi
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.12/364/
Project:
kf5-qt5 SUSEQt5.12
Date of build:
Thu, 27 Feb 2020 15:32:48 +
Build duration:
2 min 6 sec and counting
BUILD ARTIFACTS
abi-compatibil
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20WindowsMSVCQt5.14/41/
Project:
kf5-qt5 WindowsMSVCQt5.14
Date of build:
Thu, 27 Feb 2020 15:32:48 +
Build duration:
2 min 4 sec and counting
JUnit Tests
Name:
apol accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R273 KGuiAddons
BRANCH
l-urlhandler-optimi (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D27616
To: ahmadsamir, #frameworks, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2
niccolove edited the summary of this revision.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D27695
To: niccolove, mart
Cc: ahiemstra, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,
ngraham, bruns
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.12/363/
Project:
kf5-qt5 SUSEQt5.12
Date of build:
Thu, 27 Feb 2020 13:01:08 +
Build duration:
2 min 10 sec and counting
BUILD ARTIFACTS
abi-compatib
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.13/216/
Project:
kf5-qt5 SUSEQt5.13
Date of build:
Thu, 27 Feb 2020 13:01:08 +
Build duration:
2 min 10 sec and counting
BUILD ARTIFACTS
abi-compatib
lbeltrame added a comment.
This currently causes a compile error:
/home/abuild/rpmbuild/BUILD/kaccounts-integration-20.03.70git.20200225T132248~74e770c/src/daemon/daemon.cpp:62:78:
error: call of overloaded 'create(AccountsDaemon*, )' is ambiguous
REPOSITORY
R155 KAccounts Integrati
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.12/362/
Project:
kf5-qt5 SUSEQt5.12
Date of build:
Thu, 27 Feb 2020 12:16:18 +
Build duration:
2 min 51 sec and counting
BUILD ARTIFACTS
abi-compatib
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.13/215/
Project:
kf5-qt5 SUSEQt5.13
Date of build:
Thu, 27 Feb 2020 12:16:18 +
Build duration:
2 min 21 sec and counting
BUILD ARTIFACTS
abi-compatib
This revision was automatically updated to reflect the committed changes.
Closed by commit R304:94015abda31b: Fix scrolling on the EntryDetails page
(authored by leinir).
REPOSITORY
R304 KNewStuff
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D27696?vs=76532&id=76535
REVISION DETAIL
hexchain accepted this revision.
hexchain added a comment.
This revision is now accepted and ready to land.
Looks good on khotnewstuff-dialog. Thanks!
REPOSITORY
R304 KNewStuff
BRANCH
fix-scrolling (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D27696
To: leinir, n
niccolove marked an inline comment as done.
niccolove added inline comments.
INLINE COMMENTS
> ahiemstra wrote in TopArea.qml:40
> This conditional is wrong. The syntax is `condition ? true_case : false_case`
> so you want to write `flipped ? -topAreaSvg.margins.top :
> -topAreaSvg.margins.bott
niccolove updated this revision to Diff 76534.
niccolove added a comment.
Fixed conditionals
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D27695?vs=76531&id=76534
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D27695
AF
ahiemstra added inline comments.
INLINE COMMENTS
> TopArea.qml:40
> +rightInset: -topAreaSvg.margins.right
> +topInset: -topAreaSvg.margins.bottom ? flipped : -topAreaSvg.margins.top
> +bottomInset: -topAreaSvg.margins.bottom ? flipped :
> -topAreaSvg.margins.top
This conditional is
niccolove edited the summary of this revision.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D27695
To: niccolove, mart
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
leinir added reviewers: ngraham, Frameworks, Plasma, hexchain.
REPOSITORY
R304 KNewStuff
REVISION DETAIL
https://phabricator.kde.org/D27696
To: leinir, ngraham, #frameworks, #plasma, hexchain
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
leinir created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
leinir requested review of this revision.
REVISION SUMMARY
For ScrollablePage to be able to scroll, the scrollable content must
be the last Item on the page.
BUG:418191
REPO
niccolove updated this revision to Diff 76531.
niccolove added a comment.
Fixed svg path
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D27695?vs=76528&id=76531
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D27695
AFFECT
niccolove added a dependent revision: D27189: Created a top area based on
widgets/toparea.svg.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D27695
To: niccolove, mart
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
niccolove updated this revision to Diff 76528.
niccolove added a comment.
Added licence
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D27695?vs=76527&id=76528
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D27695
AFFECTE
niccolove added a reviewer: mart.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D27695
To: niccolove, mart
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
niccolove created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
niccolove requested review of this revision.
REVISION SUMMARY
This creates a new component that uses the widgets/toparea svg. First time I
try to add something to PlasmaComponen
niccolove added a dependent revision: D27695: WIP: Create a new TopArea element
using widgets/toparea svg.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D27444
To: niccolove, #vdg, ngraham, ndavis
Cc: mart, kde-frameworks-devel, LeGast00n, cblack, GB
ahmadsamir updated this revision to Diff 76522.
ahmadsamir added a comment.
Really revert some changes
REPOSITORY
R273 KGuiAddons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D27616?vs=76474&id=76522
BRANCH
l-urlhandler-optimi (branched from master)
REVISION DETAIL
https://
ervin requested changes to this revision.
ervin added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> settings.cpp:62
>
> -bool Settings::setCheckUppercase(bool check)
> +void Settings::setSkipUppercase(bool check)
> {
Rename the parameter to skip as well ple
48 matches
Mail list logo
