KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.13 - Build # 79 - Still Unstable!

2019-12-15 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.13/79/ Project: kf5-qt5 SUSEQt5.13 Date of build: Mon, 16 Dec 2019 06:05:36 + Build duration: 5 min 31 sec and counting BUILD ARTIFACTS abi-compat

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 128 - Still Unstable!

2019-12-15 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/128/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 16 Dec 2019 06:05:37 + Build duration: 3 min 44 sec and counting BUILD ARTIFACTS abi-compa

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 76 - Still Unstable!

2019-12-15 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/76/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 16 Dec 2019 06:05:36 + Build duration: 2 min 54 sec and counting JUnit Tests Name: pr

D26034: Replace KLocalSocket with QLocalSocket

2019-12-15 Thread Nicolas Fella
nicolasfella edited the summary of this revision. nicolasfella added subscribers: vonreth, cullmann. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26034 To: nicolasfella, #frameworks Cc: cullmann, vonreth, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26034: Replace KLocalSocket with QLocalSocket

2019-12-15 Thread Nicolas Fella
nicolasfella created this revision. nicolasfella added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY As described in T12010 . A

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.13 - Build # 52 - Still Unstable!

2019-12-15 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.13/52/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 15 Dec 2019 23:01:07 + Build duration: 4 min 40 sec and counting JUnit Tests Name

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.13 - Build # 156 - Unstable!

2019-12-15 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.13/156/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 15 Dec 2019 22:32:35 + Build duration: 13 min and counting JUnit Tests Name: project

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 360 - Unstable!

2019-12-15 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/360/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 15 Dec 2019 22:17:44 + Build duration: 20 min and counting BUILD ARTIFACTS acc/KF5KIO-5.66.0.xmllo

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.13 - Build # 62 - Fixed!

2019-12-15 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/62/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 15 Dec 2019 22:29:20 + Build duration: 6 min 20 sec and counting JUnit Tests Name: projec

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 227 - Still Unstable!

2019-12-15 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/227/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 15 Dec 2019 22:17:44 + Build duration: 12 min and counting JUnit Tests Name: projectroot Fai

KDE CI: Frameworks » kiconthemes » kf5-qt5 WindowsMSVCQt5.13 - Build # 35 - Fixed!

2019-12-15 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kiconthemes/job/kf5-qt5%20WindowsMSVCQt5.13/35/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Sun, 15 Dec 2019 22:10:09 + Build duration: 7 min 4 sec and counting JUnit Tests Na

KDE CI: Frameworks » kdesu » kf5-qt5 FreeBSDQt5.13 - Build # 29 - Still Unstable!

2019-12-15 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdesu/job/kf5-qt5%20FreeBSDQt5.13/29/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 15 Dec 2019 22:00:14 + Build duration: 1 min 47 sec and counting JUnit Tests Name: projectr

KDE CI: Frameworks » kimageformats » kf5-qt5 FreeBSDQt5.13 - Build # 26 - Still Unstable!

2019-12-15 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20FreeBSDQt5.13/26/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 15 Dec 2019 21:43:09 + Build duration: 1 min 9 sec and counting JUnit Tests Name: p

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.13 - Build # 44 - Still Unstable!

2019-12-15 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.13/44/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 15 Dec 2019 21:44:58 + Build duration: 2 min 28 sec and counting JUnit Tests Name: proje

KDE CI: Frameworks » kpty » kf5-qt5 FreeBSDQt5.13 - Build # 26 - Still Unstable!

2019-12-15 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpty/job/kf5-qt5%20FreeBSDQt5.13/26/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 15 Dec 2019 21:45:34 + Build duration: 1 min 32 sec and counting JUnit Tests Name: projectro

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 226 - Still Unstable!

2019-12-15 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/226/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 15 Dec 2019 21:00:38 + Build duration: 10 min and counting JUnit Tests Name: projectroot Fai

D25533: Deprecate KFileWidget::toolBar

2019-12-15 Thread Nicolas Fella
This revision was automatically updated to reflect the committed changes. Closed by commit R241:6973d4b26501: Deprecate KFileWidget::toolBar (authored by nicolasfella). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D25533?vs=70622&id=71631#toc REPOSITORY R241 KIO CHANGES SINCE LAST UP

D17071: Don't include any directory sizes in DirectorySizeJob

2019-12-15 Thread seb sasch
sasch added a comment. You created the patch within hours, it was approved within days. One year later we still have nothing within master or any usable distro. Any plans at all to show correct file sizes with KDE? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D170

D25517: Add an option to extract image data and add front cover property

2019-12-15 Thread Alexander Stippich
astippich retitled this revision from "Add an option to extract binary data and add front cover property" to "Add an option to extract image data and add front cover property". REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D25517 To: astippich, #baloo, bruns, mg

D25517: Add an option to extract binary data and add front cover property

2019-12-15 Thread Alexander Stippich
astippich updated this revision to Diff 71623. astippich added a comment. - rename flag to ImageData REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25517?vs=70723&id=71623 BRANCH binaryData REVISION DETAIL https://phabricator.kde.org/D25517 AFF

D25516: Remove unrequired private declarations for taglibextractor

2019-12-15 Thread Alexander Stippich
This revision was automatically updated to reflect the committed changes. Closed by commit R286:f2fea112: Remove unrequired private declarations for taglibextractor (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25516?vs=7039

D23205: [KProcessList] Optimize KProcessList::processInfo

2019-12-15 Thread David Hallas
hallas added a comment. Sorry for breaking the build :/ @kossebau - thanks for fixing it so quickly! I think your fix looks fine :D REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D23205 To: hallas, davidedmundson, broulik, mpyne Cc: kossebau, bcooksley, mpy

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 127 - Still Unstable!

2019-12-15 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/127/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 15 Dec 2019 18:47:55 + Build duration: 6 min 34 sec and counting BUILD ARTIFACTS abi-compa

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 75 - Still unstable!

2019-12-15 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/75/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 15 Dec 2019 18:47:55 + Build duration: 4 min 6 sec and counting JUnit Tests Name: pro

D23205: [KProcessList] Optimize KProcessList::processInfo

2019-12-15 Thread Friedrich W. H. Kossebau
kossebau added a comment. I pushed a quick fix to unbreak the build as bfdc20ed7c6fc1397ba66edd07f86c84d380e291 You might want to inspect it to add that optimization code for the procstat as well, if possible (no i

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.13 - Build # 78 - Still Unstable!

2019-12-15 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.13/78/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sun, 15 Dec 2019 18:47:55 + Build duration: 4 min 18 sec and counting BUILD ARTIFACTS abi-compat

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 74 - Still Failing!

2019-12-15 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/74/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 15 Dec 2019 18:38:09 + Build duration: 2 min 23 sec and counting CONSOLE OUTPUT [...tr

D23457: Port the search interface from QRegExp to QRegularExpression

2019-12-15 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 71618. ahmadsamir retitled this revision from "Port regex search to QRegularExpression" to "Port the search interface from QRegExp to QRegularExpression". ahmadsamir edited the summary of this revision. ahmadsamir edited the test plan for this revision. ah

D23457: Port regex search to QRegularExpression

2019-12-15 Thread Ahmad Samir
ahmadsamir added a comment. Disagreement doesn't always mean distrust. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D23457 To: ahmadsamir, #ktexteditor, dhaumann, cullmann Cc: kde-frameworks-devel, kwrite-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns

D23457: Port regex search to QRegularExpression

2019-12-15 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 71617. ahmadsamir added a comment. Address comments REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23457?vs=71178&id=71617 BRANCH l-qregularexpression (branched from master) REVISION DETAIL https://phabricat

D25984: Load translations

2019-12-15 Thread Friedrich W. H. Kossebau
kossebau added a comment. In D25984#578306 , @kossebau wrote: > Hm, though now I am confused why calling this from `KirigamiPlugin::initializeEngine` fixes things for you, the static struct constructor of that startup hook technology in the lib

D25984: Load translations

2019-12-15 Thread Kai Uwe Broulik
broulik added a comment. I guess it builds the QML tree and evaluates the `qsTr` calls and then finds it needs an item from a plugin and loads the import and only then translates it. Subsequent controls are translated, only the ones on the initial item are not. Perhaps if we shoehorn a `QQml

D25984: Load translations

2019-12-15 Thread Friedrich W. H. Kossebau
kossebau added a comment. Hm, though now I am confused why calling this from `KirigamiPlugin::initializeEngine` fixes things for you, the static struct constructor of that startup hook technology in the lib should be invoked before during loading, no? Time to go playing with the actual

D25984: Load translations

2019-12-15 Thread Friedrich W. H. Kossebau
kossebau added a comment. In D25984#578299 , @broulik wrote: > Ok, so turns out, it does call it when the plugin is loaded, but the translations are only installed *after* the QML has loaded and processed. Uh, okay, that seems like things

D25984: Load translations

2019-12-15 Thread David Edmundson
davidedmundson added a comment. > Okay. Which app did you test with? Does it link kcoreaddons? Would poke then as well a bit, as I happen to have a related rant blog post lying around ;) ). systemsettings5 exhibits this situation REPOSITORY R169 Kirigami REVISION DETAIL https://pha

D25984: Load translations

2019-12-15 Thread Friedrich W. H. Kossebau
kossebau added a comment. In D25984#578298 , @broulik wrote: > Well, whatever it is, it doesn't work. My search field isn't translated and I put breakpoints and I only get it load translations for kcoreaddons and kjobwidgets. Okay. Which

D25984: Load translations

2019-12-15 Thread Kai Uwe Broulik
broulik added a comment. Ok, so turns out, it does call it when the plugin is loaded, but the translations are only installed *after* the QML has loaded and processed. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D25984 To: broulik, #kirigami, #frameworks, kosseb

D25984: Load translations

2019-12-15 Thread Kai Uwe Broulik
broulik added a comment. Well, whatever it is, it doesn't work. My search field isn't translated and I put breakpoints and I only get it load translations for kcoreaddons and kjobwidgets. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D25984 To: broulik, #kirigami

D25984: Load translations

2019-12-15 Thread Friedrich W. H. Kossebau
kossebau added a comment. In D25984#578296 , @broulik wrote: > We don't link against Kirigami, so the startup routine stuff doesn't apply? `Q_COREAPP_STARTUP_FUNCTION` generates a static struct in the compiled code, whose constructor will

D25984: Load translations

2019-12-15 Thread Kai Uwe Broulik
broulik added a comment. We don't link against Kirigami, so the startup routine stuff doesn't apply? And we're way after the QCoreApp constructor at this point. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D25984 To: broulik, #kirigami, #frameworks, kossebau, aac

D25922: Don't use a verified nullptr as a data source

2019-12-15 Thread Dan Leinir Turthra Jensen
This revision was automatically updated to reflect the committed changes. Closed by commit R235:5a379ba5a6ce: Don't use a verified nullptr as a data source (authored by leinir). REPOSITORY R235 Attica CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25922?vs=71362&id=71608 REVISION DE

D25984: Load translations

2019-12-15 Thread Friedrich W. H. Kossebau
kossebau added a comment. In D25984#578291 , @broulik wrote: > Qt docs say "Adds a global function that will be called from the QCoreApplication constructor. " but when we at runtime somewhere load a QML plugin we're too late with that.

D25015: Update breeze theme shadows

2019-12-15 Thread Niccolò Venerandi
niccolove added a comment. Got it. Blur is not rounded either to me. The shadow was hiding it. F7819795: Screenshot_20191215_170023.png In D25015#575297 , @mart wrote: > In D25015#568865

D25984: Load translations

2019-12-15 Thread Kai Uwe Broulik
broulik added a comment. Qt docs say "Adds a global function that will be called from the QCoreApplication constructor. " but when we at runtime somewhere load a QML plugin we're too late with that. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D25984 To: broulik

D25015: Update breeze theme shadows

2019-12-15 Thread Niccolò Venerandi
niccolove added a comment. I just compared the blur and contrast effects and the mask is used in the exact same way :-/ I have no idea what could be wrong there. REPOSITORY R242 Plasma Framework (Library) BRANCH bettershadows (branched from master) REVISION DETAIL https://phabricator.

D25984: Load translations

2019-12-15 Thread Friedrich W. H. Kossebau
kossebau added a comment. > The ECM QM Loader uses Q_COREAPP_STARTUP_FUNCTION which doesn't work for things loaded as plugins like QML modules. Curious, where it exactly does it fail to work? Q_COREAPP_STARTUP_FUNCTION being nvoked during lib loading after the QApp instance exists still

D25334: Added transparent blue background to tabbars

2019-12-15 Thread Niccolò Venerandi
niccolove added a comment. Breeze dark highlight is currently #3daee9 in the Breeze Dark colorscheme. If that's too light, we could darken it there, right? Currently it's: F7819764: Screenshot_20191215_163924.png Darker could be (example value): F7

D26000: [Plasma Dialog] Use QXcbWindowFunctions for setting window types Qt WindowFlags don't knows

2019-12-15 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R242:192a50fe8c3c: [Plasma Dialog] Use QXcbWindowFunctions for setting window types Qt WindowFlags… (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D26000?vs=71538&id=71606#toc

D26016: [KeySequenceHelper] Work around Meta modifier behavior

2019-12-15 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D26016 To: broulik, #plasma, davidedmundson Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26017: [KKeySequenceWidget] Work around Meta modifier behavior

2019-12-15 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D26017 To: broulik, #frameworks, davidedmundson Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26000: [Plasma Dialog] Use QXcbWindowFunctions for setting window types Qt WindowFlags don't knows

2019-12-15 Thread David Edmundson
davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. I think we need to look at our direction of KWindowSystem long term, but in terms of what actually happens this makes complete sense. Better to set the right type once,

D25999: Add optional subtitle to grid delegate

2019-12-15 Thread Nathaniel Graham
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R296:0dda5f9566cf: Add optional subtitle to grid delegate (authored by ngraham). REPOSITORY R296 KDeclarative CHANGES SI

D25999: Add optional subtitle to grid delegate

2019-12-15 Thread Nathaniel Graham
ngraham added a comment. Got a shipit from @davidedmundson, shippingit! REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D25999 To: ngraham, #vdg, #plasma, davidedmundson Cc: ndavis, filipf, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26017: [KKeySequenceWidget] Work around Meta modifier behavior

2019-12-15 Thread Kai Uwe Broulik
broulik created this revision. broulik added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY When I press my Meta key, I get a `Key_Super_L` *without* a Meta key confusing th

D26016: [KeySequenceHelper] Work around Meta modifier behavior

2019-12-15 Thread Kai Uwe Broulik
broulik updated this revision to Diff 71596. broulik edited the summary of this revision. broulik edited the test plan for this revision. broulik added a comment. - Turns out it's not QtQuick REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26016?vs=7159

D26016: [KeySequenceHelper] Work around Meta modifier behavior

2019-12-15 Thread Kai Uwe Broulik
broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY For some reason in QtQuick when I press my Meta key, I get a `Key_Super_L` *without*

D26014: remove compiler information from bug report dialog

2019-12-15 Thread David Edmundson
davidedmundson accepted this revision. REPOSITORY R263 KXmlGui BRANCH master REVISION DETAIL https://phabricator.kde.org/D26014 To: sitter, dfaure, ngraham, davidedmundson Cc: kde-frameworks-devel, ngraham, LeGast00n, GB_2, michaelh, bruns

D13541: Port solid from Qt5::Widgets to Qt5::Gui

2019-12-15 Thread Aleix Pol Gonzalez
apol added a comment. In D13541#578027 , @bcooksley wrote: > This broke the build on FreeBSD - Please see https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.13/43/ fixed REPOSITORY R245 Solid REVISION DETAIL ht

D26014: remove compiler information from bug report dialog

2019-12-15 Thread Harald Sitter
sitter created this revision. sitter added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY it's been broken since 5.0 and nobody noticed. Nate and I also think that it doesn't re

D26014: remove compiler information from bug report dialog

2019-12-15 Thread Nathaniel Graham
ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R263 KXmlGui BRANCH master REVISION DETAIL https://phabricator.kde.org/D26014 To: sitter, dfaure, ngraham Cc: kde-frameworks-devel, ngraham, LeGast00n, GB_2, michaelh, bruns

D26013: [KeySequenceHelper] Grab actual window when embedded

2019-12-15 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, davidre. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY When used in a KCM which uses `QQuickWidget` it needs to enable grab on the r

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.13 - Build # 45 - Still unstable!

2019-12-15 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.13/45/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 15 Dec 2019 11:18:41 + Build duration: 1 min 4 sec and counting JUnit Tests Name: projectro

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.13 - Build # 44 - Still Failing!

2019-12-15 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.13/44/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 15 Dec 2019 11:11:51 + Build duration: 1 min 24 sec and counting CONSOLE OUTPUT [...truncate

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 SUSEQt5.13 - Build # 47 - Still Unstable!

2019-12-15 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20SUSEQt5.13/47/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sun, 15 Dec 2019 10:03:25 + Build duration: 4 min 53 sec and counting JUnit Tests Name:

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 SUSEQt5.12 - Build # 82 - Still Unstable!

2019-12-15 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20SUSEQt5.12/82/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 15 Dec 2019 10:03:29 + Build duration: 3 min 58 sec and counting JUnit Tests Name:

D26011: Align ECM and Qt setup with Frameworks conventions

2019-12-15 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R174:ce6699a141a0: Align ECM and Qt setup with Frameworks conventions (authored by vkrause). REPOSITORY R174 KContacts CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26011?vs=71575&id=71576 RE

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 225 - Still Unstable!

2019-12-15 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/225/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 15 Dec 2019 09:57:53 + Build duration: 8 min 43 sec and counting JUnit Tests Name: projectro

D26011: Align ECM and Qt setup with Frameworks conventions

2019-12-15 Thread Volker Krause
vkrause updated this revision to Diff 71575. vkrause added a comment. Remove duplicate include. REPOSITORY R174 KContacts CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26011?vs=71573&id=71575 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26011 AFFECTED FILES

D25972: Support PyQt5 compiled with SIP 5

2019-12-15 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes. Closed by commit R240:7c84be59f686: Support PyQt5 compiled with SIP 5 (authored by arojas). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25972?vs=71563&id=71574 REVISION D

D26011: Align ECM and Qt setup with Frameworks conventions

2019-12-15 Thread Christophe Giboudeaux
cgiboudeaux accepted this revision. cgiboudeaux added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > CMakeLists.txt:28 > include(ECMSetupVersion) > include(FeatureSummary) > include(ECMQtDeclareLoggingCategory) Remove this one REPOSITORY R174 KContacts

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 224 - Still Unstable!

2019-12-15 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/224/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 15 Dec 2019 09:45:56 + Build duration: 11 min and counting JUnit Tests Name: projectroot Fai

D26011: Align ECM and Qt setup with Frameworks conventions

2019-12-15 Thread Volker Krause
vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY This completes the previous commit which provided the hotfix for the ECM version lookup issue breaking the build. REP

KDE CI: Frameworks » kcontacts » kf5-qt5 WindowsMSVCQt5.13 - Build # 35 - Still unstable!

2019-12-15 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcontacts/job/kf5-qt5%20WindowsMSVCQt5.13/35/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Sun, 15 Dec 2019 09:46:08 + Build duration: 10 min and counting JUnit Tests Name: pr

KDE CI: Frameworks » kcontacts » kf5-qt5 SUSEQt5.13 - Build # 38 - Fixed!

2019-12-15 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kcontacts/job/kf5-qt5%20SUSEQt5.13/38/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sun, 15 Dec 2019 09:46:08 + Build duration: 5 min 9 sec and counting BUILD ARTIFACTS abi-compatibil

KDE CI: Frameworks » kcontacts » kf5-qt5 SUSEQt5.12 - Build # 37 - Fixed!

2019-12-15 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kcontacts/job/kf5-qt5%20SUSEQt5.12/37/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 15 Dec 2019 09:46:09 + Build duration: 3 min 41 sec and counting BUILD ARTIFACTS abi-compatibi

D23205: [KProcessList] Optimize KProcessList::processInfo

2019-12-15 Thread Ben Cooksley
bcooksley added a comment. This broke the build on FreeBSD - See https://build.kde.org/view/Failing/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/lastFailedBuild/console REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D23205 To: hallas, davidedmundso

KDE CI: Frameworks » kcontacts » kf5-qt5 FreeBSDQt5.13 - Build # 36 - Fixed!

2019-12-15 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kcontacts/job/kf5-qt5%20FreeBSDQt5.13/36/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 15 Dec 2019 09:46:08 + Build duration: 1 min 57 sec and counting JUnit Tests Name: proje

D13541: Port solid from Qt5::Widgets to Qt5::Gui

2019-12-15 Thread Ben Cooksley
bcooksley added a comment. This broke the build on FreeBSD - Please see https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.13/43/ REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D13541 To: graesslin, #frameworks, dhaumann, apol, broulik Cc: bcooksl

D25972: Support PyQt5 compiled with SIP 5

2019-12-15 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D25972 To: arojas, bruns, dfaure, apol Cc: apol, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh, ngraham

D26009: KCoreAddons: fix compilation with qtbase git dev branch

2019-12-15 Thread Volker Krause
vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D26009 To: dfaure, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25996: KRemoteEncoding::encoding: don't return temporary. Found with clazy.

2019-12-15 Thread Christian Ehrlicher
This revision was automatically updated to reflect the committed changes. Closed by commit R241:d80cb8c96eef: KRemoteEncoding::encoding: don't return temporary. Found with clazy. (authored by chehrlic). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25996?vs=71529

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.13 - Build # 43 - Failure!

2019-12-15 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.13/43/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 15 Dec 2019 09:44:43 + Build duration: 1 min 23 sec and counting CONSOLE OUTPUT [...truncate

D25997: KFilePlacesModel: properly parent tagsLister to avoid memleak. Introduced with D7700

2019-12-15 Thread Christian Ehrlicher
This revision was automatically updated to reflect the committed changes. Closed by commit R241:be9537998890: KFilePlacesModel: properly parent tagsLister to avoid memleak. Introduced with… (authored by chehrlic). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D259

D25922: Don't use a verified nullptr as a data source

2019-12-15 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R235 Attica BRANCH dont-use-null-qcoreapp-instance (branched from master) REVISION DETAIL https://phabricator.kde.org/D25922 To: leinir, #frameworks, #knewstuff, #plasma, ronaldv, apol Cc: kde-framewo

D25995: HTTP ioslave: call correct base class in virtual_hook(). The base of HTTP ioslave is TCPSlaveBase, not SlaveBase.

2019-12-15 Thread Christian Ehrlicher
This revision was automatically updated to reflect the committed changes. Closed by commit R241:6f1628706490: HTTP ioslave: call correct base class in virtual_hook(). The base of HTTP… (authored by chehrlic). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25995?vs

D13541: Port solid from Qt5::Widgets to Qt5::Gui

2019-12-15 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes. Closed by commit R245:9f868681b26e: Port solid from Qt5::Widgets to Qt5::Gui (authored by graesslin, committed by apol). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D13541?vs=36167&id=71569#toc REPOSITORY R245

KDE CI: Frameworks » kcodecs » kf5-qt5 SUSEQt5.13 - Build # 35 - Still Unstable!

2019-12-15 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcodecs/job/kf5-qt5%20SUSEQt5.13/35/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sun, 15 Dec 2019 08:54:59 + Build duration: 2 min 26 sec and counting BUILD ARTIFACTS abi-compatibil

KDE CI: Frameworks » kcodecs » kf5-qt5 SUSEQt5.12 - Build # 63 - Still Unstable!

2019-12-15 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcodecs/job/kf5-qt5%20SUSEQt5.12/63/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 15 Dec 2019 08:54:59 + Build duration: 2 min 15 sec and counting BUILD ARTIFACTS abi-compatibil

KDE CI: Frameworks » kcodecs » kf5-qt5 FreeBSDQt5.13 - Build # 31 - Still Unstable!

2019-12-15 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcodecs/job/kf5-qt5%20FreeBSDQt5.13/31/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 15 Dec 2019 08:54:59 + Build duration: 1 min 9 sec and counting JUnit Tests Name: project