Re: Notice of intention to remove tests from KCrash and KNotifications

On Tue, Nov 5, 2019 at 11:50 PM Harald Sitter wrote: > > I get where you are coming from, but honestly, none of this makes > pushing unreviewed commits that disable the entire test collection of > an entire framework any more correct. If it had only affected the one > test I wouldn't mind so much,

D25149: Add a new Template for KCM's.

yurchor added inline comments. INLINE COMMENTS > main.qml:37 > +QQC2.Label { > +text: i18n("Exemple KCM that does nothing") > +} Typo: Exemple -> Example REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25149 To: tcanabrav

D25149: Add a new Template for KCM's.

davidedmundson added a comment. A very sensible idea. ++ > templates/kcm-qml/qml-plasmoid.png What's this about? INLINE COMMENTS > main.qml:26 > +import org.kde.kcm 1.1 as KCM > +import Qt.labs.platform 1.1 > + lets not encourage this import REPOSITORY R242 Plasma Framework (Lib

D25149: Add a new Template for KCM's.

ognarb added a comment. Another related todo would be to update/rewrite https://techbase.kde.org/Development/Tutorials/KCM_HowTo after this template is merged and include information about it ;) REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D2514

D25067: Fix the header layouts for EntryDetails and Page components

This revision was automatically updated to reflect the committed changes. Closed by commit R304:4d56727cc7d7: Fix the header layouts for EntryDetails and Page components (authored by leinir). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25067?vs=69319&id=6

Re: Notice of intention to remove tests from KCrash and KNotifications

On Wed, 6 Nov 2019, 01:02 Harald Sitter, wrote: > I think on a CI level we can only disable test executation as a whole, > so that's an even bigger sledgehammer ;) > That is correct. That was the hammer that extra CMake modules was hit with back in 2017, when a similar issue occurred with a bro

D25159: Fix linking to libssh 0.9.1

arojas abandoned this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D25159 To: arojas, apol, sitter, fvogt Cc: fvogt, sitter, asn, apol, asturmlechner, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, G

D25159: Fix linking to libssh 0.9.1

fvogt requested changes to this revision. fvogt added a comment. This revision now requires changes to proceed. The libssh maintainer is likely reverting the change, so this should not be necessary. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D25159 To: arojas

D25159: Fix linking to libssh 0.9.1

asn added a comment. The plan is to have ssh as the target name and nothing else and support BUILD_SHARED_LIBS. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D25159 To: arojas, apol, sitter Cc: sitter, asn, apol, asturmlechner, kde-frameworks-devel, kfm-devel,

D25159: Fix linking to libssh 0.9.1

sitter added a comment. In D25159#559016 , @asn wrote: > We moved from a manually generated libssh-config.cmake to install(EXPORTS libssh-config) and it does things completely different. > > I'm currently trying to fix it. However better don'

D25159: Fix linking to libssh 0.9.1

asn added a comment. We moved from a manually generated libssh-config.cmake to install(EXPORTS libssh-config) and it does things completely different. I'm currently trying to fix it. However better don't apply this as ssh_shared will vanish as a target. I wonder how I can define LIB

D25159: Fix linking to libssh 0.9.1

sitter added subscribers: asn, sitter. sitter accepted this revision. sitter added a comment. I think there's a smarter way of dealing with this somewhere in our finder, not blocking though. I'll take a look when I find a minute. @asn it seems to me the cmake config broke compat between 0

KDE CI: Frameworks » knotifications » kf5-qt5 WindowsMSVCQt5.13 - Build # 31 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20WindowsMSVCQt5.13/31/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Tue, 05 Nov 2019 09:26:14 + Build duration: 6 hr 41 min and counting

KDE CI: Frameworks » kcrash » kf5-qt5 WindowsMSVCQt5.13 - Build # 12 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kcrash/job/kf5-qt5%20WindowsMSVCQt5.13/12/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Tue, 05 Nov 2019 09:06:58 + Build duration: 6 hr 58 min and counting JUnit Tests Name: p

D25159: Fix linking to libssh 0.9.1

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Fixes the build for me too, patch looks good. Thanks! REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D25159 To: arojas, apol Cc: apol, asturmlechner, kde-frame

D25159: Fix linking to libssh 0.9.1

arojas retitled this revision from "Fix linking to libssh 0.9" to "Fix linking to libssh 0.9.1". arojas edited the summary of this revision. arojas edited the test plan for this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D25159 To: arojas Cc: asturmlech

D25159: Fix linking to libssh 0.9

arojas created this revision. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY libssh 0.9 no longer defines LIBSSH_LIBRARIES in its cmake config, and exports a ssh_shared target inst

D25067: Fix the header layouts for EntryDetails and Page components

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R304 KNewStuff BRANCH fix-page-and-entrydetails-headers (branched from master) REVISION DETAIL https://phabricator.kde.org/D25067 To: leinir, ngraham, #knewstuff, #frameworks, #plasma Cc: ahiemstra

D24825: Add hideOnWindowDeactivate to PlasmaComponents.Dialog

This revision was automatically updated to reflect the committed changes. Closed by commit R242:96b7fc21f5b5: Add hideOnWindowDeactivate to PlasmaComponents.Dialog (authored by kmaterka). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24825?

KDE CI: Frameworks » kcmutils » kf5-qt5 WindowsMSVCQt5.13 - Build # 28 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kcmutils/job/kf5-qt5%20WindowsMSVCQt5.13/28/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Mon, 04 Nov 2019 14:43:52 + Build duration: 22 hr and counting

D24825: Add hideOnWindowDeactivate to PlasmaComponents.Dialog

davidedmundson added a comment. > maybe there is no point in fixing this? PlasmaComponents are dead in favour of Plasma Components 3 (which have to match QtQuickControls2 API) Maybe not, from what I can see the original code could use PlasmaCore.Dialog directly. Or the inbuilt way p

D24825: Add hideOnWindowDeactivate to PlasmaComponents.Dialog

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D24825 To: kmaterka, #plasma, #frameworks, davidedmundson Cc: kde-frameworks-devel, LeGast00n, GB_2,

D24825: Add hideOnWindowDeactivate to PlasmaComponents.Dialog

kmaterka added a comment. Should I proceed? This component has serious issues anyway, maybe there is no point in fixing this? For example: There is Loader that load always the same QML because... "if (true || )" - line 241. Even if this is obsolete, cleanup would be good idea. REPOSI

D25067: Fix the header layouts for EntryDetails and Page components

leinir updated this revision to Diff 69319. leinir marked 6 inline comments as done. leinir added a comment. - Remove the custom title delegate on EntryDetails REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25067?vs=69281&id=69319 BRANCH fix-page-and-e

D25067: Fix the header layouts for EntryDetails and Page components

leinir added inline comments. INLINE COMMENTS > ahiemstra wrote in EntryDetails.qml:94 > Hmm, with the new toolbar code, there's actually little reason to use a > custom delegate here, since the toolbar header already uses a title + tool > buttons style. You could convert the three toolbuttons

D25143: Basic cross-compiling support for parsetrigrams

This revision was automatically updated to reflect the committed changes. Closed by commit R246:1ada4bec82ea: Basic cross-compiling support for parsetrigrams (authored by vkrause, committed by cullmann). REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25143?vs=6

Re: Notice of intention to remove tests from KCrash and KNotifications

I think on a CI level we can only disable test executation as a whole, so that's an even bigger sledgehammer ;) For KCrash at least we've now implemented the aforementioned workaround where the broken test is disabled for windows. For knotifications I trust Kai will come up with a solution once he

D24843: [KDEPlatformSystemTrayIcon] Recreate deleted menu

This revision was automatically updated to reflect the committed changes. Closed by commit R135:bc1c85144adb: [KDEPlatformSystemTrayIcon] Recreate deleted menu (authored by kmaterka). REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE https://phabricator.kde.

D25153: disable kcrashtest and its helper executable test_crasher on windows

This revision was automatically updated to reflect the committed changes. Closed by commit R285:d3b83d931176: disable kcrashtest and its helper executable test_crasher on windows (authored by sitter). REPOSITORY R285 KCrash CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25153?vs=6930

D25154: actually set a dependency between kcrashtest and test_crasher

This revision was automatically updated to reflect the committed changes. Closed by commit R285:cc0d3c8b7977: actually set a dependency between kcrashtest and test_crasher (authored by sitter). REPOSITORY R285 KCrash CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25154?vs=69305&id=69

D25143: Basic cross-compiling support for parsetrigrams

apol accepted this revision. apol added a comment. LGTM, thanks for looking into this! REPOSITORY R246 Sonnet BRANCH master REVISION DETAIL https://phabricator.kde.org/D25143 To: vkrause, cullmann, apol Cc: apol, cullmann, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bru

D24843: [KDEPlatformSystemTrayIcon] Recreate deleted menu

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R135 Integration for Qt applications in Plasma BRANCH master REVISION DETAIL https://phabricator.kde.org/D24843 To: kmaterka, apol, davidedmundson, #plasma, #frameworks, broulik, nicolasfella Cc: plas

D25154: actually set a dependency between kcrashtest and test_crasher

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R285 KCrash BRANCH test-dep REVISION DETAIL https://phabricator.kde.org/D25154 To: sitter, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25153: disable kcrashtest and its helper executable test_crasher on windows

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R285 KCrash BRANCH master REVISION DETAIL https://phabricator.kde.org/D25153 To: sitter, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25067: Fix the header layouts for EntryDetails and Page components

ahiemstra added inline comments. INLINE COMMENTS > EntryDetails.qml:94 > title: i18nc("Combined title for the entry details page made of the name > of the entry, and the author's name", "%1 by > %2").arg(component.name).arg(entryAuthor.name) > titleDelegate: QtLayouts.RowLayout { > +

Re: Notice of intention to remove tests from KCrash and KNotifications

Would it make sense to re-enable those tests in the code repositories but disable CI for the corresponding repositories until someone addressed the issues affecting overall CI? On 2019-11-05 11:50, Harald Sitter wrote: I get where you are coming from, but honestly, none of this makes pushing un

D25152: Reenable the tests and only disable krcrashtest on windows

ahmadsamir added a comment. In D25152#558886 , @sitter wrote: > Heh, sorry 😉 Don't be sorry, yours is actually a fix, mine isn't/wasn't :D > D25153 for reference. REPOSITORY R285 KCrash REVISIO

D25152: Reenable the tests and only disable krcrashtest on windows

sitter added a comment. Heh, sorry 😉 D25153 for reference. REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D25152 To: ahmadsamir, #frameworks, sitter Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

Re: Notice of intention to remove tests from KCrash and KNotifications

I get where you are coming from, but honestly, none of this makes pushing unreviewed commits that disable the entire test collection of an entire framework any more correct. If it had only affected the one test I wouldn't mind so much, but since it hasn't it only goes to proof that we have reviews

D25067: Fix the header layouts for EntryDetails and Page components

leinir added a comment. In D25067#558557 , @ngraham wrote: > With that Kirigami patch, this *almost* works. There's still an empty area on the right: > > F7735292: Screenshot_20191104_092108.png > >

D24979: KRunner: port away from deprecated KF5 API

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R308:7bbd29591094: KRunner: port away from deprecated KF5 API (authored by dfaure, committed by kossebau). CHANGED PRIOR TO

D25154: actually set a dependency between kcrashtest and test_crasher

sitter created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY the former uses the latter to actualy conduct its test. without the declared dependency `make kcrashtest` would not prod

D25152: Reenable the tests and only disable krcrashtest on windows

ahmadsamir abandoned this revision. ahmadsamir added a comment. @sitter: I see you have a fix already :) REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D25152 To: ahmadsamir, #frameworks, sitter Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

Re: Notice of intention to remove tests from KCrash and KNotifications

On Tue, Nov 5, 2019 at 11:11 PM Harald Sitter wrote: > > Perhaps you need to find a minion to do these changes for you then or > read up on cmake and/or put these changes through review, because for > KCrash you also disabled and unrelated test :| It would be nice if people would take action to e

D25153: disable kcrashtest and its helper executable test_crasher on windows

sitter created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY test_crasher gets stuck in a loop breaking the CI system. let's disable the entire test until someone finds the interest

D24979: KRunner: port away from deprecated KF5 API

kossebau commandeered this revision. kossebau edited reviewers, added: dfaure; removed: kossebau. kossebau added a comment. This revision now requires review to proceed. @dfaure I allow myself to take over here given your are off the next days and I would like to get this off the table :) REP

D25152: Reenable the tests and only disable krcrashtest on windows

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, sitter. Herald added a project: Frameworks. ahmadsamir requested review of this revision. TEST PLAN Code builds and tests pass on Linux REPOSITORY R285 KCrash BRANCH l-win-test (branched from master) REVISION DETAIL

Re: Notice of intention to remove tests from KCrash and KNotifications

Perhaps you need to find a minion to do these changes for you then or read up on cmake and/or put these changes through review, because for KCrash you also disabled and unrelated test :| On Tue, Nov 5, 2019 at 10:24 AM Ben Cooksley wrote: > > On Tue, Nov 5, 2019 at 1:20 AM Harald Sitter wrote: >

Re: Notice of intention to remove tests from KCrash and KNotifications

On Tue, Nov 5, 2019 at 1:20 AM Harald Sitter wrote: > > Wouldn't the more appropriate workaround then be to disable the test on > windows? If one had the appropriate knowledge of CMake to do so, quite possibly. Given that I don't however, and others haven't made the necessary changes (and nobod

KDE CI: Frameworks » kcrash » kf5-qt5 WindowsMSVCQt5.13 - Build # 11 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcrash/job/kf5-qt5%20WindowsMSVCQt5.13/11/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Mon, 04 Nov 2019 09:01:16 + Build duration: 1 day 0 hr and counting JUnit Tests Name: p