D24652: Add folder-recent, extend hand of clock in folder-temp

This revision was automatically updated to reflect the committed changes. Closed by commit R266:2a36922a8cc4: Add folder-recent, extend hand of clock in folder-temp (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24652?vs=67939&id=687

D24625: Fill middle mouse button area

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R266:8732c6a99ad1: Fill middle mouse button area (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST U

D24932: [WIP]: Add Button to open the folder in filelight for more details

shubham added inline comments. INLINE COMMENTS > ngraham wrote in kpropertiesdialog.cpp:1100 > This is a `QPushButton`, so connect to `&QPushButton::clicked` It is done this way a bit below in line 1106 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24932 To: shubham, ng

D24932: [WIP]: Add Button to open the folder in filelight for more details

ngraham added a comment. Much better, thanks. INLINE COMMENTS > kpropertiesdialog.cpp:1097 > + > +if (QStandardPaths::findExecutable(QStringLiteral("filelight")) != > QString()) { > +d->m_sizeDetailsButton = new QPushButton(i18n("Explore in > Filelight?"), d->m_f

D24951: [KOpenWithDialog] Automatically select the result if the model filter has only one match

ngraham added a comment. Why wouldn't you want the first result chosen when there's more than one result? If you enter a search term and get (say) 2 results and the one you want to select is the first one, this patch would regress that, no? REPOSITORY R241 KIO REVISION DETAIL https://ph

D24476: [KPropertiesDialog] Only show volume-related info for volumes

ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. In D24476#554110 , @pino wrote: > Please remember that the properties dialog is a general dialog offered by the KIO framework, and i

D24476: [KPropertiesDialog] Only show volume-related info for volumes

pino added a comment. In D24476#543298 , @ngraham wrote: > In D24476#543297 , @broulik wrote: > > > Perhaps, but right clicking on my HOME will then give me no information as it's not a separate mou

D24884: I18N_NOOP2 was deprecated but we can't replace by I18NC_NOOP as it expends it as 2 elements (context + text)

aacid added a comment. In D24884#553786 , @mlaurent wrote: > So what is the correct fix for my case ? Port your code to I18NC_NOOP REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D24884 To: mlaurent, dfaure, ilic C

D24951: [KOpenWithDialog] Automatically select the result if the model filter has only one match

ahmadsamir created this revision. ahmadsamir added a reviewer: dfaure. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY If the user types some text in the lineEdit and there's more than one match in the model view, don't automatically select th

D24476: [KPropertiesDialog] Only show volume-related info for volumes

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. I agree with this change. REPOSITORY R241 KIO BRANCH only-show-volume-info-for-volumes (branched from master) REVISION DETAIL https://phabricator.kde.org/D24476 To: ngraham, #vdg, #

D24941: [kpropertiesdialog] Display item text() when the file is readonly and otherwise would display "." or ""

ngraham added a comment. You're right that the code is quite convoluted. But it would seem to make sense to fix the value there rather than conditionally overriding it later. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24941 To: meven, ngraham, #frameworks Cc: kde-f

D24892: Fix usage of the new deprecation macros for assignIconsToContextMenu

kossebau accepted this revision. kossebau added a comment. This revision is now accepted and ready to land. In D24892#553597 , @vkrause wrote: > In D24892#552838 , @kossebau wrote: > > > Looks good.

D24433: Move URL parsing methods from kioslave to query object

iasensio added a comment. Friday ping 😃 REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D24433 To: iasensio, #baloo, meven Cc: kde-frameworks-devel, #dolphin, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, ng

D24932: [WIP]: Add Button to open the folder in filelight for more details

shubham marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24932 To: shubham, ngraham, #frameworks Cc: kde-frameworks-devel, #frameworks, LeGast00n, GB_2, michaelh, ngraham, bruns

D24932: [WIP]: Add Button to open the folder in filelight for more details

shubham updated this revision to Diff 68759. shubham marked 3 inline comments as done. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24932?vs=68710&id=68759 REVISION DETAIL https://phabricator.kde.org/D24932 AFFECTED FILES src/widgets/kpropertiesdialog.cpp

D24941: [kpropertiesdialog] Display item text() when the file is readonly and otherwise would display "." or ""

meven added a comment. In D24941#553926 , @ngraham wrote: > Do we know why `d->oldname` is empty or `.` in the first place? Feels like maybe this should be fixed there. line 873 in kpropertiesdialog.cpp > // Extract the file name o

D24909: [PC3/button] Elide text always

This revision was automatically updated to reflect the committed changes. Closed by commit R242:12edce87bbd7: [PC3/button] Elide text always (authored by davidedmundson). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24909?vs=68657&id=68753

D24928: [TcpSlaveBase] port from KTcpSocket (deprecated) to QSslSocket

vkrause added a comment. In general I think this looks very good already! The cipher naming stuff looks very fishy though, that's not due to your changes though but coming from old KSslCipher code. I'm wondering where the ssl_cipher meta data is being consumed? If this is purely used for di

D24742: Make non-ignorable SSL errors explicit

vkrause added a comment. ping? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24742 To: vkrause Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24931: Port KSSLD internals from KSslError to QSslError

vkrause retitled this revision from "Port KSSD internals from KSslError to QSslError" to "Port KSSLD internals from KSslError to QSslError". REPOSITORY R241 KIO BRANCH next REVISION DETAIL https://phabricator.kde.org/D24931 To: vkrause, aacid Cc: kde-frameworks-devel, LeGast00n, GB_2, mi

KDE CI: Frameworks » ktexteditor » kf5-qt5 WindowsMSVCQt5.13 - Build # 94 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20WindowsMSVCQt5.13/94/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Thu, 24 Oct 2019 22:30:39 + Build duration: 15 hr and counting JUnit Tests Name: p

D24941: [kpropertiesdialog] Display item text() when the file is readonly and otherwise would display "." or ""

ngraham added a comment. Do we know why `d->oldname` is empty or `.` in the first place? Feels like maybe this should be fixed there. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24941 To: meven, ngraham, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michael

D24476: [KPropertiesDialog] Only show volume-related info for volumes

ngraham added a subscriber: Zren. ngraham added a comment. In D24476#553860 , @broulik wrote: > > Don't you already have the free space information in the status bar though? > > Isn't that supposed to be removed by default in that ominous Dol

D24476: [KPropertiesDialog] Only show volume-related info for volumes

broulik added a comment. > Don't you already have the free space information in the status bar though? Isn't that supposed to be removed by default in that ominous Dolphin redesign? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24476 To: ngraham, #vdg, #frameworks

D24476: [KPropertiesDialog] Only show volume-related info for volumes

ngraham added a comment. Ping. #VDG opinions? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24476 To: ngraham, #vdg, #frameworks, broulik Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 158 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/158/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 25 Oct 2019 11:14:55 + Build duration: 7 min 11 sec and counting JUnit Tests Name: projectro

D24827: auto-enable KIO_ASSERT_SLAVE_STATES also for from-git builds

This revision was automatically updated to reflect the committed changes. Closed by commit R241:de3ca85f058e: auto-enable KIO_ASSERT_SLAVE_STATES also for from-git builds (authored by sitter). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24827?vs=68526&id=68741

D24908: fix default shortcut detection

This revision was automatically updated to reflect the committed changes. Closed by commit R263:e9387f561fa2: fix default shortcut detection (authored by sitter). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D24908?vs=68652&id=68740#toc REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDA

D24887: WIP slave command behavior assertion system

sitter added a comment. About the list of unexpected signals in forCommand(): It looks that at least http, ftp, and sftp do call connected() as part of various commands. e.g. all do it during get(). Does that make sense? connected() refers to openConnection() in its documentation, and

D24941: [kpropertiesdialog] Display item text() when the file is readonly and otherwise would display "." or ""

meven updated this revision to Diff 68736. meven added a comment. Avoid unncessary change REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24941?vs=68735&id=68736 BRANCH arcpatch-D24941 REVISION DETAIL https://phabricator.kde.org/D24941 AFFECTED FILES sr

D24941: [kpropertiesdialog] Display item text() when the file is readonly and otherwise would display "." or ""

meven edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24941 To: meven, ngraham, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24941: [kpropertiesdialog] Display item text() when the file is readonly and otherwise would display "." or ""

meven created this revision. meven added reviewers: ngraham, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D24941 AFFEC