D24716: Fix memory leak of KQuickAddons::ConfigModule objects

ervin requested changes to this revision. ervin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kcmoduleloader.cpp:101 > } else { > KQuickAddons::ConfigModule *cm = > factory->create(nullptr, args2); > if (!cm

D24600: Use ECMGenerateExportHeader to manage deprecated API better

mlaurent accepted this revision. This revision is now accepted and ready to land. REPOSITORY R275 KItemModels BRANCH useECMGenerateExportHeader REVISION DETAIL https://phabricator.kde.org/D24600 To: kossebau, #frameworks, dfaure, mlaurent Cc: kde-frameworks-devel, LeGast00n, GB_2, michael

D24650: Use ECMGenerateExportHeader to manage deprecated API better

mlaurent accepted this revision. mlaurent added a comment. This revision is now accepted and ready to land. Seems ok for me REPOSITORY R235 Attica BRANCH useECMGenerateExportHeader REVISION DETAIL https://phabricator.kde.org/D24650 To: kossebau, #frameworks, gladhorn, leinir, mlaurent

D24611: Use ECMGenerateExportHeader to manage deprecated API better

mlaurent accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH useECMGenerateExportHeader REVISION DETAIL https://phabricator.kde.org/D24611 To: kossebau, #frameworks, bruns, mlaurent Cc: kde-frameworks-devel, #baloo, hurikhan77, lot

D24495: Use ECMGenerateExportHeader to manage deprecated API better

mlaurent accepted this revision. This revision is now accepted and ready to land. REPOSITORY R284 KCompletion BRANCH useECMGenerateExportHeader REVISION DETAIL https://phabricator.kde.org/D24495 To: kossebau, #frameworks, mlaurent Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngrah

D24707: Use ECMGenerateExportHeader to manage deprecated API better

mlaurent accepted this revision. This revision is now accepted and ready to land. REPOSITORY R269 BluezQt BRANCH useECMGenerateExportHeader REVISION DETAIL https://phabricator.kde.org/D24707 To: kossebau, #frameworks, drosca, mlaurent Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, n

D24710: Use ECMGenerateExportHeader to manage deprecated API better

mlaurent accepted this revision. This revision is now accepted and ready to land. REPOSITORY R301 KEmoticons BRANCH useECMGenerateExportHeader REVISION DETAIL https://phabricator.kde.org/D24710 To: kossebau, #frameworks, mlaurent Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraha

D24599: Use ECMGenerateExportHeader to manage deprecated API better

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R270:76460e89854f: Use ECMGenerateExportHeader to manage deprecated API better (authored by kossebau). REPOSITORY R270 KC

D24643: Use ECMGenerateExportHeader to manage deprecated API better

This revision was automatically updated to reflect the committed changes. Closed by commit R268:b6a1e260c42a: Use ECMGenerateExportHeader to manage deprecated API better (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D24643?vs=67925&id=68104#toc REPOSITORY R268 K

D23927: Improve naming of KTitleWidget icon methods

kossebau added a comment. In D23927#548607 , @kossebau wrote: > Any chance you could pik this up and complete? Thing is, the deprecated API is also still used internally,so anything but deprecated. Actually the new API calls the "deprecated" one

D23927: Improve naming of KTitleWidget icon methods

kossebau added a comment. Any chance you could pik this up and complete? Thing is, the deprecated API is also still used internally,so anything but deprecated. Actually the new API calls the "deprecated" one. I just tried to adapt the code to the new deprecation macros (forgot that this

D24716: Fix memory leak of KQuickAddons::ConfigModule objects

davidedmundson updated this revision to Diff 68096. davidedmundson added a comment. Slightly refactor so the teardown order deletes the QML content and then deletes the parent window which is a bit more logical. Now kscreen KCM doesn't crash even with the extra prompts REPOSITORY R29

D24665: Use ECMGenerateExportHeader to manage deprecated API better

This revision was automatically updated to reflect the committed changes. Closed by commit R243:31f044e50811: Use ECMGenerateExportHeader to manage deprecated API better (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D24665?vs=67980&id=68095#toc REPOSITORY R243 K

D24495: Use ECMGenerateExportHeader to manage deprecated API better

kossebau updated this revision to Diff 68093. kossebau added a comment. add some missed deprecations REPOSITORY R284 KCompletion CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24495?vs=67734&id=68093 BRANCH useECMGenerateExportHeader REVISION DETAIL https://phabricator.kde.o

D24675: Deprecate the KTcpSocket-based variant of SslUi::askIgnoreSslErrors

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Looks good. Can't use the new deprecation syntax until D24684 is in. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.o

D24716: Fix memory leak of KQuickAddons::ConfigModule objects

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY When we create a KQuickAddons::ConfigModule in the factory we di

D24568: Provide clang-format target with a KDE Frameworks style file

cullmann added a comment. In D24568#548490 , @dfaure wrote: > Do we want these, found in https://code.qt.io/cgit/qt/qt5.git/tree/_clang-format? > > # We use template< without space. > SpaceAfterTemplateKeyword: false > > # macro

D24568: Provide clang-format target with a KDE Frameworks style file

cullmann updated this revision to Diff 68091. cullmann marked 4 inline comments as done. cullmann added a comment. - fix coding style issue, we don't want indented case labels - add initial docs - adjust style - just tell the user it will not work REPOSITORY R240 Extra CMake Modules C

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.13 - Build # 40 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/40/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 16 Oct 2019 21:04:52 + Build duration: 11 min and counting JUnit Tests Name: projectroot

D24665: Use ECMGenerateExportHeader to manage deprecated API better

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D24665 To: kossebau, #frameworks, dfaure Cc: bcooksley, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > jobuidelegateextension.h:279 > + */ > +virtual bool askPrivilegeOperationConfirmation(const QString > &warningCaption, > +

D24598: Update elisa icon

ngraham added a comment. Let's get this in! REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24598 To: astippich, #vdg, ngraham, mgallien, trickyricky26 Cc: trickyricky26, GB_2, kde-frameworks-devel, stuartm, daerny, mfraser, mnesbitt, LeGast00n, carneirogustavo

D24598: Update elisa icon

ngraham accepted this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24598 To: astippich, #vdg, ngraham, mgallien, trickyricky26 Cc: trickyricky26, GB_2, kde-frameworks-devel, stuartm, daerny, mfraser, mnesbitt, LeGast00n, carneirogustavo, jguidon, ctaka

KDE CI: Frameworks » kcalendarcore » kf5-qt5 FreeBSDQt5.13 - Build # 15 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20FreeBSDQt5.13/15/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 16 Oct 2019 20:14:27 + Build duration: 39 min and counting JUnit Tests Name: projec

D24598: Update elisa icon

mgallien accepted this revision. mgallien added a comment. Thanks REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24598 To: astippich, #vdg, ngraham, mgallien, trickyricky26 Cc: trickyricky26, GB_2, kde-frameworks-devel, stuartm, daerny, mfraser, mnesbitt, LeGa

D24568: Provide clang-format target with a KDE Frameworks style file

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. I like the idea very much. INLINE COMMENTS > KDEClangFormat.cmake:76 > +else() > +message(STATUS "Could not set up the clang-format target as the > clang-format execu

D24568: Provide clang-format target with a KDE Frameworks style file

dfaure added a comment. Do we want these, found in https://code.qt.io/cgit/qt/qt5.git/tree/_clang-format? # We use template< without space. SpaceAfterTemplateKeyword: false # macros for which the opening brace stays attached. ForEachMacros: [ foreach, Q_FOREACH, BOOST

D24651: Use ECMGenerateExportHeader to manage deprecated API better

This revision was automatically updated to reflect the committed changes. Closed by commit R279:04dd50d62842: Use ECMGenerateExportHeader to manage deprecated API better (authored by kossebau). REPOSITORY R279 ThreadWeaver CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24651?vs=67937

D24682: Use ECMGenerateExportHeader to manage deprecated API better

kossebau closed this revision. REVISION DETAIL https://phabricator.kde.org/D24682 To: kossebau, #frameworks, vkrause

D24695: Add a KF6 TODO to make KXMLGUIClient generic over a state enum

dfaure added a comment. OK, next step is to consider writing that separate class now rather than hoping to dump that task on a random future reader of the TODO ;-) At least, starting it is the best way to find out how feasible it is. REPOSITORY R263 KXmlGui REVISION DETAIL https://phab

D24710: Use ECMGenerateExportHeader to manage deprecated API better

kossebau created this revision. kossebau added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Allows - projects linking to KEmoticons to hide deprecated API up to a giv

D24537: Icons for windy weather

This revision was automatically updated to reflect the committed changes. Closed by commit R266:ed5d288ae908: Icons for windy weather (authored by cblack). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24537?vs=68079&id=68080 REVISION DETAIL https://p

D24537: Icons for windy weather

cblack updated this revision to Diff 68079. cblack added a comment. Run icons through SVG cleaner REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24537?vs=68009&id=68079 BRANCH windy-weather-icons (branched from master) REVISION DETAIL https://pha

D24537: Icons for windy weather

cblack edited the test plan for this revision. REPOSITORY R266 Breeze Icons BRANCH windy-weather-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D24537 To: cblack, #vdg, ndavis, ngraham Cc: trickyricky26, GB_2, vkrause, ndavis, kossebau, ngraham, kde-frameworks-d

D24537: Icons for windy weather

trickyricky26 added a comment. With the blue color, I like these icons. Please remember to update images in the test plan when you make changes such as this color change, they're very helpful for judging things e.g. on a phone. REPOSITORY R266 Breeze Icons BRANCH windy-weather-icons (br

D24707: Use ECMGenerateExportHeader to manage deprecated API better

kossebau created this revision. kossebau added reviewers: Frameworks, drosca. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Allows - projects linking to BluezQt to hide deprecated API up to a

D24641: Collect more information from version control systems

thomasfischer updated this revision to Diff 68072. thomasfischer added a comment. I rewrote the patch to address the comments: 1. Setting `ECM_SOURCE_UNDER_VERSION_CONTROL` has been refactored to set variable `ECM_SOURCE_VERSION_CONTROL_WHICH` as well to determine which of three known VC

D24598: Update elisa icon

ngraham added a comment. In D24598#548335 , @astippich wrote: > This is with the tape window moved up 1px > F7608368: elisaBigNew2.png > When I look at images of real cassettes, they are not centered,

D24598: Update elisa icon

astippich added a comment. This is with the tape window moved up 1px F7608368: elisaBigNew2.png When I look at images of real cassettes, they are not centered, hence why I only did this slight adjustment. If everyone is okay with this, I will update

D24695: Add a KF6 TODO to make KXMLGUIClient generic over a state enum

meven updated this revision to Diff 68067. meven added a comment. Update TODO REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24695?vs=68043&id=68067 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24695 AFFECTED FILES src/kxmlguiclient.h

D24695: Add a KF6 TODO to make KXMLGUIClient generic over a state enum

meven added a comment. In D24695#548248 , @dfaure wrote: > In my experience 90 % of the users of this class don't care for the state feature, so I would rather move it to a separate class. > > Also this class is used everywhere, so the change

D24537: Icons for windy weather

ndavis added a comment. Oh yes, that would be a good thing. Any of these will be fine: https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips#SVG_optimization REPOSITORY R266 Breeze Icons BRANCH windy-weather-icons (branched from master) REVISION DETAIL https://phabricator

D24667: [KStatusNotifierItem] Allow left click when menu is null

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D24667 To: kmaterka, davidedmundson, broulik, nicolasfella, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_

D24703: Port (most of) KSslInfoDialog from KSslError to QSslError

vkrause added a task: T11620: Port from KSslError to QSslError. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24703 To: vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24667: [KStatusNotifierItem] Allow left click when menu is null

davidedmundson added a comment. Good rundown of the options. > remove SystemTray support from KdePlatformTheme It's not trivial. There's no way to access the relevant Qt classes. I should revisit the patch that allowed that. Our hopeful longterm plans for KF6 are to kill KStatus

D24703: Port (most of) KSslInfoDialog from KSslError to QSslError

vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D24703 AFFECTED FILES src/core/ksslerror_p.h src

D24700: Use ECMGenerateExportHeader to manage deprecated API better

kossebau created this revision. kossebau added reviewers: Frameworks, ilic. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Allows - projects linking to KI18n to hide deprecated API up to a giv

D24695: Add a KF6 TODO to make KXMLGUIClient generic over a state enum

dfaure added a comment. In my experience 90 % of the users of this class don't care for the state feature, so I would rather move it to a separate class. Also this class is used everywhere, so the change would have massive repercussions, while most users (both subclasses and code using a

D24652: Add folder-recent, extend hand of clock in folder-temp

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH recent-places (branched from master) REVISION DETAIL https://phabricator.kde.org/D24652 To: ndavis, #vdg, ngraham Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngrah

D24667: [KStatusNotifierItem] Allow left click when menu is null

broulik added a comment. > bool takeOwnership = true); If only Qt/we used modern C++ features to communicate object ownership :) REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D24667 To: kmaterka, davidedmundson, broulik, nicolasfella, #frameworks Cc: kde

D24667: [KStatusNotifierItem] Allow left click when menu is null

ngraham edited the summary of this revision. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D24667 To: kmaterka, davidedmundson, broulik, nicolasfella, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24697: Expose isImmutable to introspection (e.g. QML)

This revision was automatically updated to reflect the committed changes. Closed by commit R237:3f68be12f87e: Expose isImmutable to introspection (e.g. QML) (authored by ervin). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24697?vs=68046&id=68052 REVISION D

D24697: Expose isImmutable to introspection (e.g. QML)

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D24697 To: ervin, #plasma, #frameworks, mart, dfaure, broulik Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24697: Expose isImmutable to introspection (e.g. QML)

ervin created this revision. ervin added reviewers: Plasma, Frameworks, mart, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ervin requested review of this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D24697 AFFEC

D24663: Use ECMGenerateExportHeader to manage deprecated API better

kossebau added inline comments. INLINE COMMENTS > zzag wrote in plasmawindowmanagement_interface.cpp:741 > Hmm, PlasmaWindowInterface::setVirtualDesktop is wrapped in > KWAYLANDSERVER_ENABLE_DEPRECATED_SINCE in the header file. > > Is there a reason not to use KWAYLANDSERVER_BUILD_DEPRECATED_SI

D24537: Icons for windy weather

GB_2 added a comment. Can you clean the SVGs a bit? REPOSITORY R266 Breeze Icons BRANCH windy-weather-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D24537 To: cblack, #vdg, ndavis, ngraham Cc: GB_2, vkrause, ndavis, kossebau, ngraham, kde-frameworks-devel, L

D24537: Icons for windy weather

ngraham accepted this revision. ngraham added a comment. Shipit! REPOSITORY R266 Breeze Icons BRANCH windy-weather-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D24537 To: cblack, #vdg, ndavis, ngraham Cc: vkrause, ndavis, kossebau, ngraham, kde-frameworks-d

D24684: Use ECMGenerateExportHeader to manage deprecated API better

kossebau edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24684 To: kossebau, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D18299: ComboBox: fix default delegate

broulik added a comment. I checked Qt source code and Qt indeed should handle this on its own, it also works fine hwere without the code. Worse, the explicit assignment from QML breaks any binding set on `currentIndex`. In the handler that's called when the delegate model creates a delega

D24695: Add a KF6 TODO to make KXMLGUIClient generic over a state enum

meven added a comment. This is just to make sure this TODO makes sense and is consensual. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D24695 To: meven, #frameworks, kossebau, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24695: Add a KF6 TODO to make KXMLGUIClient generic over a state enum

meven created this revision. meven added reviewers: Frameworks, kossebau, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY To avoid string typing, replace usage of string with a proper enum defi

D24672: GIT_SILENT Run uncrustify-kf5 on the whole tree

ahmadsamir abandoned this revision. REPOSITORY R374 KolourPaint REVISION DETAIL https://phabricator.kde.org/D24672 To: ahmadsamir, kde-frameworks-devel, mkoller Cc: cullmann, ognarb, kde-frameworks-devel

D24689: Add support for SAE authentication used by WPA3

jgrulich added a dependent revision: D24691: Add support for WPA3. REPOSITORY R282 NetworkManagerQt REVISION DETAIL https://phabricator.kde.org/D24689 To: jgrulich, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24667: [KStatusNotifierItem] Allow left click when menu is null

kmaterka added a comment. I think the best would be to add additional parameter to KSNI. Change from: void KStatusNotifierItem::setContextMenu(QMenu *menu); to something like this: void KStatusNotifierItem::setContextMenu(QMenu *menu, bool takeOwnership = true); Then, a

D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category

guoyunhe added a comment. `kf5-network.directory` has been added to `plasma-workspace`. The trouble is still here: if we land this patch and released new frameworks, it won't work with older plasma workspace (like 5.17.0, 5.16.x). REPOSITORY R309 KService REVISION DETAIL https://pha

D24689: Add support for SAE authentication used by WPA3

jgrulich updated this revision to Diff 68029. jgrulich added a comment. Compare against lowercase value REPOSITORY R282 NetworkManagerQt CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24689?vs=68028&id=68029 BRANCH wpa3 REVISION DETAIL https://phabricator.kde.org/D24689 AFF

D24689: Add support for SAE authentication used by WPA3

jgrulich added a reviewer: Frameworks. REPOSITORY R282 NetworkManagerQt REVISION DETAIL https://phabricator.kde.org/D24689 To: jgrulich, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24689: Add support for SAE authentication used by WPA3

jgrulich created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. jgrulich requested review of this revision. REPOSITORY R282 NetworkManagerQt BRANCH wpa3 REVISION DETAIL https://phabricator.kde.org/D24689 AFFECTED FILES src/accesspoint

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 153 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/153/ Project: kf5-qt5 SUSEQt5.13 Date of build: Wed, 16 Oct 2019 08:39:36 + Build duration: 16 min and counting BUILD ARTIFACTS acc/KF5KIO-5.64.0.xmllog

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 140 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/140/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 16 Oct 2019 08:39:36 + Build duration: 12 min and counting JUnit Tests Name: projectroot Fai

D24667: [KStatusNotifierItem] Allow left click when menu is null

kmaterka added a reviewer: Frameworks. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D24667 To: kmaterka, davidedmundson, broulik, nicolasfella, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24667: [KStatusNotifierItem] Allow left click when menu is null

kmaterka retitled this revision from "Activate when both associatedWidget and menu are null" to "[KStatusNotifierItem] Allow left click when menu is null". REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D24667 To: kmaterka, davidedmundson, broulik, nicolasfella C

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

This revision was automatically updated to reflect the committed changes. Closed by commit R241:591cc2a16e3e: Treat "application/x-ms-dos-executable" as executable on all platforms (authored by Guo Yunhe ). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.

D24663: Use ECMGenerateExportHeader to manage deprecated API better

zzag edited reviewers, added: KWin; removed: Plasma. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D24663 To: kossebau, #kwin, #plasma Cc: zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24663: Use ECMGenerateExportHeader to manage deprecated API better

zzag added inline comments. INLINE COMMENTS > plasmawindowmanagement_interface.cpp:741 > > -#ifndef KWAYLANDSERVER_NO_DEPRECATED > void PlasmaWindowInterface::setVirtualDesktop(quint32 desktop) Hmm, PlasmaWindowInterface::setVirtualDesktop is wrapped in KWAYLANDSERVER_ENABLE_DEPRECATED_SINCE

D24684: Use ECMGenerateExportHeader to manage deprecated API better

dfaure added a comment. The commit log talks about KCalendarCore instead of KIO :) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24684 To: kossebau, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24686: Replace usage of deprecated SlaveBase::config() by SlaveBase::configValue

meven created this revision. meven added a reviewer: dfaure. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY With D23523 and D24582

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 139 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/139/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 16 Oct 2019 07:04:32 + Build duration: 40 min and counting JUnit Tests Name: projectroot Fai

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 152 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/152/ Project: kf5-qt5 SUSEQt5.13 Date of build: Wed, 16 Oct 2019 07:07:14 + Build duration: 32 min and counting BUILD ARTIFACTS acc/KF5KIO-5.64.0.xmllo

D24684: Use ECMGenerateExportHeader to manage deprecated API better

kossebau updated this revision to Diff 68021. kossebau added a comment. update to latest master REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24684?vs=68018&id=68021 BRANCH useECMGenerateExportHeader REVISION DETAIL https://phabricator.kde.org/D24684 AF

D24685: Replace usage of SlaveBase::config()->readEntry by SlaveBase::configValue

meven created this revision. meven added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY Followup after D24582 There are only 5 usage of Sl

D24684: Use ECMGenerateExportHeader to manage deprecated API better

kossebau added a comment. No support for EXCLUDE_DEPRECATED_BEFORE_AND_AT here as well, that needs another round of work. Thus the removal of all the KIOWIDGETS_NO_DEPRECATED from the source files, no *_BUILD_DEPRECATED_SINCE there to properly replace them for now. So patch solely conce

D24684: Use ECMGenerateExportHeader to manage deprecated API better

kossebau created this revision. kossebau added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Allows - projects linking to KCalendarCore to hide deprecated API u

D24582: Replace usage of SlaveBase::config() by SlaveBase::mapConfig()

This revision was automatically updated to reflect the committed changes. Closed by commit R241:0911763b8f19: Replace usage of SlaveBase::config() by SlaveBase::mapConfig() (authored by meven). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24582?vs=67943&id=68017