D23789: Add ECMGenerateExportHeaders, for improved handling of deprecated API

dfaure added a comment. In D23789#541134 , @kossebau wrote: > In D23789#540033 , @dfaure wrote: > > > I found confirmation in cmake's Tests/RunCMake/GenerateExportHeader/reference/ > > > Not su

D24372: Compile without deprecated foreach

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > job.cpp:181 > // kill all subjobs, without triggering their result slot > -Q_FOREACH (KJob *it, subjobs()) { > -it->kill(KJob::Quietly); > +

D24477: [PATCH] Add PATH/LD_LIBRARY_PATH to qrcAlias invocation

masonm added a reviewer: VDG. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24477 To: masonm, #vdg Cc: kde-frameworks-devel, #vdg, LeGast00n, GB_2, michaelh, ngraham, bruns

D24245: Add support for passing Unix file descriptors

aacid added a comment. ok, fair enough. Am i correct in understanding this breaks the wire-protocol for the dbus messages? Are we sure that's fine? REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D24245 To: volkov, fvogt, chinmoyr, cfeck, #frameworks, securit

D24395: Add some std::move in setter functions

This revision was automatically updated to reflect the committed changes. Closed by commit R235:1c8d9beb720f: Add some std::move in setter functions (authored by aacid). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D24395?vs=67272&id=67469#toc REPOSITORY R235 Attica CHANGES SINCE LAS

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

guoyunhe edited the summary of this revision. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D24463 To: guoyunhe, #frameworks, ngraham, dfaure Cc: dfaure, ngraham, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

guoyunhe retitled this revision from "WIP: Treat "application/x-ms-dos-executable" as executable on all platforms" to "Treat "application/x-ms-dos-executable" as executable on all platforms". guoyunhe edited the summary of this revision. REPOSITORY R241 KIO BRANCH master REVISION DETAIL

D24442: ensure winId() not called on non-native widgets

dfaure added a comment. Done, this is in the v5.63.0-rc3 tag now. REPOSITORY R252 Framework Integration REVISION DETAIL https://phabricator.kde.org/D24442 To: cullmann, #frameworks, dfaure Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24294: Port KSslCertificateManager to QSslError

aacid accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D24294 To: vkrause, dfaure, aacid Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24463: WIP: Treat "application/x-ms-dos-executable" as executable on all platforms

guoyunhe added a comment. It is now working. The condition is so complex. Please help test this patch! F7541884: image.png REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D24463 To: guoyunhe, #frameworks, ngraha

D24463: WIP: Treat "application/x-ms-dos-executable" as executable on all platforms

guoyunhe updated this revision to Diff 67458. guoyunhe added a comment. Fix *.exe execution condition REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24463?vs=67444&id=67458 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24463 AFFECTED FILES

D24476: [KPropertiesDialog] Only show volume-related info for volumes

ngraham added a comment. In D24476#543297 , @broulik wrote: > Perhaps, but right clicking on my HOME will then give me no information as it's not a separate mount. Don't you already have the free space information in the status bar though

D24476: [KPropertiesDialog] Only show volume-related info for volumes

broulik added a comment. Perhaps, but right clicking on my HOME will then give me no information as it's not a separate mount. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24476 To: ngraham, #vdg, #frameworks, broulik Cc: kde-frameworks-devel, LeGast00n, GB_2, michae

D24476: [KPropertiesDialog] Only show volume-related info for volumes

ngraham added a comment. It's not very accurate though. The free space is a property of the underlying volume, not the folder you happen to be looking at. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24476 To: ngraham, #vdg, #frameworks, broulik Cc: kde-frameworks-de

D24477: [PATCH] Add PATH/LD_LIBRARY_PATH to qrcAlias invocation

masonm created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. masonm requested review of this revision. REVISION SUMMARY Build fails to generate binary resource (breeze-icons.rcc) by default. The proposed patch fixes this by adding the QtCore

D24476: [KPropertiesDialog] Only show volume-related info for volumes

broulik added a comment. Having the free space info bar on folders was always very useful imho REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24476 To: ngraham, #vdg, #frameworks, broulik Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24476: [KPropertiesDialog] Only show volume-related info for volumes

ngraham created this revision. ngraham added reviewers: VDG, Frameworks, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY Right now volume-related information is shown on the General page for

D24463: WIP: Treat "application/x-ms-dos-executable" as executable on all platforms

guoyunhe retitled this revision from "Treat "application/x-ms-dos-executable" as executable on all platforms" to "WIP: Treat "application/x-ms-dos-executable" as executable on all platforms". guoyunhe edited the summary of this revision. REPOSITORY R241 KIO BRANCH master REVISION DETAIL

D24439: Fix test kfileplacesmodeltest after D7446

meven added a comment. Fixed as of https://build.kde.org/job/Frameworks/view/Platform%20-%20SUSEQt5.12/job/kio/job/kf5-qt5%20SUSEQt5.12/250/ REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24439 To: meven, dfaure, ngraham Cc: kde-frameworks-devel, LeGast00n, GB_2, micha

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

guoyunhe updated this revision to Diff 67444. guoyunhe added a comment. "openAsExecute" parameter for ExecutableFileOpenDialog REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24463?vs=67424&id=67444 BRANCH master REVISION DETAIL https://phabricator.kde.org

D23411: Fix crash in writer collection and cleanup

This revision was automatically updated to reflect the committed changes. Closed by commit R286:494b068af264: Fix crash in writer collection and cleanup (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23411?vs=67376&id=67443 REVI

D24442: ensure winId() not called on non-native widgets

This revision was automatically updated to reflect the committed changes. Closed by commit R252:93c19fbfa125: ensure winId() not called on non-native widgets (authored by cullmann). REPOSITORY R252 Framework Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24442?vs=67379&id

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

ahmadsamir added a reviewer: dfaure. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D24463 To: guoyunhe, #frameworks, ngraham, dfaure Cc: dfaure, ngraham, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24294: Port KSslCertificateManager to QSslError

vkrause added a comment. In D24294#543158 , @apol wrote: > I may be missing some context but this doesn't seem to be porting anything only adding a nonIgnorableErrors function that ignores whatever it gets. The context is the (still growi

D24419: Implement KSslCertificateRule with QSslError instead of KSslError

vkrause added a task: T11620: Port from KSslError to QSslError. REPOSITORY R241 KIO BRANCH next REVISION DETAIL https://phabricator.kde.org/D24419 To: vkrause, dfaure, aacid Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24294: Port KSslCertificateManager to QSslError

apol added a comment. I may be missing some context but this doesn't seem to be porting anything only adding a nonIgnorableErrors function that ignores whatever it gets. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24294 To: vkrause, dfaure Cc: apol, kde-frameworks-d

D24294: Port KSslCertificateManager to QSslError

vkrause added a comment. Ping? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24294 To: vkrause, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24443: Add a plugin system

vkrause added subscribers: dvratil, vkrause. vkrause added a comment. Thanks for working on this! Some general thoughts: - Is KDeclarative is the right place for this? It's a module on the way out in KF6, it is hard to build for Android due to its dependency chain (which isn't even neede

Re: Call for action: applying version-based deprecation macros for KDE Frameworks API

On Sunday, 6 October 2019 13:14:50 CEST Friedrich W. H. Kossebau wrote: > PROTOTYPE BECOMING PRODUCTION VERSION > > So far feedback has been positive (thanks especially David, but also > Christian & Albert for comments). Could have been more feedback, but I > project the silence onto "seems fine w

D24442: ensure winId() not called on non-native widgets

cullmann added a comment. It would be great to have that in 5.63, or I am too late? REPOSITORY R252 Framework Integration BRANCH master REVISION DETAIL https://phabricator.kde.org/D24442 To: cullmann, #frameworks, dfaure Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ng

D24442: ensure winId() not called on non-native widgets

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Looks good, quite similar to https://phabricator.kde.org/D23808 REPOSITORY R252 Framework Integration BRANCH master REVISION DETAIL https://phabricator.kde.org/D24442 To: cullmann,

D24442: ensure winId() not called on non-native widgets

cullmann added a comment. If nobody objects will push that later, without any window on secondary screen is garbage after palette change. REPOSITORY R252 Framework Integration REVISION DETAIL https://phabricator.kde.org/D24442 To: cullmann, #frameworks, dfaure Cc: broulik, kde-framework

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

guoyunhe added a comment. I just realized that this patch might be unfinished. In the pop up, you usually have "Open", "Execute" and "Cancel". But for *.exe, "Open" is actually to be executed by Wine? "Execute" will do nothing because it isn't a native executable for Linux/BSD. REPOSITORY

D24431: Restore cursor thumbnailer

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Nice. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D24431 To: broulik, #plasma, fredrik, ngraham Cc: ngraham, kde-frameworks-devel, kfm-devel, iasensio, fpr

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

ngraham accepted this revision. ngraham added a subscriber: dfaure. ngraham added a comment. This revision is now accepted and ready to land. I suppose that's true. Would be nice to also do that as a follow-up patch. Shipit! @dfaure given the security implications here, maybe we shoul

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

guoyunhe added a comment. In D24463#543070 , @ngraham wrote: > Maybe can we check to see if WINE is installed or if there's a handler for `application/x-ms-dos-executable`? Otherwise if you don't have WINE installed, won't you see a dialog that

D24464: i18n: Add ellipsis to action items (X-Purpose-ActionDisplay)

This revision was automatically updated to reflect the committed changes. Closed by commit R495:39b92febeec5: i18n: Add ellipsis to action items (X-Purpose-ActionDisplay) (authored by aspotashev). REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24464?vs

D24453: [RFC] Unify style of new Kirigami.ListSectionHeader and CategoryDrawer

ngraham added a comment. In D24453#543069 , @davidre wrote: > I could set `categorySpacing` in `KCategorizedView::Private::Private` to 0. F7538956: Screenshot_20191007_163458.png > But the difference is t

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

ngraham added a comment. Maybe can we check to see if WINE is installed or if there's a handler for `application/x-ms-dos-executable`? Otherwise if you don't have WINE installed, won't you see a dialog that gives you the option to execute it when that doesn't work? REPOSITORY R241 KIO RE

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24463 To: guoyunhe, #frameworks Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24453: [RFC] Unify style of new Kirigami.ListSectionHeader and CategoryDrawer

davidre added a comment. I could set `categorySpacing` in `KCategorizedView::Private::Private` to 0. F7538956: Screenshot_20191007_163458.png But the difference is that in widgets the scrollbar doesn't overlap the contents. REPOSITORY R276 KItemView

D24464: i18n: Add ellipsis to action items (X-Purpose-ActionDisplay)

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R495 Purpose Library BRANCH master REVISION DETAIL https://phabricator.kde.org/D24464 To: aspotashev, apol, nicolasfella, ngraham Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24453: [RFC] Unify style of new Kirigami.ListSectionHeader and CategoryDrawer

ngraham added a comment. Might also be nice to add a comment somewhere in here reminding people to adjust the Kirigami BasicListHeader accordingly when this is changed (and vice versa). REPOSITORY R276 KItemViews REVISION DETAIL https://phabricator.kde.org/D24453 To: davidre, #framewor

D24453: [RFC] Unify style of new Kirigami.ListSectionHeader and CategoryDrawer

ngraham added a task: T10384: Unify styles for lists and their buttons. REPOSITORY R276 KItemViews REVISION DETAIL https://phabricator.kde.org/D24453 To: davidre, #frameworks, #vdg Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24453: [RFC] Unify style of new Kirigami.ListSectionHeader and CategoryDrawer

ngraham added a comment. Nice. Is there any way to make it touch the edges of its parent view rather than having those small margins? REPOSITORY R276 KItemViews REVISION DETAIL https://phabricator.kde.org/D24453 To: davidre, #frameworks, #vdg Cc: ngraham, kde-frameworks-devel, LeGast00n

D24402: [PlasmaComponents3] Fix checkable toolbutton background

This revision was automatically updated to reflect the committed changes. Closed by commit R242:949a26d3fa0c: [PlasmaComponents3] Fix checkable toolbutton background (authored by ngraham). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24402

D24468: Use ECMGenerateExportHeader to manage deprecated API better

kossebau created this revision. kossebau added reviewers: Frameworks, cfeck. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Allows - projects linking to KWidgetsAddons to hide deprecated API u

D24467: Use ECMGenerateExportHeader to manage deprecated API better

kossebau created this revision. kossebau added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Allows - projects linking to KParts to hide deprecated API up to a

D24466: Use ECMGenerateExportHeader to manage deprecated API better

kossebau created this revision. kossebau added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Allows - projects linking to KXmlGui to hide deprecated API up to a

D24402: [PlasmaComponents3] Fix checkable toolbutton background

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH fix-checkable-pc3-toolbutton-background (branched from master) REVISION DETAIL https://phabricator.kde.org/D24402 To: ngraham, #plasma, mart Cc: kde-frameworks-d

D24465: Use ECMGenerateExportHeader to manage deprecated API better

kossebau created this revision. kossebau added reviewers: Frameworks, KWin, dfaure, zzag. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Allows - projects linking to KWindowSystem to hide depr

D24464: i18n: Add ellipsis to action items (X-Purpose-ActionDisplay)

aspotashev created this revision. aspotashev added reviewers: apol, nicolasfella. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aspotashev requested review of this revision. TEST PLAN none REPOSITORY R495 Purpose Library BRANCH master REVISION DETAIL

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

broulik added a comment. +1 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24463 To: guoyunhe, #frameworks Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

guoyunhe added a reviewer: Frameworks. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24463 To: guoyunhe, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

guoyunhe created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. guoyunhe requested review of this revision. REVISION SUMMARY Because of Wine, *.exe can be executed in almost all desktop platforms. BUG: 412694 REPOSITORY R241 KIO BRANCH

D24443: Add a plugin system

davidedmundson added a comment. Plan makes sense. INLINE COMMENTS > calendarentry.h:35 > +Q_PROPERTY(CalendarType type READ type CONSTANT) > +Q_PROPERTY(KCalendarCore::Calendar::Ptr calendar READ calendar CONSTANT) > +public: If the intention is for QML to be able to get and access t

D24436: Add applications-network icon for renaming Internet category to Network

This revision was automatically updated to reflect the committed changes. Closed by commit R266:87d712c7a0e2: Add applications-network icon for renaming Internet category to Network (authored by Guo Yunhe ). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://pha

D24453: [RFC] Unify style of new Kirigami.ListSectionHeader and CategoryDrawer

davidre edited the summary of this revision. davidre edited the test plan for this revision. davidre added reviewers: Frameworks, VDG. REPOSITORY R276 KItemViews REVISION DETAIL https://phabricator.kde.org/D24453 To: davidre, #frameworks, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, micha

D24429: [ConfigModule] Expose mainUi component status and error string

broulik added a comment. > Is the text in the window mouse-selectable? I don't think so (didn't test, just read the code) but should be trivial to add. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D24429 To: broulik, #plasma Cc: ngraham, kde-frameworks-d

D24453: [RFC] Unify style of new Kirigami.ListSectionHeader and CategoryDrawer

davidre created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidre requested review of this revision. REPOSITORY R276 KItemViews BRANCH newcategorystyle (branched from master) REVISION DETAIL https://phabricator.kde.org/D24453 AFFEC

D23682: Make use of KPluginMetaData where we can

apol added a comment. ping? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23682 To: apol, #plasma Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns