D23832: Backup on save: Support time and date string replacements

dhaumann added inline comments. INLINE COMMENTS > katedocument.cpp:2594 > +const auto backupSuffix = > KTextEditor::EditorPrivate::self()->variableExpansionManager()->expandText(config()->backupSuffix(), > nullptr); > +if (backupPrefix.contains(QDir::separator())) { > /** Shal

D23832: Backup on save: Support time and date string replacements

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Looks fine. REPOSITORY R39 KTextEditor BRANCH bug REVISION DETAIL https://phabricator.kde.org/D23832 To: dhaumann, cullmann Cc: ngraham, kwrite-devel, kde-frameworks-devel, LeGa

D23861: Port away from Qt's foreach: loop directly over pimpl member

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Looks more consistent. REPOSITORY R263 KXmlGui BRANCH portloopdirectlyoverdmembers REVISION DETAIL https://phabricator.kde.org/D23861 To: kossebau, dfaure, cullmann Cc: cullmann

D23848: Add Breeze icons for Jupyter Notebook files

ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. The spheres around the planet need better pixel alignment, particularly on the 16, 22 and 32px versions. The planet itself could have better pixel alignment too, but it's not as c

D23861: Port away from Qt's foreach: loop directly over pimpl member

kossebau created this revision. kossebau added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY The old implementation of all the KActionCollection methods was a bit inconsisten

D23855: Avoid installing log categorie file to KDE_INSTALL_CONFDIR

This revision was automatically updated to reflect the committed changes. Closed by commit R159:31f921f65093: Avoid installing log categorie file to KDE_INSTALL_CONFDIR (authored by meven). REPOSITORY R159 KActivities Statistics CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23855?vs

D23855: Avoid installing log categorie file to KDE_INSTALL_CONFDIR

meven added a comment. Btw we have quite a few CMakeLists.txt files that would need the same attention. REPOSITORY R159 KActivities Statistics BRANCH arcpatch-D23855 REVISION DETAIL https://phabricator.kde.org/D23855 To: meven, ivan, cgiboudeaux Cc: kde-frameworks-devel, LeGast00n, G

D23842: [KCompletion] Port away from deprecated methods in Qt 5.14

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R284 KCompletion BRANCH master REVISION DETAIL https://phabricator.kde.org/D23842 To: dfaure, cfeck, dhaumann, aacid, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23813: Port away from foreach loops over arguments without calls to owner class

kossebau added a comment. Thanks for review :) INLINE COMMENTS > dfaure wrote in kkeysequencewidget.cpp:127 > This could even be `const QString seq = it.key().toString();` so that > toString() is only called once. I try (hard, there are many temptations when looking at all exisiting loop c

D23813: Port away from foreach loops over arguments without calls to owner class

This revision was automatically updated to reflect the committed changes. Closed by commit R263:02ee352df1af: Port away from foreach loops over arguments without calls to owner class (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D23813?vs=65716&id=65808#toc REPOSI

D23713: strongswan support for custom proposals

jgrulich accepted this revision. This revision is now accepted and ready to land. REVISION DETAIL https://phabricator.kde.org/D23713 To: rrichmond, fvogt, jgrulich Cc: pino, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23857: Honor global animation speed factor

broulik created this revision. broulik added reviewers: Plasma, davidedmundson. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Multiplies the animation speed by the given factor. TEST PLAN See al

D23851: Avoid sending KDirNotify::emitFilesAdded when the emptytrashjob finishes

meven retitled this revision from "Avoid sending KDirNotify::emitFilesAdded when the trash is emptied" to "Avoid sending KDirNotify::emitFilesAdded when the emptytrashjob finishes". REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23851 To: meven, broulik, ngraham Cc: kde-f

D23855: Avoid installing log categorie file to KDE_INSTALL_CONFDIR

cgiboudeaux accepted this revision. cgiboudeaux added a comment. This revision is now accepted and ready to land. Thanks REPOSITORY R159 KActivities Statistics BRANCH arcpatch-D23855 REVISION DETAIL https://phabricator.kde.org/D23855 To: meven, ivan, cgiboudeaux Cc: kde-frameworks-dev

D23855: Avoid installing log categorie file to KDE_INSTALL_CONFDIR

meven added a comment. See https://phabricator.kde.org/D22143#526980 REPOSITORY R159 KActivities Statistics REVISION DETAIL https://phabricator.kde.org/D23855 To: meven, ivan, cgiboudeaux Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23855: Avoid installing log categorie file to KDE_INSTALL_CONFDIR

meven updated this revision to Diff 65802. meven added a comment. rebase REPOSITORY R159 KActivities Statistics CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23855?vs=65801&id=65802 BRANCH arcpatch-D23855 REVISION DETAIL https://phabricator.kde.org/D23855 AFFECTED FILES

D23855: Avoid installing log categorie file to KDE_INSTALL_CONFDIR

meven created this revision. meven added reviewers: ivan, cgiboudeaux. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY Since we depend here on ECM > 5.61 we don't need to install the categorie file to

D23713: strongswan support for custom proposals

rrichmond updated this revision to Diff 65799. rrichmond added a comment. Custom proposals unchecked by default. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23713?vs=65711&id=65799 REVISION DETAIL https://phabricator.kde.org/D23713 AFFECTED FILES plasma-nm-5.15.5/vpn/strongs

D23851: Avoid sending KDirNotify::emitFilesAdded when the trash is emptied

meven created this revision. meven added reviewers: broulik, ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY D23650 added an empty trash check in trash fi

D23789: RFC: Add ECMGenerateExportHeaders, for improved handling of deprecated API

dfaure added a comment. Great work. Not really easy to grasp at first sight (because it handles BC for no-compat builds of the lib itself, which we never did before) but this is certainly quite comprehensive. Since we don't yet have any source compat to worry about for these macros (unl

D23813: Port away from foreach loops over arguments without calls to owner class

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. (Thread usage is completely unlikely in users of this code, on the containers being passed in, this is really 100% GUI code; it's up to the caller to synchronize this correctly anyway, in t

D23835: Add TabKCM

ngraham added a comment. In D23835#528756 , @onvitaik wrote: > Can I also suggest making the tabs occupy the full width of the area available (sort of like Kate)? It minimizes the unused space and keeps everything in a nice rectangle: > > F7

D23848: Add Breeze icons for Jupyter Notebook files

alexde edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23848 To: alexde, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23742: Add two special cases url recentlyused:/files and recentlyused:/folders

ngraham added inline comments. INLINE COMMENTS > meven wrote in recentlyused.cpp:98 > Should we allow the filtering through type with /files path ? > I am thinking I should change that. Sure, sounds like a neat bonus feature. REPOSITORY R320 KIO Extras BRANCH arcpatch-D23742 REVISION DETA

D23742: Add two special cases url recentlyused:/files and recentlyused:/folders

meven added inline comments. INLINE COMMENTS > recentlyused.cpp:98 > -// handles type aka mimetype > -if (urlQuery.hasQueryItem(QStringLiteral("type"))) { > -const auto typeValue = > urlQuery.queryItemValue(QStringLiteral("type")); Should we allow the filtering through type with

D23848: Add Breeze icons for Jupyter Notebook files

alexde created this revision. alexde added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. alexde requested review of this revision. REVISION SUMMARY This patch adds icons for Jupyter Notebook files. It uses the offical SVG logo. As far I

KDE CI: Frameworks » kitemviews » kf5-qt5 WindowsMSVCQt5.13 - Build # 6 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kitemviews/job/kf5-qt5%20WindowsMSVCQt5.13/6/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Tue, 10 Sep 2019 18:02:48 + Build duration: 28 min and counting JUnit Tests Name: pro

D23812: Port away from foreach loops over members without calls to owner class

This revision was automatically updated to reflect the committed changes. Closed by commit R263:c0844ac2a6d6: Port away from foreach loops over members without calls to owner class (authored by kossebau). REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23812?vs

D23420: Use solid to check if a KFileItem is located on a network mount

bruns added a comment. Solid should be quite fine. When queried for devices providing 'Solid::DeviceInterface::NetworkShare', it will only use the fstab backend, which does not block and only reparses fstab/mtab when these change. There are some unnecessary QString constructions in the f

KDE CI: Frameworks » kitemviews » kf5-qt5 FreeBSDQt5.13 - Build # 13 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kitemviews/job/kf5-qt5%20FreeBSDQt5.13/13/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 10 Sep 2019 18:02:48 + Build duration: 11 min and counting JUnit Tests Name: projectroo

KDE CI: Frameworks » kitemviews » kf5-qt5 SUSEQt5.13 - Build # 14 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kitemviews/job/kf5-qt5%20SUSEQt5.13/14/ Project: kf5-qt5 SUSEQt5.13 Date of build: Tue, 10 Sep 2019 18:02:48 + Build duration: 7 min 30 sec and counting BUILD ARTIFACTS abi-compatib

KDE CI: Frameworks » kitemviews » kf5-qt5 SUSEQt5.12 - Build # 36 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kitemviews/job/kf5-qt5%20SUSEQt5.12/36/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 10 Sep 2019 18:02:48 + Build duration: 5 min 36 sec and counting BUILD ARTIFACTS abi-compatib

KDE CI: Frameworks » kitemviews » kf5-qt5 AndroidQt5.13 - Build # 12 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kitemviews/job/kf5-qt5%20AndroidQt5.13/12/ Project: kf5-qt5 AndroidQt5.13 Date of build: Tue, 10 Sep 2019 18:02:48 + Build duration: 2 min 32 sec and counting

D23816: [KItemViews] Port to non-deprecated QWheelEvent API

dfaure added a comment. Yep, I just spotted the CI-failure emails on k-f-d and pushed a fix. It wasn't clear from the docs that this constructor was new. They forgot a \since ... REPOSITORY R276 KItemViews REVISION DETAIL https://phabricator.kde.org/D23816 To: dfaure, mlaurent Cc:

KDE CI: Frameworks » kbookmarks » kf5-qt5 WindowsMSVCQt5.13 - Build # 5 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kbookmarks/job/kf5-qt5%20WindowsMSVCQt5.13/5/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Tue, 10 Sep 2019 17:46:09 + Build duration: 10 min and counting JUnit Tests Name: pro

D23842: [KCompletion] Port away from deprecated methods in Qt 5.14

dfaure created this revision. dfaure added reviewers: cfeck, dhaumann, aacid. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY the QComboBox::activated(QString) signal being deprecated and optionally

D23812: Port away from foreach loops over members without calls to owner class

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R263 KXmlGui BRANCH portmoreforeachwithoutrecursivecalls REVISION DETAIL https://phabricator.kde.org/D23812 To: kossebau, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

Minutes from the KF6 BoF session at Akademy

We discussed the topic of KF6, to have some sort of common direction. When, what, how, etc. Raw notes at https://notes.kde.org/p/akademy2019-kf6-notes, but let me try to make this more readable here. * We created a phabricator board to manage all the tasks involved in being able to have a Qt6-b

D23816: [KItemViews] Port to non-deprecated QWheelEvent API

kossebau added a comment. Seems not okay with KDE CI though ;) -> https://build.kde.org/view/Failing/job/Frameworks/job/kitemviews/ Some 5.14 API-only method now used? REPOSITORY R276 KItemViews REVISION DETAIL https://phabricator.kde.org/D23816 To: dfaure, mlaurent Cc: kossebau, k

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.13 - Build # 24 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.13/24/ Project: kf5-qt5 SUSEQt5.13 Date of build: Tue, 10 Sep 2019 16:46:51 + Build duration: 8 min 50 sec and counting BUILD ARTIFACTS acc/KF5W

D23811: [KImageFormats] Port HDR (Radiance RGBE) image loader to Qt5

cfeck updated this revision to Diff 65784. cfeck added a comment. Add hdr to autotests REPOSITORY R287 KImageFormats CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23811?vs=65713&id=65784 REVISION DETAIL https://phabricator.kde.org/D23811 AFFECTED FILES autotests/CMakeLists.

D23839: Port away from Qt's foreach

This revision was automatically updated to reflect the committed changes. Closed by commit R278:1081a6b284ba: Port away from Qt's foreach (authored by kossebau). REPOSITORY R278 KWindowSystem CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23839?vs=65768&id=65782 REVISION DETAIL ht

KDE CI: Frameworks » kitemviews » kf5-qt5 FreeBSDQt5.13 - Build # 12 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kitemviews/job/kf5-qt5%20FreeBSDQt5.13/12/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 10 Sep 2019 16:24:19 + Build duration: 21 min and counting CONSOLE OUTPUT [...truncated

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 68 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/68/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 10 Sep 2019 16:06:37 + Build duration: 34 min and counting JUnit Tests Name: projectroot Fail

D23839: Port away from Qt's foreach

zzag accepted this revision. zzag added a comment. This revision is now accepted and ready to land. I tend to leave only one comment about troubling issue/problem and expect that the author of a patch will address all other occurrences of the issue/problem. However, let's get this change

KDE CI: Frameworks » kitemviews » kf5-qt5 WindowsMSVCQt5.13 - Build # 5 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kitemviews/job/kf5-qt5%20WindowsMSVCQt5.13/5/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Tue, 10 Sep 2019 16:24:19 + Build duration: 5 min 47 sec and counting CONSOLE OUTPUT

D21760: Add KListOpenFilesJob

dfaure added a comment. The tagging has been done, you can push. REPOSITORY R244 KCoreAddons BRANCH add_list_processes_with_open_files (branched from master) REVISION DETAIL https://phabricator.kde.org/D21760 To: hallas, davidedmundson, broulik, #frameworks, dfaure, bruns, #plasma Cc:

KDE CI: Frameworks » kitemviews » kf5-qt5 AndroidQt5.13 - Build # 11 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kitemviews/job/kf5-qt5%20AndroidQt5.13/11/ Project: kf5-qt5 AndroidQt5.13 Date of build: Tue, 10 Sep 2019 16:24:19 + Build duration: 2 min 27 sec and counting CONSOLE OUTPUT [...tru

KDE CI: Frameworks » kitemviews » kf5-qt5 SUSEQt5.12 - Build # 35 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kitemviews/job/kf5-qt5%20SUSEQt5.12/35/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 10 Sep 2019 16:24:19 + Build duration: 1 min 10 sec and counting CONSOLE OUTPUT [...truncated

KDE CI: Frameworks » kitemviews » kf5-qt5 SUSEQt5.13 - Build # 13 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kitemviews/job/kf5-qt5%20SUSEQt5.13/13/ Project: kf5-qt5 SUSEQt5.13 Date of build: Tue, 10 Sep 2019 16:24:19 + Build duration: 1 min 10 sec and counting CONSOLE OUTPUT [...truncated

D23839: Port away from Qt's foreach

kossebau added a comment. @zzag Actually, while you commented on that one loop only, the same would be valid also for other loops touched in the patch. So, do you want const ref with all of them? As you can see by the existing code, it also already used values, not const ref, surely also for

D23816: [KItemViews] Port to non-deprecated QWheelEvent API

dfaure closed this revision. REPOSITORY R276 KItemViews REVISION DETAIL https://phabricator.kde.org/D23816 To: dfaure, mlaurent Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D11987: [CopyJob] Pass resolved URL to finalDestUrl so looking up trash filename works

broulik abandoned this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11987 To: broulik, #frameworks, dfaure Cc: kde-frameworks-devel, ngraham, LeGast00n, GB_2, michaelh, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 67 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/67/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 10 Sep 2019 14:51:37 + Build duration: 1 hr 14 min and counting JUnit Tests Name: projectroot

D23839: Port away from Qt's foreach

kossebau added inline comments. INLINE COMMENTS > zzag wrote in kwindowsystem_threadtest.cpp:61 > I asked that because `for (const Type &item : collection) {` is more common. > I know that const ref doesn't have any advantages here. (Gah, phab ate this comment before, rewriting) Getting the ite

D22365: KNotification macOS native support by NSNotificationCenter

nicolasfella accepted this revision. nicolasfella added a comment. This revision is now accepted and ready to land. Let's get this in REVISION DETAIL https://phabricator.kde.org/D22365 To: Inoki, rjvbb, nicolasfella Cc: nicolasfella, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D23839: Port away from Qt's foreach

kossebau added a comment. Thanks for review, Albert & Vlad. BTW; still one foreach left in macOS branch of code, which I could not test-drive, so did not change (also touching internals that I could not quickly understand if there is a chance to conflicting container changes in the call

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 211 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/211/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 10 Sep 2019 15:21:19 + Build duration: 22 min and counting BUILD ARTIFACTS acc/KF5KIO-5.62.0.xmllo

D23839: Port away from Qt's foreach

zzag added inline comments. INLINE COMMENTS > zzag wrote in kwindowsystem_threadtest.cpp:61 > I asked that because `for (const Type &item : collection) {` is more common. > I know that const ref doesn't have any advantages here. In either case, this change is good to go. However, it would be gr

D23816: [KItemViews] Port to non-deprecated QWheelEvent API

mlaurent accepted this revision. mlaurent added a comment. This revision is now accepted and ready to land. It seems ok for me. +2 REPOSITORY R276 KItemViews BRANCH master REVISION DETAIL https://phabricator.kde.org/D23816 To: dfaure, mlaurent Cc: kde-frameworks-devel, LeGast00n, GB_2

D23839: Port away from Qt's foreach

zzag added inline comments. INLINE COMMENTS > kossebau wrote in kwindowsystem_threadtest.cpp:61 > Would a const ref make sense here, given the type nature of WId which boils > down to a integer matching the byte size of a pointer? I asked that because `for (const Type &item : collection) {` is

D23839: Port away from Qt's foreach

kossebau added a comment. In D23839#528788 , @zzag wrote: > Did you use a script to create this patch? Nope, manually done. INLINE COMMENTS > zzag wrote in kwindowsystem_threadtest.cpp:61 > Capture the value by const ref please. Would a

D23420: Use solid to check if a KFileItem is located on a network mount

dfaure added a comment. Heh, yeah, we have 3 APIs about mounted filesystems. Solid, KMountPoint, and KFileSystemType. KFileSystemType uses the blocking statvfs, while KMountPoint relies on a properly filled in /etc/fstab -- which breaks on the FreeBSD CI these days, some weird magic wit

D11987: [CopyJob] Pass resolved URL to finalDestUrl so looking up trash filename works

dfaure added a comment. @Kai-Uwe, you can drop this merge request, given that D23758 is in. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11987 To: broulik, #frameworks, dfaure Cc: kde-frameworks-devel, ngraham, LeGast00n, GB_2, mi

D23839: Port away from Qt's foreach

zzag added a comment. Did you use a script to create this patch? INLINE COMMENTS > kwindowsystem_threadtest.cpp:61 > const QList windows = KWindowSystem::stackingOrder(); > -foreach (auto wid, windows) { > +for (auto wid : windows) { > KWindowInfo info(wi

D23832: Backup on save: Support time and date string replacements

dhaumann retitled this revision from "Variable expansion: Prefer return value over return argument" to "Backup on save: Support time and date string replacements". dhaumann edited the summary of this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D23832 To

D23825: Split KSslErrorUiData from KTcpSocket

This revision was automatically updated to reflect the committed changes. Closed by commit R241:79ee43be4d3f: Split KSslErrorUiData from KTcpSocket (authored by vkrause). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23825?vs=65731&id=65775 REVISION DETAIL htt

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 27 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/27/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 10 Sep 2019 14:15:53 + Build duration: 1 hr 1 min and counting JUnit Tests Name: proj

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.13 - Build # 77 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.13/77/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 10 Sep 2019 14:14:19 + Build duration: 59 min and counting JUnit Tests Name: projectro

D23839: Port away from Qt's foreach

aacid added a comment. seems good to me, but let someone of the people that actually know the code to the +2 REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D23839 To: kossebau, #kwin, zzag Cc: aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, br

D23816: [KItemViews] Port to non-deprecated QWheelEvent API

dfaure updated this revision to Diff 65770. dfaure added a comment. rebase on top of Laurent's angleDelta().y() commit REPOSITORY R276 KItemViews CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23816?vs=65720&id=65770 BRANCH master REVISION DETAIL https://phabricator.kde.org/

D23816: [KItemViews] Port to non-deprecated QWheelEvent API

dfaure added a reviewer: mlaurent. REPOSITORY R276 KItemViews REVISION DETAIL https://phabricator.kde.org/D23816 To: dfaure, mlaurent Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23835: Add TabKCM

onvitaik added a comment. Can I also suggest making the tabs occupy the full width of the area available? It minimizes the unused space and keeps everything in a nice rectangle: F7337756: wide_tabs.png REPOSITORY R296 KDeclarative REVISION DETAI

D23839: Port away from Qt's foreach

kossebau created this revision. kossebau added reviewers: KWin, zzag. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REPOSITORY R278 KWindowSystem BRANCH portfromforeach REVISION DETAIL https://phabricator.kd

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.13 - Build # 27 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/27/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 10 Sep 2019 14:14:07 + Build duration: 46 min and counting JUnit Tests Name: projectroot

D23833: Fix port to QJS

This revision was automatically updated to reflect the committed changes. Closed by commit R241:9e1220bf76ad: Fix port to QJS (authored by carewolf). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23833?vs=65752&id=65767 REVISION DETAIL https://phabricator.kde.o

D23833: Fix port to QJS

carewolf added a comment. It was already described in the two tests included kpactest.pac and kpactest2.pac REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D23833 To: carewolf, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23835: Add TabKCM

nicolasfella edited the test plan for this revision. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D23835 To: nicolasfella, mart Cc: zzag, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23835: Add TabKCM

nicolasfella updated this revision to Diff 65761. nicolasfella added a comment. - Implement Vlad's suggestion REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23835?vs=65760&id=65761 BRANCH tabkcm REVISION DETAIL https://phabricator.kde.org/D23835

D23835: Add TabKCM

nicolasfella added a comment. In D23835#528688 , @ngraham wrote: > Nice, I think we need this. > > From the image, I think the frame's background color needs to be the same as the active tab color, and there shouldn't be a line separating the

D23835: Add TabKCM

nicolasfella updated this revision to Diff 65760. nicolasfella added a comment. - Remove line beneath active tab REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23835?vs=65755&id=65760 BRANCH tabkcm REVISION DETAIL https://phabricator.kde.org/D238

D23835: Add TabKCM

ngraham added a comment. Also related: the lack of a real QML tab view: https://bugs.kde.org/show_bug.cgi?id=394296 REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D23835 To: nicolasfella, mart Cc: zzag, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D23835: Add TabKCM

ngraham added a dependent revision: D23836: Use new TabKCM API. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D23835 To: nicolasfella, mart Cc: zzag, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.13 - Build # 76 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.13/76/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 10 Sep 2019 12:26:41 + Build duration: 1 hr 47 min and counting JUnit Tests Name: pro

T11542: Remove KHTML

knauss reopened subtask T11575: Port Parley away from KHTML as "Open". TASK DETAIL https://phabricator.kde.org/T11542 To: knauss Cc: cordlandwehr, ngraham, #konqueror, #plasma, #okular, #kde_applications, #frameworks, knauss, GB_2, kpiwowarski, asturmlechner, vkrause, dfaure

D23835: Add TabKCM

zzag added inline comments. INLINE COMMENTS > TabKCM.qml:153-160 > +var theTabs = [] > +var i = 0 > + > +for( i=0; i < tabs.length; i++) { > +tabs[i].delegate.createObject(sl, {}) > +theTabs.push(tabs[i].title) > +} FYI, QML has some featur

D23835: Add TabKCM

ngraham added a comment. Nice, I think we need this. From the image, I think the frame's background color needs to be the same as the active tab color, and there shouldn't be a line separating them, This is something we currently have in the Plasma-pa KCM (albeit with the wrong backgrou

D23832: Variable expansion: Prefer return value over return argument

dhaumann added a subscriber: ngraham. dhaumann added a comment. @ngraham: This may be interesting to you as well (and a prereq for the External Tools plugin) REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D23832 To: dhaumann, cullmann Cc: ngraham, kwrite-devel, k

D23832: Variable expansion: Prefer return value over return argument

dhaumann edited the summary of this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D23832 To: dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D23835: Add TabKCM

nicolasfella edited the test plan for this revision. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D23835 To: nicolasfella, mart Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23835: Add TabKCM

nicolasfella created this revision. nicolasfella added a reviewer: mart. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY We have quite a few KCMs that use tabs as top-level components. Since tab

D23832: Variable expansion: Prefer return value over return argument

dhaumann added a reviewer: cullmann. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D23832 To: dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D23832: Variable expansion: Prefer return value over return argument

dhaumann updated this revision to Diff 65754. dhaumann added a comment. - rebase to master REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23832?vs=65750&id=65754 BRANCH bug REVISION DETAIL https://phabricator.kde.org/D23832 AFFECTED FILES src/di

D23833: Fix port to QJS

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Can you maybe document how to test this, e.g. in the README in this dir? REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D23833 To: carewolf, dfaure Cc

D23832: Variable expansion: Prefer return value over return argument

dhaumann reopened this revision. dhaumann added a comment. arc bug: it's not yet committed. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D23832 To: dhaumann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cul

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.12 - Build # 198 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.12/198/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 10 Sep 2019 12:26:41 + Build duration: 1 hr 8 min and counting BUILD ARTIFACTS abi-compatib

D23833: Fix port to QJS

carewolf created this revision. carewolf added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. carewolf requested review of this revision. REVISION SUMMARY Two mistakes with DateRange was discovered after I figured out how to test it. R

D23832: Variable expansion: Prefer return value over return argument

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R39:5ed71b5b75ec: Variable expansion: Prefer return value over return argument (authored by dhaumann). CHANGED PRIOR TO COM

D23832: Variable expansion: Prefer return value over return argument

dhaumann added a comment. KateDialogs contains the following: if (uiadv->edtBackupSuffix->text().isEmpty() && uiadv->edtBackupPrefix->text().isEmpty()) { KMessageBox::information( this, i18n("You did not provide a backup suffix or prefix. Using default s

D23832: Variable expansion: Prefer return value over return argument

dhaumann created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. dhaumann requested review of this revision. REVISION SUMMARY Backup on save: Support time and date string replacements Supported variables are: - %{Dat

  1   2   >