D21760: Add KListOpenFiles::listProcessesWithOpenFiles

broulik added inline comments. INLINE COMMENTS > klistopenfiles.cpp:26 > + > +void listProcessesWithOpenFiles(QDir path, Callback callback) > +{ Can you allow passing an optional context object, so when the caller gets deleted, you don't crash when the reply comes in? REPOSITORY R244 KCoreAd

D23112: Add a event Spy for GtkFileChooser recent files

broulik added inline comments. INLINE COMMENTS > GtkEventSpy.cpp:135 > +// See > https://techbase.kde.org/Development/Tutorials/Services/Traders#The_KTrader_Query_Language > +QString query = QString("exist Exec and ((Exec ~~ '%1') or (exist > GenericName and '%1' ~~ GenericName)

D23133: avoid duplicate notifications from showing up on Windows and remove whitespaces

broulik added a comment. I think this is a bug in KDE Connect? I've seen numerous people complain about that in the new notification system that didn't filter them out originally. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D23133 To: brute4s99, #framewor

D23136: Jam: Fix local with variable without initilisation and highlight SubRule

This revision was automatically updated to reflect the committed changes. Closed by commit R216:1f5f6172e88d: Jam: Fix local with variable without initilisation and highlight SubRule (authored by jpoelen, committed by cullmann). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D23136?vs=636

D23136: Jam: Fix local with variable without initilisation and highlight SubRule

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Testcase looks ok, there we go ;=) REPOSITORY R216 Syntax Highlighting BRANCH fix_jam (branched from master) REVISION DETAIL https://phabricator.kde.org/D23136 To: jpoelen, #fra

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.13 - Build # 18 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.13/18/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 14 Aug 2019 03:06:42 + Build duration: 7 min 27 sec and counting JUnit Tests Name

D23137: C++: contracts are not in C++20

jpoelen updated this revision to Diff 63689. jpoelen added a comment. - increase version REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23137?vs=63686&id=63689 BRANCH cpp_no_contract (branched from master) REVISION DETAIL https://phabricat

D23137: C++: contracts are not in C++20

jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. jpoelen added projects: Kate, Frameworks. jpoelen requested review of this revision. REVISION SUMMARY For C ++ 23 or C ++ 26 with perhaps a syntax change REPOSITORY R216 Syntax Highligh

D23136: Jam: Fix local with variable without initilisation and highlight SubRule

jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. jpoelen added projects: Kate, Frameworks. jpoelen requested review of this revision. REPOSITORY R216 Syntax Highlighting BRANCH fix_jam (branched from master) REVISION DETAIL https:/

D23135: Gettext: fix "previous untranslated string" and other improvements/fixes

jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. jpoelen added projects: Kate, Frameworks. jpoelen requested review of this revision. REVISION SUMMARY - fix #| (previous untranslated string) - fix hexadecimal entity - fix html tag in

D23116: Fix missing digit and pixel-perfect alignment of depth action icons

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. In D23116#511480 , @trickyricky26 wrote: > I thought about that, too, and while the red used in the icon is exactly `NegativeText`, the blue

D23134: fix additionalDeliminator attribute

jpoelen added a comment. I don't understand why there's so much difference in what's displayed :/ REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D23134 To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel,

D23134: fix additionalDeliminator attribute

jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. jpoelen added projects: Kate, Frameworks. jpoelen requested review of this revision. REVISION SUMMARY The initialization of the `Rule::m_wordDelimiter` cache was done before the delimiter

D23116: Fix missing digit and pixel-perfect alignment of depth action icons

trickyricky26 added a comment. In D23116#511430 , @GB_2 wrote: > Maybe instead of hardcoding the blue and red colors you can use the stylesheet colors `ButtonFocus` and `NegativeText`: https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflo

D23108: Add KWindowSystem::setMainWindow(QWindow *) overload

zzag added inline comments. INLINE COMMENTS > kwindowsystem.h:233 > * when the parent is deleted are unaffected and normally use > * the QWidget parent. > * > and normally use the QWidget parent. I think this statement is inaccurate. Documentation needs more love. :-) REPOSIT

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 FreeBSDQt5.13 - Build # 19 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20FreeBSDQt5.13/19/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 13 Aug 2019 20:33:46 + Build duration: 49 min and counting JUnit Tests Name: p

D17137: KTextEditor: File menu: Put Save, Print and Export in submenus

cullmann commandeered this revision. cullmann added a reviewer: gregormi. cullmann added a comment. I think we need to start here from scratch. Gregor, if you have some time again, open a new request please! REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17137

D17137: KTextEditor: File menu: Put Save, Print and Export in submenus

cullmann abandoned this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17137 To: cullmann, #kate, #kdevelop, gregormi Cc: loh.tar, anthonyfieroni, ngraham, cullmann, flherne, dhaumann, kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, bruns,

D23034: implicit fallthough if there is fallthoughContext

cullmann closed this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D23034 To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: nibags, kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraham, bruns, demsking, cullma

D23034: implicit fallthough if there is fallthoughContext

cullmann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting BRANCH auto_fallthrough (branched from master) REVISION DETAIL https://phabricator.kde.org/D23034 To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: nibag

D23034: implicit fallthough if there is fallthoughContext

cullmann added a comment. Some whitespace stuff, git diff -w looks OK. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D23034 To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: nibags, kwrite-devel, kde-frameworks-devel, LeGast00n, domson,

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 WindowsMSVCQt5.13 - Build # 5 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20WindowsMSVCQt5.13/5/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Tue, 13 Aug 2019 20:33:46 + Build duration: 8 min 38 sec and counting JUnit Tests

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.13 - Build # 22 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.13/22/ Project: kf5-qt5 SUSEQt5.13 Date of build: Tue, 13 Aug 2019 20:33:46 + Build duration: 7 min 41 sec and counting BUILD ARTIFACTS abi

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.12 - Build # 126 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.12/126/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 13 Aug 2019 20:33:46 + Build duration: 3 min 27 sec and counting BUILD ARTIFACTS ab

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 FreeBSDQt5.13 - Build # 18 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20FreeBSDQt5.13/18/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 13 Aug 2019 20:24:36 + Build duration: 8 min 48 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.12 - Build # 125 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.12/125/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 13 Aug 2019 20:24:37 + Build duration: 3 min 4 sec and counting CONSOLE OUTPUT [...

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.13 - Build # 21 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.13/21/ Project: kf5-qt5 SUSEQt5.13 Date of build: Tue, 13 Aug 2019 20:24:36 + Build duration: 1 min 30 sec and counting CONSOLE OUTPUT [...

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 WindowsMSVCQt5.13 - Build # 4 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20WindowsMSVCQt5.13/4/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Tue, 13 Aug 2019 20:24:36 + Build duration: 1 min 29 sec and counting CONSOLE OUTP

D22662: Add common GLSL file extensions (.vs, .gs, .fs)

cullmann closed this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D22662 To: smokris, #framework_syntax_highlighting, cullmann Cc: cullmann, kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraham, bruns, demsking, sars, dhaumann

D22662: Add common GLSL file extensions (.vs, .gs, .fs)

smokris added a comment. Sounds good, thanks. I just emailed you at your KDE address. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D22662 To: smokris, #framework_syntax_highlighting, cullmann Cc: cullmann, kwrite-devel, kde-frameworks-devel, LeGast00n,

D22662: Add common GLSL file extensions (.vs, .gs, .fs)

cullmann added a comment. If you pass me name + email, will push it. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D22662 To: smokris, #framework_syntax_highlighting, cullmann Cc: cullmann, kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh,

D22662: Add common GLSL file extensions (.vs, .gs, .fs)

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Sorry, then I did misread that in the diff, I thought QTest::newRow("fs") << QStringLiteral("test.fs") << QStringLiteral("FSharp"); enforces that FSharp is used, not the other way aroun

D22662: Add common GLSL file extensions (.vs, .gs, .fs)

smokris requested review of this revision. smokris added a comment. In D22662#511424 , @cullmann wrote: > I am not sure we want to override F# for .fs. > Either we should not add that or we shall lower the priority of this highlighting to loos

D23116: Fix missing digit and pixel-perfect alignment of depth action icons

GB_2 added a comment. Maybe instead of hardcoding the blue and red colors you can use the stylesheet colors `ButtonFocus` and `NegativeText`: https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips#Stylesheets REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.k

D22662: Add common GLSL file extensions (.vs, .gs, .fs)

cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. I am not sure we want to override F# for .fs. Either we should not add that or we shall lower the priority of this highlighting to loose against F#. REPOSITORY R216 Syntax

D23133: avoid duplicate notifications from showing up on Windows and remove whitespaces

brute4s99 created this revision. brute4s99 added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. brute4s99 requested review of this revision. REVISION SUMMARY without this patch, most notifications show every notification twice. This

D23124: Remove unused DBus XML file

vkrause accepted this revision. vkrause added a comment. This revision is now accepted and ready to land. Not only unused, but also seems to contain an interface that doesn't exist (anymore). REPOSITORY R289 KNotifications BRANCH noknotixml REVISION DETAIL https://phabricator.kde.org/

D23131: Define install location for JAR/AAR files for Android

vkrause added reviewers: Build System, Android. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D23131 To: vkrause, #build_system, #android Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, bencreasy, michaelh, ngraham, bruns

D23131: Define install location for JAR/AAR files for Android

vkrause created this revision. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY This follows where Qt installs those, and thus androiddeployqt looks for them. Currently

D23112: Add a event Spy for GtkFileChooser recent files

ivan requested changes to this revision. ivan added a comment. This revision now requires changes to proceed. Thanks for geting involved this much! INLINE COMMENTS > GtkEventSpy.cpp:129 > +// remove "'" caracters wrapping the command > +exec = exec.mid(1, exec.size() -2 ); > +

D23112: Add a event Spy for GtkFileChooser recent files

meven updated this revision to Diff 63669. meven added a comment. Add a logging category REPOSITORY R161 KActivity Manager Service CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23112?vs=63654&id=63669 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23112 AFFECTE

D21795: [KAuth] Add support for action details in Polkit1 backend.

ngraham added a comment. @chinmoyr, any word on this? REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D21795 To: chinmoyr, apol, bruns, davidedmundson, #frameworks, dfaure, cfeck, sitter Cc: ngraham, sitter, mreeves, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21760: Add KListOpenFiles::listProcessesWithOpenFiles

hallas marked 3 inline comments as done. hallas added inline comments. INLINE COMMENTS > dfaure wrote in klistopenfiles.cpp:49 > This reminds me of KCoreAddons' new KProcessInfo class, although that one > doesn't actually do this. > > I see that FreeBSD and OSX have lsof (and the man page doesn

D14631: Adds a new RenameDialog to KIO with more options for batch renaming

ngraham added a comment. @emateli Ping :) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14631 To: emateli, #frameworks, dfaure, mlaurent Cc: anthonyfieroni, chinmoyr, mlaurent, asensi, rkflx, dfaure, aacid, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21760: Add KListOpenFiles::listProcessesWithOpenFiles

hallas added a subscriber: cfeck. hallas added a comment. In D21760#493817 , @cfeck wrote: > You wrote "ported from Device Notifier". I haven't check in detail yet, but do other copyright holders need to be mentioned? I have added the cop

D21204: Ensure mounted nfs filesystems matches their fstab declared counterpart

ngraham added a comment. @bruns ping! :) REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D21204 To: meven, bruns, #frameworks Cc: broulik, dhaumann, anthonyfieroni, ngraham, bruns, apol, kde-frameworks-devel, LeGast00n, michaelh

D23124: Remove unused DBus XML file

nicolasfella created this revision. nicolasfella added reviewers: Frameworks, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY This file appears to be unused TEST PLAN KNotifications

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.13 - Build # 17 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.13/17/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 13 Aug 2019 11:26:21 + Build duration: 55 min and counting JUnit Tests Name: proj

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.12 - Build # 124 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.12/124/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 13 Aug 2019 11:45:29 + Build duration: 14 min and counting BUILD ARTIFACTS abi-comp

KDE CI: Frameworks » threadweaver » kf5-qt5 WindowsMSVCQt5.13 - Build # 3 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/threadweaver/job/kf5-qt5%20WindowsMSVCQt5.13/3/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Tue, 13 Aug 2019 11:44:07 + Build duration: 14 min and counting JUnit Tests Name: p

D23112: Add a event Spy for GtkFileChooser recent files

meven updated this revision to Diff 63654. meven added a comment. Readd include QDebug used by qWarning REPOSITORY R161 KActivity Manager Service CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23112?vs=63647&id=63654 BRANCH master REVISION DETAIL https://phabricator.kde.org/

KDE CI: Frameworks » threadweaver » kf5-qt5 WindowsMSVCQt5.13 - Build # 2 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/threadweaver/job/kf5-qt5%20WindowsMSVCQt5.13/2/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Tue, 13 Aug 2019 11:22:20 + Build duration: 4 min 56 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.12 - Build # 123 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.12/123/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 13 Aug 2019 11:02:52 + Build duration: 1 min 37 sec and counting CONSOLE OUTPUT [..

D21661: add snoretoast backend for KNotifications on Windows

vkrause added a comment. In D21661#511172 , @brute4s99 wrote: > In D21661#510813 , @vkrause wrote: > > > It looks like this made D-Bus and Phonon hard required dependencies on Android again!? >

KDE CI: Frameworks » knotifications » kf5-qt5 WindowsMSVCQt5.13 - Build # 5 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20WindowsMSVCQt5.13/5/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Tue, 13 Aug 2019 10:21:38 + Build duration: 22 min and counting JUnit Tests Name

D21661: add snoretoast backend for KNotifications on Windows

brute4s99 added a comment. In D21661#510813 , @vkrause wrote: > It looks like this made D-Bus and Phonon hard required dependencies on Android again!? https://cgit.kde.org/knotifications.git/commit/?id=a56a379097d5159f1efa247a109c82e0287

D23116: Fix missing digit and pixel-perfect alignment of depth action icons

trickyricky26 marked 4 inline comments as done. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23116 To: trickyricky26, #vdg, ngraham, ndavis Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, michaelh, bruns

D23116: Fix missing digit and pixel-perfect alignment of depth action icons

trickyricky26 updated this revision to Diff 63652. trickyricky26 added a comment. - Fix stylesheet ids REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23116?vs=63626&id=63652 BRANCH fix-depth-icons (branched from master) REVISION DETAIL https://ph

D23029: Fix the attica pkgconfig file.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R235:134e0290cc2f: Fix the attica pkgconfig file. (authored by cgiboudeaux). REPOSITORY R235 Attica CHANGES SINCE LAST U

D23112: Add a event Spy for GtkFileChooser recent files

meven updated this revision to Diff 63647. meven marked an inline comment as done. meven added a comment. Remove unused include REPOSITORY R161 KActivity Manager Service CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23112?vs=63641&id=63647 BRANCH master REVISION DETAIL http

D23112: Add a event Spy for GtkFileChooser recent files

meven updated this revision to Diff 63641. meven added a comment. Use KServiceTypeTrader to look for apps being used REPOSITORY R161 KActivity Manager Service CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23112?vs=63603&id=63641 BRANCH master REVISION DETAIL https://phabric

D23112: Add a event Spy for GtkFileChooser recent files

meven added a comment. In D23112#510798 , @broulik wrote: > Can you check out the `KBookmarks` framework which has classes for processing xbel files Thanks for pointing it out. I just did, and It does not seem to cover my use case here