D22952: Kirigami.Icon: Fix loading bigger images when source is a URL

broulik added inline comments. INLINE COMMENTS > icon.cpp:406 > +m_networkReply = qnam->get(request); > +connect(m_networkReply.data(), &QNetworkReply::finished, this, > [this](){handleFinished(m_networkReply); }); > } Just noticed, doesn't the `m_networkReply` leak? It's n

D22960: Add handle icons

hein created this revision. hein added reviewers: Frameworks, apol, mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. hein requested review of this revision. REPOSITORY R169 Kirigami BRANCH master REVISION DETAIL https://phabricator.kde.org/D22960 AFFECTED F

D22958: Add initial Android support to ecm_add_app_icon

hein added inline comments. INLINE COMMENTS > apol wrote in ECMAddAppIcon.cmake:154 > this if could go up to where we're checking the icon name in an elseif up at > line 146. We'd need to do a `get_filename_component` there and end up either pulling the `ext` thing out twice (unless CMake does

D22952: Kirigami.Icon: Fix loading bigger images when source is a URL

apol updated this revision to Diff 63153. apol added a comment. simplify REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22952?vs=63133&id=63153 BRANCH master REVISION DETAIL https://phabricator.kde.org/D22952 AFFECTED FILES src/icon.cpp src/icon

D22958: Add initial Android support to ecm_add_app_icon

apol added a comment. The patch makes sense. +1 INLINE COMMENTS > ECMAddAppIcon.cmake:154 > +set(ext "${CMAKE_MATCH_4}") > +if(NOT ${icon_type} STREQUAL ".svg" OR NOT ${icon_type} > STREQUAL ".svgz") > +message(AUTHOR_WARNING "${icon_full

D22955: Add icon used by Kirigami.AboutPage

This revision was automatically updated to reflect the committed changes. Closed by commit R169:c17c048ec2f7: Add icon used by Kirigami.AboutPage (authored by hein). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22955?vs=63146&id=63152 REVISION DETAIL htt

D22955: Add icon used by Kirigami.AboutPage

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R169 Kirigami BRANCH master REVISION DETAIL https://phabricator.kde.org/D22955 To: hein, #frameworks, mart, apol Cc: mart, plasma-devel, fbampaloukas, domson, dkardarakos, apol, davidedmundson, hein

D22958: Add initial Android support to ecm_add_app_icon

hein added a comment. This is the culmination of a patch series that makes About dialogs in Kirigami work reasonably across platforms: F7168840: about.jpg REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D22958 T

D22958: Add initial Android support to ecm_add_app_icon

hein added a comment. The code is mostly copy-and-pasted together from ECMAddAppIcon.cmake and ECMInstallIcons.cmake. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D22958 To: hein, #frameworks, mart, leinir, apol Cc: kde-frameworks-devel, kde-buildsyste

D22958: Add initial Android support to ecm_add_app_icon

hein created this revision. hein added reviewers: Frameworks, mart, leinir, apol. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. hein requested review of this revision. REVISION SUMMARY Kirigami has a `kirigami_package_breeze_ico

D22698: Support passing target to ki18n_wrap_ui macro

This revision was automatically updated to reflect the committed changes. Closed by commit R249:8f84d19aad04: Support passing target to ki18n_wrap_ui macro (authored by daandemeyer, committed by aacid). REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22698?vs=624

Re: KCrash crash racing

El dimecres, 31 de juliol de 2019, a les 12:26:23 CEST, Harald Sitter va escriure: > Moin Moin! > > I've been haunting down a nasty backtrace problem in drkonqi where it > entirely fails to create a backtrace and am now fairly confident this > is in fact a design flaw with kcrash, but I have no a

D22955: Add icon used by Kirigami.AboutPage

hein created this revision. hein added reviewers: Frameworks, mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. hein requested review of this revision. REPOSITORY R169 Kirigami BRANCH master REVISION DETAIL https://phabricator.kde.org/D22955 AFFECTED FILES

D22698: Support passing target to ki18n_wrap_ui macro

ilic accepted this revision. This revision is now accepted and ready to land. REVISION DETAIL https://phabricator.kde.org/D22698 To: daandemeyer, ilic Cc: ltoscano, alexmerry, turbov, cgiboudeaux, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22698: Support passing target to ki18n_wrap_ui macro

alexmerry added a comment. Since you tagged me in this, I'll say that (as a former maintainer of Extra-CMake-Modules as well as someone who still makes extensive use of CMake professionally despite not doing much KDE stuff these days) the change looks good (and following modern conventions)

D22709: Support passing target to ecm_add_app_icon.

daandemeyer added a comment. Ping REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D22709 To: daandemeyer, alexmerry, dschmidt Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, sbergeron, bencreasy, michaelh, ngraham, bruns

D22699: Support passing target to ecm_qt_declare_logging_category

daandemeyer added a comment. Ping REVISION DETAIL https://phabricator.kde.org/D22699 To: daandemeyer, alexmerry Cc: cgiboudeaux, apol, kde-frameworks-devel, kde-buildsystem, LeGast00n, sbergeron, bencreasy, michaelh, ngraham, bruns

D22768: Forward declare KLocalizedString and make I18n a private dependency.

daandemeyer added a comment. Ping REPOSITORY R310 KTextWidgets REVISION DETAIL https://phabricator.kde.org/D22768 To: daandemeyer, #frameworks Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22698: Support passing target to ki18n_wrap_ui macro

daandemeyer added a comment. To give an example of how the addition would improve KDE CMake build scripts, let's look at part of Kate's CMake build script. It currently looks like this: # collect the needed source files set (KATE_LIBRARY_SRCS kateappadaptor.cpp ka

D22724: Add ECMAddQtDesignerPlugin

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R240:6709de184aa3: Add ECMAddQtDesignerPlugin (authored by kossebau). REPOSITORY R240 Extra CMake Modules CHANGES SINCE

D22952: Kirigami.Icon: Fix loading bigger images when source is a URL

apol created this revision. apol added reviewers: Frameworks, Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Port to using the QImage::load() that takes a QIODevice and only do it when the execution

D22884: [RFC] Don't show title on page by default

ngraham added a comment. In D22884#506943 , @hpereiradacosta wrote: > "KPageWidgetItems live in a multi-page KPageDialog" > Is that really true ? Does it not live also standalone when running e.g. kcmshell5 kwindecoration (or any other kcm ?)

D22942: [kded/baloosearchmodule] Remove useless qDebug messages

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH no-qdebug (branched from master) REVISION DETAIL https://phabricator.kde.org/D22942 To: poboiko, #baloo, bruns, ngraham Cc: kde-frameworks-devel, LeGast00n, sbergeron, fbampalouka

Re: KCrash crash racing

On Wed, Jul 31, 2019 at 12:26 PM Harald Sitter wrote: > > Moin Moin! > > I've been haunting down a nasty backtrace problem in drkonqi where it > entirely fails to create a backtrace and am now fairly confident this > is in fact a design flaw with kcrash, but I have no awesome ideas on > how to sol

D22946: Include API to generically implement --replace arguments

apol updated this revision to Diff 63124. apol added a comment. More documentation. Don't wait for the original process to finish. REPOSITORY R271 KDBusAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22946?vs=63116&id=63124 BRANCH master REVISION DETAIL https://phabr

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 22 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/22/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 05 Aug 2019 13:59:07 + Build duration: 7 min 41 sec and counting JUnit Tests Name: projectroo

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 29 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/29/ Project: kf5-qt5 SUSEQt5.13 Date of build: Mon, 05 Aug 2019 13:59:07 + Build duration: 6 min 56 sec and counting BUILD ARTIFACTS acc/KF5KIO-5.61.0.x

D22763: [KDirOperator] Use more human-readable sort order descriptions

This revision was automatically updated to reflect the committed changes. Closed by commit R241:10b6d83bbc4c: [KDirOperator] Use more human-readable sort order descriptions (authored by meven). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22763?vs=62711&id=63122

D22946: Include API to generically implement --replace arguments

kossebau added inline comments. INLINE COMMENTS > apol wrote in kdbusservice.h:121 > I'd say this is for applications using KDBusService really and it's not like > this is the only usage of this org.qtproject.* here. By just reading the API dox, I would have assumed one can replace any "unique

D22946: Include API to generically implement --replace arguments

apol updated this revision to Diff 63116. apol added a comment. error handling REPOSITORY R271 KDBusAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22946?vs=63115&id=63116 BRANCH master REVISION DETAIL https://phabricator.kde.org/D22946 AFFECTED FILES src/kdbusservi

D22946: Include API to generically implement --replace arguments

apol marked an inline comment as done. apol added inline comments. INLINE COMMENTS > kossebau wrote in kdbusservice.h:121 > A unique service which has a /MainApplication object implementing a > rg.qtproject.Qt.QCoreApplication interface,... > > Any chance to make this non-Qt-only? I'd say this

D22946: Include API to generically implement --replace arguments

kossebau added inline comments. INLINE COMMENTS > kdbusservice.cpp:119 > +} > +} > + What if the quit fails? No error handling? I fear for having such logic in the library it needs to be more elaborared IMHO. REPOSITORY R271 KDBusAddons REVISION DETAIL https://phabrica

D22946: Include API to generically implement --replace arguments

kossebau added inline comments. INLINE COMMENTS > kdbusservice.h:121 > + * Indicates that if there's already a unique service running, to be > quit and replaced > + * with our own. > + * A unique service which has a /MainApplication object implementing a rg.qtproject.Qt

D22946: Include API to generically implement --replace arguments

apol updated this revision to Diff 63115. apol added a comment. Argument -> flag REPOSITORY R271 KDBusAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22946?vs=63114&id=63115 BRANCH master REVISION DETAIL https://phabricator.kde.org/D22946 AFFECTED FILES src/kdbusser

D22946: Include API to generically implement --replace arguments

apol edited the summary of this revision. REPOSITORY R271 KDBusAddons REVISION DETAIL https://phabricator.kde.org/D22946 To: apol, #frameworks Cc: broulik, kossebau, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22946: Include API to generically implement --replace arguments

apol marked 3 inline comments as done. REPOSITORY R271 KDBusAddons REVISION DETAIL https://phabricator.kde.org/D22946 To: apol, #frameworks Cc: broulik, kossebau, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22884: [RFC] Don't show title on page by default

hpereiradacosta added a comment. "KPageWidgetItems live in a multi-page KPageDialog" Is that really true ? Does it not leave also standalone when running e.g. kcmshell5 kwindecoration (or any other kcm ?) If yes, and at least in this case, the title has to stay, because there is no side b

D22946: Include API to generically implement --replace arguments

broulik added inline comments. INLINE COMMENTS > kossebau wrote in kdbusservice.h:151 > Please no "bool" type argument, this makes places calling harder to > understand -> https://community.kde.org/Policies/Library_Code_Policy#Flags especially given there is an `options` flag already, you can j

D22946: Include API to generically implement --replace arguments

kossebau added a comment. Just some API style nitpicks while this was by-passing. Not dealt with KDBusService recently, so cannot really comment otherwise. QCoreApplication::processEvents() in the constructor though makes me feel uncomfortable, any chance to make this async? INLINE COMMENTS

D22946: Include API to generically implement --replace arguments

apol created this revision. apol added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY It's quite wide-spread in KDE applications, and having to implement it in every applicat

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir updated this revision to Diff 63107. leinir added a comment. - Use typed animations instead of the inefficient PropertyAnimation REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21721?vs=62850&id=63107 BRANCH knsquick-feature-parity-with-kns (bran

D22942: [kded/baloosearchmodule] Remove useless qDebug messages

poboiko created this revision. poboiko added reviewers: Baloo, bruns, ngraham. Herald added projects: Frameworks, Baloo. poboiko requested review of this revision. REVISION SUMMARY Those messages are not informative anyway; they are categorized as "kdeinit5"; and they tend to spam logs during

D22528: KIO FTP: Fix file copy hanging when copying to existing file

sitter added a comment. @dfaure are we ok to land this for now? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D22528 To: ZaWertun, sitter, dfaure, cfeck Cc: rikmills, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns