KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.12 - Build # 34 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.12/34/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Wed, 29 May 2019 05:50:24 + Build duration: 1 min 14 sec and counting JUnit Tests Name: projectr

D21467: fix highlighting of '\0' in C mode

This revision was automatically updated to reflect the committed changes. Closed by commit R216:6ae1acec9ff5: fix highlighting of '\0' in C mode (authored by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21467?vs=58802&id=58808 REVISIO

D21467: fix highlighting of '\0' in C mode

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Guess that's fine. REPOSITORY R216 Syntax Highlighting BRANCH master REVISION DETAIL https://phabricator.kde.org/D21467 To: cullmann, dhaumann, vkrause, nibags Cc: kwrite-devel,

D21466: Recommend rebooting after installing Samba

ngraham added a comment. In D21466#471371 , @bruns wrote: > In D21466#471325 , @ngraham wrote: > > > In D21466#471321 , @bruns wrote: > > > > > For gro

D21466: Recommend rebooting after installing Samba

bruns added a comment. In D21466#471325 , @ngraham wrote: > In D21466#471321 , @bruns wrote: > > > For group membership changes, only a relogin is required (at most). > > > I know, but telling p

D19785: DocumentPrivate: Review del/backspace

cullmann added a comment. Thanks! REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19785 To: loh.tar, #ktexteditor, cullmann Cc: safaalfulaij, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D21467: fix highlighting of '\0' in C mode

cullmann added reviewers: dhaumann, vkrause, nibags. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D21467 To: cullmann, dhaumann, vkrause, nibags Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D21467: fix highlighting of '\0' in C mode

cullmann created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. cullmann requested review of this revision. REVISION SUMMARY before the second ' was red for the '\0' literal now it is ok, just like '\123' TEST PLAN make

D21466: Recommend rebooting after installing Samba

ngraham added a comment. In D21466#471321 , @bruns wrote: > For group membership changes, only a relogin is required (at most). I know, but telling people to log out and log back in again involves more ways to mess up than just telling th

D21466: Recommend rebooting after installing Samba

bruns added a comment. For group membership changes, only a relogin is required (at most). The only relevant group membership here is the usershare group, which can be determined from the owner/group of the "usershare path = " directory (samba config). If the user can write to the direct

D21466: Recommend rebooting after installing Samba

ngraham updated this revision to Diff 58801. ngraham added a comment. Revert unintentional whitespace change REPOSITORY R432 File Sharing (Samba) integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21466?vs=58800&id=58801 BRANCH recommend-rebooting (branched from master)

D21466: Recommend rebooting after installing Samba

ngraham created this revision. ngraham added reviewers: VDG, Frameworks, Dolphin, apol. ngraham requested review of this revision. REVISION SUMMARY After Samba is installed, very frequently it will not work correctly until the machine is rebooted. One potential reason is when the installed pa

D19785: DocumentPrivate: Review del/backspace

This revision was automatically updated to reflect the committed changes. Closed by commit R39:7e739920fd23: Don't delete entire previous line by backspace in pos 0 (authored by loh.tar). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D19785?vs=58682&id=58796#toc REPOSITORY R39 KTextEdi

D14631: Adds a new RenameDialog to KIO with more options for batch renaming

ngraham added a comment. No problem, thanks for checking in again! REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14631 To: emateli, #frameworks, dfaure, mlaurent Cc: anthonyfieroni, chinmoyr, mlaurent, asensi, rkflx, dfaure, aacid, ngraham, kde-frameworks-devel, micha

D19785: DocumentPrivate: Review del/backspace

cullmann added a comment. I ATM have no access to my compile env. here, please commit the fix. It would be best to have some test for this, too, for future reference. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19785 To: loh.tar, #ktexteditor, cullmann Cc: s

D21315: Dolphin-style view modes in the file dialog

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Works perfectly and the code looks sensible! INLINE COMMENTS > meven wrote in kdiroperator.cpp:1955 > Well there are pretty much reusable already, their actions are available in > the ac

D21459: Always save view settings when switching from one view mode to another

ngraham added a comment. Nice! What do you think about moving the `if (configGroup && itemView) {` into the new function and calling it something more conditional, like `writeIconZoomSettingsIfNeeded`? Also it seems like there could be some code shared in a new function so that `KDirOperator

D21315: Dolphin-style view modes in the file dialog

abetts added a comment. +1 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D21315 To: meven, #frameworks, ngraham, #vdg Cc: abetts, anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns

D21401: Use native dialog overwrite check

ngraham added a comment. So nice! REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D21401 To: meven, ngraham, #frameworks, #kate, cullmann Cc: cullmann, kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, demsking, sars, dhaumann

D21441: Start krunner later

ngraham added a task: T10958: Faster Startup. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21441 To: broulik, #plasma, davidedmundson Cc: plasma-devel, kde-frameworks-devel, mart, jraleigh, GB_2, ragreen, Pitel, michaelh, ZrenBot, ngraham, bruns, himcesjf, l

D19785: DocumentPrivate: Review del/backspace

loh.tar added a comment. That may fix it. diff --git a/src/document/katedocument.cpp b/src/document/katedocument.cpp index e365c380..7c24f67f 100644 --- a/src/document/katedocument.cpp +++ b/src/document/katedocument.cpp @@ -3350,7 +3350,9 @@ void KTextEditor::DocumentPr

D19785: DocumentPrivate: Review del/backspace

cullmann reopened this revision. cullmann added a comment. This revision is now accepted and ready to land. See https://bugs.kde.org/show_bug.cgi?id=408016 Guess this needs a revert, + some tests for that cases + a fix, thanks ;=) REPOSITORY R39 KTextEditor REVISION DETAIL https://ph

D21315: Dolphin-style view modes in the file dialog

meven marked an inline comment as done. meven added inline comments. INLINE COMMENTS > anthonyfieroni wrote in kdiroperator.cpp:1955 > Can we make them reusable, it should be in framework and then accessed in > Dolphin. Well there are pretty much reusable already, their actions are available in

D21459: Always save view settings when switching from one view mode to another

meven updated this revision to Diff 58780. meven added a comment. Removing parent commit REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21459?vs=58779&id=58780 BRANCH icon-save2 REVISION DETAIL https://phabricator.kde.org/D21459 AFFECTED FILES src/file

D21440: Start baloo_file later

broulik added a comment. The idle tracking is only in the extractor process, not in baloo_file itself. On startup it runs the `UnindexedFileIndexer` and iterates all the folders looking for files to re-index, consuming a considerable amount of CPU time, spending most of its time doing regexp

D21459: Always save view settings when switching from one view mode to another

meven updated this revision to Diff 58779. meven added a comment. Make the expanded detail view and the regular one share the same zoom setting REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21459?vs=58778&id=58779 BRANCH icon-save2 REVISION DETAIL https:

D12378: Properly search for NetworkManager

Herald added a subscriber: kde-frameworks-devel. REPOSITORY R239 KDELibs4Support REVISION DETAIL https://phabricator.kde.org/D12378 To: jgrulich, #frameworks Cc: kde-frameworks-devel, rikmills, #frameworks, michaelh, ngraham, bruns

D21315: Dolphin-style view modes in the file dialog

meven added a dependent revision: D21459: Always save view settings when switching from one view mode to another. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D21315 To: meven, #frameworks, ngraham, #vdg Cc: anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns

D21459: Always save view settings when switching from one view mode to another

meven added a dependency: D21315: Dolphin-style view modes in the file dialog. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D21459 To: meven, #frameworks, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21459: Always save view settings when switching from one view mode to another

meven added a task: T8552: Polish Open/Save dialogs. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D21459 To: meven, #frameworks, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21459: Always save view settings when switching from one view mode to another

meven created this revision. meven added reviewers: Frameworks, ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY - Add zoom setings for each view kind - Save and restore zoom when view is cha

D21235: Add handling of fuseiso filesystem type

bruns added inline comments. INLINE COMMENTS > hallas wrote in fstabdevice.cpp:88 > This is what I have in mounts: > > fuseiso on /home/dha/mnt1 type fuse.fuseiso > (rw,nosuid,nodev,relatime,user_id=1000,group_id=1000) > > so there just isn't a whole lot of information - we don't even have t

D21315: Dolphin-style view modes in the file dialog

meven updated this revision to Diff 58776. meven added a comment. Bad comment REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21315?vs=58775&id=58776 BRANCH arcpatch-D21315 REVISION DETAIL https://phabricator.kde.org/D21315 AFFECTED FILES src/filewidget

D21315: Dolphin-style view modes in the file dialog

meven updated this revision to Diff 58775. meven added a comment. Remove icon zoom settings change this belong to another review REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21315?vs=58774&id=58775 BRANCH arcpatch-D21315 REVISION DETAIL https://phabrica

D21315: Dolphin-style view modes in the file dialog

meven updated this revision to Diff 58774. meven added a comment. Allow to save different zoom settings for all view kinds REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21315?vs=58642&id=58774 BRANCH arcpatch-D21315 REVISION DETAIL https://phabricator.kd

D21440: Start baloo_file later

bruns added a comment. One possible reason for the idle tracking not working, IIRC it tries to connect to some service via DBus, don't know what happens if that is not available (yet). REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D21440 To: broulik, bruns, #baloo,

D21440: Start baloo_file later

bruns added a comment. The reason to start baloo_file early is to be notified of all file changes. The extractor could be started later, and it has some mechanisms to throttle itself if the system isn't idle. If this isn't working as expected we have to fix it. REPOSITORY R293 Baloo REVI

D21440: Start baloo_file later

broulik added a comment. Thanks for your input. Yeah, I was mostly interested in having the file extractor wait some more. I'll poke the thing a bit then. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D21440 To: broulik, bruns, #baloo, davidedmundson Cc: kde-framewor

D21315: Dolphin-style view modes in the file dialog

anthonyfieroni added inline comments. INLINE COMMENTS > kdiroperator.cpp:1955 > > +// View modes that match those of Dolphin > +KToggleAction *iconsViewAction = new KToggleAction(i18n("Icons View"), > this); Can we make them reusable, it should be in framework and then accessed in Do

D14631: Adds a new RenameDialog to KIO with more options for batch renaming

anthonyfieroni added inline comments. INLINE COMMENTS > batchrenametypes.cpp:98-106 > +QStringList firstCapturedGroups() > +{ > +return capturedGroups; > +} > + > +void clearCapturedGroups() > +{ Make a class instead, free functions with global variable in, is no-go. It's totally miss of en

D21441: Start krunner later

This revision was automatically updated to reflect the committed changes. Closed by commit R120:5bb4680bcffc: Start krunner later (authored by broulik). Herald added a project: Plasma. Herald added a subscriber: plasma-devel. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://

D21441: Start krunner later

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R308 KRunner REVISION DETAIL https://phabricator.kde.org/D21441 To: broulik, #plasma, davidedmundson Cc: kde-frameworks-devel, mart, michaelh, ngraham, bruns

D21441: Start krunner later

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. TEST PLAN Ideally, KRunner were DBus-activated and launched the first time you hit the shortcut, or ne

D21440: Start baloo_file later

broulik created this revision. broulik added reviewers: bruns, Baloo, davidedmundson. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY We noticed that `baloo_file` starts quite early in the proc

D21315: Dolphin-style view modes in the file dialog

meven added a reviewer: VDG. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D21315 To: meven, #frameworks, ngraham, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14631: Adds a new RenameDialog to KIO with more options for batch renaming

emateli added a comment. I'll need to rewrite the BatchRenameJob part which does the batch processing without breaking binary compatibility. Been unusually busy lately between job and uni but I'll start working on this sooner than later. REPOSITORY R241 KIO REVISION DETAIL https://phabr

D21204: Ensure no trailing slash in mountpoint read from fstab file.

meven added inline comments. INLINE COMMENTS > bruns wrote in fstabhandling.cpp:142 > for NFS the following entries are valid: > > - 192.168.0.1:/some/dir > - 192.168.0.1:/some/dir/ > - server:/other > - server:/ > > while `server:` (without slash) is invalid. > > The first two entries are sem

D21315: Dolphin-style view modes in the file dialog

meven added a comment. ANy REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D21315 To: meven, #frameworks, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns