D21401: Use native dialog overwrite check

meven added a comment. In D21401#470121 , @ngraham wrote: > This will work fine for a KDE environment where we know that the file dialog correctly handles the overwrite use case. Do we know that the GTK file dialog does the same for when Kate is

D21412: Add action to reset font size

kishoreg created this revision. kishoreg added a reviewer: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. kishoreg requested review of this revision. REVISION SUMMARY Add an action to reset the font size to the default and set

D21401: Use native dialog overwrite check

ngraham added a comment. This will work fine for a KDE environment where we know that the file dialog correctly handles the overwrite use case. Do we know that the GTK file dialog does the same for when Kate is run on GNOME, XFCE, or MATE? REPOSITORY R39 KTextEditor BRANCH native-overwr

D21390: Test reading and seeking in KCompressionDevice

aacid closed this revision. REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D21390 To: aacid, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21388: KCompressionDevice: Remove bIgnoreData

aacid closed this revision. REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D21388 To: aacid, apol Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D21411: YAML: only comments after spaces and other improvements/fixes

dhaumann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting BRANCH improve-yaml REVISION DETAIL https://phabricator.kde.org/D21411 To: nibags, dhaumann, cullmann, #framework_syntax_highlighting Cc: kwrite-devel, kde-frameworks-deve

D21410: Markdown: use includeAttrib in code blocks

dhaumann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting BRANCH markdown-code REVISION DETAIL https://phabricator.kde.org/D21410 To: nibags, dhaumann, cullmann, #framework_syntax_highlighting Cc: kwrite-devel, kde-frameworks-dev

D21411: YAML: only comments after spaces and other improvements/fixes

nibags edited the summary of this revision. nibags added reviewers: dhaumann, cullmann, Framework: Syntax Highlighting. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D21411 To: nibags, dhaumann, cullmann, #framework_syntax_highlighting Cc: kwrite-devel, kde-

D21411: YAML: only comments after spaces and other improvements/fixes

nibags created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REPOSITORY R216 Syntax Highlighting BRANCH improve-yaml REVISION DETAIL https://phabricator.kde.org/D21411 AFFECTE

D21410: Markdown: use includeAttrib in code blocks

nibags edited the summary of this revision. nibags added reviewers: dhaumann, cullmann, Framework: Syntax Highlighting. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D21410 To: nibags, dhaumann, cullmann, #framework_syntax_highlighting Cc: kwrite-devel, kde-

D21410: Markdown: use includeAttrib in code blocks

nibags created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REPOSITORY R216 Syntax Highlighting BRANCH markdown-code REVISION DETAIL https://phabricator.kde.org/D21410 AFFECT

D21401: Use native dialog overwrite check

cullmann added a comment. checkOverwrite decl. should be removed, too. REPOSITORY R39 KTextEditor BRANCH native-overwrite-check REVISION DETAIL https://phabricator.kde.org/D21401 To: meven, ngraham, #frameworks, #kate, cullmann Cc: cullmann, kwrite-devel, kde-frameworks-devel, domson,

D21401: Use native dialog overwrite check

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Sounds reasonable. REPOSITORY R39 KTextEditor BRANCH native-overwrite-check REVISION DETAIL https://phabricator.kde.org/D21401 To: meven, ngraham, #frameworks, #kate, cullmann C

D21402: Avoid double overwrite check

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Ok, then lets do this. REPOSITORY R40 Kate BRANCH native-check REVISION DETAIL https://phabricator.kde.org/D21402 To: meven, #kate, #frameworks, cullmann Cc: apol, dhaumann, kwr

D21204: Ensure no trailing slash in mountpoint read from fstab file.

bruns added inline comments. INLINE COMMENTS > meven wrote in fstabhandling.cpp:142 > I am not familiar with those mounts. > What is the udi of those mounted filesystem ? for NFS the following entries are valid: - 192.168.0.1:/some/dir - 192.168.0.1:/some/dir/ - server:/other - server:/ while

D21379: [UDev Backend] Narrow subsystems queried for cameras

bruns requested changes to this revision. bruns added a comment. This revision now requires changes to proceed. Please also update the summary. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D21379 To: broulik, #frameworks, davidedmundson, bruns Cc: apol, kde-framework

D21402: Avoid double overwrite check

apol added a comment. That should work on every platform. In fact, it would be a bug if any platform didn't do it. https://doc.qt.io/qt-5/qfiledialog.html#Option-enum See QFileDialog::DontConfirmOverwrite. REPOSITORY R40 Kate REVISION DETAIL https://phabricator.kde.org/D21402 To:

D21400: Downgrade KDEWebKit from Tier 3 to Porting Aids

apol added a comment. +1 REPOSITORY R300 KDEWebKit REVISION DETAIL https://phabricator.kde.org/D21400 To: vkrause Cc: apol, asturmlechner, kde-frameworks-devel, michaelh, ngraham, bruns

D21388: KCompressionDevice: Remove bIgnoreData

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R243 KArchive BRANCH master REVISION DETAIL https://phabricator.kde.org/D21388 To: aacid, apol Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D21390: Test reading and seeking in KCompressionDevice

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R243 KArchive BRANCH master REVISION DETAIL https://phabricator.kde.org/D21390 To: aacid, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21367: kioexec: change the scary debug messages for delayed deletion

elvisangelaccio added inline comments. INLINE COMMENTS > main.cpp:262 > // it will have time to start up and read the file before it > gets deleted. #130709. > -qDebug() << "sleeping..."; > -QThread::currentThread()->sleep(180); // 3 mn > +const i

D21402: Avoid double overwrite check

dhaumann added a comment. Is this correct in all cases? Do we support KIO here? Does that depend on platform integration, i.e. gnome or Windows? REPOSITORY R40 Kate REVISION DETAIL https://phabricator.kde.org/D21402 To: meven, #kate, #frameworks, cullmann Cc: dhaumann, kwrite-devel, dom

D21401: Use native dialog overwrite check

meven added a task: T8552: Polish Open/Save dialogs. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D21401 To: meven, ngraham, #frameworks, #kate Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D21402: Avoid double overwrite check

meven created this revision. meven added reviewers: Kate, Frameworks, cullmann. Herald added a project: Kate. Herald added a subscriber: kwrite-devel. meven requested review of this revision. REVISION SUMMARY QFileDialog has by default an overwrite check, avoid the second one done by kate.

D21401: Use native dialog overwrite check

meven created this revision. meven added reviewers: ngraham, Frameworks, Kate. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. meven requested review of this revision. REVISION SUMMARY Past review https://git.reviewboard.kde.org/r/128452/ av

D21400: Downgrade KDEWebKit from Tier 3 to Porting Aids

vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY QtWebKit is dead, even the "revived" version has no changes since more than a year. REPOSITORY R300 KDEWebKit BRAN

D21315: Dolphin-style view modes in the file dialog

meven updated this revision to Diff 58642. meven added a comment. Fix missing ')' REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21315?vs=58424&id=58642 BRANCH dolphin-view-modes REVISION DETAIL https://phabricator.kde.org/D21315 AFFECTED FILES src/fil

D12647: Move the inline preview button into the menu

meven added a comment. In D12647#456283 , @meven wrote: > In D12647#434327 , @ngraham wrote: > > > I don't think this makes sense anymore. > > > "Put the Show Inline Preview button in the setti

D21367: kioexec: change the scary debug messages for delayed deletion

Lekensteyn updated this revision to Diff 58640. Lekensteyn marked an inline comment as done. Lekensteyn edited the test plan for this revision. Lekensteyn added a comment. Addressed review comment by adding a constant for the interval. Changed minutes -> seconds in the debug message. CHANGES

D21390: Test reading and seeking in KCompressionDevice

aacid added a comment. The companion commit that fixes this test is https://phabricator.kde.org/D21388 REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D21390 To: aacid Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21388: KCompressionDevice: Remove bIgnoreData

aacid added a comment. test at https://phabricator.kde.org/D21390 Made it in two separate bits so you can: a) cherry-pick the test, run it, see it fails b) cherry-pick this fix on top, run test it, see it doesn't fail REPOSITORY R243 KArchive REVISION DETAIL https://phabricato

D21390: Test reading and seeking in KCompressionDevice

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY This test fails without the patch to remove bIgnoreData from KCompressionDevice REPOSITORY R243 KArchive BRANCH mast

D21390: Test reading and seeking in KCompressionDevice

aacid updated this revision to Diff 58630. aacid added a comment. forgot to add the _p.h file REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21390?vs=58629&id=58630 BRANCH master REVISION DETAIL https://phabricator.kde.org/D21390 AFFECTED FILES au

D21381: use org.freedesktop.appstream-glib package to validate appstream data

mgallien added a comment. In D21381#469617 , @apol wrote: > How about we test against both? I have just pushed a new diff to do that. I am not sure if it desirable to keep appstreamcli test given it fails to validate files that are vali

D21381: use org.freedesktop.appstream-glib package to validate appstream data

mgallien updated this revision to Diff 58628. mgallien added a comment. - use appstream-util and appstreamcli to validate appdata file REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21381?vs=58595&id=58628 BRANCH master REVISION DETAIL htt

D21313: Create specific directory for kdebugsettings categories file

mlaurent added a comment. LOGGINGCATEGORIESDIR indeed it's more specific +1 for me debug-categories5 => indeed it's just using by kdebugsettings at the moment. => kdebugsettings-categories5 ? no idea if it's better. @dfaure do you have an idea ?:) REPOSITORY R240 Extra CMake Modul