D20197: Fix desktop link to file or directory

michaelweghorn added a comment. In D20197#443689 , @hoffmannrobert wrote: > Thanks, I've learned that QFileDialog only creates a well behaving directory chooser, if the QFileDialog::ShowDirsOnly option is set to true _after_ having set the file

D21313: Create specific directory for kdebugsettings categories file

mlaurent updated this revision to Diff 58454. mlaurent added a comment. Use DEBUGCATEGORIESDIR and debug-categories5 REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21313?vs=58391&id=58454 BRANCH add_specific_kdebugsetting_directory REVISION

D21328: Add qml import for KItemModels

apol added a comment. I wonder if it was necessary to do the whole move into core :P. +1 overall INLINE COMMENTS > concatenaterows.qml:5 > +ListView { > +model: KConcatenateRowsProxyModel { > +id: myModel can we turn this into an autotest? REPOSITORY R275 KItemModels REV

D21328: Add qml import for KItemModels

davidedmundson updated this revision to Diff 58449. davidedmundson added a comment. Sync copyright headers to existing style REPOSITORY R275 KItemModels CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21328?vs=58448&id=58449 BRANCH davidedmundson/qmlify REVISION DETAIL https:

D21328: Add qml import for KItemModels

davidedmundson retitled this revision from "Move everything in src to a subdirectory" to "Add qml import for KItemModels". davidedmundson edited the summary of this revision. REPOSITORY R275 KItemModels REVISION DETAIL https://phabricator.kde.org/D21328 To: davidedmundson Cc: kde-frameworks

D21328: Move everything in src to a subdirectory

davidedmundson created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY Add qml import for KItemModels QML dependency is optional and all original classes are kept away from

D21327: Support installing multiple Samba packages

apol added a comment. Hope this helps ^^' INLINE COMMENTS > sambausershareplugin.cpp:155 > SIGNAL(package(PackageKit::Transaction::Info,QString,QString)), > > SLOT(packageInstall(PackageKit::Transaction::Info,QString,QString))); > This is a bit weird now, because

D20959: Allow to change the Mode, after changing the Highlighting

nibags added a comment. errata: the `setDontChangeHlOnSave()` function has nothing to do here. more time I upload a patch. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D20959 To: nibags, #ktexteditor, #kate, cullmann Cc: cullmann, kwrite-devel, kde-frameworks-

D21327: Support installing multiple Samba packages

ngraham created this revision. ngraham added reviewers: apol, Frameworks. ngraham requested review of this revision. REVISION SUMMARY Some distros (such as Manjaro) require multiple packages to be installed before a working Samba stack is present. This patch adjusts the CMake packaging and Sa

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.12 - Build # 47 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.12/47/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 21 May 2019 21:32:38 + Build duration: 2 min 13 sec and counting JUnit Tests Name: pr

D21287: Try to find always an unique visible document name without a number suffix

dhaumann added a comment. There even is a bug report about this: https://bugs.kde.org/show_bug.cgi?id=381532 In this bug report, there is also an example of how sublime text handles this, namely "Document name - path/bla", i.e. the path is appended behind the document name. What about this

D20959: Allow to change the Mode, after changing the Highlighting

nibags added a comment. The function `setDontChangeHlOnSave()` uses the `m_hlSetByUser` variable to avoid resetting the syntax highlighting, which I removed in `updateFileType()`. I could use another binary for this. INLINE COMMENTS > katedocument.cpp:1893 > > void KTextEditor::Document

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 117 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/117/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 21 May 2019 19:49:43 + Build duration: 7 min 21 sec and counting JUnit Tests Name: projectro

D21249: Test current filter before setting a new one

ngraham added a comment. Thanks. :) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D21249 To: jglogowski, #frameworks, ngraham, dfaure Cc: elvisangelaccio, ngraham, michaelweghorn, kde-frameworks-devel, michaelh, bruns

D21249: Test current filter before setting a new one

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R241:c4e90b5a6bf4: Test current filter before setting a new one (authored by jglogowski, committed by ngraham). REPOSITORY

D21249: Test current filter before setting a new one

jglogowski updated this revision to Diff 58427. jglogowski added a comment. - switch declaration KFileWidgetPrivate::findMatchingFilter from bool to QString … again Not sure how that exactly slipped in :-( REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21

D21249: Test current filter before setting a new one

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Actually looks like we've got compilation errors now: /home/dev/kde/src/kio/src/filewidgets/kfilewidget.cpp:2456:9: error: prototype for ‘QString KFileWidgetPrivate::findM

D21315: Dolphin-style view modes in the file dialog

meven marked 2 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D21315 To: meven, #frameworks, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21315: Dolphin-style view modes in the file dialog

meven updated this revision to Diff 58424. meven added a comment. Reword Allow Expansion to Allow Expansion in Details View REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21315?vs=58395&id=58424 BRANCH dolphin-view-modes REVISION DETAIL https://phabricato

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 106 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/106/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 21 May 2019 16:27:04 + Build duration: 10 min and counting BUILD ARTIFACTS acc/KF5KIO-5.59.0.xmllog

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 116 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/116/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 21 May 2019 16:26:06 + Build duration: 8 min 51 sec and counting JUnit Tests Name: projectro

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 115 - Aborted!

BUILD ABORTED Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/115/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 21 May 2019 11:10:54 + Build duration: 5 hr 14 min and counting

D21249: Test current filter before setting a new one

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Thanks! REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D21249 To: jglogowski, #frameworks, ngraham, dfaure Cc: elvisangelaccio, ngraham, michaelweghorn, kde-frameworks

D21315: Dolphin-style view modes in the file dialog

ngraham added a comment. This is fantastic. You fixed all the issues I was having, and the UX is practically perfect. The code looks totally sane too. In my testing I found only one small issue: when changing the icon size in one view and then switching to another view and then back, the fir

D21315: Dolphin-style view modes in the file dialog

ngraham added a task: T8552: Polish Open/Save dialogs. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D21315 To: meven, #frameworks, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21315: Dolphin-style view modes in the file dialog

ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D21315 To: meven, #frameworks, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21314: Don't enable QT_STRICT_ITERATORS on Windows.

dvratil accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D21314 To: dfaure, vkrause, dvratil Cc: apol, kde-frameworks-devel, kde-buildsystem, bencreasy, michaelh, ngraham,

D21315: Dolphin-style view modes in the file dialog

ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D21315 To: meven, #frameworks, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21315: Dolphin-style view modes in the file dialog

ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D21315 To: meven, #frameworks, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12326: In Short View, display icons on top and increase icon size

ngraham removed a task: T8552: Polish Open/Save dialogs. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12326 To: ngraham Cc: kde-frameworks-devel, rkflx, abetts, anemeth, michaelh, ngraham, bruns

D12326: In Short View, display icons on top and increase icon size

ngraham abandoned this revision. ngraham marked 2 inline comments as done. ngraham added a comment. Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks. Better-implemented in D21315 REPOSITORY R241 KIO REVISION DETAIL https://ph

D21249: Test current filter before setting a new one

ngraham accepted this revision. ngraham added a comment. Thanks, LGTM now! Please wait for @dfaure's review too. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D21249 To: jglogowski, #frameworks, ngraham, dfaure Cc: elvisangelaccio, ngraham, michaelweghorn, kde-framework

D21317: Manipulate bytes instead of characters

chinmoyr created this revision. chinmoyr added reviewers: bruns, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. chinmoyr requested review of this revision. REVISION SUMMARY D21155 trucates a QString. Since most L

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 105 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/105/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 21 May 2019 11:10:55 + Build duration: 30 min and counting BUILD ARTIFACTS acc/KF5KIO-5.59.0.xmllo

D18161: [kioslave/file] Add a codec for legacy filenames

This revision was automatically updated to reflect the committed changes. Closed by commit R241:6738a8b2f71c: [kioslave/file] Add a codec for legacy filenames (authored by cfeck). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D18161?vs=49684&id=58399#toc REPOSITORY R241 KIO CHANGES SI

D21313: Create specific directory for kdebugsettings categories file

mlaurent added a comment. DEBUGCATEGORIESDIR is fine for me too debug-categories5 ? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D21313 To: mlaurent, dfaure, cgiboudeaux Cc: kde-frameworks-devel, kde-buildsystem, bencreasy, michaelh, ngraham, bruns

D21314: Don't enable QT_STRICT_ITERATORS on Windows.

apol added a comment. +1 REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D21314 To: dfaure, vkrause, dvratil Cc: apol, kde-frameworks-devel, kde-buildsystem, bencreasy, michaelh, ngraham, bruns

D21315: Dolphin-style view modes in the file dialog

meven edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D21315 To: meven, #frameworks, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21315: Dolphin-style view modes in the file dialog

meven created this revision. meven added reviewers: Frameworks, ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY Add Icons, Compact and Details view to the filewidgets. Added an "Allow Exp

D21249: Test current filter before setting a new one

jglogowski updated this revision to Diff 58394. jglogowski added a comment. - const findMatchingFilter - amend comments REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21249?vs=58345&id=58394 REVISION DETAIL https://phabricator.kde.org/D21249 AFFECTED FILE

D21249: Test current filter before setting a new one

jglogowski added inline comments. INLINE COMMENTS > dfaure wrote in kfilewidgettest.cpp:88 > ... use setUrls *to* auto-select ODT filter? > > ("to" is missing) No. The first line is missing a point or semicolon, if you read the comment like a sentence. I had two independent comments in mind. O

D21313: Create specific directory for kdebugsettings categories file

cgiboudeaux added a comment. Looks mostly fine safe for the directory name that needs the major version to avoid conflicts when libfoo.categories built using KF5 will have to coexist with KF6. It needs a '5' in its name. I'm also unsure about 'KDEBUGSETTINGSDIR'. kdebugsettings is the

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 104 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/104/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 21 May 2019 07:25:29 + Build duration: 24 min and counting BUILD ARTIFACTS acc/KF5KIO-5.59.0.xmllog

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 114 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/114/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 21 May 2019 07:25:29 + Build duration: 12 min and counting JUnit Tests Name: projectroot Fai

D21314: Don't enable QT_STRICT_ITERATORS on Windows.

dfaure updated this revision to Diff 58393. dfaure added a comment. Remove unrelated change REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21314?vs=58392&id=58393 BRANCH master REVISION DETAIL https://phabricator.kde.org/D21314 AFFECTED F

D21314: Don't enable QT_STRICT_ITERATORS on Windows.

dfaure created this revision. dfaure added reviewers: vkrause, dvratil. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY Strict iterators can't be used on Windows, they lea

D20626: Rely upon QSysInfo to retrieve the system details

dfaure closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20626 To: shubham, dfaure Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns

D21249: Test current filter before setting a new one

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Almost there. Thanks for *your* patience :-) INLINE COMMENTS > kfilewidgettest.cpp:88 > +// setUrl runs with blocked signals, so use setUrls > +// auto-select ODT

D21313: Create specific directory for kdebugsettings categories file

cgiboudeaux added inline comments. INLINE COMMENTS > KDEInstallDirs.cmake:583 > _define_relative(KXMLGUI5DIR DATAROOTDIR "kxmlgui5" > "kxmlgui .rc files" > _define_relative(KTEMPLATESDIR DATAROOTDIR "kdevappwizard/templates" KXMLGUI_INSTALL_DIR) came from this line :) REPOSITORY R240 E

D21313: Create specific directory for kdebugsettings categories file

mlaurent updated this revision to Diff 58391. mlaurent added a comment. Fix comment reported by Christophe Giboudeaux REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21313?vs=58390&id=58391 BRANCH add_specific_kdebugsetting_directory REVISION