D20838: Allow to drop one file or one folder on KDirOperator

meven updated this revision to Diff 57625. meven added a comment. review feedback REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20838?vs=57599&id=57625 BRANCH arcpatch-D20838 REVISION DETAIL https://phabricator.kde.org/D20838 AFFECTED FILES autotests/

D20838: Allow to drop one file or one folder on KDirOperator

meven marked 5 inline comments as done. meven added inline comments. INLINE COMMENTS > ngraham wrote in kdiroperator.cpp:418 > Yep, I'd say so now. Any idea where I should add this information ? An example would suffice. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D2083

D21028: add multiple gestures and a handler class to KWidgetsAddons

apol added a comment. It could make sense to run clazy on these, I'm pretty sure we'd find interesting stuff. INLINE COMMENTS > koneandtwofingerswipe.h:36 > +{ > +//Q_PROPERTY(bool left READ left WRITE left) > +//Q_PROPERTY(bool right READ right WRITE right) Why is this commented ou

D21041: [Fstab] Use folder-decrypted icon for encrypting fuse mounts

bruns added a comment. F6810948: Screenshot_20190506_000345.png REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D21041 To: bruns, #frameworks, ngraham, hallas Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21041: [Fstab] Use folder-decrypted icon for encrypting fuse mounts

bruns created this revision. bruns added reviewers: Frameworks, ngraham, hallas. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY When Vaults are mounted and show up in the mtab, use the matching icon.

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.12 - Build # 28 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.12/28/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 05 May 2019 21:57:59 + Build duration: 1 min 14 sec and counting JUnit Tests Name: projectr

D20995: [Fstab] Add support for non-network filesystems

This revision was automatically updated to reflect the committed changes. Closed by commit R245:116c805ba461: [Fstab] Add support for non-network filesystems (authored by bruns). REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20995?vs=57478&id=57620 REVISION DE

D20958: New menu of syntax highlighting in the status bar

nibags updated this revision to Diff 57618. nibags added a comment. - Allow to select an item with a single click, regardless of the configuration of the system. I had forgotten that it's possible to change the settings for the click/double-click actions, now I correct it. Then it loo

D20838: Allow to drop one file or one folder on KDirOperator

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Still works great, and I have just a few code change requests. Then let's aim to land this early in the 5.59 cycle so it gets lots of testing. INLINE COMMENTS > meven wrote in

D16116: [KPropertiesDialog] Show a filename for the / directory

thsurrel added a comment. It is still missing the '/' for me, but I am on the latest releases, not on master right now. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16116 To: thsurrel, #frameworks, ngraham Cc: bruns, ngraham, kde-frameworks-devel, michaelh

D20995: [Fstab] Add support for non-network filesystems

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Hmm yeah, feels like maybe it should happen in the Panel code to use the Product rather than the Description. REPOSITORY R245 Solid BRANCH master REVISION DETAIL https://phabricat

D20958: New menu of syntax highlighting in the status bar

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Still needs the menu items to apply and close on single-click even when using the systemwide double-click mode. The option itself in System Settings Provides a clue regarding wh

D20995: [Fstab] Add support for non-network filesystems

bruns added a comment. In D20995#460439 , @ngraham wrote: > Nice! Can we make the Places panel display the product rather than the description? I don't think it's necessary to have the fs type listed there in the label. Interested parties can al

D20964: [FileWidget] Replace "Filter:" with "File type:" when saving with a limited list of mimetypes

ngraham added inline comments. INLINE COMMENTS > pino wrote in kfilewidget.cpp:2804-2806 > why is this limited to the saving mode? you can perfectly use a mimetype > filter when opening files When opening, the mimetype chooser still has filtering functionality and isn't a drop-down menu combob

D21028: add multiple gestures and a handler class to KWidgetsAddons

nicolasfella added a comment. The name "KTouch" is already used for https://kde.org/applications/education/ktouch/ REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D21028 To: steffenh, #frameworks Cc: nicolasfella, cfeck, kde-frameworks-devel, michaelh, ngraham

D20964: [FileWidget] Replace "Filter:" with "File type:" when saving with a limited list of mimetypes

pino added inline comments. INLINE COMMENTS > kfilewidget.cpp:2804-2806 > +if (operationMode == KFileWidget::Saving && > filterWidget->isMimeFilter()) { > +label = i18n("&File type:"); > +whatsThisText = i18n("This is the file type selector. It is used > to select the format

D21028: add multiple gestures and a handler class to KWidgetsAddons

ngraham added a reviewer: Frameworks. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D21028 To: steffenh, #frameworks Cc: cfeck, kde-frameworks-devel, michaelh, ngraham, bruns

D20964: [FileWidget] Replace "Filter:" with "File type:" when saving with a limited list of mimetypes

ngraham added a comment. Yep, will do. Thanks! REPOSITORY R241 KIO BRANCH file-type-when-saving-and-mimetype-is-defined (branched from master) REVISION DETAIL https://phabricator.kde.org/D20964 To: ngraham, #vdg, elvisangelaccio, GB_2 Cc: apol, kde-frameworks-devel, michaelh, ngraham,

D20964: [FileWidget] Replace "Filter:" with "File type:" when saving with a limited list of mimetypes

elvisangelaccio accepted this revision. elvisangelaccio added a comment. This revision is now accepted and ready to land. Please wait the tagging before pushing. REPOSITORY R241 KIO BRANCH file-type-when-saving-and-mimetype-is-defined (branched from master) REVISION DETAIL https://phab

D20301: Ensure to add a trailing / at the end of fstab mounted devices.

bruns added a comment. I think this is the wrong way round: man mount.cifs: > The mount.cifs utility attaches the UNC name (exported network resource) specified as service (using //server/share syntax, where "server" is the server name or IP address and "share" is the name of the sh

D20301: Ensure to add a trailing / at the end of fstab mounted devices.

meven added a comment. What do you think @bruns ? REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D20301 To: meven, bruns, lukas, broulik Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D20838: Allow to drop one file or one folder on KDirOperator

meven updated this revision to Diff 57599. meven added a comment. oops REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20838?vs=57597&id=57599 BRANCH arcpatch-D20838 REVISION DETAIL https://phabricator.kde.org/D20838 AFFECTED FILES autotests/kfilewidget

D20838: Allow to drop one file or one folder on KDirOperator

meven updated this revision to Diff 57597. meven added a comment. Clean up test code REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20838?vs=57589&id=57597 BRANCH arcpatch-D20838 REVISION DETAIL https://phabricator.kde.org/D20838 AFFECTED FILES autotes

D19420: Fix KCompressionDevice::atEnd() for uncompressed .gz files

croick added a comment. In D19420#460766 , @apol wrote: > Looks good to me, have you checked that it's now not breaking what @broulik found? Yes, I tested loading systemsettings.svg (`/usr/share/icons/breeze/apps/48/systemsettings.svg`)

D20838: Allow to drop one file or one folder on KDirOperator

meven updated this revision to Diff 57589. meven added a comment. Clean up and fix test REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20838?vs=57442&id=57589 BRANCH arcpatch-D20838 REVISION DETAIL https://phabricator.kde.org/D20838 AFFECTED FILES auto

D10910: Add unshadowed opaque variants for Breeze Light and Dark desktop themes

achauvel added a comment. Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks. I opened a bug but I didn’t have any answer so far. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/

D21028: add multiple gestures and a handler class to KWidgetsAddons

cfeck added a comment. Did you try to submit the additional gesture types to Qt? We should only add them here if they rejected the idea to add new types in Qt. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D21028 To: steffenh Cc: cfeck, kde-frameworks-devel,