D20372: [kemoticons] make it compile without foreach

This revision was automatically updated to reflect the committed changes. Closed by commit R301:7b7476efb82a: [kemoticons] make it compile without foreach (authored by mlaurent). REPOSITORY R301 KEmoticons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20372?vs=55721&id=55722 REVISI

D20372: [kemoticons] make it compile without foreach

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Looks reasonable. REPOSITORY R301 KEmoticons BRANCH compile_without_foreach REVISION DETAIL https://phabricator.kde.org/D20372 To: mlaurent, dfaure, cullmann Cc: cullmann, kde-f

D20372: [kemoticons] make it compile without foreach

mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY compile without foreach TEST PLAN autotest ok REPOSITORY R301 KEmoticons BRA

D20284: Fix l/100 km to MPG conversion

madcatx added inline comments. INLINE COMMENTS > apol wrote in fuel_efficiency.cpp:36 > I'm not sure I understand what isReciprocal means here. l/100 km (amount of fuel needed to cross a given distance) is reciprocal to MPG (distance crossed with a given amount of fuel). KUnitConverter can only

Re: New framework: KCalCore

вс, 7 апр. 2019 г. в 17:24, Alexander Potashev : > > вс, 7 апр. 2019 г. в 15:45, Volker Krause : > > Hi, > > > > I'd like to propose KCalCore for review to move from KDE PIM to KF5. > > > > KCalCore is an implementation of the iCalendar standard based on libical, > > covering the data model, input/

D20284: Fix l/100 km to MPG conversion

apol added inline comments. INLINE COMMENTS > fuel_efficiency.cpp:36 > +const KLocalizedString &realString, const > KLocalizedString &integerString, > +const bool isReciprocal = false) > : UnitPrivate(categoryId, id, multiplier, I'm not sure I un

D20367: Add alternatives icon

ngraham added a comment. I like the arrows. But is that little window icon really the best we can do to represent a widget? The presence of a titlebar makes it look like an app window, not a widget. For that matter //do// we have a generic icon for widgets? I know we don't for apps (and

D20367: Add alternatives icon

GB_2 edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20367 To: GB_2, #vdg Cc: kde-frameworks-devel, #vdg, michaelh, ngraham, bruns

D20367: Add alternatives icon

GB_2 created this revision. GB_2 added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. GB_2 requested review of this revision. REVISION SUMMARY Add a more appropriate icon for "Alternative Widgets". TEST PLAN Search for "alternatives" in C

D20366: Postpone term parsing until needed, do not set both term and searchstring

This revision was automatically updated to reflect the committed changes. Closed by commit R293:6f065327: Postpone term parsing until needed, do not set both term and searchstring (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20366?vs=5

D20366: Postpone term parsing until needed, do not set both term and searchstring

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH kio_search REVISION DETAIL https://phabricator.kde.org/D20366 To: bruns, #baloo, #frameworks, ngraham, astippich, poboiko Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov,

D20366: Postpone term parsing until needed, do not set both term and searchstring

bruns created this revision. bruns added reviewers: Baloo, Frameworks, ngraham, astippich, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY `Query::toJSON()` adds both the term and search

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

meven marked 2 inline comments as done. REPOSITORY R241 KIO BRANCH arcpatch-D20096 REVISION DETAIL https://phabricator.kde.org/D20096 To: meven, #frameworks, dfaure, fvogt, bruns, broulik Cc: pino, bcooksley, ngraham, kde-frameworks-devel, michaelh, bruns

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

meven marked an inline comment as done. meven added inline comments. INLINE COMMENTS > pino wrote in ConfigureChecks.cmake:19 > sorry, i realized that my sentence was ambiguous: i meant to check for the > existance of statx no matter the platform We discussed previously that we would restrict u

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

pino added inline comments. INLINE COMMENTS > pino wrote in ConfigureChecks.cmake:19 > just do the test unconditionally sorry, i realized that my sentence was ambiguous: i meant to check for the existance of statx no matter the platform REPOSITORY R241 KIO BRANCH arcpatch-D20096 REVISION

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

meven updated this revision to Diff 55709. meven marked 4 inline comments as done. meven added a comment. review feedback REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20096?vs=55683&id=55709 BRANCH arcpatch-D20096 REVISION DETAIL https://phabricator.kde

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.10 - Build # 33 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.10/33/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 07 Apr 2019 19:49:32 + Build duration: 9 min 12 sec and counting BUILD ARTIFACTS abi-compati

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 29 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/29/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 07 Apr 2019 19:49:32 + Build duration: 3 min 17 sec and counting BUILD ARTIFACTS acc/KF5Core

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.12 - Build # 34 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.12/34/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 07 Apr 2019 19:49:32 + Build duration: 1 min 36 sec and counting JUnit Tests Name: pr

D20352: Skip running benchmarks when in debug mode.

dfaure closed this revision. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D20352 To: dfaure, bcooksley, mwolff Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D11882: autotests: Use built executable instead of installed

bruns abandoned this revision. bruns added a comment. Obsoleted by D19268 REPOSITORY R824 Baloo Widgets REVISION DETAIL https://phabricator.kde.org/D11882 To: bruns, elvisangelaccio, #baloo, #frameworks, michaelh Cc: astippich, bruns, alexeymin, genna

D11882: autotests: Use built executable instead of installed

bruns commandeered this revision. bruns added a reviewer: michaelh. REPOSITORY R824 Baloo Widgets REVISION DETAIL https://phabricator.kde.org/D11882 To: bruns, elvisangelaccio, #baloo, #frameworks, michaelh Cc: astippich, bruns, alexeymin, gennad, domson, ashaposhnikov, spoorun, abrahams

D11882: autotests: Use built executable instead of installed

astippich added a comment. @bruns this diff tries to accomplish the same as D19268 , and can be closed, right? REPOSITORY R824 Baloo Widgets REVISION DETAIL https://phabricator.kde.org/D11882 To: michaelh, elvisangelaccio, #baloo, #frameworks Cc: asti

D20364: Dont add default valued date filters to json

This revision was automatically updated to reflect the committed changes. Closed by commit R293:ff630d96ec78: Dont add default valued date filters to json (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20364?vs=55700&id=55706 REVISION DETAI

D20345: Use compact Json format when converting query URLs

This revision was automatically updated to reflect the committed changes. Closed by commit R293:e1b9e2605617: Use compact Json format when converting query URLs (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20345?vs=55655&id=55704 REVISION

D20345: Use compact Json format when converting query URLs

astippich accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH kio_search REVISION DETAIL https://phabricator.kde.org/D20345 To: bruns, #baloo, #frameworks, ngraham, astippich, poboiko Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.12 - Build # 47 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.12/47/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 07 Apr 2019 18:44:24 + Build duration: 12 min and counting BUILD ARTIFACTS acc/KF5Baloo-5.57.0.xml

D20364: Dont add default valued date filters to json

astippich accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH kio_search REVISION DETAIL https://phabricator.kde.org/D20364 To: bruns, #baloo, #frameworks, ngraham, astippich, poboiko Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov

D20358: Force en locale for propertyinfotest

bruns added inline comments. INLINE COMMENTS > astippich wrote in propertyinfotest.cpp:51 > "en_US" also fixes the test for me... Can you open a upstream Qt bug for the differences you see between C and en_US? REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20358

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 72 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/72/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 07 Apr 2019 18:44:15 + Build duration: 2 min 10 sec and counting BUILD ARTIFACTS acc/KF5F

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 77 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/77/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 07 Apr 2019 18:44:15 + Build duration: 2 min 42 sec and counting BUILD ARTIFACTS abi-comp

KDE CI: Frameworks » kfilemetadata » kf5-qt5 FreeBSDQt5.12 - Build # 77 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20FreeBSDQt5.12/77/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 07 Apr 2019 18:44:15 + Build duration: 1 min 49 sec and counting JUnit Tests Name:

D20358: Force en locale for propertyinfotest

astippich added inline comments. INLINE COMMENTS > bruns wrote in propertyinfotest.cpp:51 > This is somewhat strange ... > > According to > https://doc.qt.io/qt-5/qlocale.html#Language-enum > > > The "C" locale is identical in behavior to English/UnitedStates. > > So either "en" is not "en_US"

D20360: Test all extractors with strict mime type

This revision was automatically updated to reflect the committed changes. Closed by commit R286:0cfa32c2a376: Test all extractors with strict mime type (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20360?vs=55692&id=55703 REVIS

D20328: [balooshow] Do not print a bogus warning for a non-indexed file

This revision was automatically updated to reflect the committed changes. Closed by commit R293:e05514aa6469: [balooshow] Do not print a bogus warning for a non-indexed file (authored by bruns). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D20328?vs=55694&id=55702#toc REPOSITORY R293

D20328: [balooshow] Do not print a bogus warning for a non-indexed file

bruns added inline comments. INLINE COMMENTS > astippich wrote in main.cpp:136 > Also add a space here after "Url:"? Yes, will add it. REPOSITORY R293 Baloo BRANCH master REVISION DETAIL https://phabricator.kde.org/D20328 To: bruns, #baloo, #frameworks, ngraham, astippich, poboiko Cc:

D20328: [balooshow] Do not print a bogus warning for a non-indexed file

astippich accepted this revision. astippich added a comment. This revision is now accepted and ready to land. only one minor nitpick INLINE COMMENTS > main.cpp:136 > > +stream << "Url:" << url << "\n"; > stream << "GivenID: " << fid << " ActualID: " << actua

D20352: Skip running benchmarks when in debug mode.

bcooksley accepted this revision. bcooksley added a comment. This revision is now accepted and ready to land. Thanks David, this looks good to me! REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D20352 To: dfaure, bcooksley, mwolff Cc: kde-framewo

D20364: Dont add default valued date filters to json

bruns created this revision. bruns added reviewers: Baloo, Frameworks, ngraham, astippich, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Commit 41d5013e5b7c

D20358: Force en locale for propertyinfotest

bruns added inline comments. INLINE COMMENTS > propertyinfotest.cpp:51 > if (!m_useLocalization) { > -QLocale().setDefault(QLocale::c()); > +QLocale().setDefault(QLocale(QStringLiteral("en"))); > } This is somewhat strange ... According to https://doc.qt.io/qt-5/qlocal

D20360: Test all extractors with strict mime type

bruns accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH test_mimetypes REVISION DETAIL https://phabricator.kde.org/D20360 To: astippich, bruns Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, astippich,

D20328: [balooshow] Do not print a bogus warning for a non-indexed file

bruns added inline comments. INLINE COMMENTS > ngraham wrote in main.cpp:139 > Why were all these spaces after the colons removed? confused this with a debug stream ... REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D20328 To: bruns, #baloo, #frameworks, ngraham, astipp

D20328: [balooshow] Do not print a bogus warning for a non-indexed file

bruns marked an inline comment as done. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D20328 To: bruns, #baloo, #frameworks, ngraham, astippich, poboiko Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

pino added inline comments. INLINE COMMENTS > ConfigureChecks.cmake:19 > + > +if (LIBC_IS_GLIBC) > +check_cxx_source_compiles(" just do the test unconditionally > ConfigureChecks.cmake:24 > +int main() { > + int t = STATX_BASIC_STATS; > + return 0; other than this

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 76 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/76/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 07 Apr 2019 17:00:20 + Build duration: 2 min 40 sec and counting BUILD ARTIFACTS abi-comp

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 71 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/71/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 07 Apr 2019 17:00:20 + Build duration: 2 min 9 sec and counting BUILD ARTIFACTS acc/KF5Fi

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 SUSEQt5.12 - Build # 27 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20SUSEQt5.12/27/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 07 Apr 2019 17:00:50 + Build duration: 1 min 24 sec and counting Cobertura Report

KDE CI: Frameworks » kfilemetadata » kf5-qt5 FreeBSDQt5.12 - Build # 76 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20FreeBSDQt5.12/76/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 07 Apr 2019 17:00:20 + Build duration: 1 min 9 sec and counting JUnit Tests Name: p

D20328: [balooshow] Do not print a bogus warning for a non-indexed file

bruns updated this revision to Diff 55694. bruns added a comment. readd erroneously removed spaces REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20328?vs=55608&id=55694 BRANCH master REVISION DETAIL https://phabricator.kde.org/D20328 AFFECTED FILES

D20349: Unconditionally enable -DQT_STRICT_ITERATORS, not just in debug mode

dfaure closed this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D20349 To: dfaure, dvratil, mlaurent, aacid Cc: aacid, kde-buildsystem, kde-frameworks-devel, bencreasy, michaelh, ngraham, bruns

D20349: Unconditionally enable -DQT_STRICT_ITERATORS, not just in debug mode

aacid accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D20349 To: dfaure, dvratil, mlaurent, aacid Cc: aacid, kde-buildsystem, kde-frameworks-devel, bencreasy, michaelh, n

Re: New framework: KCalCore

El diumenge, 7 d’abril de 2019, a les 14:45:09 CEST, Volker Krause va escriure: > Hi, > > I'd like to propose KCalCore for review to move from KDE PIM to KF5. Does exceptions.h need a d-pointer? Cheers, Albert

Re: New framework: KContacts

El dissabte, 6 d’abril de 2019, a les 18:01:09 CEST, Volker Krause va escriure: > Hi, > > I'd like to propose KContacts for review to move from KDE PIM to KF5. ## QUESTION 1 ## Does VCardTool need a d-pointer? Should it be a namespace instead of a class? It's a class with no members, seems a bi

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 75 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/75/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 07 Apr 2019 16:38:29 + Build duration: 4 min 35 sec and counting BUILD ARTIFACTS abi-comp

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 74 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/74/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 07 Apr 2019 16:28:44 + Build duration: 9 min 43 sec and counting BUILD ARTIFACTS abi-comp

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 70 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/70/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 07 Apr 2019 16:30:59 + Build duration: 3 min 2 sec and counting BUILD ARTIFACTS acc/KF5Fi

KDE CI: Frameworks » kfilemetadata » kf5-qt5 FreeBSDQt5.12 - Build # 75 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20FreeBSDQt5.12/75/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 07 Apr 2019 16:30:59 + Build duration: 1 min 29 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 69 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/69/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 07 Apr 2019 16:28:44 + Build duration: 2 min 8 sec and counting BUILD ARTIFACTS acc/KF5Fi

KDE CI: Frameworks » kfilemetadata » kf5-qt5 FreeBSDQt5.12 - Build # 74 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20FreeBSDQt5.12/74/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 07 Apr 2019 16:28:44 + Build duration: 1 min 18 sec and counting JUnit Tests Name:

D20360: Test all extractors with strict mime type

astippich created this revision. astippich added a reviewer: bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Test all the extractors with the strictMimeType function Fortunatel

D20120: Use new mimetype helper in taglib extractor test

This revision was automatically updated to reflect the committed changes. Closed by commit R286:0d9aebdd05b5: Use new mimetype helper in taglib extractor test (authored by astippich). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D20120?vs=55058&id=55691#toc REPOSITORY R286 KFileMetaDa

D20349: Unconditionally enable -DQT_STRICT_ITERATORS, not just in debug mode

dfaure added a comment. All the modules that use this cmake file, already build fine in debug mode with strict iterators. This enables the same setting in release mode, for code that already builds fine in debug mode. So unless people have bad code in #ifndef NDEBUG, I don't expect this to

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 68 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/68/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 07 Apr 2019 16:15:44 + Build duration: 7 min 55 sec and counting BUILD ARTIFACTS acc/KF5F

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 73 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/73/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 07 Apr 2019 16:18:26 + Build duration: 2 min 24 sec and counting BUILD ARTIFACTS abi-comp

D20120: Use new mimetype helper in taglib extractor test

bruns accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH mimetype_tests REVISION DETAIL https://phabricator.kde.org/D20120 To: astippich, bruns Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, astippich,

KDE CI: Frameworks » kfilemetadata » kf5-qt5 FreeBSDQt5.12 - Build # 73 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20FreeBSDQt5.12/73/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 07 Apr 2019 16:17:27 + Build duration: 1 min 0 sec and counting JUnit Tests Name: p

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 72 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/72/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 07 Apr 2019 16:15:44 + Build duration: 2 min 40 sec and counting BUILD ARTIFACTS abi-comp

D20136: [UserMetaData] Handle changes in attribute data size correctly

This revision was automatically updated to reflect the committed changes. Closed by commit R286:08fb5f2e5c3a: [UserMetaData] Handle changes in attribute data size correctly (authored by bruns). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20136?vs=5509

KDE CI: Frameworks » kfilemetadata » kf5-qt5 FreeBSDQt5.12 - Build # 72 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20FreeBSDQt5.12/72/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 07 Apr 2019 16:15:44 + Build duration: 1 min 41 sec and counting JUnit Tests Name:

D20133: [UserMetaData] Untangle Windows, Linux/BSD/Mac and stub code.

This revision was automatically updated to reflect the committed changes. Closed by commit R286:1e3f84f00620: [UserMetaData] Untangle Windows, Linux/BSD/Mac and stub code. (authored by bruns). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20133?vs=55088

D20120: Use new mimetype helper in taglib extractor test

astippich added a comment. ping REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20120 To: astippich, bruns Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D20133: [UserMetaData] Untangle Windows, Linux/BSD/Mac and stub code.

astippich accepted this revision. astippich added a comment. This revision is now accepted and ready to land. Still kind of hard to read, especially on phabricator. Anyway, a definite improvement. Untested on anything besides linux REPOSITORY R286 KFileMetaData BRANCH master REVISION

D20359: Fix rating write for mp4 in newer TagLib versions

astippich created this revision. astippich added a reviewer: bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY This fixes reading and writing rating via the mp4 rate atom. This d

D20349: Unconditionally enable -DQT_STRICT_ITERATORS, not just in debug mode

aacid added a comment. Are we sure we don't break code by introducing this? Or we're just going to play Whac-A-Mole with compile errors until all it's compiling again? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D20349 To: dfaure, dvratil, mlaurent Cc

D20358: Force en locale for propertyinfotest

astippich created this revision. astippich added a reviewer: bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Fix CI propertyinfotest REPOSITORY R286 KFileMetaData BRANCH fi

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

dfaure added a comment. The month of testing starts today. Code pushed to master starting from today will end up in 5.58. REPOSITORY R241 KIO BRANCH arcpatch-D20096 REVISION DETAIL https://phabricator.kde.org/D20096 To: meven, #frameworks, dfaure, fvogt, bruns, broulik Cc: pino, bcoo

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

meven added inline comments. INLINE COMMENTS > ConfigureChecks.cmake:19 > + > +if (LIBC_IS_GLIBC) > +check_cxx_source_compiles(" I am not sure this is acceptable, this variable is set by ECM in extra-cmake-modules/kde-modules/KDECompilerSettings.cmake REPOSITORY R241 KIO BRANCH arcpat

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

meven marked an inline comment as done. REPOSITORY R241 KIO BRANCH arcpatch-D20096 REVISION DETAIL https://phabricator.kde.org/D20096 To: meven, #frameworks, dfaure, fvogt, bruns, broulik Cc: pino, bcooksley, ngraham, kde-frameworks-devel, michaelh, bruns

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

meven updated this revision to Diff 55683. meven added a comment. Remove reference to old differential revision from the commit comment REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20096?vs=55679&id=55683 BRANCH arcpatch-D20096 REVISION DETAIL https://p

D20087: Enable glGetGraphicsResetStatus support by default on Qt >= 5.13

This revision was automatically updated to reflect the committed changes. Closed by commit R296:c244729b6771: Enable glGetGraphicsResetStatus support by default on Qt >= 5.13 (authored by davidedmundson). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D200

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

meven edited the summary of this revision. REPOSITORY R241 KIO BRANCH arcpatch-D20096 REVISION DETAIL https://phabricator.kde.org/D20096 To: meven, #frameworks, dfaure, fvogt, bruns, broulik Cc: pino, bcooksley, ngraham, kde-frameworks-devel, michaelh, bruns

D20216: Export path of kwalletd binary for kwallet_pam

This revision was automatically updated to reflect the committed changes. Closed by commit R311:f38c007cc770: Export path of kwalletd binary for kwallet_pam (authored by davidedmundson). REPOSITORY R311 KWallet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20216?vs=55316&id=55681 R

D19986: Install .desktop file for kded5

This revision was automatically updated to reflect the committed changes. Closed by commit R297:496b785f2218: Install .desktop file for kded5 (authored by davidedmundson). REPOSITORY R297 KDED CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19986?vs=54588&id=55680 REVISION DETAIL h

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

meven marked an inline comment as done. meven added a comment. In D20096#445410 , @ngraham wrote: > BTW Frameworks 5.57 has been tagged, so whenever folks are good with this, it can be landed at any time. :) I think this would be best to

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

meven marked an inline comment as done. meven added inline comments. INLINE COMMENTS > pino wrote in file.cpp:72-74 > TBH, instead of this static define, I'd do a proper cmake check (see > ConfigureChecks.cmake, and config-kioslave-file.h.cmake in src/ioslaves/file). It was not too easy to do.

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

meven updated this revision to Diff 55679. meven added a comment. Use proper cmake check, fix an issue with KIO::UDSEntry::UDS_DEVICE_ID having value of stat_mode instead of stat_dev REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20096?vs=55644&id=55679 BRANC

D7423: [WIP/assistance needed] Populate UDS_CREATION_TIME on Linux if statx system call is available

ngraham abandoned this revision. ngraham added a comment. Yep, I'm happy to. So glad to see that the feature's going in soon! REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7423 To: ngraham, dfaure, broulik, elvisangelaccio, #frameworks, #dolphin, fvogt Cc: huftis, dako

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

ngraham added a comment. BTW Frameworks 5.57 has been tagged, so whenever folks are good with this, it can be landed at any time. :) REPOSITORY R241 KIO BRANCH arcpatch-D20096 REVISION DETAIL https://phabricator.kde.org/D20096 To: meven, #frameworks, dfaure, fvogt, bruns, broulik Cc:

Re: New framework: KCalCore

вс, 7 апр. 2019 г. в 15:45, Volker Krause : > Hi, > > I'd like to propose KCalCore for review to move from KDE PIM to KF5. > > KCalCore is an implementation of the iCalendar standard based on libical, > covering the data model, input/output and the rather complex recurrence > algorithms defined in

KDE CI: Frameworks » khtml » kf5-qt5 WindowsMSVCQt5.11 - Build # 38 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/khtml/job/kf5-qt5%20WindowsMSVCQt5.11/38/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Sun, 07 Apr 2019 09:41:12 + Build duration: 4 hr 32 min and counting JUnit Tests Name: pr

D19446: DocumentPrivate: Support auto bracket in block selection mode

This revision was automatically updated to reflect the committed changes. Closed by commit R39:ad4cd4a72508: DocumentPrivate: Support auto bracket in block selection mode (authored by loh.tar). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19446?vs=55355&i

KDE CI: Frameworks » kiconthemes » kf5-qt5 WindowsMSVCQt5.11 - Build # 51 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kiconthemes/job/kf5-qt5%20WindowsMSVCQt5.11/51/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Sun, 07 Apr 2019 08:59:37 + Build duration: 4 hr 45 min and counting JUnit Tests N

D20352: Skip running benchmarks when in debug mode.

dfaure created this revision. dfaure added reviewers: bcooksley, mwolff. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY The results make no sense without compiler optimizations, and those heavy ben

D20349: Unconditionally enable -DQT_STRICT_ITERATORS, not just in debug mode

dfaure created this revision. dfaure added reviewers: dvratil, mlaurent. Herald added projects: Frameworks, Build System. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY It turns out QT_STRICT_ITERATORS does not introduce any overhead

D20233: Add syntax highlighting for fish shell

cullmann added a comment. If you think you nearly changed everything, I guess MIT is ok. If you think still too much is derived, I can live with LGPL ;=) I let you decide. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D20233 To: adiestelhorst, #frame

D20221: AppArmor: don't highlight variable assignments and alias rules within profiles

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. See no obvious issues, please commit, thanks! REPOSITORY R216 Syntax Highlighting BRANCH arcpatch-D20221 REVISION DETAIL https://phabricator.kde.org/D20221 To: nibags, #framewor

KDE CI: Frameworks » kdoctools » kf5-qt5 WindowsMSVCQt5.11 - Build # 47 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kdoctools/job/kf5-qt5%20WindowsMSVCQt5.11/47/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Sun, 07 Apr 2019 08:39:44 + Build duration: 4 hr 37 min and counting JUnit Tests Name

D19446: DocumentPrivate: Support auto bracket in block selection mode

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. The new functionality works ok enough for me. For the other issues you found with the cursor updates and the range stuff I would like different patches if we want to tackle them. R

New framework: KCalCore

Hi, I'd like to propose KCalCore for review to move from KDE PIM to KF5. KCalCore is an implementation of the iCalendar standard based on libical, covering the data model, input/output and the rather complex recurrence algorithms defined in that standard. It's used outside of KDE PIM as well,

D20345: Use compact Json format when converting query URLs

bruns created this revision. bruns added reviewers: Baloo, Frameworks, ngraham, astippich, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY There is no need for indenting (less data to tr

  1   2   3   4   >