D19812: Add a web page to view and compare icons of different sizes

guoyunhe added a comment. F6709477: image.png REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19812 To: guoyunhe, ngraham, #vdg, ndavis, #breeze Cc: bcooksley, ngraham, kde-frameworks-devel, michaelh, bruns

D19812: Add a web page to view and compare icons of different sizes

guoyunhe updated this revision to Diff 54533. guoyunhe added a comment. Add color blind mode REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19812?vs=54532&id=54533 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19812 AFFECTED FILES

D19965: kactivities: remove unused variable

carneirogustavo added a reviewer: KActivities. REPOSITORY R6 KActivities REVISION DETAIL https://phabricator.kde.org/D19965 To: carneirogustavo, #kactivities Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19812: Add a web page to view and compare icons of different sizes

guoyunhe updated this revision to Diff 54532. guoyunhe added a comment. Move build files to CMake build directory REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19812?vs=54257&id=54532 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19

D19934: [kded] compile without foreach

This revision was automatically updated to reflect the committed changes. Closed by commit R297:0de849663e98: [kded] compile without foreach (authored by mlaurent). REPOSITORY R297 KDED CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19934?vs=54465&id=54531 REVISION DETAIL https://

D19935: [KCMUTILS] compile without foreach

This revision was automatically updated to reflect the committed changes. Closed by commit R295:50a8a30bcc1e: [KCMUTILS] compile without foreach (authored by mlaurent). REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19935?vs=54466&id=54530 REVISION DETAIL

D19965: kactivities: remove unused variable

carneirogustavo created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. carneirogustavo requested review of this revision. REVISION SUMMARY Signed-off-by: Gustavo Carneiro REPOSITORY R6 KActivities BRANCH remove_unused_variable REVISION

D19961: Properly fix copy constructor

bruns created this revision. bruns added reviewers: Baloo, Frameworks, ngraham, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Instead of printing a warning (which probably nobody would

D19960: bluez-qt: remove warnings

carneirogustavo retitled this revision from "remove warnings" to "bluez-qt: remove warnings". REPOSITORY R269 BluezQt REVISION DETAIL https://phabricator.kde.org/D19960 To: carneirogustavo, andreagenor, tcanabrava, patrickelectric Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19960: remove warnings

carneirogustavo created this revision. carneirogustavo added reviewers: andreagenor, tcanabrava, patrickelectric. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. carneirogustavo requested review of this revision. REVISION SUMMARY Signed-off-by: Gustavo Carnei

D19935: [KCMUTILS] compile without foreach

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R295 KCMUtils BRANCH compile_without_foreach (branched from master) REVISION DETAIL https://phabricator.kde.org/D19935 To: mlaurent, dfaure, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19934: [kded] compile without foreach

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R297 KDED BRANCH compile_without_foreach (branched from master) REVISION DETAIL https://phabricator.kde.org/D19934 To: mlaurent, dfaure, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19298: Make it compile without foreach

hindenburg added a comment. FYI, this breaks mac building since there's a foreach in src/backends/mac/kauth-policy-gen-mac.cpp; also a few under src/backends/fake REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D19298 To: mlaurent, dfaure Cc: hindenburg, kde-frameworks

D19945: Update link to fsearch project

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R304 KNewStuff BRANCH update-fsearch-link REVISION DETAIL https://phabricator.kde.org/D19945 To: meven, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

ndavis added a comment. You need to make the icons on 16x16px and 22x22px canvases. If you use a grid with 1 line every pixel, it will be easier to make icons look sharp. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19952 To: arvidhansson, #vdg, ndavis Cc: n

D19956: ki18n: updating memory manager and removing compile warnings

aacid added a comment. -1 AFAIK this is a copy from upstream, we probably don't want to deviate from it REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D19956 To: carneirogustavo, andreagenor, tcanabrava, patrickelectric Cc: aacid, kde-frameworks-devel, michaelh, ngrah

D19956: ki18n: updating memory manager and removing compile warnings

carneirogustavo added a reviewer: patrickelectric. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D19956 To: carneirogustavo, andreagenor, tcanabrava, patrickelectric Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19956: ki18n: updating memory manager and removing compile warnings

carneirogustavo created this revision. carneirogustavo added reviewers: andreagenor, tcanabrava. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. carneirogustavo requested review of this revision. REVISION SUMMARY Signed-off-by: Gustavo Carneiro REPOSITORY

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

arvidhansson added a comment. In D19952#435940 , @ndavis wrote: > That "1" is too blurry. Did you use the font tool or did you draw it with the pen or rectangle tools? I used the font tool in Inkscape and pasted the 1 in the input-caps-on

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 51 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/51/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Thu, 21 Mar 2019 20:35:24 + Build duration: 1 hr 25 min and counting JUnit Tests Name

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 50 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/50/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Thu, 21 Mar 2019 18:15:40 + Build duration: 2 hr 19 min and counting JUnit Tests Name

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

ndavis added a reviewer: ndavis. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19952 To: arvidhansson, #vdg, ndavis Cc: ndavis, kde-frameworks-devel, michaelh, ngraham, bruns

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

ndavis added a comment. That "1" is too blurry. Did you use the font tool or did you draw it with the pen or rectangle tools? Since this is "numlock" Wouldn't it make more sense to put a "1" inside of a lock? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

arvidhansson edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19952 To: arvidhansson, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

ndavis added a reviewer: VDG. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19952 To: arvidhansson, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

arvidhansson created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. arvidhansson requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH num-lock-patch (branched from master) REVISION DETAIL https://phabricator.kde.org/D19

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 39 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/39/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 21 Mar 2019 18:37:15 + Build duration: 16 min and counting BUILD ARTIFACTS abi-compati

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 47 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/47/ Project: kf5-qt5 SUSEQt5.10 Date of build: Thu, 21 Mar 2019 18:37:15 + Build duration: 11 min and counting BUILD ARTIFACTS abi-compati

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 38 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/38/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 21 Mar 2019 18:15:40 + Build duration: 21 min and counting BUILD ARTIFACTS abi-compati

D19907: Add Theme::blurBehindEnabled()

This revision was automatically updated to reflect the committed changes. Closed by commit R242:fb1a332948e3: Add Theme::blurBehindEnabled() (authored by kossebau). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19907?vs=54417&id=54501 REVI

KDE CI: Frameworks » plasma-framework » kf5-qt5 WindowsMSVCQt5.11 - Build # 132 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20WindowsMSVCQt5.11/132/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Thu, 21 Mar 2019 18:15:40 + Build duration: 16 min and counting JUnit Tests

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 46 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/46/ Project: kf5-qt5 SUSEQt5.10 Date of build: Thu, 21 Mar 2019 18:15:40 + Build duration: 15 min and counting BUILD ARTIFACTS abi-compati

D19907: Add Theme::blurBehindEnabled()

davidedmundson accepted this revision. REPOSITORY R242 Plasma Framework (Library) BRANCH addblurbehindflag REVISION DETAIL https://phabricator.kde.org/D19907 To: kossebau, #plasma, davidedmundson Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19786: Fix WebDAV directory renaming if KeepAlive is off

hoffmannrobert added a comment. In D19786#433580 , @sitter wrote: > setting server to keepalive=false? what is this? the 90's? :O Perhaps they are low on memory? I don't know, I can't change that. > wouldn't it be simpler to `finishDa

D19786: Fix WebDAV directory renaming if KeepAlive is off

hoffmannrobert updated this revision to Diff 54496. hoffmannrobert added a comment. - Call resetSessionSettings() REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19786?vs=53956&id=54496 BRANCH fix_webdav_rename_directory REVISION DETAIL https://phabricator

D19945: Update link to fsearch project

meven created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY fsearch.org seems to be domain squatting. REPOSITORY R304 KNewStuff BRANCH update-fsearch-link REVISION DETAIL http

D19939: Avoid failing installation via temporary dir due to file name clashes

kossebau added a comment. So the solution would be to cache the calculated result. Which would also allow to have this as flag for some proper post-install cleanup once that is sorted out and defined. Problem is: `KNSCore::Installation` is an exported class, with an installed header. So

D19939: Avoid failing installation via temporary dir due to file name clashes

kossebau planned changes to this revision. kossebau added a comment. Found a flaw: this will result in a different path on every call of the method for the same object, which can happen. Needs more thought. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D19939 To:

D19923: Improve the KCM error message

This revision was automatically updated to reflect the committed changes. Closed by commit R295:e51e8e1e34fd: Improve the KCM error message (authored by GB_2). REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19923?vs=54437&id=54479 REVISION DETAIL https://p

D19929: [kparts] compile without foreacg

mlaurent added a comment. Argg I don't understand... I used 'git ci --amend' and it doesn't wotk when I used arc land... Sorry for your script... REPOSITORY R306 KParts REVISION DETAIL https://phabricator.kde.org/D19929 To: mlaurent, dfaure Cc: kde-frameworks-devel, michaelh, ngraham,

D19929: [kparts] compile without foreacg

This revision was automatically updated to reflect the committed changes. Closed by commit R306:921f1f1fe09d: [kparts] compile without foreacg (authored by mlaurent). REPOSITORY R306 KParts CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19929?vs=54454&id=54478 REVISION DETAIL http

D19939: Avoid failing installation via temporary dir due to file name clashes

kossebau added a reviewer: apol. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D19939 To: kossebau, #frameworks, leinir, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19939: Avoid failing installation via temporary dir due to file name clashes

kossebau created this revision. kossebau added reviewers: Frameworks, leinir. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY When installing to a temporary dir, there could be file name clashes a

D19824: KFileWidget In saving single file mode an enter/return press on the KDirOperator triggers slotOk

meven added a reviewer: dfaure. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D19824 To: meven, #frameworks, #dolphin, ngraham, dfaure Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D19598: DocumentPrivate: Skip auto quotes when these looks already balanced

cullmann added a comment. For "Is the fix-in number right?" I think yes ;=) REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19598 To: loh.tar, #ktexteditor, cullmann, mwolff Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson, michaelh, ngraham,

D19598: DocumentPrivate: Skip auto quotes when these looks already balanced

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Given we have some test that ensures the new behavior is not broken again, I have no issues with merging this. Did you get your account yet or shall I push? REPOSITORY R39 KTextEdit

D19887: Proposal for KFileItem to skip stat()

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. The use case for this needs to be documented in the constructor. I am not sure I am in favour of this because it breaks mimetype determination from contents, which is part of the

D19929: [kparts] compile without foreacg

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Patch OK but please fix typo in commit log before pushing. It matters for my changelog-filtering script :-) REPOSITORY R306 KParts BRANCH compile_without_foreach (branched from master)