D19935: [KCMUTILS] compile without foreach

mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY compile without foreach TEST PLAN autotest ok REPOSITORY R295 KCMUtils BRANC

D19934: [kded] compile without foreach

mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY compile without foreach TEST PLAN autotest ok REPOSITORY R297 KDED BRANCH

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.12 - Build # 23 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.12/23/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 21 Mar 2019 04:52:52 + Build duration: 10 min and counting BUILD ARTIFACTS abi-compatibility-re

D19903: Fix build with msvc

aacid added a comment. In D19903#435469 , @vonreth wrote: > Msvc2017. > I think frameworks is still c++11? Not sure, probably yes. REPOSITORY R159 KActivities Statistics REVISION DETAIL https://phabricator.kde.org/D19903 To: vonr

D19923: Improve the KCM error message

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R295 KCMUtils BRANCH improve-kcm-error-message (branched from master) REVISION DETAIL https://phabricator.kde.org/D19923 To: GB_2, #plasma, #vdg, ngraham Cc: #vdg, kde-frameworks-devel, #plasma, mi

D19903: Fix build with msvc

vonreth added a comment. Msvc2017. I think frameworks is still c++11? REPOSITORY R159 KActivities Statistics REVISION DETAIL https://phabricator.kde.org/D19903 To: vonreth, mlaurent, davidedmundson, aacid Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.12 - Build # 16 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.12/16/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Wed, 20 Mar 2019 12:42:29 + Build duration: 9 hr 7 min and counting JUnit Tests Name: project

D19930: [kwallets] compile without foreach

mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY compile without foreach TEST PLAN autotest ok REPOSITORY R311 KWallet BRANCH

D19929: [kparts] compile without foreacg

mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY compile without foreach TEST PLAN autotest ok REPOSITORY R306 KParts BRANCH

KDE CI: Frameworks » baloo » kf5-qt5 FreeBSDQt5.12 - Build # 40 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20FreeBSDQt5.12/40/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Wed, 20 Mar 2019 09:01:35 + Build duration: 11 hr and counting JUnit Tests Name: projectroot.auto

D19903: Fix build with msvc

aacid added a comment. Which MSVC is that? it seems the decltype change is workarounding non C++14 support? REPOSITORY R159 KActivities Statistics REVISION DETAIL https://phabricator.kde.org/D19903 To: vonreth, mlaurent, davidedmundson, aacid Cc: kde-frameworks-devel, michaelh, ngraham,

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.12 - Build # 22 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.12/22/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 20 Mar 2019 16:42:28 + Build duration: 14 min and counting BUILD ARTIFACTS abi-compatibility-re

D19923: Improve the KCM error message

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. GB_2 requested review of this revision. REVISION SUMMARY Improve the KCM error message. TEST PLAN Open a broken KCM. To get one, remove for examp

D19895: Use https for links in the UI and documentation

vkrause updated this revision to Diff 54435. vkrause added a comment. Update konqueror.org link. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19895?vs=54356&id=54435 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19895 AFFECTED FILES docs

D19891: Use https for the pastebin backend and publicly accessible documentation

This revision was automatically updated to reflect the committed changes. Closed by commit R495:fbd859319a80: Use https for the pastebin backend and publicly accessible documentation (authored by vkrause). REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/

D19917: Additions for ProviderManager documentation

This revision was automatically updated to reflect the committed changes. Closed by commit R235:533b31b5d6f9: Additions for ProviderManager documentation (authored by leinir). REPOSITORY R235 Attica CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19917?vs=54422&id=54426 REVISION DETA

D19917: Additions for ProviderManager documentation

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. We'll see I guess. REPOSITORY R235 Attica REVISION DETAIL https://phabricator.kde.org/D19917 To: leinir, #frameworks, #knewstuff, apol Cc: apol, kde-frameworks-devel, #knewstuff, michaelh,

D19917: Additions for ProviderManager documentation

leinir added inline comments. INLINE COMMENTS > apol wrote in providermanager.h:50 > You can use @see so doxygen creates a link? It's supposed to pick those up automatically, i thought? REPOSITORY R235 Attica REVISION DETAIL https://phabricator.kde.org/D19917 To: leinir, #frameworks, #kne

D19917: Additions for ProviderManager documentation

apol added inline comments. INLINE COMMENTS > providermanager.h:50 > * > - * Once you have loaded a Provider, use its functions to access the service. > + * See addProviderFileToDefaultProviders(const QUrl &url) for an example of > + * what the provider file sohuld look like. You can add provid

D19917: Additions for ProviderManager documentation

leinir created this revision. leinir added reviewers: Frameworks, KNewStuff. leinir added a project: KNewStuff. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. leinir requested review of this revision. REVISION SUMMARY Someone attempting to work on an Attica

D19907: Add Theme::blurBehindEnabled()

kossebau updated this revision to Diff 54417. kossebau added a comment. Remove sneaked-in code clean-up for repeated fetching of mask @davidedmundson Is the new dialog code fine? REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19907?v

D19907: Add Theme::blurBehindEnabled()

kossebau updated this revision to Diff 54416. kossebau added a comment. add missed-out application of the flag in PlasmaQuick::Dialog REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19907?vs=54399&id=54416 BRANCH addblurbehindflag REVI

D19551: [knotifications] compile without foreach

This revision was automatically updated to reflect the committed changes. Closed by commit R289:99e1dc8786a1: [knotifications] compile without foreach (authored by mlaurent). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19551?vs=54392&id=54411 REVISI

D19913: [plasma-desktop] make it compiles without foreach

mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY compile without foreach TEST PLAN autotest ok REPOSITORY R242 Plasma Framewor

KDE CI: Frameworks » knotifications » kf5-qt5 AndroidQt5.12 - Build # 13 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20AndroidQt5.12/13/ Project: kf5-qt5 AndroidQt5.12 Date of build: Wed, 20 Mar 2019 12:42:44 + Build duration: 1 min 4 sec and counting CONSOLE OUTPUT [...

D19897: [kservice ] Make it compile without foreach

This revision was automatically updated to reflect the committed changes. Closed by commit R309:0c673cd78f6b: [kservice ] Make it compile without foreach (authored by mlaurent). REPOSITORY R309 KService CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19897?vs=54361&id=54406 REVISION

D19907: Add Theme::blurBehindEnabled()

kossebau added inline comments. INLINE COMMENTS > theme.h:391 > + * \code > + * [BlurEffect] > + * enabled=false And this and above should have been updated to "[BlurBehindEffect]", as actually used in the code. So much for quick pre-lunch uploading, tss. Will fix when landing the

D19907: Add Theme::blurBehindEnabled()

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH addblurbehindflag REVISION DETAIL https://phabricator.kde.org/D19907 To: kossebau, #plasma, davidedmundson Cc: kde-frameworks-devel, michaelh, ngraham,

D19876: Fix: apply correctly the text colors of the chosen scheme

nibags updated this revision to Diff 54404. nibags added a comment. - Fix theme names Convert theme names from KTextEditor => KSyntaxHighlighting and avoid using invalid `KSyntaxHighlighting::Theme` objects. The `KDE` and `vim (dark)` themes don't exist in KSyntaxHighlighting, in suc

D19908: [ConfigModule] Pass initial properties

broulik created this revision. broulik added reviewers: Plasma, mart. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. TEST PLAN There's probably some std algo for it but `std::copy` didn't work so I gave up. di

D19907: Add Theme::blurBehindEnabled()

kossebau created this revision. kossebau added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Allows themes to disable the blurring of what is behind panels, if they either do

D19888: Add runtime guard that pages are KCMs in KCMultiDialog

This revision was automatically updated to reflect the committed changes. Closed by commit R295:d9ddd3524535: Add runtime guard that pages are KCMs in KCMultiDialog (authored by davidedmundson). REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19888?vs=54341&id

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.12 - Build # 33 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.12/33/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 20 Mar 2019 09:01:35 + Build duration: 7 min 7 sec and counting BUILD ARTIFACTS abi-compatibility

D15983: React to config updates inside indexer

poboiko closed this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15983 To: poboiko, #baloo, #frameworks, bruns, ngraham Cc: kde-frameworks-devel, bruns, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, abrahams

D19551: [knotifications] compile without foreach

dfaure accepted this revision. dfaure added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > mlaurent wrote in knotifyconfig.cpp:53 > How we can use iterator here ? > I didn't find a method for it. Urgh, indeed. What kind of container is that Never mind the

D19897: [kservice ] Make it compile without foreach

dfaure accepted this revision. dfaure added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > vfolder_menu.cpp:125 > { > -foreach (const KService::Ptr &p, items1) { > +const QHash tmpItems1 = items1; > +for (const KService::Ptr &p : tmpItems1) { Thi

D19551: [knotifications] compile without foreach

mlaurent updated this revision to Diff 54392. mlaurent added a comment. Fix loop REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19551?vs=54388&id=54392 BRANCH compile_without_foreach (branched from master) REVISION DETAIL https://phabricator.kd

D19903: Fix build with msvc

vonreth added a comment. btw .vim-template:cpp .vim-template:h aren't valid file names on windows, and look strange for unix too REPOSITORY R159 KActivities Statistics REVISION DETAIL https://phabricator.kde.org/D19903 To: vonreth, mlaurent, davidedmundson, aacid Cc: kde-

D19903: Fix build with msvc

vonreth added reviewers: mlaurent, davidedmundson, aacid. REPOSITORY R159 KActivities Statistics REVISION DETAIL https://phabricator.kde.org/D19903 To: vonreth, mlaurent, davidedmundson, aacid Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19903: Fix build with msvc

vonreth created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vonreth requested review of this revision. REVISION SUMMARY For the decltype change see https://stackoverflow.com/a/51347067 REPOSITORY R159 KActivities Statistics BRANCH mas

D19902: Remove illegal file names

vonreth abandoned this revision. REPOSITORY R159 KActivities Statistics REVISION DETAIL https://phabricator.kde.org/D19902 To: vonreth Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19902: Remove illegal file names

vonreth updated this revision to Diff 54390. vonreth added a comment. - Fix build with msvc REPOSITORY R159 KActivities Statistics CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19902?vs=54389&id=54390 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19902 AFFECTE

D19902: Remove illegal file names

vonreth created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vonreth requested review of this revision. REPOSITORY R159 KActivities Statistics BRANCH master REVISION DETAIL https://phabricator.kde.org/D19902 AFFECTED FILES .vim-temp

D19551: [knotifications] compile without foreach

pino added inline comments. INLINE COMMENTS > notifybypopup.cpp:424 > +QMap::const_iterator i = > d->passivePopups.constBegin(); > +while (i != d->passivePopups.constEnd()) { > +emit finished(i.key()); this loop now will run forever... REPOSITORY R289 KNotifications REVISION

D19551: [knotifications] compile without foreach

mlaurent updated this revision to Diff 54388. mlaurent added a comment. Use iterator here REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19551?vs=53231&id=54388 BRANCH compile_without_foreach (branched from master) REVISION DETAIL https://phabr

D19551: [knotifications] compile without foreach

mlaurent added inline comments. INLINE COMMENTS > dfaure wrote in knotifyconfig.cpp:53 > horribly slow, should use STL iterators How we can use iterator here ? I didn't find a method for it. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D19551 To: mlaurent, df