D19598: DocumentPrivate: Make auto bracket slightly smarter

loh.tar updated this revision to Diff 53412. loh.tar set the repository for this revision to R39 KTextEditor. loh.tar added a comment. - *hmpf* forgot may last cleanup change REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19598?vs=53410&id=53412 REVISIO

D19598: DocumentPrivate: Make auto bracket slightly smarter

loh.tar updated this revision to Diff 53410. loh.tar added reviewers: cullmann, mwolff. loh.tar added a comment. - Add KateDocumentTest::testAutoBrackets Just a note to the current RegEx solution: It's done as you see in a slightly redundant dumb way. Perhaps is a special function witho

D19602: [KParts] Fix compilation for Qt 5.13

matthieugras created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. matthieugras requested review of this revision. REVISION SUMMARY Method is deprecated in Qt 5.13 TEST PLAN Compiles REPOSITORY R306 KParts BRANCH master REVISION DET

D19575: Add collapse-all and expand-all action icons

ndavis added a comment. I just noticed, there is already a `go-top` icon that looks just like `collapse-all`. That's a problem. "Collapse all" is different enough from "Go to top" that they shouldn't be the same icon. I do think that the arrow with the bar on top is more appropriate for

D19575: Add collapse-all and expand-all action icons

ndavis requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19575 To: trickyricky26, #vdg, ngraham, ndavis Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D19575: Add collapse-all and expand-all action icons

ndavis added a comment. The symlinks in the symbolic folder should end with `-symbolic` REPOSITORY R266 Breeze Icons BRANCH collapse-expand-all-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D19575 To: trickyricky26, #vdg, ngraham Cc: ndavis, ngraham, kde-fra

D19575: Add collapse-all and expand-all action icons

ndavis added a comment. In D19575#426762 , @ngraham wrote: > Could we get symlinks for these that point to `window-keep-above` and `window-keep-below` too? Ink KWin, the keep above and keep below icons are different. These are the shade/

D19575: Add collapse-all and expand-all action icons

ngraham added a comment. Could we get symlinks for these that point to `window-keep-above` and `window-keep-below` too? REPOSITORY R266 Breeze Icons BRANCH collapse-expand-all-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D19575 To: trickyricky26, #vdg, ngr

D19307: Enforce new muted icon style in all action icons

This revision was automatically updated to reflect the committed changes. Closed by commit R266:ae8fcdcd409b: Enforce new muted icon style in all action icons (authored by Rafael Brandmaier ). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabr

D19307: Enforce new muted icon style in all action icons

rooty accepted this revision. REPOSITORY R266 Breeze Icons BRANCH correct-muted-action-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D19307 To: trickyricky26, #vdg, ngraham, rooty Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D19307: Enforce new muted icon style in all action icons

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH correct-muted-action-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D19307 To: trickyricky26, #vdg, ngraham Cc: ngraham, kde-frameworks-devel, mic

D18904: [FileCopyJob] Clean up after file copy operation is cancelled

chinmoyr added a comment. There's free space check in CopyJob. And Dolphin still gives an error in the said situation. But if some application decides to directly use FileCopyJob then IMO the free space check should be at application's side. Anyway, I tried adding it here and it felt awkward

D19599: textfield height based only on clear text

rooty added a dependent revision: D19214: [sddm-theme] Replace login button label with icon. REPOSITORY R242 Plasma Framework (Library) BRANCH phab/echo REVISION DETAIL https://phabricator.kde.org/D19599 To: mart, #plasma, ngraham, rooty Cc: rooty, ngraham, kde-frameworks-devel, michaelh

D19599: textfield height based only on clear text

rooty accepted this revision. rooty added a comment. Good things come to those who wait, thanks for the fix. I can also confirm that this doesn't affect any other font adversely in any way. REPOSITORY R242 Plasma Framework (Library) BRANCH phab/echo REVISION DETAIL https://phabricat

D19599: textfield height based only on clear text

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. It's fixed Of course now the issue with the dots is worse since the dots are just too high up in the text field: F6670642: Peek 2019-03-07 10-44.gif

D19585: [CopyJob] Report results after finishing copy

chinmoyr added a comment. > Opened Dolphin, Ctrl+C on a file, Ctrl+V it into the same folder, let it sit at the "Override?" prompt until the job view in Plasma showed up. >Chose a different filename and continued. > [...] > The URL isn't updated in case of a rename but I bet it just needs

D19599: textfield height based only on clear text

mart created this revision. mart added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mart requested review of this revision. REVISION SUMMARY as the implicit height could change when switching to password mode, use a textmetrics which

D19598: DocumentPrivate: Make auto bracket slightly smarter

loh.tar created this revision. loh.tar added a reviewer: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY ..in handling of quotes - Skip auto quotes when these look

D19557: Update css

abetts added a comment. +1 REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D19557 To: ognarb, #vdg, #documentation Cc: abetts, broulik, aacid, kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, bruns, skadinna

D19557: Update css

ognarb edited the summary of this revision. REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D19557 To: ognarb, #vdg, #documentation Cc: broulik, aacid, kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, bruns, skadinna

D19557: Update css

ognarb updated this revision to Diff 53367. ognarb added a comment. Add breeze like style for note/info/warning/tip admonitions and make image responsive REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19557?vs=53359&id=53367 BRANCH master REVISION DE

D19532: Don't crash when no contexts are present

cullmann added a comment. In D19532#426505 , @dhaumann wrote: > As you wish. > > Questions remains: does it fix https://bugs.kde.org/show_bug.cgi?id=401480 No, will just crash later. Therefore one needs a proper variant of https://ph

D19532: Don't crash when no contexts are present

dhaumann added a comment. As you wish. Questions remains: does it fix https://bugs.kde.org/show_bug.cgi?id=401480 REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D19532 To: davispuh, cullmann, dhaumann, vandenoever, vkrause Cc: kwrite-devel, kde-frame

D19557: Update css

ognarb updated this revision to Diff 53359. ognarb edited the test plan for this revision. ognarb added a comment. Change to jpg and remove now useless files REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19557?vs=53251&id=53359 BRANCH master REVISION

D19534: [i18n] compile without foreach

mlaurent closed this revision. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D19534 To: mlaurent, dfaure Cc: kossebau, sh-zam, kde-frameworks-devel, michaelh, ngraham, bruns

D19586: [CopyJob] Treat URL as dirty when renaming file as conflict resolution

broulik added a dependent revision: D19588: [Notifications] Improve finished notification. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D19586 To: broulik, dfaure, chinmoyr Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19585: [CopyJob] Report results after finishing copy

broulik added a dependent revision: D19588: [Notifications] Improve finished notification. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D19585 To: broulik, dfaure, chinmoyr Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19583: [KUiServerJobTracker] Update destUrl before finishing the job

broulik added a dependent revision: D19588: [Notifications] Improve finished notification. REPOSITORY R288 KJobWidgets REVISION DETAIL https://phabricator.kde.org/D19583 To: broulik, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19586: [CopyJob] Treat URL as dirty when renaming file as conflict resolution

broulik created this revision. broulik added reviewers: dfaure, chingku. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY When a file already exists and user choses to rename the file, the URL wasn't

D19586: [CopyJob] Treat URL as dirty when renaming file as conflict resolution

broulik edited reviewers, added: chinmoyr; removed: chingku. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D19586 To: broulik, dfaure, chinmoyr, chingku Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19585: [CopyJob] Report results after finishing copy

broulik created this revision. broulik added reviewers: dfaure, chinmoyr. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Currently, `slotReport` is called all the way at the end when in `STATE_SETT

D19583: [KUiServerJobTracker] Update destUrl before finishing the job

broulik edited the test plan for this revision. REPOSITORY R288 KJobWidgets REVISION DETAIL https://phabricator.kde.org/D19583 To: broulik, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19583: [KUiServerJobTracker] Update destUrl before finishing the job

broulik created this revision. broulik added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY It is not really meant to be changing after the job started, but there can be instanc

D19532: Don't crash when no contexts are present

cullmann added a comment. I the unit test is separated, no longer all things will be tested with the invalid definitions. In D19532#426268 , @dhaumann wrote: > Could you change the unit test please to not mix with the other ones? > > - a

D19581: Fix build with cmake < 3.7

This revision was automatically updated to reflect the committed changes. Closed by commit R216:a08e2ebd589f: Fix build with cmake < 3.7 (authored by wbauer). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19581?vs=53332&id=53336 REVISION DETAIL

D19581: Fix build with cmake < 3.7

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D19581 To: wbauer, vkrause Cc: kwrite-devel, kde-frameworks-devel, cullmann, gennad, bmortimer, domson, michaelh, genethomas, ngra

D19581: Fix build with cmake < 3.7

wbauer created this revision. wbauer added a project: Framework: Syntax Highlighting. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. wbauer requested review of this revision. REVISION SUMMARY VERSION_GREATER_EQUAL requires cmake 3.7 or high

D19532: Don't crash when no contexts are present

dhaumann added a comment. Could you change the unit test please to not mix with the other ones? - add a new void testBrokenDefinition() - use a local Repository repo; - add custom search oath to this repo - and then check only the broken file. This would be much cleaner and bett

D19532: Don't crash when no contexts are present

dhaumann added a comment. Will this fix https://bugs.kde.org/show_bug.cgi?id=401480 ? REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D19532 To: davispuh, cullmann, dhaumann, vandenoever, vkrause Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, mich