D18114: FakeInput: add support for pointer move with absolute coordinates

jgrulich added a comment. Hi, can I get please this re-approved? It's now just again about the additional mouse support. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D18114 To: jgrulich, davidedmundson, graesslin, zzag Cc: graesslin, zzag, kde-frameworks-devel, m

D18010: Allow zero altitude/longitude/latitude exiv gps data

astippich added inline comments. INLINE COMMENTS > bruns wrote in exiv2extractor.cpp:298 > when you rewrite this as > > if (it != data.end()) { > auto ratio = it->value().toRational(); > it = data.findKey(Exiv2::ExifKey("Exif.GPSInfo.GPSAltitudeRef")); > if ((ratio.second !=

D18308: Ignore all non-storage deviceAdded signals from Solid

bruns created this revision. bruns added reviewers: Baloo, Frameworks, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY createCacheEntry is also called from SolidDeviceNotifier::deviceAdd

D18161: [WIP/RFC] [kioslave/file] Add a codec for legacy filenames

cfeck added a comment. Thanks for testing, btw. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18161 To: cfeck, #frameworks, #dolphin, dfaure Cc: nerdopolist, ngraham, kde-frameworks-devel, michaelh, bruns

D18161: [WIP/RFC] [kioslave/file] Add a codec for legacy filenames

cfeck added a comment. It's possible that Kate doesn't use KIO for local files, but falls back to QFile. It _would_ be possible somehow (e.g. via the QPA plugins) to inject the hack into all Qt applications, but I suggest to improve Dolphin in a way that it shows an error message or even a r

D17816: Support for xattrs on kio copy/move

cfeck added a comment. I am still not fond of having a local event loop in KIO. The whole point of KIO is that it should work asynchronously. If the tests fail, could they be adapted? Or is the reason why the tests fail unfixable? REPOSITORY R241 KIO REVISION DETAIL https://phabric

D15999: Add icons with added background to system.svgz

ngraham added a comment. In D15999#394818 , @filipf wrote: > +1 in regards to at least getting the new switch user icon into master, it's great @pstefan, any chance we can cudgel you into doing this? 😛 REPOSITORY R242 Plasma Framework

D13316: manually set format in jpeg thumbnail creator

ngraham added a comment. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. Is there any reason not to commit this now? REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D13316 To: miklosm, dfaure, elvisangelaccio,

D18161: [WIP/RFC] [kioslave/file] Add a codec for legacy filenames

nerdopolist added a comment. Awesome! For what I can input, base file operations work. I can copy, delete, rename files, and testing, and diffing the trees with my kiocopy test script, it copies them perfectly. However, for example, some of the files I cannot open with kate REPOSITORY R24

D18161: [WIP/RFC] [kioslave/file] Add a codec for legacy filenames

cfeck updated this revision to Diff 49684. cfeck added a comment. Fix worst case estimate. We need up to two UTF-16 code units for each byte. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18161?vs=49176&id=49684 REVISION DETAIL https://phabricator.kde.org/D

D11320: Fix QVariantMapList operator >> implementation

This revision was automatically updated to reflect the committed changes. Closed by commit R281:66362ec67b8f: Fix QVariantMapList operator >> implementation (authored by aleksanderm, committed by aacid). Herald added a subscriber: kde-frameworks-devel. REPOSITORY R281 ModemManagerQt CHANGES SI

D13416: image thumbnailer: instruct Qt to look at the file contents when detecting its format

aacid closed this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D13416 To: miklosm, #frameworks, #dolphin, dfaure, elvisangelaccio Cc: kde-frameworks-devel, kfm-devel, aacid, alexde, feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros,

D13416: image thumbnailer: instruct Qt to look at the file contents when detecting its format

aacid added a comment. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. I pushed this at https://commits.kde.org/kio-extras/0be80392f01e0ec01174990c430dcd8f1ed35d9e REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.or

D15999: Add icons with added background to system.svgz

filipf added a comment. They only work for me when using a dark theme: F6552425: image.png F6552428: image.png We could just do QML circles. Pro is they assure legibility with many non-Breeze icons, co

D15999: Add icons with added background to system.svgz

ngraham requested changes to this revision. ngraham added a subscriber: rooty. ngraham added a comment. This revision now requires changes to proceed. I still haven't managed to get these icons to actually work, per recent discussions. The background is always light instead of dark. Also the p

D17664: fix for macOS

This revision was automatically updated to reflect the committed changes. Closed by commit R6:74f3eeb69ead: fix for macOS (authored by yurikoles, committed by aacid). Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. CHANGED PRIOR TO COMMIT https://phabricator

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 17 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/17/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Wed, 16 Jan 2019 23:07:00 + Build duration: 5 min 31 sec and counting JUnit Tests Name: projectroo

D17726: Add helper function to disable redirections (useful for kde-open)

This revision was automatically updated to reflect the committed changes. Closed by commit R241:8c3f000b72ed: Add helper function to disable redirections (useful for kde-open) (authored by achauvel, committed by aacid). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D17726?vs=48028&id=4967

D16643: Correct the accept flag of the event object on DragMove

aacid added a comment. @bruns waiting for your comment on whether your issues were addressed or not REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D16643 To: trmdi, mart, broulik, #plasma, hein, bruns Cc: aacid, bruns, dkorth, ngraham, kde-frameworks-devel, mich

D18237: Fix ResultIterator

ngraham added reviewers: Baloo, bruns, poboiko. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D18237 To: aacid, #baloo, bruns, poboiko Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D18237: Fix ResultIterator

aacid set the repository for this revision to R293 Baloo. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D18237 To: aacid Cc: kde-frameworks-devel, #baloo, ashaposhnikov, micha

Power Management and Inhibition by Applications

Hello, I am trying to work on a feature request to add the ability to suppress laptop sleep when playing music. Currently, Juk is doing it via dbus calls to "org.kde.Solid.PowerManagement". I also had a look to Solid frameworks and the power classes that add an asynchronous way to do that. Cur

Power Management and Inhibition by Applications

Hello, I am trying to work on a feature request to add the ability to suppress laptop sleep when playing music. Currently, Juk is doing it via dbus calls to "org.kde.Solid.PowerManagement". I also had a look to Solid frameworks and the power classes that add an asynchronous way to do that. Cur

D18164: Review KateGotoBar

loh.tar updated this revision to Diff 49665. loh.tar added a comment. - Connect/Disconnect - Remove m_gotoRange->setFocus Like this? :-/ I noticed bad behavior and have remove these setFocus, test it if its OK. On edit was always the focus set to the spinbox. CHANGES SINCE LAST U

D18302: Add Android notification channel support

vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY This is required for API level 28 or higher. This actually matches the notfication events KNotification defines quite

D18288: Make the clock svg's shadows more logically correct and visually appropriate

This revision was automatically updated to reflect the committed changes. Closed by commit R242:d755013c7421: Make the clock svg's shadows more logically correct and visually appropriate (authored by ngraham). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabr

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.11 - Build # 16 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.11/16/ Project: kf5-qt5 SUSEQt5.11 Date of build: Wed, 16 Jan 2019 16:44:14 + Build duration: 20 min and counting BUILD ARTIFACTS abi-compati

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 6 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/6/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 16 Jan 2019 16:44:14 + Build duration: 16 min and counting BUILD ARTIFACTS abi-compatib

D18164: Review KateGotoBar

cullmann added a comment. I would disconnect the textChanged in ::closed() to avoid having updates there even if the bar is hidden again (and reconnect on show). Otherwise I think this is ready to go in. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D18164

KDE CI: Frameworks » knotifications » kf5-qt5 AndroidQt5.11 - Build # 12 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20AndroidQt5.11/12/ Project: kf5-qt5 AndroidQt5.11 Date of build: Wed, 16 Jan 2019 16:51:14 + Build duration: 49 sec and counting CONSOLE OUTPUT [...trunc

D18274: Make notifications work on Android with API level < 23

This revision was automatically updated to reflect the committed changes. Closed by commit R289:60dc31f81b4f: Make notifications work on Android with API level < 23 (authored by vkrause). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18274?vs=49551&id=

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 10 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/10/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Wed, 16 Jan 2019 16:44:14 + Build duration: 3 min 55 sec and counting JUnit Tests Nam

D11235: [DrKonqi] Request change of ptrace scope from KCrash

ossi added a comment. will also need to wait for commit message update, like the other change. INLINE COMMENTS > ptracer.cpp:92 > + > +qCWarning(DRKONQI_LOG) << "debugged process did not acknowledge setting > ptracer to" << debuggerpid; > +close(sfd); not wrong per se, but mildly mi

D18164: Review KateGotoBar

loh.tar updated this revision to Diff 49653. loh.tar edited the summary of this revision. loh.tar set the repository for this revision to R39 KTextEditor. loh.tar added a comment. - Morph updateData() into a slot - connect to Document::textChanged signal REPOSITORY R39 KTextEditor CHANGES

D11235: [DrKonqi] Request change of ptrace scope from KCrash

croick updated this revision to Diff 49651. croick marked 5 inline comments as done. croick added a comment. - emit warning if no socket is available REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11235?vs=49649&id=49651 BRANCH ptracer REVISION DETAIL

D11235: [DrKonqi] Request change of ptrace scope from KCrash

croick added inline comments. INLINE COMMENTS > ossi wrote in ptracer.cpp:65 > you really could just use != here ... ^^ wow... REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D11235 To: croick, #plasma_workspaces, #frameworks, ossi Cc: ossi, lepagevalleeemmanuel, maxim

D11236: [KCrash] Establish socket to allow change of ptracer

croick marked 2 inline comments as done. croick added a comment. > that sounds suspicious. i don't think the kernel's behavior did changed, and the process hierarchy presumably didn't, either. the right is handed down the ancestry, and that's irrespective of whether the tracer is a "natural"

D18164: Review KateGotoBar

cullmann added a comment. In D18164#394498 , @loh.tar wrote: > - Fix typo of member vars > - Add missing setView(m_view) > - Remove FIXME hint about timer, however would a comment for me nice > - Use QString() > > Things which could be

D11236: [KCrash] Establish socket to allow change of ptracer

croick updated this revision to Diff 49650. croick marked 2 inline comments as done. croick added a comment. - modify comment and remove check for EAGAIN REPOSITORY R285 KCrash CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11236?vs=49617&id=49650 BRANCH ptracer REVISION DETAI

D11235: [DrKonqi] Request change of ptrace scope from KCrash

croick updated this revision to Diff 49649. croick marked an inline comment as done. croick added a comment. - change order and add comment to kdeinit option in crashtest - add warning if debuggee does not respond as expected REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://pha

D18125: KateStatusBar: Add dictionary button

loh.tar added a subscriber: cullmann. loh.tar added a comment. @cullmann @dhaumann A short not how to progress would be nice. - Keep codes as they are - Shorten codes as suggested - Replace codes by flags/ensign (no idea how) - Add (unneeded) label - Show (unneeded long) full name

D11235: [DrKonqi] Request change of ptrace scope from KCrash

ossi requested changes to this revision. ossi added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > ptracer.cpp:65 > +bytes += r; > +else if (r == -1 && !(errno == EINTR)) > +break; you really could just use != here ..

D11236: [KCrash] Establish socket to allow change of ptracer

ossi added a comment. In D11236#394363 , @croick wrote: > Actually the point I removed does not seem to be true any longer. I'm almost certain, that the `prctrl(PR_SET_PTRACER, ...)` was not required until some time ago when starting DrKonqi as

D18299: ComboBox: fix default delegate

broulik added inline comments. INLINE COMMENTS > ComboBox.qml:58 > +controlRoot.currentIndex = index; > +controlRoot.popup.visible = false; > +} Are you sure this is needed? Qt docs say for that using `ItemDelegate` for a `ComboBox` is recommended as: "This ensur

D18299: ComboBox: fix default delegate

This revision was automatically updated to reflect the committed changes. Closed by commit R858:cb49b355f946: ComboBox: fix default delegate (authored by apol). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18299?vs=49646&id=49648

D18299: ComboBox: fix default delegate

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R858 Qt Quick Controls 2: Desktop Style BRANCH master REVISION DETAIL https://phabricator.kde.org/D18299 To: apol, #frameworks, davidedmundson Cc: plasma-devel, jraleigh, GB_2, ragreen, Pite

D18299: ComboBox: fix default delegate

apol created this revision. apol added a reviewer: Frameworks. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Should use the selected item when it's interacted with using the mouse. TEST PLAN Selecting an item

D18274: Make notifications work on Android with API level < 23

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D18274 To: vkrause, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18164: Review KateGotoBar

loh.tar updated this revision to Diff 49636. loh.tar added a comment. - Fix typo of member vars - Add missing setView(m_view) - Remove FIXME hint about timer, however would a comment for me nice - Use QString() Things which could be improved or not - The up/down buttons are a li

D18249: [datamodel] Rework items insert/remove

anthonyfieroni updated this revision to Diff 49630. REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18249?vs=49469&id=49630 REVISION DETAIL https://phabricator.kde.org/D18249 AFFECTED FILES src/declarativeimports/core/datamodel.cpp To:

D18249: [datamodel] Rework items insert/remove

anthonyfieroni added inline comments. INLINE COMMENTS > anthonyfieroni wrote in datamodel.cpp:379 > Optimization is you have [5, 6, 8] then [5, 6, 8, 9] so it make only > beginInsertRows({}, 3, 3); > full replace (m_items[sourceName] = list.toVector();) > endInsertRows() > Same if you [5, 6] > b

D18288: Make the clock svg's shadows more logically correct and visually appropriate

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH clock-spindle-shadow (branched from master) REVISION DETAIL https://phabricator.kde.org/D18288 To: ngraham, #vdg, #plasma, davidedmundson Cc: kde-frame

D11235: [DrKonqi] Request change of ptrace scope from KCrash

croick marked 11 inline comments as done. croick added a comment. `read()` and `write()` were assumed to work right away, I added a loop around. INLINE COMMENTS > ossi wrote in crashtest.cpp:133 > this addition isn't used or explained anywhere for all i can tell. It's used to unset the `Alwa

D11236: [KCrash] Establish socket to allow change of ptracer

croick marked 10 inline comments as done. croick added a comment. > please explicitly mark all handled issues as done - you'll notice on the way that you didn't address some of them. Sorry, you were just responding too quickly. > you adjusted the summary kinda the wrong way around ..

D11235: [DrKonqi] Request change of ptrace scope from KCrash

croick updated this revision to Diff 49618. croick added a comment. - use debuggee pid instead of DrKonqi pid for socket name - make sure to read/write all bytes from/to socket REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11235?vs=49607&id=49618 BRANCH

D11236: [KCrash] Establish socket to allow change of ptracer

croick updated this revision to Diff 49617. croick marked 2 inline comments as done. croick added a comment. - unlink old sockets before binding - remove superfluous EAGAIN check - use debuggee pid instead of DrKonqi pid for socket name - fix comments REPOSITORY R285 KCrash CHANGES SI

D11235: [DrKonqi] Request change of ptrace scope from KCrash

ossi requested changes to this revision. ossi added a comment. This revision now requires changes to proceed. mark handled issues as done here as well. INLINE COMMENTS > ptracer.cpp:47 > + > QStringLiteral("%1/kcrash_%2").arg(QStandardPaths::writableLocation(QStandardPaths::RuntimeLoc

D11236: [KCrash] Establish socket to allow change of ptracer

ossi requested changes to this revision. ossi added a comment. This revision now requires changes to proceed. mostly minor issues left. please explicitly mark all handled issues as done - you'll notice on the way that you didn't address some of them. you adjusted the summary kinda th

D17691: Add rows info to the plasma virtual desktop protocol

mart updated this revision to Diff 49610. mart added a comment. - remove dead symbol REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17691?vs=49425&id=49610 BRANCH phab/virtualdesktoprows REVISION DETAIL https://phabricator.kde.org/D17691 AFFECTED FI

D11236: [KCrash] Establish socket to allow change of ptracer

croick updated this revision to Diff 49609. croick retitled this revision from "[KCrash] Establish socket to allow change of ptrace scope" to "[KCrash] Establish socket to allow change of ptracer". croick edited the summary of this revision. croick added a comment. - use poll instead of select

D11235: [DrKonqi] Request change of ptrace scope from KCrash

croick updated this revision to Diff 49607. croick edited the summary of this revision. croick edited the test plan for this revision. croick added a comment. - rename queryPtrace to setPtracer - add a kdeinit option in crashtest REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https:/

D18249: [datamodel] Rework items insert/remove

anthonyfieroni added inline comments. INLINE COMMENTS > davidedmundson wrote in datamodel.cpp:379 > I don't understand what you're changing here, can you provide a bit more > detail on the exact problem. Optimization is you have [5, 6, 8] then [5, 6, 8, 9] so it make only beginInsertRows({}, 3

D18174: Ruby: fix RegExp after ": " and fix/improve detection of HEREDOC

nibags closed this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D18174 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D18174: Ruby: fix RegExp after ": " and fix/improve detection of HEREDOC

nibags edited the summary of this revision. REPOSITORY R216 Syntax Highlighting BRANCH fix-ruby REVISION DETAIL https://phabricator.kde.org/D18174 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, demski

D18174: Ruby: fix RegExp after ": " and fix/improve detection of HEREDOC

nibags updated this revision to Diff 49600. nibags edited the summary of this revision. nibags added a comment. - Small correction in comment REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18174?vs=49212&id=49600 BRANCH fix-ruby REVISION DET

D18164: Review KateGotoBar

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. I think it is a nice enhancement over the current state. I give it an accept, but wait for the "Regarding code comments, will fix it when it got in general an "OK"" before I apply i