D11604: kdirlistertest doesn't fail at random

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kdirlistertest.cpp:374 > +QTRY_COMPARE(m_dirLister.spyStarted.count(), 0); // fast path: no > directory listing needed > +QTRY_VERIFY(m_dirLister.spyC

D10937: Retouching of Screen Layout Selection OSD Icons

bruns added a comment. I think this works better if you actually rotate the screen: F6203935: rotate2.png REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D10937 To: pstefan, #breeze, ngraham Cc: broulik, bruns, #vdg, kde-f

D14922: Assert if trying to use a KCatalog without a QCoreApplication

aacid added subscribers: ilic, ltoscano. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D14922 To: aacid Cc: ltoscano, ilic, kde-frameworks-devel, michaelh, ngraham, bruns

D14922: Assert if trying to use a KCatalog without a QCoreApplication

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY QCoreApplication init calls setlocale(LC_ALL, ""); that is crucial for gettext to work, so assert if the user

D14908: Bindings: Add support for scoped enums

bruns added a comment. Compilation succeeds again, and the generated code looks sane. I have not actually tested it, though. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D14908 To: bruns, #frameworks Cc: mpyne, kde-frameworks-devel, kde-buildsystem, mi

D14908: Bindings: Add support for scoped enums

mpyne added a comment. LGTM but then I don't use the Python bindings. Have you already tried the kcoreaddons build to see if this makes it work where it had failed before? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D14908 To: bruns, #frameworks Cc: m

D11828: Simplify orPostingIterator and make it faster

bruns marked an inline comment as done. bruns added a comment. Ping! REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11828 To: bruns, #baloo, michaelh, #frameworks Cc: fvogt, kde-frameworks-devel, #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, brun

D11828: Simplify orPostingIterator and make it faster

bruns removed a reviewer: michaelh. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11828 To: bruns, #baloo, #frameworks Cc: fvogt, kde-frameworks-devel, #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D12125: Avoid inserting an invalid "Size" property from the Filesystem interface

bruns added a comment. Herald added a subscriber: kde-frameworks-devel. Ping! REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D12125 To: bruns, #frameworks Cc: kde-frameworks-devel, broulik, #frameworks, michaelh, ngraham, bruns

D12127: Do not query properties when no interfaces are left

bruns added a comment. Herald added a subscriber: kde-frameworks-devel. Ping! REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D12127 To: bruns, #frameworks Cc: kde-frameworks-devel, broulik, michaelh, ngraham, bruns

D14757: Warn user before copy operation if available space is not enough

shubham added inline comments. INLINE COMMENTS > pino wrote in copyjob.cpp:909 > The return value is `JobUiDelegateExtension::MessageBoxType`, not > `KMessageBox::ButtonCode`. There is no enum for Button Code inside JobUiDelegatextension. So how to take that into consideration? REPOSITORY R

D14912: Bindings: Make generator forward compatible with Python 3

bruns added a comment. Another option is to include a wrapper function directly in the code, instead of importing it REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D14912 To: bruns, #frameworks Cc: arojas, kde-frameworks-devel, kde-buildsystem, michaelh,

D14920: KCompressionDevice: don't call write after WriteError

dfaure closed this revision. REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D14920 To: dfaure, cullmann Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14920: KCompressionDevice: don't call write after WriteError

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. One corner case more fixed. REPOSITORY R243 KArchive BRANCH master REVISION DETAIL https://phabricator.kde.org/D14920 To: dfaure, cullmann Cc: kde-frameworks-devel, michaelh, ng

Re: New framework: KF5Syndication

On Wednesday, 22 April 2015 21:44:05 CEST Daniel Vrátil wrote: > Hi all, > > I'd like to ask for review of another Framework from kdepimlibs: > KF5Syndication > > KF5Syndication is an RSS/Atom parsing library. It also provides API to > fetch > feeds directly from network. > > It's a Tier 3 Frame

D14920: KCompressionDevice: don't call write after WriteError

dfaure created this revision. dfaure added a reviewer: cullmann. Herald added a project: Frameworks. Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks. dfaure requested review of this revision. REVISION SUMMARY if an earlier call to write failed, then there is no point

D14912: Bindings: Make generator forward compatible with Python 3

bruns added a comment. In D14912#311063 , @arojas wrote: > This adds a new build time dependency to all frameworks which support bindings. Any chance to simply port it to python 3 instead? Dropping python2 means dropping support for any d

KDE CI: Frameworks ktexteditor kf5-qt5 WindowsMSVCQt5.10 - Build # 90 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20WindowsMSVCQt5.10/90/ Project: Frameworks ktexteditor kf5-qt5 WindowsMSVCQt5.10 Date of build: Sat, 18 Aug 2018 12:15:14 + Build duration: 29 min and counting JUnit

KDE CI: Frameworks ktexteditor kf5-qt5 WindowsMSVCQt5.10 - Build # 89 - Failure!

Error processing tokens: Error while parsing action 'Text/ZeroOrMore/FirstOf/Token/DelimitedToken/DelimitedToken_Action3' at input position (line 1, pos 38): ${JELLY_SCRIPT,template="html_gmail"} ^ hudson.remoting.ChannelClosedException: Channel "unknown": Remo

D14890: Remove QSaveFile in favor of plain old file saving

This revision was not accepted when it landed; it landed in state "Changes Planned". This revision was automatically updated to reflect the committed changes. Closed by commit R39:38870f3b3173: correct error handling for QFileDevice and KCompressedDevice (authored by cullmann). CHANGED PRIOR TO

KDE CI: Frameworks karchive kf5-qt5 WindowsMSVCQt5.10 - Build # 28 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20karchive%20kf5-qt5%20WindowsMSVCQt5.10/28/ Project: Frameworks karchive kf5-qt5 WindowsMSVCQt5.10 Date of build: Sat, 18 Aug 2018 11:42:14 + Build duration: 3 min 4 sec and counting JUnit T

D14890: Remove QSaveFile in favor of plain old file saving

cullmann added a comment. My local patch already does that :) REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D14890 To: cullmann, dhaumann, dfaure Cc: dfaure, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars, dha

D14890: Remove QSaveFile in favor of plain old file saving

dfaure added a comment. Oops fixed. BTW, doing a qobject_cast twice (for each type) seems a bit wasteful, you might want to split the if() like I did in KArchive... REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D14890 To: cullmann, dhaumann, dfaure Cc: dfau

D14890: Remove QSaveFile in favor of plain old file saving

cullmann added a comment. Just wanted to add the alternative code path, might it be that the Q_OBJECT stuff is really missing by accident? Or is this intentional? /usr/include/qt5/QtCore/qobject.h: In instantiation of ‘T qobject_cast(QObject*) [with T = KCompressionDevice*]’: /home/cu

KDE CI: Frameworks karchive kf5-qt5 WindowsMSVCQt5.10 - Build # 26 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20karchive%20kf5-qt5%20WindowsMSVCQt5.10/26/ Project: Frameworks karchive kf5-qt5 WindowsMSVCQt5.10 Date of build: Sat, 18 Aug 2018 11:02:29 + Build duration: 3 min 16 sec and counting JUnit

D14913: KCompressionDevice: propagate errors from QIODevice::close()BUG: 397545

dfaure closed this revision. REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D14913 To: dfaure, cullmann Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14913: KCompressionDevice: propagate errors from QIODevice::close()BUG: 397545

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Looks reasonable, given we must live with the constraint of having error() atm only in QFileDevice. REPOSITORY R243 KArchive BRANCH master REVISION DETAIL https://phabricator.kd

D14913: KCompressionDevice: propagate errors from QIODevice::close()BUG: 397545

dfaure updated this revision to Diff 39963. dfaure added a comment. Rework as discussed Updating D14913: KCompressionDevice: propagate errors from QIODevice::close() = BUG: 397545 REPOSITORY R243 KArchive

KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.10 - Build # 134 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.10/134/ Project: Frameworks ktexteditor kf5-qt5 SUSEQt5.10 Date of build: Sat, 18 Aug 2018 10:35:51 + Build duration: 6 min 10 sec and counting JUnit Tests

KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.9 - Build # 91 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.9/91/ Project: Frameworks ktexteditor kf5-qt5 SUSEQt5.9 Date of build: Sat, 18 Aug 2018 10:34:56 + Build duration: 5 min 4 sec and counting JUnit Tests

KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.10 - Build # 133 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.10/133/ Project: Frameworks ktexteditor kf5-qt5 SUSEQt5.10 Date of build: Sat, 18 Aug 2018 09:12:29 + Build duration: 1 hr 23 min and counting JUnit Tests

KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.9 - Build # 90 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.9/90/ Project: Frameworks ktexteditor kf5-qt5 SUSEQt5.9 Date of build: Sat, 18 Aug 2018 09:12:29 + Build duration: 1 hr 22 min and counting JUnit Tests

D14890: Remove QSaveFile in favor of plain old file saving

cullmann added a comment. Thanks! REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D14890 To: cullmann, dhaumann, dfaure Cc: dfaure, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars, dhaumann

D14890: Remove QSaveFile in favor of plain old file saving

dfaure added a comment. I'll look into it. I also just reported https://bugreports.qt.io/browse/QTBUG-70033 REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D14890 To: cullmann, dhaumann, dfaure Cc: dfaure, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew,

D14890: Remove QSaveFile in favor of plain old file saving

cullmann added a comment. > But pending that, I'm afraid that we'll have to downcast to KCompressionDevice to call a new error() accessor after close()... I can live with that, see comment above, I already added the QFileDevice case. It is not that nice but at least one can handle the e

D14890: Remove QSaveFile in favor of plain old file saving

dfaure added a comment. (the alternative is to use Unbuffered on those devices, but that's probably not a great idea performance wise) REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D14890 To: cullmann, dhaumann, dfaure Cc: dfaure, kwrite-devel, kde-frameworks-de

D14890: Remove QSaveFile in favor of plain old file saving

cullmann added a comment. For the QFile case, I added now this check: // did save work? // FIXME for KCompressionDevice if (qobject_cast(saveFile.data()) && qobject_cast(saveFile.data())->error() != QFileDevice::NoError) { BUFFER_DEBUG << "Saving file " << filename

D14890: Remove QSaveFile in favor of plain old file saving

dfaure added a comment. Yeah that's the problem. The way I see it, the QIODevice API assumes that one will call errorString() only after some method returns an error, e.g. after QAbstractSocket::error() is emitted, or after socket.waitForEncrypted() returns false. QFile[Device] and

D14890: Remove QSaveFile in favor of plain old file saving

cullmann added a comment. For the QFile case, I could query http://doc.qt.io/qt-5/qfiledevice.html#error, but for the FilterDev case I have no such function available, or? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D14890 To: cullmann, dhaumann, dfaure Cc: d

D14890: Remove QSaveFile in favor of plain old file saving

cullmann planned changes to this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D14890 To: cullmann, dhaumann, dfaure Cc: dfaure, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars, dhaumann

D14890: Remove QSaveFile in favor of plain old file saving

cullmann added a comment. Atm reverted the last addition of // did save work? - if (!saveFile->errorString().isEmpty()) { - BUFFER_DEBUG << "Saving file " << filename << "failed with error" << saveFile->errorString(); - return false; - } +//FIXME if (!saveFile->error

D14890: Remove QSaveFile in favor of plain old file saving

cullmann reopened this revision. cullmann added a comment. This revision is now accepted and ready to land. The errorString().isEmpty doesn't work, you get unknown error even for the non-errors cases. QFile would allow to check for the set errorCode. REPOSITORY R39 KTextEditor REVISION D

D14913: KCompressionDevice: propagate errors from QIODevice::close()BUG: 397545

cullmann requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D14913 To: dfaure, cullmann Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14913: KCompressionDevice: propagate errors from QIODevice::close()BUG: 397545

cullmann added a comment. Hmm, actually, that has other issues. You can't check errorString().isEmpty() for checking if an error is there. I just commited my other patch with the addition of that code (and was to dumb to run make test) e.g. even after constructing a QFile, you already

D14890: Remove QSaveFile in favor of plain old file saving

This revision was automatically updated to reflect the committed changes. Closed by commit R39:681cafb74607: Remove QSaveFile in favor of plain old file saving (authored by cullmann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14890?vs=39956&id=39962 R

D14890: Remove QSaveFile in favor of plain old file saving

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Looks reasonable to me. REPOSITORY R39 KTextEditor BRANCH nosavefile (branched from master) REVISION DETAIL https://phabricator.kde.org/D14890 To: cullmann, dhaumann, dfaure Cc:

D14912: Bindings: Make generator forward compatible with Python 3

arojas added a comment. This adds a new build time dependency to all frameworks which support bindings. Any chance to simply port it to python 3 instead? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D14912 To: bruns, #frameworks Cc: arojas, kde-framewo