D14661: Force reevaluation of Predicates if interfaces are removed

2018-08-11 Thread Anthony Fieroni
anthonyfieroni added inline comments. INLINE COMMENTS > udisksmanager.cpp:239 > +emit deviceRemoved(udi); > +emit deviceAdded(udi); > } Your code seems to work, but i don't get it - why device is added again? How predicate will work on removed device? REPOSITORY R245 So

D14692: Use custom QScrollArea with size hint not limited by font size

2018-08-11 Thread Nathaniel Graham
ngraham added a comment. Are you waiting for another review before landing this? REPOSITORY R295 KCMUtils BRANCH master REVISION DETAIL https://phabricator.kde.org/D14692 To: valeriymalov, #frameworks, ngraham Cc: ngraham, kde-frameworks-devel, michaelh, bruns

KDE CI: Frameworks knotifications kf5-qt5 WindowsMSVCQt5.10 - Build # 27 - Still unstable!

2018-08-11 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20knotifications%20kf5-qt5%20WindowsMSVCQt5.10/27/ Project: Frameworks knotifications kf5-qt5 WindowsMSVCQt5.10 Date of build: Sat, 11 Aug 2018 15:19:52 + Build duration: 13 hr and counting

Re: purpose unittest (AlternativesModelTest::runJobTest) fails randomly

2018-08-11 Thread Aleix Pol
On Thu, Aug 9, 2018 at 11:37 AM David Faure wrote: > > On lundi 6 août 2018 10:52:52 CEST Ben Cooksley wrote: > > On Mon, Aug 6, 2018 at 7:27 PM, David Faure wrote: > > > On lundi 6 août 2018 01:18:44 CEST Aleix Pol wrote: > > >> On Sat, Aug 4, 2018 at 12:31 PM David Faure wrote: > > >> > Any id

D14674: handle non-ASCII encodings of file names in tar archives

2018-08-11 Thread Rinat Ibragimov
ibragimovrinat updated this revision to Diff 39480. ibragimovrinat added a comment. Added couple of tests. One tests that file name's not truncated, and the other tests that checksum is calculated in a correct way. REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kd

D14744: Make Definition::isDelimiter() also work for invalid definitions

2018-08-11 Thread Dominik Haumann
This revision was automatically updated to reflect the committed changes. Closed by commit R216:eef5bce7080f: Make Definition::isDelimiter() also work for invalid definitions (authored by dhaumann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14

D14744: Make Definition::isDelimiter() also work for invalid definitions

2018-08-11 Thread Volker Krause
vkrause accepted this revision. REPOSITORY R216 Syntax Highlighting BRANCH delimiters-for-invalid-definitions (branched from master) REVISION DETAIL https://phabricator.kde.org/D14744 To: dhaumann, cullmann, vkrause Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, b

D14744: Make Definition::isDelimiter() also work for invalid definitions

2018-08-11 Thread Dominik Haumann
dhaumann updated this revision to Diff 39470. dhaumann added a comment. - Add support for getters of invalid Definitions REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14744?vs=39455&id=39470 BRANCH delimiters-for-invalid-definitions (branche

D14744: Make Definition::isDelimiter() also work for invalid definitions

2018-08-11 Thread Volker Krause
vkrause accepted this revision. REPOSITORY R216 Syntax Highlighting BRANCH delimiters-for-invalid-definitions (branched from master) REVISION DETAIL https://phabricator.kde.org/D14744 To: dhaumann, cullmann, vkrause Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, b

D14131: Add enum alias Property::Language for typo Property::Langauge

2018-08-11 Thread Friedrich W. H. Kossebau
This revision was automatically updated to reflect the committed changes. Closed by commit R286:0f5a6c892473: Add enum alias Property::Language for typo Property::Langauge (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D14131?vs=37798&id=39468#toc REPOSITORY R286

KDE CI: Frameworks ktexteditor kf5-qt5 WindowsMSVCQt5.10 - Build # 57 - Still unstable!

2018-08-11 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20WindowsMSVCQt5.10/57/ Project: Frameworks ktexteditor kf5-qt5 WindowsMSVCQt5.10 Date of build: Sat, 11 Aug 2018 15:20:10 + Build duration: 2 hr 4 min and counting J

D14131: Add enum alias Property::Language for typo Property::Langauge

2018-08-11 Thread Matthieu Gallien
mgallien accepted this revision. mgallien added a comment. This revision is now accepted and ready to land. Thanks for your work and good idea. REPOSITORY R286 KFileMetaData BRANCH fixLangaugeEnumTypoNow REVISION DETAIL https://phabricator.kde.org/D14131 To: kossebau, mgallien Cc: bco

KDE CI: Frameworks qqc2-desktop-style kf5-qt5 WindowsMSVCQt5.10 - Build # 65 - Fixed!

2018-08-11 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20qqc2-desktop-style%20kf5-qt5%20WindowsMSVCQt5.10/65/ Project: Frameworks qqc2-desktop-style kf5-qt5 WindowsMSVCQt5.10 Date of build: Sat, 11 Aug 2018 15:20:13 + Build duration: 1 hr 28 min and cou

KDE CI: Frameworks kjobwidgets kf5-qt5 WindowsMSVCQt5.10 - Build # 23 - Fixed!

2018-08-11 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kjobwidgets%20kf5-qt5%20WindowsMSVCQt5.10/23/ Project: Frameworks kjobwidgets kf5-qt5 WindowsMSVCQt5.10 Date of build: Sat, 11 Aug 2018 15:20:12 + Build duration: 1 hr 27 min and counting

KDE CI: Frameworks kwallet kf5-qt5 WindowsMSVCQt5.10 - Build # 26 - Fixed!

2018-08-11 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kwallet%20kf5-qt5%20WindowsMSVCQt5.10/26/ Project: Frameworks kwallet kf5-qt5 WindowsMSVCQt5.10 Date of build: Sat, 11 Aug 2018 15:20:06 + Build duration: 1 hr 25 min and counting JUnit Tes

KDE CI: Frameworks ktextwidgets kf5-qt5 WindowsMSVCQt5.10 - Build # 26 - Fixed!

2018-08-11 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20ktextwidgets%20kf5-qt5%20WindowsMSVCQt5.10/26/ Project: Frameworks ktextwidgets kf5-qt5 WindowsMSVCQt5.10 Date of build: Sat, 11 Aug 2018 15:20:09 + Build duration: 1 hr 24 min and counting

KDE CI: Frameworks kwidgetsaddons kf5-qt5 WindowsMSVCQt5.10 - Build # 46 - Still unstable!

2018-08-11 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20WindowsMSVCQt5.10/46/ Project: Frameworks kwidgetsaddons kf5-qt5 WindowsMSVCQt5.10 Date of build: Sat, 11 Aug 2018 15:20:06 + Build duration: 1 hr 21 min and counting

KDE CI: Frameworks kross kf5-qt5 WindowsMSVCQt5.10 - Build # 25 - Fixed!

2018-08-11 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kross%20kf5-qt5%20WindowsMSVCQt5.10/25/ Project: Frameworks kross kf5-qt5 WindowsMSVCQt5.10 Date of build: Sat, 11 Aug 2018 15:19:57 + Build duration: 1 hr 11 min and counting JUnit Tests

KDE CI: Frameworks threadweaver kf5-qt5 WindowsMSVCQt5.10 - Build # 23 - Fixed!

2018-08-11 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20threadweaver%20kf5-qt5%20WindowsMSVCQt5.10/23/ Project: Frameworks threadweaver kf5-qt5 WindowsMSVCQt5.10 Date of build: Sat, 11 Aug 2018 15:19:56 + Build duration: 1 hr 6 min and counting

D14723: Add option to disable KWallet entirely in the new wallet dialog

2018-08-11 Thread Fabian Vogt
fvogt added a comment. In D14723#306659 , @aacid wrote: > Isn't this actually bad for the privacy goal? AFAIK some apps will just write the password in cleartext in a config file when kwallet is not present. It's not selected by default -

KDE CI: Frameworks kparts kf5-qt5 WindowsMSVCQt5.10 - Build # 26 - Fixed!

2018-08-11 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kparts%20kf5-qt5%20WindowsMSVCQt5.10/26/ Project: Frameworks kparts kf5-qt5 WindowsMSVCQt5.10 Date of build: Sat, 11 Aug 2018 15:19:56 + Build duration: 1 hr 1 min and counting JUnit Tests

D14723: Add option to disable KWallet entirely in the new wallet dialog

2018-08-11 Thread Albert Astals Cid
aacid added a comment. Isn't this actually bad for the privacy goal? AFAIK some apps will just write the password in cleartext in a config file when kwallet is not present. INLINE COMMENTS > knewwalletdialog.h:67 > protected Q_SLOTS: > -void onBlowfishToggled(bool); > +void onGpgTog

KDE CI: Frameworks kpackage kf5-qt5 WindowsMSVCQt5.10 - Build # 49 - Still unstable!

2018-08-11 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20WindowsMSVCQt5.10/49/ Project: Frameworks kpackage kf5-qt5 WindowsMSVCQt5.10 Date of build: Sat, 11 Aug 2018 15:19:55 + Build duration: 56 min and counting JUnit Tests

D14747: [Exe Thumbnailer] Don't generate QTemporaryFile

2018-08-11 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Frameworks, Windows. broulik requested review of this revision. REVISION SUMMARY Keep everything in memory and don't needlessly write to disk TEST PLAN - Thumbnails still generate just fine - Doesn't create files in `/tmp` anymore -

KDE CI: Frameworks knotifyconfig kf5-qt5 WindowsMSVCQt5.10 - Build # 22 - Fixed!

2018-08-11 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20knotifyconfig%20kf5-qt5%20WindowsMSVCQt5.10/22/ Project: Frameworks knotifyconfig kf5-qt5 WindowsMSVCQt5.10 Date of build: Sat, 11 Aug 2018 15:19:54 + Build duration: 52 min and counting

KDE CI: Frameworks sonnet kf5-qt5 WindowsMSVCQt5.10 - Build # 33 - Fixed!

2018-08-11 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20sonnet%20kf5-qt5%20WindowsMSVCQt5.10/33/ Project: Frameworks sonnet kf5-qt5 WindowsMSVCQt5.10 Date of build: Sat, 11 Aug 2018 15:19:53 + Build duration: 49 min and counting JUnit Tests

KDE CI: Frameworks kunitconversion kf5-qt5 WindowsMSVCQt5.10 - Build # 22 - Fixed!

2018-08-11 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kunitconversion%20kf5-qt5%20WindowsMSVCQt5.10/22/ Project: Frameworks kunitconversion kf5-qt5 WindowsMSVCQt5.10 Date of build: Sat, 11 Aug 2018 15:19:52 + Build duration: 46 min and counting

KDE CI: Frameworks plasma-framework kf5-qt5 WindowsMSVCQt5.10 - Build # 121 - Still unstable!

2018-08-11 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20WindowsMSVCQt5.10/121/ Project: Frameworks plasma-framework kf5-qt5 WindowsMSVCQt5.10 Date of build: Sat, 11 Aug 2018 15:19:51 + Build duration: 42 min and counting

D9387: Add cross compile support for kconfig_compiler and kconf_update.

2018-08-11 Thread Ralf Habacker
habacker added a comment. Sorry for the two spam comments, I had a freeze at phabricator web site. > Here's the android scripts for reference. https://cgit.kde.org/sysadmin/ci-tooling.git/tree/system-images/android/sdk Ah I see, on Android the packages containing native tools are bui

D14308: [Exe Thumbnailer] Improve icon selection algorithm

2018-08-11 Thread Kai Uwe Broulik
broulik updated this revision to Diff 39462. broulik edited the test plan for this revision. broulik added a comment. - Use algorithm suggested by Stefan, thanks. REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14308?vs=38296&id=39462 REVISION DETAIL h

KDE CI: Frameworks syntax-highlighting kf5-qt5 WindowsMSVCQt5.10 - Build # 72 - Fixed!

2018-08-11 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20WindowsMSVCQt5.10/72/ Project: Frameworks syntax-highlighting kf5-qt5 WindowsMSVCQt5.10 Date of build: Sat, 11 Aug 2018 15:19:51 + Build duration: 22 min and counti

KDE CI: Frameworks kmediaplayer kf5-qt5 WindowsMSVCQt5.10 - Build # 21 - Fixed!

2018-08-11 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kmediaplayer%20kf5-qt5%20WindowsMSVCQt5.10/21/ Project: Frameworks kmediaplayer kf5-qt5 WindowsMSVCQt5.10 Date of build: Sat, 11 Aug 2018 15:19:50 + Build duration: 21 min and counting JUni

D12380: [Containment Interface] Honor plasma/containment_context_menu restriction

2018-08-11 Thread Kai Uwe Broulik
broulik abandoned this revision. Restricted Application edited subscribers, added: kde-frameworks-devel; removed: Frameworks. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D12380 To: broulik, #plasma, sitter Cc: kde-frameworks-devel, michaelh, ngraha

KDE CI: Frameworks knewstuff kf5-qt5 WindowsMSVCQt5.10 - Build # 59 - Still unstable!

2018-08-11 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20knewstuff%20kf5-qt5%20WindowsMSVCQt5.10/59/ Project: Frameworks knewstuff kf5-qt5 WindowsMSVCQt5.10 Date of build: Sat, 11 Aug 2018 15:19:50 + Build duration: 19 min and counting JUnit Tes

KDE CI: Frameworks kjs kf5-qt5 WindowsMSVCQt5.10 - Build # 20 - Fixed!

2018-08-11 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kjs%20kf5-qt5%20WindowsMSVCQt5.10/20/ Project: Frameworks kjs kf5-qt5 WindowsMSVCQt5.10 Date of build: Sat, 11 Aug 2018 15:19:48 + Build duration: 15 min and counting JUnit Tests Name

KDE CI: Frameworks kjsembed kf5-qt5 WindowsMSVCQt5.10 - Build # 19 - Fixed!

2018-08-11 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kjsembed%20kf5-qt5%20WindowsMSVCQt5.10/19/ Project: Frameworks kjsembed kf5-qt5 WindowsMSVCQt5.10 Date of build: Sat, 11 Aug 2018 15:19:49 + Build duration: 16 min and counting

KDE CI: Frameworks kwindowsystem kf5-qt5 WindowsMSVCQt5.10 - Build # 27 - Fixed!

2018-08-11 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20WindowsMSVCQt5.10/27/ Project: Frameworks kwindowsystem kf5-qt5 WindowsMSVCQt5.10 Date of build: Sat, 11 Aug 2018 15:19:48 + Build duration: 15 min and counting JU

KDE CI: Frameworks solid kf5-qt5 WindowsMSVCQt5.10 - Build # 39 - Still unstable!

2018-08-11 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20solid%20kf5-qt5%20WindowsMSVCQt5.10/39/ Project: Frameworks solid kf5-qt5 WindowsMSVCQt5.10 Date of build: Sat, 11 Aug 2018 15:15:43 + Build duration: 17 min and counting JUnit Tests

KDE CI: Frameworks kservice kf5-qt5 WindowsMSVCQt5.10 - Build # 41 - Still unstable!

2018-08-11 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20WindowsMSVCQt5.10/41/ Project: Frameworks kservice kf5-qt5 WindowsMSVCQt5.10 Date of build: Sat, 11 Aug 2018 15:19:21 + Build duration: 12 min and counting JUnit Tests

KDE CI: Frameworks purpose kf5-qt5 WindowsMSVCQt5.10 - Build # 78 - Still unstable!

2018-08-11 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20WindowsMSVCQt5.10/78/ Project: Frameworks purpose kf5-qt5 WindowsMSVCQt5.10 Date of build: Sat, 11 Aug 2018 15:15:33 + Build duration: 7 min 50 sec and counting JUnit T

KDE CI: Frameworks kunitconversion kf5-qt5 AndroidQt5.11 - Build # 12 - Still Failing!

2018-08-11 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kunitconversion%20kf5-qt5%20AndroidQt5.11/12/ Project: Frameworks kunitconversion kf5-qt5 AndroidQt5.11 Date of build: Sat, 11 Aug 2018 15:20:08 + Build duration: 2 min 47 sec and counting

D7033: Port ki18n from QtScript to QtQml

2018-08-11 Thread Allan Sandfeld Jensen
carewolf updated this revision to Diff 39460. carewolf added a comment. Updated and ensured autotests passes. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7033?vs=17489&id=39460 REVISION DETAIL https://phabricator.kde.org/D7033 AFFECTED FILES CMakeLists.txt autotests/CMakeL

KDE CI: Frameworks kxmlrpcclient kf5-qt5 WindowsMSVCQt5.10 - Build # 21 - Fixed!

2018-08-11 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kxmlrpcclient%20kf5-qt5%20WindowsMSVCQt5.10/21/ Project: Frameworks kxmlrpcclient kf5-qt5 WindowsMSVCQt5.10 Date of build: Sat, 11 Aug 2018 15:15:24 + Build duration: 5 min 9 sec and counting

KDE CI: Frameworks kpackage kf5-qt5 AndroidQt5.11 - Build # 14 - Still Failing!

2018-08-11 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20AndroidQt5.11/14/ Project: Frameworks kpackage kf5-qt5 AndroidQt5.11 Date of build: Sat, 11 Aug 2018 15:19:54 + Build duration: 35 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks krunner kf5-qt5 WindowsMSVCQt5.10 - Build # 26 - Still unstable!

2018-08-11 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20WindowsMSVCQt5.10/26/ Project: Frameworks krunner kf5-qt5 WindowsMSVCQt5.10 Date of build: Sat, 11 Aug 2018 15:15:05 + Build duration: 4 min 41 sec and counting JUnit T

KDE CI: Frameworks kplotting kf5-qt5 WindowsMSVCQt5.10 - Build # 21 - Fixed!

2018-08-11 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kplotting%20kf5-qt5%20WindowsMSVCQt5.10/21/ Project: Frameworks kplotting kf5-qt5 WindowsMSVCQt5.10 Date of build: Sat, 11 Aug 2018 15:14:55 + Build duration: 3 min 24 sec and counting JUni

KDE CI: Frameworks kross kf5-qt5 WindowsMSVCQt5.10 - Build # 24 - Still Failing!

2018-08-11 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kross%20kf5-qt5%20WindowsMSVCQt5.10/24/ Project: Frameworks kross kf5-qt5 WindowsMSVCQt5.10 Date of build: Sat, 11 Aug 2018 15:14:35 + Build duration: 1 min 38 sec and counting CONSOLE OUTP

KDE CI: Frameworks kparts kf5-qt5 WindowsMSVCQt5.10 - Build # 25 - Still Failing!

2018-08-11 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kparts%20kf5-qt5%20WindowsMSVCQt5.10/25/ Project: Frameworks kparts kf5-qt5 WindowsMSVCQt5.10 Date of build: Sat, 11 Aug 2018 15:14:20 + Build duration: 1 min 36 sec and counting CONSOLE OU

KDE CI: Frameworks syntax-highlighting kf5-qt5 WindowsMSVCQt5.10 - Build # 71 - Failure!

2018-08-11 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20WindowsMSVCQt5.10/71/ Project: Frameworks syntax-highlighting kf5-qt5 WindowsMSVCQt5.10 Date of build: Sat, 11 Aug 2018 13:55:29 + Build duration: 1 hr 20 min and c

KDE CI: Frameworks kpackage kf5-qt5 WindowsMSVCQt5.10 - Build # 48 - Still Failing!

2018-08-11 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20WindowsMSVCQt5.10/48/ Project: Frameworks kpackage kf5-qt5 WindowsMSVCQt5.10 Date of build: Sat, 11 Aug 2018 15:14:28 + Build duration: 1 min 35 sec and counting CONSOL

KDE CI: Frameworks knotifications kf5-qt5 WindowsMSVCQt5.10 - Build # 26 - Still Failing!

2018-08-11 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20knotifications%20kf5-qt5%20WindowsMSVCQt5.10/26/ Project: Frameworks knotifications kf5-qt5 WindowsMSVCQt5.10 Date of build: Sat, 11 Aug 2018 15:14:11 + Build duration: 1 min 37 sec and counting

KDE CI: Frameworks threadweaver kf5-qt5 WindowsMSVCQt5.10 - Build # 22 - Failure!

2018-08-11 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20threadweaver%20kf5-qt5%20WindowsMSVCQt5.10/22/ Project: Frameworks threadweaver kf5-qt5 WindowsMSVCQt5.10 Date of build: Sat, 11 Aug 2018 13:55:32 + Build duration: 1 hr 20 min and counting

KDE CI: Frameworks sonnet kf5-qt5 WindowsMSVCQt5.10 - Build # 32 - Failure!

2018-08-11 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20sonnet%20kf5-qt5%20WindowsMSVCQt5.10/32/ Project: Frameworks sonnet kf5-qt5 WindowsMSVCQt5.10 Date of build: Sat, 11 Aug 2018 13:55:26 + Build duration: 1 hr 19 min and counting CONSOLE OUT

KDE CI: Frameworks solid kf5-qt5 WindowsMSVCQt5.10 - Build # 38 - Failure!

2018-08-11 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20solid%20kf5-qt5%20WindowsMSVCQt5.10/38/ Project: Frameworks solid kf5-qt5 WindowsMSVCQt5.10 Date of build: Sat, 11 Aug 2018 13:55:21 + Build duration: 1 hr 19 min and counting CONSOLE OUTPU

KDE CI: Frameworks qqc2-desktop-style kf5-qt5 WindowsMSVCQt5.10 - Build # 64 - Failure!

2018-08-11 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20qqc2-desktop-style%20kf5-qt5%20WindowsMSVCQt5.10/64/ Project: Frameworks qqc2-desktop-style kf5-qt5 WindowsMSVCQt5.10 Date of build: Sat, 11 Aug 2018 13:55:17 + Build duration: 1 hr 19 min and cou

KDE CI: Frameworks purpose kf5-qt5 WindowsMSVCQt5.10 - Build # 77 - Failure!

2018-08-11 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20WindowsMSVCQt5.10/77/ Project: Frameworks purpose kf5-qt5 WindowsMSVCQt5.10 Date of build: Sat, 11 Aug 2018 13:55:13 + Build duration: 1 hr 19 min and counting CONSOLE O

KDE CI: Frameworks plasma-framework kf5-qt5 WindowsMSVCQt5.10 - Build # 120 - Failure!

2018-08-11 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20WindowsMSVCQt5.10/120/ Project: Frameworks plasma-framework kf5-qt5 WindowsMSVCQt5.10 Date of build: Sat, 11 Aug 2018 13:55:07 + Build duration: 1 hr 19 min and counti

KDE CI: Frameworks kxmlrpcclient kf5-qt5 WindowsMSVCQt5.10 - Build # 20 - Failure!

2018-08-11 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kxmlrpcclient%20kf5-qt5%20WindowsMSVCQt5.10/20/ Project: Frameworks kxmlrpcclient kf5-qt5 WindowsMSVCQt5.10 Date of build: Sat, 11 Aug 2018 13:54:51 + Build duration: 1 hr 19 min and counting

KDE CI: Frameworks kwidgetsaddons kf5-qt5 WindowsMSVCQt5.10 - Build # 45 - Failure!

2018-08-11 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20WindowsMSVCQt5.10/45/ Project: Frameworks kwidgetsaddons kf5-qt5 WindowsMSVCQt5.10 Date of build: Sat, 11 Aug 2018 13:54:42 + Build duration: 1 hr 18 min and counting

KDE CI: Frameworks kwindowsystem kf5-qt5 WindowsMSVCQt5.10 - Build # 26 - Failure!

2018-08-11 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20WindowsMSVCQt5.10/26/ Project: Frameworks kwindowsystem kf5-qt5 WindowsMSVCQt5.10 Date of build: Sat, 11 Aug 2018 13:54:46 + Build duration: 1 hr 18 min and counting

KDE CI: Frameworks kwallet kf5-qt5 WindowsMSVCQt5.10 - Build # 25 - Failure!

2018-08-11 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kwallet%20kf5-qt5%20WindowsMSVCQt5.10/25/ Project: Frameworks kwallet kf5-qt5 WindowsMSVCQt5.10 Date of build: Sat, 11 Aug 2018 13:54:34 + Build duration: 1 hr 18 min and counting CONSOLE O

KDE CI: Frameworks kunitconversion kf5-qt5 WindowsMSVCQt5.10 - Build # 21 - Failure!

2018-08-11 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kunitconversion%20kf5-qt5%20WindowsMSVCQt5.10/21/ Project: Frameworks kunitconversion kf5-qt5 WindowsMSVCQt5.10 Date of build: Sat, 11 Aug 2018 13:54:32 + Build duration: 1 hr 18 min and counting

KDE CI: Frameworks ktextwidgets kf5-qt5 WindowsMSVCQt5.10 - Build # 25 - Failure!

2018-08-11 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20ktextwidgets%20kf5-qt5%20WindowsMSVCQt5.10/25/ Project: Frameworks ktextwidgets kf5-qt5 WindowsMSVCQt5.10 Date of build: Sat, 11 Aug 2018 13:54:27 + Build duration: 1 hr 17 min and counting

KDE CI: Frameworks ktexteditor kf5-qt5 WindowsMSVCQt5.10 - Build # 56 - Failure!

2018-08-11 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20WindowsMSVCQt5.10/56/ Project: Frameworks ktexteditor kf5-qt5 WindowsMSVCQt5.10 Date of build: Sat, 11 Aug 2018 13:54:25 + Build duration: 1 hr 17 min and counting C

KDE CI: Frameworks kservice kf5-qt5 WindowsMSVCQt5.10 - Build # 40 - Failure!

2018-08-11 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20WindowsMSVCQt5.10/40/ Project: Frameworks kservice kf5-qt5 WindowsMSVCQt5.10 Date of build: Sat, 11 Aug 2018 13:54:19 + Build duration: 1 hr 17 min and counting CONSOLE

KDE CI: Frameworks kross kf5-qt5 WindowsMSVCQt5.10 - Build # 23 - Failure!

2018-08-11 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kross%20kf5-qt5%20WindowsMSVCQt5.10/23/ Project: Frameworks kross kf5-qt5 WindowsMSVCQt5.10 Date of build: Sat, 11 Aug 2018 13:54:14 + Build duration: 1 hr 17 min and counting CONSOLE OUTPU

KDE CI: Frameworks kparts kf5-qt5 WindowsMSVCQt5.10 - Build # 24 - Failure!

2018-08-11 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kparts%20kf5-qt5%20WindowsMSVCQt5.10/24/ Project: Frameworks kparts kf5-qt5 WindowsMSVCQt5.10 Date of build: Sat, 11 Aug 2018 13:53:59 + Build duration: 1 hr 17 min and counting CONSOLE OUT

KDE CI: Frameworks krunner kf5-qt5 WindowsMSVCQt5.10 - Build # 25 - Failure!

2018-08-11 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20WindowsMSVCQt5.10/25/ Project: Frameworks krunner kf5-qt5 WindowsMSVCQt5.10 Date of build: Sat, 11 Aug 2018 13:54:16 + Build duration: 1 hr 17 min and counting CONSOLE O

KDE CI: Frameworks kplotting kf5-qt5 WindowsMSVCQt5.10 - Build # 20 - Failure!

2018-08-11 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kplotting%20kf5-qt5%20WindowsMSVCQt5.10/20/ Project: Frameworks kplotting kf5-qt5 WindowsMSVCQt5.10 Date of build: Sat, 11 Aug 2018 13:54:05 + Build duration: 1 hr 17 min and counting CONSO

KDE CI: Frameworks kpackage kf5-qt5 WindowsMSVCQt5.10 - Build # 47 - Failure!

2018-08-11 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20WindowsMSVCQt5.10/47/ Project: Frameworks kpackage kf5-qt5 WindowsMSVCQt5.10 Date of build: Sat, 11 Aug 2018 13:53:55 + Build duration: 1 hr 16 min and counting CONSOLE

KDE CI: Frameworks knewstuff kf5-qt5 WindowsMSVCQt5.10 - Build # 58 - Failure!

2018-08-11 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20knewstuff%20kf5-qt5%20WindowsMSVCQt5.10/58/ Project: Frameworks knewstuff kf5-qt5 WindowsMSVCQt5.10 Date of build: Sat, 11 Aug 2018 13:53:46 + Build duration: 1 hr 16 min and counting CONSO

KDE CI: Frameworks knotifications kf5-qt5 WindowsMSVCQt5.10 - Build # 25 - Failure!

2018-08-11 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20knotifications%20kf5-qt5%20WindowsMSVCQt5.10/25/ Project: Frameworks knotifications kf5-qt5 WindowsMSVCQt5.10 Date of build: Sat, 11 Aug 2018 13:53:49 + Build duration: 1 hr 16 min and counting

KDE CI: Frameworks knotifyconfig kf5-qt5 WindowsMSVCQt5.10 - Build # 21 - Failure!

2018-08-11 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20knotifyconfig%20kf5-qt5%20WindowsMSVCQt5.10/21/ Project: Frameworks knotifyconfig kf5-qt5 WindowsMSVCQt5.10 Date of build: Sat, 11 Aug 2018 13:53:51 + Build duration: 1 hr 16 min and counting

KDE CI: Frameworks kjsembed kf5-qt5 WindowsMSVCQt5.10 - Build # 18 - Failure!

2018-08-11 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kjsembed%20kf5-qt5%20WindowsMSVCQt5.10/18/ Project: Frameworks kjsembed kf5-qt5 WindowsMSVCQt5.10 Date of build: Sat, 11 Aug 2018 13:53:39 + Build duration: 1 hr 16 min and counting CONSOLE

KDE CI: Frameworks kmediaplayer kf5-qt5 WindowsMSVCQt5.10 - Build # 20 - Failure!

2018-08-11 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kmediaplayer%20kf5-qt5%20WindowsMSVCQt5.10/20/ Project: Frameworks kmediaplayer kf5-qt5 WindowsMSVCQt5.10 Date of build: Sat, 11 Aug 2018 13:53:41 + Build duration: 1 hr 16 min and counting

KDE CI: Frameworks kjs kf5-qt5 WindowsMSVCQt5.10 - Build # 19 - Failure!

2018-08-11 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kjs%20kf5-qt5%20WindowsMSVCQt5.10/19/ Project: Frameworks kjs kf5-qt5 WindowsMSVCQt5.10 Date of build: Sat, 11 Aug 2018 13:53:36 + Build duration: 1 hr 16 min and counting CONSOLE OUTPUT

KDE CI: Frameworks kjobwidgets kf5-qt5 WindowsMSVCQt5.10 - Build # 22 - Failure!

2018-08-11 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kjobwidgets%20kf5-qt5%20WindowsMSVCQt5.10/22/ Project: Frameworks kjobwidgets kf5-qt5 WindowsMSVCQt5.10 Date of build: Sat, 11 Aug 2018 13:53:31 + Build duration: 1 hr 16 min and counting C

KDE CI: Frameworks kwindowsystem kf5-qt5 SUSEQt5.9 - Build # 25 - Still Unstable!

2018-08-11 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20SUSEQt5.9/25/ Project: Frameworks kwindowsystem kf5-qt5 SUSEQt5.9 Date of build: Sat, 11 Aug 2018 13:54:45 + Build duration: 47 min and counting JUnit Tests

KDE CI: Frameworks kdelibs4support kf5-qt5 SUSEQt5.9 - Build # 34 - Still Unstable!

2018-08-11 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.9/34/ Project: Frameworks kdelibs4support kf5-qt5 SUSEQt5.9 Date of build: Sat, 11 Aug 2018 13:52:21 + Build duration: 40 min and counting JUnit Tests

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.9 - Build # 47 - Still Unstable!

2018-08-11 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.9/47/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.9 Date of build: Sat, 11 Aug 2018 13:52:05 + Build duration: 39 min and counting JUnit Tests Nam

KDE CI: Frameworks kwidgetsaddons kf5-qt5 SUSEQt5.10 - Build # 69 - Fixed!

2018-08-11 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20SUSEQt5.10/69/ Project: Frameworks kwidgetsaddons kf5-qt5 SUSEQt5.10 Date of build: Sat, 11 Aug 2018 13:54:42 + Build duration: 31 min and counting JUnit Tests

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 195 - Still Unstable!

2018-08-11 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/195/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Sat, 11 Aug 2018 13:55:07 + Build duration: 28 min and counting JUnit Te

KDE CI: Frameworks kwindowsystem kf5-qt5 SUSEQt5.10 - Build # 37 - Still Unstable!

2018-08-11 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20SUSEQt5.10/37/ Project: Frameworks kwindowsystem kf5-qt5 SUSEQt5.10 Date of build: Sat, 11 Aug 2018 13:54:45 + Build duration: 28 min and counting JUnit Tests

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.10 - Build # 45 - Fixed!

2018-08-11 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.10/45/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.10 Date of build: Sat, 11 Aug 2018 13:55:07 + Build duration: 20 min and counting

KDE CI: Frameworks kwindowsystem kf5-qt5 FreeBSDQt5.10 - Build # 13 - Fixed!

2018-08-11 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20FreeBSDQt5.10/13/ Project: Frameworks kwindowsystem kf5-qt5 FreeBSDQt5.10 Date of build: Sat, 11 Aug 2018 13:54:45 + Build duration: 17 min and counting

KDE CI: Frameworks kwayland kf5-qt5 FreeBSDQt5.10 - Build # 42 - Fixed!

2018-08-11 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20FreeBSDQt5.10/42/ Project: Frameworks kwayland kf5-qt5 FreeBSDQt5.10 Date of build: Sat, 11 Aug 2018 13:54:37 + Build duration: 16 min and counting

KDE CI: Frameworks kpty kf5-qt5 FreeBSDQt5.10 - Build # 14 - Fixed!

2018-08-11 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kpty%20kf5-qt5%20FreeBSDQt5.10/14/ Project: Frameworks kpty kf5-qt5 FreeBSDQt5.10 Date of build: Sat, 11 Aug 2018 13:54:10 + Build duration: 13 min and counting

KDE CI: Frameworks kdelibs4support kf5-qt5 SUSEQt5.10 - Build # 60 - Still Unstable!

2018-08-11 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.10/60/ Project: Frameworks kdelibs4support kf5-qt5 SUSEQt5.10 Date of build: Sat, 11 Aug 2018 13:52:21 + Build duration: 13 min and counting JUnit Tests

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 102 - Still Unstable!

2018-08-11 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/102/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 Date of build: Sat, 11 Aug 2018 13:52:06 + Build duration: 10 min and counting JUnit Tests

KDE CI: Frameworks kpackage kf5-qt5 AndroidQt5.11 - Build # 13 - Still Failing!

2018-08-11 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20AndroidQt5.11/13/ Project: Frameworks kpackage kf5-qt5 AndroidQt5.11 Date of build: Sat, 11 Aug 2018 13:53:56 + Build duration: 1 min 45 sec and counting CONSOLE OUTPUT

D14743: Copy PlasmaCore binary qmldir file structure into bin for unit testsThis way tests pass before installation.

2018-08-11 Thread David Edmundson
davidedmundson updated this revision to Diff 39458. davidedmundson added a comment. Copy at build time REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14743?vs=39454&id=39458 BRANCH master REVISION DETAIL https://phabricator.kde.org/

D14744: Make Definition::isDelimiter() also work for invalid definitions

2018-08-11 Thread Christoph Cullmann
cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Avoids to have that workaround on the user side. Actually I think we want that, too, for things like "formats", that you always have some default normal format. But that is a differe

D14744: Make Definition::isDelimiter() also work for invalid definitions

2018-08-11 Thread Dominik Haumann
dhaumann created this revision. dhaumann added reviewers: cullmann, vkrause. Restricted Application added projects: Kate, Frameworks. Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. dhaumann requested review of this revision. REVISION SUMMARY Used by KTextEditor. T

D14743: Copy PlasmaCore binary qmldir file structure into bin for unit testsThis way tests pass before installation.

2018-08-11 Thread David Faure
dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > CMakeLists.txt:73 > +# #also install to $BUILD_DIR/bin for unit tests > +install(TARGETS corebindingsplugin DESTINATION > ${CMAKE_BINARY_DIR}/bin/org/kde/plas

D14743: Copy PlasmaCore binary qmldir file structure into bin for unit testsThis way tests pass before installation.

2018-08-11 Thread David Edmundson
davidedmundson updated this revision to Diff 39454. davidedmundson added a comment. whitespace REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14743?vs=39453&id=39454 BRANCH master REVISION DETAIL https://phabricator.kde.org/D14743

D14743: Copy PlasmaCore binary qmldir file structure into bin for unit testsThis way tests pass before installation.

2018-08-11 Thread David Edmundson
davidedmundson retitled this revision from "Copy PlasmaCore binary qmldir file structure into bin for unit tests This way tests pass before installation." to "Copy PlasmaCore binary qmldir file structure into bin for unit testsThis way tests pass before installation.". davidedmundson added a rev

D14743: Copy PlasmaCore binary qmldir file structure into bin for unit testsThis way tests pass before installation.

2018-08-11 Thread David Edmundson
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. TEST PLAN Before patch Created a broken env b

D14741: Definition: Expose bool isDelimiter() const

2018-08-11 Thread Dominik Haumann
This revision was automatically updated to reflect the committed changes. Closed by commit R216:196ddc151b85: Definition: Expose bool isDelimiter() const (authored by dhaumann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14741?vs=39442&id=39452

D14741: Definition: Expose bool isDelimiter() const

2018-08-11 Thread Christoph Cullmann
cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Needed for KTextEditor and better than to expose the characters directly as done before in KTextEditor itself. REPOSITORY R216 Syntax Highlighting BRANCH is-delimiter (branched fro

D14201: Set system default shortcut Ctrl+0 for "Actual Size" action

2018-08-11 Thread Peter Mühlenpfordt
This revision was automatically updated to reflect the committed changes. Closed by commit R237:f651a817ab00: Set system default shortcut Ctrl+0 for "Actual Size" action (authored by muhlenpfordt). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14201?vs=38004&

  1   2   >