D14544: Android: Don't hardcode a random version of the Android SDK

alexeymin added a comment. From all of my installed build tools: `19.1.0, 20.0.0, 21.1.2, 22.0.1, 23.0.1, 23.0.2, 23.0.3, 24.0.0, 26.0.1` it selects _default_sdk as `19.1.0`, is it fine? 😄 REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D14544 To: apol,

D14529: Android: Make sure Qm translations get loaded

apol added a comment. I don't really see how, with the information we have provided today. Here I printed the env variables and QStandardPath values at boot. stdpaths 0 QStandardPaths::StandardLocation(DesktopLocation) ("/data/user/0/org.kde.kalgebramobile/files") stdpaths 1 QS

D14544: Android: Don't hardcode a random version of the Android SDK

apol created this revision. apol added reviewers: Frameworks, vkrause. Restricted Application added projects: Frameworks, Build System. Restricted Application added subscribers: kde-buildsystem, kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY Just default to whiche

D14529: Android: Make sure Qm translations get loaded

aacid added a comment. Is there a way we can get /../qt-reserved-files/share/ in a more natural way? fishing up to .. feels always like it'll break REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D14529 To: apol, #frameworks Cc: aacid, kde-frameworks-deve

D14504: Save few string allocations

apol abandoned this revision. apol added a comment. Probably not worth it if it needs to become public. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D14504 To: apol, #frameworks, ilic Cc: dfaure, pino, kde-frameworks-devel, michaelh, ngraham, bruns

D10362: Swap reveal password button logic

rizzitello added a comment. Restricted Application edited subscribers, added: kde-frameworks-devel; removed: Frameworks. In D10362#202592 , @elvisangelaccio wrote: > Would it be possible to implement this feature like in the Windows 10 lock scr

D14457: Forward-declare X509 structure

ngraham added reviewers: Frameworks, cfeck. REPOSITORY R239 KDELibs4Support REVISION DETAIL https://phabricator.kde.org/D14457 To: luc4, #frameworks, cfeck Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14541: ECMOptionalAddSubdirectory: Provide a bit more detail

This revision was automatically updated to reflect the committed changes. Closed by commit R240:59b311bcc2ed: ECMOptionalAddSubdirectory: Provide a bit more detail (authored by heikobecker). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14541?vs=3

D14360: Remove custom icon selection for trash

shubham updated this revision to Diff 38913. shubham added a comment. remove @since tag, return m_iconButton != nullptr REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14360?vs=38868&id=38913 REVISION DETAIL https://phabricator.kde.org/D14360 AFFECTED FIL

D14360: Remove custom icon selection for trash

shubham added a comment. @anthonyfieroni righty said , strictly it should return T/F REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14360 To: shubham, ngraham, broulik, #dolphin, #frameworks, pino Cc: anthonyfieroni, cfeck, pino, kde-frameworks-devel, michaelh, ngraham,

D14360: Remove custom icon selection for trash

anthonyfieroni added inline comments. INLINE COMMENTS > kfileplaceeditdialog.cpp:220 > +{ > +return m_iconButton; > +} This will produce error on strict level it should be m_iconButton != nullptr REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14360 To: shubham, ng

Fwd: KDE CI: Dependency Build Extragear kf5-qt5 SUSEQt5.9 - Build # 121 - Still Failing!

Hi folks, Looks like there has been a regression in libkscreen, as can be seen below. Can someone please take a look? Thanks, Ben -- Forwarded message -- From: CI System Date: Thu, Aug 2, 2018 at 1:00 AM Subject: KDE CI: Dependency Build Extragear kf5-qt5 SUSEQt5.9 - Build # 12

D14360: Remove custom icon selection for trash

shubham added a comment. ping? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14360 To: shubham, ngraham, broulik, #dolphin, #frameworks, pino Cc: cfeck, pino, kde-frameworks-devel, michaelh, ngraham, bruns

D14541: ECMOptionalAddSubdirectory: Provide a bit more detail

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D14541 To: heikobecker, apol Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D14541: ECMOptionalAddSubdirectory: Provide a bit more detail

heikobecker created this revision. Restricted Application added projects: Frameworks, Build System. Restricted Application added subscribers: kde-buildsystem, kde-frameworks-devel. heikobecker requested review of this revision. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAI

D14528: Android: Make sure we're looking for .mo files in the right path

apol added a comment. In D14528#301809 , @ltoscano wrote: > Is this a possible Qt bug where the output of QStandardPaths should be tuned on Android? Not really, QStandardPaths are something that feels quite alien to Android already. We c

D14528: Android: Make sure we're looking for .mo files in the right path

ltoscano added a comment. Is this a possible Qt bug where the output of QStandardPaths should be tuned on Android? REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D14528 To: apol, #frameworks, ilic, ckertesz Cc: ltoscano, kde-frameworks-devel, michaelh, ngraham, bruns

D14400: Fix Mixed to Upper mode latching in Aztec code generation

vkrause added a reviewer: svuorela. REPOSITORY R280 Prison REVISION DETAIL https://phabricator.kde.org/D14400 To: vkrause, svuorela Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14397: Support libcanberra for audio notification

rjvbb added a comment. That was already mentioned :) I see no problem with those components depending on something that is probably inevitable in a "linuxy desktop" environment. Also FYI: I built the latest canberra (PA support disabled) and gstreamer1 on Mac and am not getting any

D6513: Add support for Attica tags support

leinir added a comment. @mlaurent quick ping? :) Also in general, sorry, would really like to get this merged in asap - i realise it's the summer holidays for a lot of people ;) REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D6513 To: leinir, #knewstuff, apol

D14397: Support libcanberra for audio notification

dfaure added a comment. Just FYI, canberra is already an optional dependency of kmix and plasma-pa. https://lxr.kde.org/search?_filestring=CMakeLists.txt&_string=canberra REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D14397 To: broulik, #frameworks, dfaure,

D14504: Save few string allocations

dfaure added a comment. Has this been measured to actually reduce the number of string allocations? (e.g. using heaptrack)? If so, I'm fine with it. If a public API is needed, then indeed that will have different considerations -- it might want to them wrap the internal QStringRef-based

D12709: Allow skipping the build of the KPackage install handlers when building `frameworkintegration`

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. We have done similar things in other frameworks, to indeed make it easier to reuse them in contexts where not all dependencies are wanted. See SONNET_USE_WIDGETS, KSYNTAXHIGHLIGHTING_USE_G

D14531: [Icon Item] Use ItemEnabledHasChanged

broulik created this revision. broulik added reviewers: Plasma, davidedmundson. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Preferred over having a connect and it

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.10 - Build # 40 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.10/40/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.10 Date of build: Wed, 01 Aug 2018 03:52:13 + Build duration: 4 hr 43 min and counting

D14434: add functions to access keywords

dhaumann added a comment. @asemke Ok, thanks. It's available for 5.49, which is scheduled for released for Saturda 11th of August. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14434 To: jpoelen, #framework_syntax_highlighting, dhaumann, asemke Cc: vkr

D14524: Fix compiler warning -Wimplicit-fallthrough

dhaumann added a comment. Thanks for the info - I will look into this again later. I can see that it's code duplication, but strictly speaking the case statement of StartElement and EndElement are now more "symmetric". REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phab

D8256: Add _XOPEN_SOURCE to C definitions

dfaure added a comment. Restricted Application edited subscribers, added: kde-buildsystem, kde-frameworks-devel; removed: Frameworks, Build System. (BTW where is rindex being used? lxr says only in ksysguard's FreeBSD and IRIX files, surely that's not the issue?) REPOSITORY R240 Extra CMak

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 95 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/95/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 31 Jul 2018 17:55:34 + Build duration: 13 hr and counting JUnit Tests Name: (root)

D14435: Fix KTimeComboBox input mask for AM/PM times

glennw updated this revision to Diff 38890. glennw added a comment. Switched test to use QVERIFY(). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14435?vs=38748&id=38890 REVISION DETAIL https://phabricator.kde.org/D14435 AFFECTED FILES autotes