D13743: Migrate build system to use find_package in autotests/ki18n_install

bcooksley added a comment. Setting up automatic notifications requires permission to alter the global Herald rules, which only a member of #community_admins can do. Please ping one of them or file a #Sysadmin

D13743: Migrate build system to use find_package in autotests/ki18n_install

habacker added a comment. In D13743#283757 , @ltoscano wrote: > Most of the projects are configured so that the reviews are automatic subscription to the relevant list. This means that the people involved with the project should already know abo

D13813: make this test work again with new uds implementation

jtamate added a comment. In D13813#286313 , @aacid wrote: > Did we break how KIO works and we're now going after the users of KIO and fixing them or was this a "bad usage" from starters that worked by chance? We break how KIO works and we

D13559: Fix some of cppcheck warnings

bshah added subscribers: aacid, apol. bshah added a comment. Added subscribers back which arc removed. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D13559 To: bshah, #frameworks Cc: apol, aacid, kde-frameworks-devel, michaelh, ngraham, bruns

D13559: Fix some of cppcheck warnings

bshah updated this revision to Diff 37088. bshah edited the summary of this revision. bshah removed subscribers: aacid, apol. bshah added a comment. update commit message REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13559?vs=37087&id=37088 BRANCH fix-

D13559: Fix some of cppcheck warnings

bshah updated this revision to Diff 37087. bshah added a comment. - fix memory leak properly REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13559?vs=36199&id=37087 BRANCH fix-cppcheck REVISION DETAIL https://phabricator.kde.org/D13559 AFFECTED FILES

D13559: Fix some of cppcheck warnings

aacid added a comment. In D13559#285836 , @bshah wrote: > In D13559#285804 , @apol wrote: > > > I don't see any fix here. It's just silencing cppcheck. > > > Only supressing done is the memleak

D13813: make this test work again with new uds implementation

aacid added a comment. Did we break how KIO works and we're now going after the users of KIO and fixing them or was this a "bad usage" from starters that worked by chance? REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D13813 To: jtamate, #dolphin, #frameworks, elvi

D13777: KMessageWidget : revert to using highlight colour for Information style (WIP)

aacid added a comment. Please don't use kdeglobals, kdeglobals has to die, it's a "KDE 4" thing, there's no such thing as "KDE" anymore so using kdeglobals is a very bad idea. INLINE COMMENTS > kmessagewidget.cpp:272 > case Positive: > -bgBaseColor.setRgb(39, 174, 96); // Windo

D13808: Fix KMainWindow saving incorrect widget settings

aacid added a comment. Maybe you need an event loop in your tests? REPOSITORY R263 KXmlGui BRANCH fix-window-state-save REVISION DETAIL https://phabricator.kde.org/D13808 To: maxrd2, #kde_applications, dfaure, elvisangelaccio, broulik, cfeck Cc: wbauer, aacid, ngraham, kde-frameworks-

D13124: Add Share action to Dolphin context menu

markg added a comment. In D13124#286263 , @elvisangelaccio wrote: > In D13124#286115 , @broulik wrote: > > > Check out `KFileItemActions::addServiceActionsTo` > > > Actually, `KFileItemActions

D13814: Speedup sort

elvisangelaccio requested changes to this revision. elvisangelaccio added a comment. This revision now requires changes to proceed. Impressive, I went from 18 seconds to 4 :O But please remove friend class KFileItemModelLessThan; from `kfileitemmodel.h` REPOSITORY R318 Dolph

D13124: Add Share action to Dolphin context menu

elvisangelaccio accepted this revision. elvisangelaccio added a comment. This revision is now accepted and ready to land. In D13124#286115 , @broulik wrote: > Check out `KFileItemActions::addServiceActionsTo` Actually, `KFileItemActions::a

KDE CI: Frameworks kwindowsystem kf5-qt5 SUSEQt5.10 - Build # 32 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20SUSEQt5.10/32/ Project: Frameworks kwindowsystem kf5-qt5 SUSEQt5.10 Date of build: Mon, 02 Jul 2018 19:01:13 + Build duration: 5 min 1 sec and counting JUnit Test

KDE CI: Frameworks kwindowsystem kf5-qt5 FreeBSDQt5.10 - Build # 8 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20FreeBSDQt5.10/8/ Project: Frameworks kwindowsystem kf5-qt5 FreeBSDQt5.10 Date of build: Mon, 02 Jul 2018 19:01:13 + Build duration: 2 min 5 sec and counting JUnit

KDE CI: Frameworks kwindowsystem kf5-qt5 SUSEQt5.9 - Build # 19 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20SUSEQt5.9/19/ Project: Frameworks kwindowsystem kf5-qt5 SUSEQt5.9 Date of build: Mon, 02 Jul 2018 19:01:13 + Build duration: 2 min 10 sec and counting JUnit Tests

D13124: Add Share action to Dolphin context menu

nicolasfella added a reviewer: Dolphin. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D13124 To: nicolasfella, apol, #dolphin Cc: markg, broulik, kde-frameworks-devel, elvisangelaccio, ngraham, apol, kfm-devel, #dolphin, michaelh, spoorun, navarromorales, isido

D13848: Fix device label with unknown size

broulik added a comment. I have seen it do that for e.g. a Floppy that is not "present" (I fixed that independently from this patch to show "Floppy" again). I guess whenever an external media isn't present, like an SD card in a reader or so. REPOSITORY R245 Solid REVISION DETAIL https:/

D13848: Fix device label with unknown size

bruns added a comment. So the question is, on which occasion does solid return a size of 0? REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D13848 To: broulik, davidedmundson Cc: bruns, kde-frameworks-devel, michaelh, ngraham

D13124: Add Share action to Dolphin context menu

broulik added a comment. Check out `KFileItemActions::addServiceActionsTo` REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D13124 To: nicolasfella, apol Cc: markg, broulik, kde-frameworks-devel, elvisangelaccio, ngraham, apol, kfm-devel, #dolphin, michaelh, s

D13124: Add Share action to Dolphin context menu

markg added a comment. This looks great! But i don't get how it is magically included in Dolphin.. Perhaps someone could explain? I get that it's a fileitemaction plugin and that it's being loaded by dolphin (somehow), i take that for granted. But even so, if i look in the dolphin code

D13814: Speedup sort

markg accepted this revision. markg added a comment. This revision is now accepted and ready to land. 2x +1 = +2 Ship it :) REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D13814 To: jtamate, #dolphin, #frameworks, markg Cc: apol, bruns, markg, kfm-devel, spoorun, n

D13848: Fix device label with unknown size

broulik created this revision. broulik added a reviewer: davidedmundson. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY `size_str` can never actually become empty as

D10040: Add serial number and EISA ID to OutputDevice interface

davidedmundson added a comment. In another patch I'm doing a V2 of this interface in the next frameworks cycle. May as well try to merge this at the same time so we only have 1 version bump? @dvratil want me to finish this? REPOSITORY R127 KWayland REVISION DETAIL https://phabrica

D10040: Add serial number and EISA ID to OutputDevice interface

davidedmundson added a reviewer: KWin. Restricted Application edited subscribers, added: kde-frameworks-devel; removed: Frameworks. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D10040 To: dvratil, graesslin, sebas, #kwin Cc: kde-frameworks-devel, davidedmundson, plas

D13814: Speedup sort

jtamate updated this revision to Diff 37056. jtamate added a comment. Undo the right number of steps from a quick experiment. :-) REPOSITORY R318 Dolphin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13814?vs=37053&id=37056 REVISION DETAIL https://phabricator.kde.org/D13814 A

D13124: Add Share action to Dolphin context menu

apol added a comment. Looks good to me, would appreciate if someone from dolphin could accept. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D13124 To: nicolasfella, apol Cc: markg, broulik, kde-frameworks-devel, elvisangelaccio, ngraham, apol, kfm-devel, #

D13814: Speedup sort

bruns added a comment. In D13814#285736 , @jtamate wrote: > In D13814#285691 , @bruns wrote: > > > I assume you are sorting by name with "natural sorting". There may be another possibility for speedu

D13814: Speedup sort

bruns added a comment. In D13814#286034 , @jtamate wrote: > > In other words, the fix for that can probably be removed now. > > I prefer not to do it (even I've tried without any crash), because QVariant is not even reentrant. Reentra

D13814: Speedup sort

jtamate updated this revision to Diff 37053. jtamate marked an inline comment as done. jtamate added a comment. > In other words, the fix for that can probably be removed now. I prefer not to do it (even I've tried without any crash), because QVariant is not even reentrant. Changed t

D13124: Add Share action to Dolphin context menu

nicolasfella retitled this revision from "[RFC] Add Share action to Dolphin context menu" to "Add Share action to Dolphin context menu". REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D13124 To: nicolasfella, apol Cc: markg, broulik, kde-frameworks-devel, elvisa

D13124: [RFC] Add Share action to Dolphin context menu

nicolasfella updated this revision to Diff 37052. nicolasfella added a comment. - Rename to ShareFileItemAction REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13124?vs=36578&id=37052 BRANCH fiap REVISION DETAIL https://phabricator.kde.org/D131

D6513: Add support for Attica tags support

leinir added a comment. Test tool using the default settings, and with QT__LOGGING_RULES="org.kde.knewstuff.*=true" F5998853: image.png REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D6513 To: leinir, #knewstuff, apol, #kde

D6513: Add support for Attica tags support

leinir updated this revision to Diff 37047. leinir edited the summary of this revision. leinir edited the test plan for this revision. leinir added a comment. Restricted Application edited subscribers, added: kde-frameworks-devel; removed: Frameworks. - add test tool - add support for filter

D13729: Isolate every test within WaylandOutputManagement

romangg accepted this revision. romangg added a comment. This revision is now accepted and ready to land. There is no reason to use the member variable `m_outputConfiguration` and the method `createConfig` anymore. Just use a scoped pointer in the tests you need it. But we can leave it like t

D13730: Fix memory management in WaylandOutputManagement

romangg accepted this revision. romangg added a comment. This revision is now accepted and ready to land. This seems to depend on D13601 because of the `scaleFCallback`. REPOSITORY R127 KWayland BRANCH dave REVISION DETAIL https://phabricator.kde.o

D13488: Make XDGShellV5 co-compilable with XDGWMBase

romangg accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D13488 To: davidedmundson, #plasma, romangg Cc: romangg, kde-frameworks-devel, michaelh, ngraham, bruns

D13488: Make XDGShellV5 co-compilable with XDGWMBase

davidedmundson updated this revision to Diff 37034. davidedmundson added a comment. update REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13488?vs=36029&id=37034 BRANCH master REVISION DETAIL https://phabricator.kde.org/D13488 AFFECTED FILES src/c

D9446: WIP: Allow to autogenerate and install categories file

dfaure added a comment. I don't understand what difference that would make. Any user of project_debug.h would get recompiled every time that file (or one of the files it includes) is modified (i.e. every time a category is added, modified or removed). So if every piece of code should include

D13559: Fix some of cppcheck warnings

bshah added a comment. In D13559#285804 , @apol wrote: > I don't see any fix here. It's just silencing cppcheck. Only supressing done is the memleak in the autotests, otherwise for selfInitialization it is the false alarm, which can be fi