D13641: [KCharSelect] Port generate-datafile.py to Python 3

lbeltrame accepted this revision. This revision is now accepted and ready to land. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D13641 To: cfeck, #frameworks, lbeltrame Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13643: Add LabPlot project file icon

mtrescott created this revision. mtrescott added reviewers: LabPlot, VDG, Breeze. mtrescott added a project: Breeze. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. mtrescott requested review of this revision. REVISION SUMMARY

D11529: Balooctl: Deindex unfound files with check command.

smithjd updated this revision to Diff 36419. smithjd added a comment. Rebase REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11529?vs=35204&id=36419 BRANCH master-filedeindexer (branched from master) REVISION DETAIL https://phabricator.kde.org/D11529 AF

D13216: Overhaul the file index scheduler.

smithjd removed a dependent revision: D11529: Balooctl: Deindex unfound files with check command.. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13216 To: smithjd, bruns, mgallien Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, b

D13424: Run a file changed check when the file watches are updated.

smithjd added a dependent revision: D11529: Balooctl: Deindex unfound files with check command.. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13424 To: smithjd, mgallien, bruns Cc: mgallien, kde-frameworks-devel, bruns, #baloo, ashaposhnikov, michaelh, astippich, spoo

D11529: Balooctl: Deindex unfound files with check command.

smithjd edited dependencies, added: D13424: Run a file changed check when the file watches are updated.; removed: D13216: Overhaul the file index scheduler.. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11529 To: smithjd, #baloo, vhanda, michaelh, broulik Cc: kde-frame

D13424: Run a file changed check when the file watches are updated.

smithjd updated this revision to Diff 36418. smithjd added a comment. - Remove a fixme. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13424?vs=36415&id=36418 BRANCH master-scheduler-watchesInstalled (branched from master) REVISION DETAIL https://phabri

D13216: Overhaul the file index scheduler.

smithjd removed a dependent revision: D13424: Run a file changed check when the file watches are updated.. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13216 To: smithjd, bruns, mgallien Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, sp

D13424: Run a file changed check when the file watches are updated.

smithjd edited dependencies, added: D13425: file indexer closing inprovements.; removed: D13216: Overhaul the file index scheduler.. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13424 To: smithjd, mgallien, bruns Cc: mgallien, kde-frameworks-devel, bruns, #baloo, ashap

D13425: file indexer closing inprovements.

smithjd added a dependent revision: D13424: Run a file changed check when the file watches are updated.. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13425 To: smithjd, bruns, mgallien Cc: mgallien, kde-frameworks-devel, bruns, #baloo, ashaposhnikov, michaelh, astippi

D13425: file indexer closing inprovements.

smithjd removed a dependency: D13424: Run a file changed check when the file watches are updated.. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13425 To: smithjd, bruns, mgallien Cc: mgallien, kde-frameworks-devel, bruns, #baloo, ashaposhnikov, michaelh, astippich, sp

D13424: Run a file changed check when the file watches are updated.

smithjd removed a dependent revision: D13425: file indexer closing inprovements.. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13424 To: smithjd, mgallien, bruns Cc: mgallien, kde-frameworks-devel, bruns, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, a

D13216: Overhaul the file index scheduler.

smithjd updated this revision to Diff 36417. smithjd added a comment. - Re-write the the file index scheduler. - Update the balooctl tool with the changed suspend/resume behaviour. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13216?vs=35810&id=36417 BRAN

D13425: file indexer closing inprovements.

smithjd updated this revision to Diff 36416. smithjd added a comment. Consolidate file indexer close changes into a single review. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13425?vs=35813&id=36416 BRANCH master-scheduler-haltonquit (branched from mast

D13425: file indexer closing inprovements.

smithjd retitled this revision from "Quit the file indexer when closing." to "file indexer closing inprovements.". smithjd edited the summary of this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13425 To: smithjd, bruns, mgallien Cc: mgallien, kde-frameworks-

D13424: Run a file changed check when the file watches are updated.

smithjd retitled this revision from "On config change halt the file indexer and run a file changed check when the file watches are updated." to "Run a file changed check when the file watches are updated.". REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13424 To: smithj

D13424: On config change halt the file indexer and run a file changed check when the file watches are updated.

smithjd updated this revision to Diff 36415. smithjd added a comment. Run a full check for unindexed files when the watches are installed. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13424?vs=35812&id=36415 BRANCH master-scheduler-watchesInstalled (bran

D13641: [KCharSelect] Port generate-datafile.py to Python 3

cfeck created this revision. cfeck added a reviewer: Frameworks. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. cfeck requested review of this revision. REVISION SUMMARY - Add missing parentheses for print() - Writing string

KDE CI: Frameworks kwidgetsaddons kf5-qt5 SUSEQt5.10 - Build # 56 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20SUSEQt5.10/56/ Project: Frameworks kwidgetsaddons kf5-qt5 SUSEQt5.10 Date of build: Wed, 20 Jun 2018 22:53:38 + Build duration: 3 min 8 sec and counting JUnit Tes

KDE CI: Frameworks kwidgetsaddons kf5-qt5 SUSEQt5.9 - Build # 29 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20SUSEQt5.9/29/ Project: Frameworks kwidgetsaddons kf5-qt5 SUSEQt5.9 Date of build: Wed, 20 Jun 2018 21:47:43 + Build duration: 7 min 56 sec and counting JUnit Test

KDE CI: Frameworks kwidgetsaddons kf5-qt5 SUSEQt5.10 - Build # 55 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20SUSEQt5.10/55/ Project: Frameworks kwidgetsaddons kf5-qt5 SUSEQt5.10 Date of build: Wed, 20 Jun 2018 21:47:43 + Build duration: 2 min 19 sec and counting JUnit T

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 177 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/177/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Wed, 20 Jun 2018 20:02:31 + Build duration: 13 min and counting JUnit Te

D13636: add icons for Keyboard Indicator #T9050

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R242:5ff9756047ed: Icons for Keyboard Indicator T9050 (authored by varlesh). REPOSITORY R242 Plasma Framework (Library)

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.10 - Build # 28 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.10/28/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.10 Date of build: Wed, 20 Jun 2018 20:02:31 + Build duration: 3 min 23 sec and counting

D12320: add ability to read embedded cover files

astippich added a comment. sorry for the caused inconvenience REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12320 To: astippich, mgallien, michaelh, bruns Cc: bcooksley, dfaure, anthonyfieroni, kde-frameworks-devel, #baloo, bruns, ashaposhnikov, michaelh, as

D12320: add ability to read embedded cover files

bcooksley added a comment. Thanks for sorting that out. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12320 To: astippich, mgallien, michaelh, bruns Cc: bcooksley, dfaure, anthonyfieroni, kde-frameworks-devel, #baloo, bruns, ashaposhnikov, michaelh, astippic

D13442: Implemented displaying of total lines in kate

cullmann added a comment. I don't think we should alter the default. If you can not find it in neither the settings nor the context menu, we really can't help you. And I agree with Dominik, that usually, you just not care for the maximum number. REPOSITORY R39 KTextEditor REVISION DET

D13442: Implemented displaying of total lines in kate

ngraham added a comment. Thanks! Unfortunately, Subham's patch still had the feature turned off by default. Any chance we have have it on by default, and rely on the new context menu to help experts with limited horizontal status bar space figure out how to turn it off as needed? REPOS

D13636: add icons for Keyboard Indicator #T9050

varlesh created this revision. varlesh added a reviewer: apol. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. varlesh requested review of this revision. REVISION SUMMARY Icons for Keyboard Indicator #T9050 REPOSITORY R242 P

D13635: Fixes for Java comments

vkrause created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY Remove hardcoded colors and add support for alerts. REPOSITORY R216 Syntax Highlighti

D13442: Implemented displaying of total lines in kate

cullmann closed this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D13442 To: shubham, #ktexteditor, cullmann, brauch Cc: firef, mludwig, zhigalin, ngraham, dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, bruns, demsking, head7, cullma

D13442: Implemented displaying of total lines in kate

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. We can keep the dialog stuff ;=) Ok, I pushed the original parts + the status bar stuff. (and a minor fix in updateConfig) Git commit 3f0638e717a990c81fbc248298cc62709e8af851 b

D13442: Implemented displaying of total lines in kate

ngraham added a comment. In terms of user interface principles, a context menu should never be the sole place where something can be accessed. Context menus are accelerators for experts; many regular users never use them, and of course they're not available at all with a touch interface (e.g

D13442: Implemented displaying of total lines in kate

shubham added a comment. Okay fine REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D13442 To: shubham, #ktexteditor, cullmann, brauch Cc: firef, mludwig, zhigalin, ngraham, dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, bruns, demsking, head7

D13442: Implemented displaying of total lines in kate

cullmann added a comment. I want a context menu on the status bar, it is only a few lines of code. I will add that and move the show word count option to that place too. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D13442 To: shubham, #ktexteditor, cullmann, b

D13442: Implemented displaying of total lines in kate

shubham added a comment. You want a context menu which opens when right clicked on the status bar or the editor? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D13442 To: shubham, #ktexteditor, cullmann, brauch Cc: firef, mludwig, zhigalin, ngraham, dhaumann, kwr

D13442: Implemented displaying of total lines in kate

cullmann added a comment. I will take a look at the context menu part. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D13442 To: shubham, #ktexteditor, cullmann, brauch Cc: firef, mludwig, zhigalin, ngraham, dhaumann, kwrite-devel, kde-frameworks-devel, michaelh,

D13402: FrameSvg: Simplify updateSizes

zzag added a comment. Ping. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D13402 To: zzag, #plasma, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13496: FrameSvg: Update mask frame if image path has been changed

zzag added a comment. Ping. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D13496 To: zzag, #plasma, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13384: FrameSvg: Do not wreck shared mask frames

zzag added a comment. Ping. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D13384 To: zzag, #plasma, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks kfilemetadata kf5-qt5 WindowsMSVCQt5.10 - Build # 35 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kfilemetadata%20kf5-qt5%20WindowsMSVCQt5.10/35/ Project: Frameworks kfilemetadata kf5-qt5 WindowsMSVCQt5.10 Date of build: Wed, 20 Jun 2018 14:44:59 + Build duration: 5 min 5 sec and counting

D13630: automatic tests: do not embed EmbeddedImageData already in the library

This revision was automatically updated to reflect the committed changes. Closed by commit R286:aa90123a8c18: automatic tests: do not embed EmbeddedImageData already in the library (authored by mgallien). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13

D13630: automatic tests: do not embed EmbeddedImageData already in the library

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH master REVISION DETAIL https://phabricator.kde.org/D13630 To: mgallien, dfaure, bcooksley, bruns, astippich Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astip

D12320: add ability to read embedded cover files

mgallien added a comment. D13630 should fix the Windows build. Sorry for not noticing this before. I was mostly away from keyboard for the last two weeks after having been sick. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.or

D13630: automatic tests: do not embed EmbeddedImageData already in the library

mgallien created this revision. mgallien added reviewers: dfaure, bcooksley, bruns, astippich. Restricted Application added projects: Frameworks, Baloo. Restricted Application added subscribers: Baloo, kde-frameworks-devel. mgallien requested review of this revision. REVISION SUMMARY should fix

D13627: [KIconThemes] Isolate private data from race conditions

anthonyfieroni added a comment. @davidedmundson i don't have much time to test right now, so that's why my reviews looks like *guessing*. I want to know you a sure that loadIcon is called safety, so maybe dbus notifier connect(s_globalData, &KIconLoaderGlobalData::iconChanged, this, &

D12320: add ability to read embedded cover files

bcooksley added subscribers: dfaure, bcooksley. bcooksley added a comment. This change broke the build on Windows, which due to the CI notification being ignored has now become a maintainability issue. The failure log can be found at https://build.kde.org/job/Frameworks%20kfilemetadata%20kf

KDE CI: Frameworks kfilemetadata kf5-qt5 WindowsMSVCQt5.10 - Build # 34 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kfilemetadata%20kf5-qt5%20WindowsMSVCQt5.10/34/ Project: Frameworks kfilemetadata kf5-qt5 WindowsMSVCQt5.10 Date of build: Wed, 20 Jun 2018 10:06:29 + Build duration: 3 min 8 sec and counting

D13627: [KIconThemes] Isolate private data from race conditions

davidedmundson added a comment. > It looks like to KIconLoader::loadIcon is called from multiple threads, but i'm not sure It's important to know a bug before trying to fix the bug, otherwise you can't know what to fix. Plasma::IconItem definitely does things in the main thread. Tha

D13627: [KIconThemes] Isolate private data from race conditions

anthonyfieroni created this revision. anthonyfieroni added reviewers: davidedmundson, dfaure, Frameworks. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. anthonyfieroni requested review of this revision. REVISION SUMMARY This p