D13373: haskell.xml: highlight promoted data constructors

xialiyao created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. xialiyao requested review of this revision. REPOSITORY R216 Syntax Highlighting BRANCH haskell-promoted-types REVISION DETAIL https://phabric

D13365: Fixed the cursor(caret) width in kate

cullmann accepted this revision. cullmann added a comment. Yep, looks nice! REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D13365 To: shubham, #ktexteditor, brauch, cullmann Cc: cullmann, ngraham, brauch, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew,

D13365: Fixed the cursor(caret) width in kate

brauch accepted this revision. brauch added a comment. This revision is now accepted and ready to land. Yep, with that, it looks good to me. Do you have commit access? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D13365 To: shubham, #ktexteditor, brauch Cc: ngra

D13365: Fixed the cursor(caret) width in kate

shubham updated this revision to Diff 35643. shubham added a comment. In this updated diff, setRenderHint() is called in between the pair of save() and restore() functions so as to save painter's previous state and achieve better painting quality. REPOSITORY R39 KTextEditor CHANGES SINCE

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 170 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/170/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Tue, 05 Jun 2018 23:12:58 + Build duration: 8 min 39 sec and counting JU

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.10 - Build # 21 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.10/21/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 05 Jun 2018 23:12:59 + Build duration: 2 min 33 sec and counting

D13275: Teach ContainmentInterface::processMimeData how to handle Task Manager drops

This revision was automatically updated to reflect the committed changes. Closed by commit R242:e108d7e90e36: Teach ContainmentInterface::processMimeData how to handle Task Manager drops (authored by hein). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabrica

D13342: Fix regression when pasting binary data from clipboard

dfaure added a comment. Done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13342 To: elvisangelaccio, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.9 - Build # 36 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.9/36/ Project: Frameworks purpose kf5-qt5 SUSEQt5.9 Date of build: Tue, 05 Jun 2018 20:39:48 + Build duration: 13 min and counting JUnit Tests Name: (root

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.10 - Build # 60 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.10/60/ Project: Frameworks purpose kf5-qt5 SUSEQt5.10 Date of build: Tue, 05 Jun 2018 20:39:48 + Build duration: 9 min 4 sec and counting JUnit Tests Name

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 46 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/46/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 05 Jun 2018 20:39:58 + Build duration: 6 min 17 sec and counting JUnit Tests Name:

D13342: Fix regression when pasting binary data from clipboard

elvisangelaccio added a comment. @dfaure Can you respin the kio tarball with this commit? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13342 To: elvisangelaccio, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks purpose kf5-qt5 FreeBSDQt5.10 - Build # 25 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20FreeBSDQt5.10/25/ Project: Frameworks purpose kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 05 Jun 2018 20:39:48 + Build duration: 1 min 41 sec and counting JUnit Tests

D13342: Fix regression when pasting binary data from clipboard

This revision was automatically updated to reflect the committed changes. Closed by commit R241:95865915945d: Fix regression when pasting binary data from clipboard (authored by elvisangelaccio). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13342?vs=35556&id=356

D13343: Properly reset plugins

This revision was automatically updated to reflect the committed changes. Closed by commit R495:2c582ad02cdb: Properly reset plugins (authored by elvisangelaccio). REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13343?vs=35560&id=35650 REVISION DETAIL

D13370: haskell.xml: add keywords family, forall, pattern

xialiyao created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. xialiyao requested review of this revision. REPOSITORY R216 Syntax Highlighting BRANCH haskell-keywords REVISION DETAIL https://phabricator.k

D13365: BUG:391518 Fixed the cursor(caret) width in kate

brauch added a comment. Good find (annoyed me too) and sounds plausible to me. Thanks! Just one thing, do you call setRenderHint() inside the save() / restore() pair of the painter so the previous state is restored after drawing the caret? REPOSITORY R39 KTextEditor REVISION DETAIL

D13365: BUG:391518 Fixed the cursor(caret) width in kate

apol edited the summary of this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D13365 To: shubham, #ktexteditor Cc: ngraham, brauch, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, bruns, demsking, cullmann, sars, dhaumann

D13365: BUG:391518 Fixed the cursor(caret) width in kate

shubham added a comment. This patch will fix the Bug:391518 REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D13365 To: shubham, #ktexteditor Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars, dhaumann

D13365: BUG:391518 Fixed the cursor(caret) width in kate

brauch added a comment. Good find (annoyed me too) and sounds plausible to me. Thanks! Just one thing, do you call setRenderHint() inside the save() / restore() pair of the painter so the previous state is restored after drawing the caret? REPOSITORY R39 KTextEditor REVISION DETAIL

D13365: Fixed the cursor(caret) width in kate

shubham retitled this revision from "BUG:391518 Fixed the cursor(caret) width in kate" to "Fixed the cursor(caret) width in kate". REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D13365 To: shubham, #ktexteditor Cc: ngraham, brauch, kwrite-devel, kde-frameworks-devel,

D13365: BUG:391518 Fixed the cursor(caret) width in kate

shubham added a reviewer: KTextEditor. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D13365 To: shubham, #ktexteditor Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars, dhaumann

D13365: BUG:391518 Fixed the cursor(caret) width in kate

shubham added a comment. In D13365#274370 , @brauch wrote: > Good find (annoyed me too) and sounds plausible to me. Thanks! > > Just one thing, do you call setRenderHint() inside the save() / restore() pair of the painter so the previous stat

D13358: Add new class that is a model of numbers between two values

davidedmundson added a comment. For any C++ project you're right that you'd use that or even a basic for loop instead of a model. But when writing declaratively means we shouldn't be doing programatic lopos. For a KDE project I wanted a QtQuickControls2 Tumbler to show year selection

D13365: BUG:391518 Fixed the cursor(caret) width in kate

shubham created this revision. shubham created this object with visibility "All Users". shubham added a project: Kate. Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. Restricted Application added a project: Frameworks. shubham requested review of this revision. REVISI

D13358: Add new class that is a model of numbers between two values

markg added a comment. This basically is the equivalent of the C++ range iterator (https://github.com/ryanhaining/cppitertools#range, but more libraries have a "range" iterator like that). In all the documentation blocks you miss the argument and return value documentation. I'm cur

D13365: BUG:391518 Fixed the cursor(caret) width in kate

ngraham added a comment. Please edit the Summary section to put `BUG: 391518` on its own line. See https://community.kde.org/Infrastructure/Phabricator#Add_special_keywords Thanks! REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D13365 To: shubham, #ktextedit

KDE CI: Frameworks extra-cmake-modules kf5-qt5 WindowsMSVCQt5.10 - Build # 26 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20extra-cmake-modules%20kf5-qt5%20WindowsMSVCQt5.10/26/ Project: Frameworks extra-cmake-modules kf5-qt5 WindowsMSVCQt5.10 Date of build: Tue, 05 Jun 2018 15:34:37 + Build duration: 38 sec and counti

D13102: Don't include a 64 when building 64bit architectures on flatpak

This revision was automatically updated to reflect the committed changes. Closed by commit R240:5cf0be9327c3: Don't include a 64 when building 64bit architectures on flatpak (authored by apol). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13102?v

D13102: Don't include a 64 when building 64bit architectures on flatpak

cgiboudeaux accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D13102 To: apol, #frameworks, cgiboudeaux Cc: cgiboudeaux, eszlari, kde-frameworks-devel, kde-buildsystem, mic

D13102: Don't include a 64 when building 64bit architectures on flatpak

apol added a comment. Ping? @cgiboudeaux maybe you can accept the patch? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D13102 To: apol, #frameworks Cc: cgiboudeaux, eszlari, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D13275: Teach ContainmentInterface::processMimeData how to handle Task Manager drops

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D13275 To: hein, davidedmundson, Zren, mart Cc: ngraham, zzag, kde-frameworks-devel, plasma-devel, m

KDE CI: Frameworks extra-cmake-modules kf5-qt5 WindowsMSVCQt5.10 - Build # 25 - Failure!

Error processing tokens: Error while parsing action 'Text/ZeroOrMore/FirstOf/Token/DelimitedToken/DelimitedToken_Action3' at input position (line 1, pos 38): ${JELLY_SCRIPT,template="html_gmail"} ^ java.io.IOException: remote file operation failed: C:\CI\worksp

D13358: Add new class that is a model of numbers between two values

davidedmundson edited the summary of this revision. REPOSITORY R275 KItemModels REVISION DETAIL https://phabricator.kde.org/D13358 To: davidedmundson Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12945: kcoredirlister lstItems benchmark

jtamate updated this revision to Diff 35585. jtamate edited the summary of this revision. jtamate added a comment. Changed the structure QListBinaryHash to QMap Changed from KFileItems pointers to Values (it caused memory problems). Imported the parts that handle the filters to do the be

D13358: Add new class that is a model of numbers between two values

davidedmundson created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY In QML a lot of code is built up on list models. One thing I found is

D13342: Fix regression when pasting binary data from clipboard

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Heh, indeed. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D13342 To: elvisangelaccio, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns