D12218: Remove Reload button from the file dialogs' toolbar

ngraham abandoned this revision. ngraham added a comment. I'd be in favor of putting it into `KUrlNavigator`. But in retrospect, I see people's point regarding its usefulness somewhere visible in the dialog. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12218 To: ngra

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.9 - Build # 32 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.9/32/ Project: Frameworks purpose kf5-qt5 SUSEQt5.9 Date of build: Fri, 01 Jun 2018 03:35:54 + Build duration: 2 min 20 sec and counting JUnit Tests Name:

D7038: [server] Respect input region of sub-surfaces on pointer surface focus

romangg added a comment. In D7038#265444 , @graesslin wrote: > any update on this? Currently I'm working on other stuff and don't want to increase the mental load. I really only need this when looking again into sub-surfaces to handle Xwa

D13257: [server] Send frame event instead of flush on relative pointer motion

romangg added a task: T8923: Improve cursor locking and confining. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D13257 To: romangg, #plasma, #kwin, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13257: [server] Send frame event instead of flush on relative pointer motion

romangg created this revision. romangg added reviewers: Plasma, KWin, Frameworks. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. romangg requested review of this revision. REVISION SUMMARY This solves for me not working relati

D12320: [RFC] add ability to read embedded cover files

astippich added a comment. Sorry, I meant Kf 5.47, so deadline on Saturday. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12320 To: astippich, mgallien, michaelh, bruns Cc: anthonyfieroni, kde-frameworks-devel, #baloo, bruns, ashaposhnikov, michaelh, astippi

D12320: [RFC] add ability to read embedded cover files

bruns added a comment. This looks good now, but haven't checked to thoroughly. Did you mean 5.47 or 5.48 - 5.48 is almost a month away ... REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12320 To: astippich, mgallien, michaelh, bruns Cc: anthonyfieroni, kde-f

D12320: [RFC] add ability to read embedded cover files

mgallien added a comment. In D12320#271300 , @astippich wrote: > any more comments? would be nice to ship it with Kf 5.48 @bruns you requested changes. Can you have a look when you have time ? REPOSITORY R286 KFileMetaData REVISION DE

D12218: Remove Reload button from the file dialogs' toolbar

markg added a comment. In D12218#271375 , @rkflx wrote: > In D12218#271290 , @davidedmundson wrote: > > > > It can be useful for network views, but those are a minority of use cases > > > > Ever

D12756: [KDateTable] Use more appropriate and readable text colors for weekends and holidays

cfeck added a reviewer: VDG. cfeck added a comment. I love how phabricator thinks I wanted to remove anyone. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D12756 To: ngraham, #frameworks, #vdg Cc: alex-l, rkflx, cfeck, kde-frameworks-devel, mwolff, apol, mich

D12756: [KDateTable] Use more appropriate and readable text colors for weekends and holidays

cfeck removed a reviewer: VDG. cfeck added a comment. QColor c; c = QColor(Qt::gray); qDebug() << c.lightnessF(); c = QColor(Qt::darkGray); qDebug() << c.lightnessF(); I get: 0.635294 0.501961 Both colors are very similar and neither has enough contrast for backg

D13238: [tests] Add pointer constraints test

zzag added a comment. Some nitpicks. :-) INLINE COMMENTS > pointerconstraints.cpp:50 > + > +void WaylandBackend::init(MainWindow *window) { > +Backend::init(window); Coding style nitpick: put `{` on a new line. > pointerconstraints.cpp:169 > + > +auto *confinedPointer = > m_pointer

D13026: Open Schema toolbar button with normal click rather than click-and-hold

ngraham edited the summary of this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D13026 To: ngraham, #ktexteditor, #kate, dhaumann, cullmann Cc: hpereiradacosta, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann,

D13026: Open Schema toolbar button with normal click rather than click-and-hold

ngraham added reviewers: dhaumann, cullmann. ngraham added a comment. Friendly ping! REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D13026 To: ngraham, #ktexteditor, #kate, dhaumann, cullmann Cc: hpereiradacosta, kwrite-devel, kde-frameworks-devel, michaelh, kevin

D13238: [tests] Add pointer constraints test

romangg added a comment. It could make more sense to have this test in KWin instead of KWayland. Especially when later on the Xwayland backend is added (would be optional on compile time though). Any opinions on this? REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.9 - Build # 31 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.9/31/ Project: Frameworks purpose kf5-qt5 SUSEQt5.9 Date of build: Thu, 31 May 2018 15:54:46 + Build duration: 10 min and counting JUnit Tests Name: (root

D12156: implement reading of rating tag

mgallien accepted this revision. mgallien added a comment. This revision is now accepted and ready to land. I hope application developers will not complain about the need to support a second api to get ratings. I am still unsure this the best way to add this support. REPOSITORY R286 KFileM

D13238: [tests] Add pointer constraints test

romangg updated this revision to Diff 35265. romangg added a comment. - Cleanup one shot constraints REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13238?vs=35256&id=35265 BRANCH pointerConstraintsTest REVISION DETAIL https://phabricator.kde.org/D132

D13238: [tests] Add pointer constraints test

romangg added a task: T8923: Improve cursor locking and confining. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D13238 To: romangg, #plasma, #frameworks Cc: kde-frameworks-devel, ragreen, Pitel, schernikov, michaelh, ZrenBot, ngraham, bruns, alexeymin, lesliezhai, al

D13238: [tests] Add pointer constraints test

romangg added a project: Plasma on Wayland. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D13238 To: romangg, #plasma, #frameworks Cc: kde-frameworks-devel, ragreen, Pitel, schernikov, michaelh, ZrenBot, ngraham, bruns, alexeymin, lesliezhai, ali-mohamed, jensreuterbe

D13238: [tests] Add pointer constraints test

romangg added a comment. There are some visual glitches with the QWidget code. If there are simple fixes for that, I will very happily do them. Otherwise since it's just a test application, it isn't really worth the effort. I also thought about using QGraphicsAnchorLayout, instead of normal

D13238: [tests] Add pointer constraints test

romangg edited the summary of this revision. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D13238 To: romangg, #plasma, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13238: [tests] Add pointer constraints test

romangg created this revision. romangg added reviewers: Plasma, Frameworks. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. romangg requested review of this revision. REVISION SUMMARY To better test the usage of pointer confine

KDE CI: Frameworks kwidgetsaddons kf5-qt5 AndroidQt5.11 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20AndroidQt5.11/1/ Project: Frameworks kwidgetsaddons kf5-qt5 AndroidQt5.11 Date of build: Thu, 31 May 2018 11:08:04 + Build duration: 29 min and counting

KDE CI: Frameworks kcodecs kf5-qt5 AndroidQt5.11 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kcodecs%20kf5-qt5%20AndroidQt5.11/1/ Project: Frameworks kcodecs kf5-qt5 AndroidQt5.11 Date of build: Thu, 31 May 2018 11:08:04 + Build duration: 27 min and counting

KDE CI: Frameworks kirigami kf5-qt5 AndroidQt5.11 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20AndroidQt5.11/1/ Project: Frameworks kirigami kf5-qt5 AndroidQt5.11 Date of build: Thu, 31 May 2018 11:08:04 + Build duration: 26 min and counting

KDE CI: Frameworks karchive kf5-qt5 AndroidQt5.11 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20karchive%20kf5-qt5%20AndroidQt5.11/1/ Project: Frameworks karchive kf5-qt5 AndroidQt5.11 Date of build: Thu, 31 May 2018 11:08:02 + Build duration: 25 min and counting

KDE CI: Frameworks attica kf5-qt5 AndroidQt5.11 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20attica%20kf5-qt5%20AndroidQt5.11/1/ Project: Frameworks attica kf5-qt5 AndroidQt5.11 Date of build: Thu, 31 May 2018 11:08:02 + Build duration: 24 min and counting

KDE CI: Frameworks kpackage kf5-qt5 AndroidQt5.11 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20AndroidQt5.11/1/ Project: Frameworks kpackage kf5-qt5 AndroidQt5.11 Date of build: Thu, 31 May 2018 11:08:02 + Build duration: 23 min and counting

KDE CI: Frameworks kguiaddons kf5-qt5 AndroidQt5.11 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kguiaddons%20kf5-qt5%20AndroidQt5.11/1/ Project: Frameworks kguiaddons kf5-qt5 AndroidQt5.11 Date of build: Thu, 31 May 2018 11:08:03 + Build duration: 22 min and counting

KDE CI: Frameworks kcoreaddons kf5-qt5 AndroidQt5.11 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20AndroidQt5.11/1/ Project: Frameworks kcoreaddons kf5-qt5 AndroidQt5.11 Date of build: Thu, 31 May 2018 11:08:02 + Build duration: 21 min and counting

KDE CI: Frameworks kunitconversion kf5-qt5 AndroidQt5.11 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kunitconversion%20kf5-qt5%20AndroidQt5.11/1/ Project: Frameworks kunitconversion kf5-qt5 AndroidQt5.11 Date of build: Thu, 31 May 2018 11:08:03 + Build duration: 19 min and counting

KDE CI: Frameworks kjobwidgets kf5-qt5 AndroidQt5.11 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kjobwidgets%20kf5-qt5%20AndroidQt5.11/1/ Project: Frameworks kjobwidgets kf5-qt5 AndroidQt5.11 Date of build: Thu, 31 May 2018 11:08:03 + Build duration: 19 min and counting

KDE CI: Frameworks kcompletion kf5-qt5 AndroidQt5.11 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kcompletion%20kf5-qt5%20AndroidQt5.11/1/ Project: Frameworks kcompletion kf5-qt5 AndroidQt5.11 Date of build: Thu, 31 May 2018 11:08:03 + Build duration: 18 min and counting

KDE CI: Frameworks kconfig kf5-qt5 AndroidQt5.11 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kconfig%20kf5-qt5%20AndroidQt5.11/1/ Project: Frameworks kconfig kf5-qt5 AndroidQt5.11 Date of build: Thu, 31 May 2018 11:08:03 + Build duration: 17 min and counting

KDE CI: Frameworks ki18n kf5-qt5 AndroidQt5.11 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20ki18n%20kf5-qt5%20AndroidQt5.11/1/ Project: Frameworks ki18n kf5-qt5 AndroidQt5.11 Date of build: Thu, 31 May 2018 11:08:03 + Build duration: 16 min and counting

KDE CI: Frameworks kimageformats kf5-qt5 AndroidQt5.11 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kimageformats%20kf5-qt5%20AndroidQt5.11/1/ Project: Frameworks kimageformats kf5-qt5 AndroidQt5.11 Date of build: Thu, 31 May 2018 11:08:02 + Build duration: 15 min and counting

D12218: Remove Reload button from the file dialogs' toolbar

rkflx added a comment. In D12218#271290 , @davidedmundson wrote: > > It can be useful for network views, but those are a minority of use cases > > Every large scale KDE deployment (from my POV by far our most important userbase) has a networ

KDE CI: Frameworks extra-cmake-modules kf5-qt5 AndroidQt5.11 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20extra-cmake-modules%20kf5-qt5%20AndroidQt5.11/1/ Project: Frameworks extra-cmake-modules kf5-qt5 AndroidQt5.11 Date of build: Thu, 31 May 2018 11:08:03 + Build duration: 14 min and counting

KDE CI: Frameworks threadweaver kf5-qt5 AndroidQt5.11 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20threadweaver%20kf5-qt5%20AndroidQt5.11/1/ Project: Frameworks threadweaver kf5-qt5 AndroidQt5.11 Date of build: Thu, 31 May 2018 11:08:02 + Build duration: 13 min and counting

KDE CI: Frameworks breeze-icons kf5-qt5 AndroidQt5.11 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20AndroidQt5.11/1/ Project: Frameworks breeze-icons kf5-qt5 AndroidQt5.11 Date of build: Thu, 31 May 2018 11:08:02 + Build duration: 12 min and counting

D13218: Draw FrameSVG corners only if both borders in both directions are enabled

zzag edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D13218 To: zzag, #plasma, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13215: Update sizes before generating frame svg background

zzag added a reviewer: Frameworks. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D13215 To: zzag, #plasma, #frameworks Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D13218: Draw FrameSVG corners only if both borders in both directions are enabled

zzag added a reviewer: Frameworks. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D13218 To: zzag, #plasma, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13137: Updated handles and overflow-menu-*

mart closed this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D13137 To: alex-l, mart, andreask, andreaska, hein, ngraham Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D12156: implement reading of rating tag

astippich updated this revision to Diff 35242. astippich added a comment. - update comments REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12156?vs=34398&id=35242 BRANCH rating REVISION DETAIL https://phabricator.kde.org/D12156 AFFECTED FILES

D12320: [RFC] add ability to read embedded cover files

astippich added a comment. any more comments? would be nice to ship it with Kf 5.48 REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12320 To: astippich, mgallien, michaelh, bruns Cc: anthonyfieroni, kde-frameworks-devel, #baloo, bruns, ashaposhnikov, michaelh,

D12218: Remove Reload button from the file dialogs' toolbar

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. Usability rules normally are that anything a user needs should be accessible without a context menu. > It can be useful for network views, but those are a mino

D13198: Android toolchain: allow to specify extra libs manually

This revision was automatically updated to reflect the committed changes. Closed by commit R240:0dc051905ae9: Android toolchain: allow to specify extra libs manually (authored by Alexey Minnekhanov , committed by alexeymin). REPOSITORY R240 Extra CMake Modules CHAN