D12854: Awk: fix regex in a function and update syntax for gawk

2018-05-13 Thread jonathan poelen
jpoelen updated this revision to Diff 34098. jpoelen added a comment. - Awk: add collating symbols and equivalence classes REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12854?vs=34076&id=34098 BRANCH awk REVISION DETAIL https://phabricato

D12860: DoxygenLua: fix closing comment blocks

2018-05-13 Thread jonathan poelen
jpoelen edited the test plan for this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D12860 To: jpoelen, #framework_syntax_highlighting, dhaumann Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12860: DoxygenLua: fix closing comment blocks

2018-05-13 Thread jonathan poelen
jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D12860 To: jpoelen, #framework_syntax_highlighting, dhaumann Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12860: DoxygenLua: fix closing comment blocks

2018-05-13 Thread jonathan poelen
jpoelen created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. jpoelen requested review of this revision. REVISION SUMMARY Kate-editor needs the context to be marked dynamic to use a placeholder in a dynamic ru

D12858: [KCharSelect] Fix table cell width

2018-05-13 Thread Christoph Feck
cfeck created this revision. cfeck added a reviewer: Frameworks. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. cfeck requested review of this revision. REVISION SUMMARY Qt 5.11 now respects minimumSectionWidth (QTBUG-68239).

D12392: Fix the "Default" color scheme to match Breeze again

2018-05-13 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R265:ebdb8424cd12: Fix the "Default" color scheme to match Breeze again (authored by ngraham). REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12392?vs=32683&id=34

D12392: Fix the "Default" color scheme to match Breeze again

2018-05-13 Thread Nathaniel Graham
ngraham added a comment. Thanks! I didn't find anything in kdelibs or the color KCM code, actually. The Colors KCM has several other color schemes listed in there, but not a copy of Breeze. REPOSITORY R265 KConfigWidgets BRANCH fix-default-color-scheme (branched from master) REVISION D

D12689: Lua: updated for Lua5.3

2018-05-13 Thread jonathan poelen
jpoelen added a comment. There is indeed a problem with Kate, but it works with KSyntaxHighlighting. I will look in what part of doxygenlua.xml the problem is. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D12689 To: jpoelen, dhaumann, #framework_syntax

D12854: Awk: fix regex in a function and update syntax for gawk

2018-05-13 Thread jonathan poelen
jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D12854 To: jpoelen, #framework_syntax_highlighting, dhaumann Cc: kde-frameworks-devel, michaelh, genethomas, ngraham, bruns, cullmann, vkrause,

D12854: Awk: fix regex in a function and update syntax for gawk

2018-05-13 Thread jonathan poelen
jpoelen created this revision. jpoelen added a project: Framework: Syntax Highlighting. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. jpoelen requested review of this revision. REVISION SUMMARY - fix `match(str, /it's a regex

D12787: Ignore more types of source files

2018-05-13 Thread Nathaniel Graham
ngraham added reviewers: michaelh, bruns. ngraham added a comment. Friendly ping! REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12787 To: ngraham, michaelh, bruns Cc: cfeck, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns

D12130: Use the more user-friendly string "File type" in the save dialogs

2018-05-13 Thread Henrik Fehlauer
rkflx added a comment. Restricted Application added a subscriber: kde-frameworks-devel. In D12130#250478 , @ngraham wrote: > Yes, and I did more investigation myself, and all the glue is in plasma-integration. Some changes might be needed there t

D12848: Set fix steps for icon sizes

2018-05-13 Thread Henrik Fehlauer
rkflx added a comment. As mentioned in the task: In T8552#139581 , @rkflx wrote: > > In T8552#139578 , @anemeth wrote: > > > >> Could we have the same icon zoom slider as in Dolphin? > >> > >

Re: kfilemetadata compile failure

2018-05-13 Thread Matthieu Gallien
On dimanche 13 mai 2018 23:03:02 CEST Albert Astals Cid wrote: > El divendres, 11 de maig de 2018, a les 23:22:15 CEST, Jonathan Riddell va > > escriure: > > On Thu, Apr 26, 2018 at 08:31:46AM +0200, Kevin Funk wrote: > > > On Wednesday, 25 April 2018 14:34:58 CEST Jonathan Riddell wrote: > > > >

KDE CI: Frameworks kfilemetadata kf5-qt5 FreeBSDQt5.10 - Build # 7 - Fixed!

2018-05-13 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kfilemetadata%20kf5-qt5%20FreeBSDQt5.10/7/ Project: Frameworks kfilemetadata kf5-qt5 FreeBSDQt5.10 Date of build: Sun, 13 May 2018 21:22:44 + Build duration: 1 min 7 sec and counting JUnit

Re: kfilemetadata compile failure

2018-05-13 Thread Albert Astals Cid
El divendres, 11 de maig de 2018, a les 23:22:15 CEST, Jonathan Riddell va escriure: > On Thu, Apr 26, 2018 at 08:31:46AM +0200, Kevin Funk wrote: > > On Wednesday, 25 April 2018 14:34:58 CEST Jonathan Riddell wrote: > > > kfilemetadata does not compile in KDE neon from git master currently > > >

KDE CI: Frameworks kdelibs4support kf5-qt5 SUSEQt5.10 - Build # 44 - Still Unstable!

2018-05-13 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.10/44/ Project: Frameworks kdelibs4support kf5-qt5 SUSEQt5.10 Date of build: Sun, 13 May 2018 20:04:19 + Build duration: 8 min 38 sec and counting JUnit

KDE CI: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.10 - Build # 4 - Still Unstable!

2018-05-13 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20FreeBSDQt5.10/4/ Project: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.10 Date of build: Sun, 13 May 2018 20:04:19 + Build duration: 7 min 42 sec and counting

KDE CI: Frameworks kdelibs4support kf5-qt5 SUSEQt5.9 - Build # 17 - Still Unstable!

2018-05-13 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.9/17/ Project: Frameworks kdelibs4support kf5-qt5 SUSEQt5.9 Date of build: Sun, 13 May 2018 20:04:19 + Build duration: 3 min 32 sec and counting JUnit T

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 83 - Still Unstable!

2018-05-13 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/83/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 Date of build: Sun, 13 May 2018 18:56:53 + Build duration: 8 min 19 sec and counting JUnit Tests

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.9 - Build # 28 - Still Unstable!

2018-05-13 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.9/28/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.9 Date of build: Sun, 13 May 2018 18:56:53 + Build duration: 3 min 6 sec and counting JUnit Tests

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.10 - Build # 6 - Still Unstable!

2018-05-13 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.10/6/ Project: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.10 Date of build: Sun, 13 May 2018 18:56:54 + Build duration: 2 min 57 sec and counting JUnit Te

KDE CI: Frameworks kconfig kf5-qt5 SUSEQt5.10 - Build # 36 - Still Unstable!

2018-05-13 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kconfig%20kf5-qt5%20SUSEQt5.10/36/ Project: Frameworks kconfig kf5-qt5 SUSEQt5.10 Date of build: Sun, 13 May 2018 18:31:38 + Build duration: 6 min 30 sec and counting JUnit Tests Nam

KDE CI: Frameworks kconfig kf5-qt5 FreeBSDQt5.10 - Build # 6 - Still Unstable!

2018-05-13 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kconfig%20kf5-qt5%20FreeBSDQt5.10/6/ Project: Frameworks kconfig kf5-qt5 FreeBSDQt5.10 Date of build: Sun, 13 May 2018 18:31:38 + Build duration: 2 min 20 sec and counting JUnit Tests

KDE CI: Frameworks kconfig kf5-qt5 SUSEQt5.9 - Build # 18 - Still Unstable!

2018-05-13 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kconfig%20kf5-qt5%20SUSEQt5.9/18/ Project: Frameworks kconfig kf5-qt5 SUSEQt5.9 Date of build: Sun, 13 May 2018 18:31:38 + Build duration: 1 min 37 sec and counting JUnit Tests Name:

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.9 - Build # 29 - Still Unstable!

2018-05-13 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.9/29/ Project: Frameworks breeze-icons kf5-qt5 SUSEQt5.9 Date of build: Sun, 13 May 2018 15:57:38 + Build duration: 10 min and counting JUnit Tests N

KDE CI: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.10 - Build # 5 - Still Unstable!

2018-05-13 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20FreeBSDQt5.10/5/ Project: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.10 Date of build: Sun, 13 May 2018 15:57:38 + Build duration: 1 min 14 sec and counting JUnit

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 - Build # 85 - Still Unstable!

2018-05-13 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.10/85/ Project: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 Date of build: Sun, 13 May 2018 15:57:38 + Build duration: 1 min 35 sec and counting JUnit Tests

D12848: Set fix steps for icon sizes

2018-05-13 Thread Alex Nemeth
anemeth updated this revision to Diff 34064. anemeth added a comment. - Remove unused function REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12848?vs=34063&id=34064 BRANCH standard-icon-sizes (branched from master) REVISION DETAIL https://phabricator.kde

D12848: Set fix steps for icon sizes

2018-05-13 Thread Alex Nemeth
anemeth edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12848 To: anemeth, #frameworks, #vdg Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D12848: Set fix steps for icon sizes

2018-05-13 Thread Alex Nemeth
anemeth edited the summary of this revision. anemeth edited the test plan for this revision. anemeth added reviewers: Frameworks, VDG. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12848 To: anemeth, #frameworks, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12848: Set fix steps for icon sizes

2018-05-13 Thread Alex Nemeth
anemeth added a subscriber: ngraham. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12848 To: anemeth, #frameworks, #vdg Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D12848: Set fix steps for icon sizes

2018-05-13 Thread Alex Nemeth
anemeth created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. anemeth requested review of this revision. REPOSITORY R241 KIO BRANCH standard-icon-sizes (branched from master) REVISION DETAIL https://phabr

D12800: split tests for better readability

2018-05-13 Thread Alexander Stippich
This revision was automatically updated to reflect the committed changes. Closed by commit R286:0c738df2c2b7: split tests for better readability (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12800?vs=33935&id=34059 REVISION DET

KDE CI: Frameworks kfilemetadata kf5-qt5 FreeBSDQt5.10 - Build # 6 - Failure!

2018-05-13 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kfilemetadata%20kf5-qt5%20FreeBSDQt5.10/6/ Project: Frameworks kfilemetadata kf5-qt5 FreeBSDQt5.10 Date of build: Sun, 13 May 2018 10:25:42 + Build duration: 11 sec and counting CONSOLE OUT

D12801: search for album artist and albumartist tags in taglibextractor

2018-05-13 Thread Alexander Stippich
This revision was automatically updated to reflect the committed changes. Closed by commit R286:5b6caa0b118b: search for album artist and albumartist tags in taglibextractor (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12801?vs

D12392: Fix the "Default" color scheme to match Breeze again

2018-05-13 Thread Eike Hein
hein accepted this revision. hein added a comment. This revision is now accepted and ready to land. This looks good, but I think there might be additional copies of these values in (a) the color KCM code and (b) the kdeglobals code in kdelibs4support, did you have a chance to look into those?