D12016: [ktexteditor] much faster positionFromCursor

2018-05-01 Thread Christoph Cullmann
cullmann added a comment. Hmm, I don't understand that comment? Now you have one (or more) object per view, or? That looks sane to me. Or do I misunderstand how that works? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D12016 To: jtamate, #kate, cullmann, #

D12016: [ktexteditor] much faster positionFromCursor

2018-05-01 Thread Anthony Fieroni
anthonyfieroni added a comment. So design is broken,for me. Function should be static and cursor from view (KateViewInternal) should be compared against cursor parameter. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D12016 To: jtamate, #kate, cullmann, #framewo

D12016: [ktexteditor] much faster positionFromCursor

2018-05-01 Thread Christoph Cullmann
cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. I am ok with it as it is ;=) I would have been ok with the version that still inherits from QObject, too, but now that one has done all the hassle to avoid that ok ;) REPOSITORY R39

D10663: Remove a partially copied file if copyjob was cancelled in the middle of file copying

2018-05-01 Thread Dmitri Ovodok
dmitrio added a comment. If I understand correctly what has happened, without this patch the file at destination path existed after the operation was cancelled, and it might even not be corrupted. Still I believe that it is the **source** file that may remain after the cancellation, but not

KDE CI: Frameworks kimageformats kf5-qt5 FreeBSDQt5.10 - Build # 2 - Still Unstable!

2018-05-01 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kimageformats%20kf5-qt5%20FreeBSDQt5.10/2/ Project: Frameworks kimageformats kf5-qt5 FreeBSDQt5.10 Date of build: Wed, 02 May 2018 00:11:20 + Build duration: 3 hr 39 min and counting JUnit

D10663: Remove a partially copied file if copyjob was cancelled in the middle of file copying

2018-05-01 Thread Anthony Fieroni
anthonyfieroni added inline comments. INLINE COMMENTS > filecopyjob.cpp:320 > +// It is better to clean up this file. > +if (!isSuspended() && d->m_bFileWritingIsInProcess) { > +KIO::file_delete(d->m_dest); && metadata(QStringLiteral("overwrite")) != QLatin1String("true") REPOSI

D10663: Remove a partially copied file if copyjob was cancelled in the middle of file copying

2018-05-01 Thread Nathaniel Graham
ngraham added a comment. Here, let me show you. Without your patch: F5829979: without the patch.webm With your patch: F5829981: with the patch.webm REPOSITORY R241 KIO REVISION DETAIL https://phabr

KDE CI: Frameworks kimageformats kf5-qt5 SUSEQt5.9 - Build # 9 - Still Unstable!

2018-05-01 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kimageformats%20kf5-qt5%20SUSEQt5.9/9/ Project: Frameworks kimageformats kf5-qt5 SUSEQt5.9 Date of build: Wed, 02 May 2018 00:11:20 + Build duration: 4 min 7 sec and counting JUnit Tests

KDE CI: Frameworks kimageformats kf5-qt5 SUSEQt5.10 - Build # 17 - Still Unstable!

2018-05-01 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kimageformats%20kf5-qt5%20SUSEQt5.10/17/ Project: Frameworks kimageformats kf5-qt5 SUSEQt5.10 Date of build: Wed, 02 May 2018 00:11:20 + Build duration: 1 min 10 sec and counting JUnit Tes

D12650: Fix incorrect version in @since tag

2018-05-01 Thread Huon Imberger
This revision was automatically updated to reflect the committed changes. Closed by commit R302:b506a48214a0: Fix incorrect version in @since tag (authored by huoni). REPOSITORY R302 KIconThemes CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12650?vs=33466&id=33468 REVISION DETAIL

D12557: [XCF/GIMP loader] Raise maximimum allowed image size to 32767x32767 on 64 bit platforms

2018-05-01 Thread Christoph Feck
This revision was automatically updated to reflect the committed changes. Closed by commit R287:19f33239e7a7: [XCF/GIMP loader] Raise maximimum allowed image size to 32767x32767 on 64 bit… (authored by cfeck). REPOSITORY R287 KImageFormats CHANGES SINCE LAST UPDATE https://phabricator.kde.or

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 2 - Still Unstable!

2018-05-01 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/2/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 21:12:33 + Build duration: 2 hr 58 min and counting JUnit Tests Name: (

D12650: Fix incorrect version in @since tag

2018-05-01 Thread Christoph Feck
cfeck accepted this revision. This revision is now accepted and ready to land. REPOSITORY R302 KIconThemes BRANCH master REVISION DETAIL https://phabricator.kde.org/D12650 To: huoni, #frameworks, cfeck Cc: michaelh, bruns

D10663: Remove a partially copied file if copyjob was cancelled in the middle of file copying

2018-05-01 Thread Dmitri Ovodok
dmitrio added a comment. Sorry, but I was not able to locate such a behavior. When cancelling an overwrite in the middle of the process I got only a partially copied file at the destination path. Tested in the latest git-stable KDE Neon, the procedure was a copying of the source file to the

D12650: Fix incorrect version in @since tag

2018-05-01 Thread Huon Imberger
huoni created this revision. huoni added a reviewer: Frameworks. Restricted Application added a project: Frameworks. huoni requested review of this revision. REVISION SUMMARY The following functions only appeared in v5.39, however their @since tag specified v5.38. `KIconLoader::setCustomP

D12385: Thumbnail smooth scaling in filepicker

2018-05-01 Thread Nathaniel Graham
ngraham added a comment. Seems like nobody has any objections. Wanna land this, @anemeth? REPOSITORY R241 KIO BRANCH image_smooth_downscale (branched from master) REVISION DETAIL https://phabricator.kde.org/D12385 To: anemeth, #frameworks, #vdg, ngraham, elvisangelaccio, rkflx Cc: cfe

D12513: CVE-2018-10361: privilege escalation

2018-05-01 Thread Albert Astals Cid
aacid added a comment. Next time please use arc to upload patches, so that instead of those ugly "Context not available." we get nice links to see more code :) @mgerstner I don't really understand why we need the chdir, renameat, etc. Dropping privileges to the minimum needed should

D12388: Output device color curves correction

2018-05-01 Thread David Edmundson
davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Note frameworks tags are in 3 days. It would be reckless to rush merging anything. REPOSITORY R127 KWayland BRANCH outputColorCorrectionCurvesOnly REVISION DETAIL ht

D12337: Give the file dialogs a "Sort by" menu button on the toolbar

2018-05-01 Thread Nathaniel Graham
ngraham added a comment. Yeah, once all is said and done, we might be able to remove both the View and Sorting menu items from the file dialog's context menu. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12337 To: ngraham, #frameworks, #dolphin, #vdg, rkflx Cc: andre

D12337: Give the file dialogs a "Sort by" menu button on the toolbar

2018-05-01 Thread Nathaniel Graham
ngraham updated this revision to Diff 33464. ngraham added a comment. - Address review comments: Sorting > Sort by Name REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12337?vs=33459&id=33464 BRANCH arcpatch-D12337 REVISION DETAIL https://phabricator.kde.o

D12337: Give the file dialogs a "Sort by" menu button on the toolbar

2018-05-01 Thread Nathaniel Graham
ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12337 To: ngraham, #frameworks, #dolphin, #vdg, rkflx Cc: andreaska, markg, broulik, anemeth, michaelh, bruns

D12337: Give the file dialogs a "Sort by" menu button on the toolbar

2018-05-01 Thread Henrik Fehlauer
rkflx added a comment. In D12337#256813 , @ngraham wrote: > the context menu will have "Sorting > Sort by name. Thoughts? Actually I'd still find that kind of acceptable. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.or

D12337: Give the file dialogs a "Sort by" menu button on the toolbar

2018-05-01 Thread Henrik Fehlauer
rkflx added a comment. In D12337#256813 , @ngraham wrote: > Now we have a problem. With no text in the toolbar button, the actual items don't reveal their purpose so readily unless we change all of their strings to say "Sort by Name" (etc.). But

KDE CI: Frameworks baloo kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

2018-05-01 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks baloo kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:16 + Build duration: 7 hr 37 min and counting JUnit Tests Name

KDE CI: Frameworks kdoctools kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

2018-05-01 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kdoctools%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks kdoctools kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:17 + Build duration: 7 hr 36 min and counting JUnit Tests

D12337: Give the file dialogs a "Sort by" menu button on the toolbar

2018-05-01 Thread Nathaniel Graham
ngraham added a comment. Now we have a problem. With no text in the toolbar button, the actual items don't reveal their purpose so readily unless we change all of their strings to say "Sort by Name" (etc.). But if we do that, then the context menu will have "Sorting > Sort by name. Thoughts?

KDE CI: Frameworks kplotting kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

2018-05-01 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kplotting%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks kplotting kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:16 + Build duration: 7 hr 35 min and counting JUnit Tests

KDE CI: Frameworks krunner kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

2018-05-01 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks krunner kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:16 + Build duration: 7 hr 34 min and counting JUnit Tests

KDE CI: Frameworks kfilemetadata kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

2018-05-01 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kfilemetadata%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks kfilemetadata kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:17 + Build duration: 7 hr 34 min and counting JUnit

KDE CI: Frameworks kparts kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

2018-05-01 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kparts%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks kparts kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:17 + Build duration: 7 hr 33 min and counting JUnit Tests Na

KDE CI: Frameworks kguiaddons kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

2018-05-01 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kguiaddons%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks kguiaddons kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:17 + Build duration: 7 hr 32 min and counting JUnit Tests

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 93 - Still Unstable!

2018-05-01 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/93/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Tue, 01 May 2018 21:12:33 + Build duration: 17 min and counting JUnit Tests Name: (root) Failed

KDE CI: Frameworks kwindowsystem kf5-qt5 FreeBSDQt5.10 - Build # 1 - Unstable!

2018-05-01 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks kwindowsystem kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:17 + Build duration: 7 hr 31 min and counting JUnit

KDE CI: Frameworks bluez-qt kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

2018-05-01 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20bluez-qt%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks bluez-qt kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:17 + Build duration: 7 hr 31 min and counting JUnit Tests

KDE CI: Frameworks kjs kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

2018-05-01 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kjs%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks kjs kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:17 + Build duration: 7 hr 29 min and counting JUnit Tests Name: (r

KDE CI: Frameworks kunitconversion kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

2018-05-01 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kunitconversion%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks kunitconversion kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:17 + Build duration: 7 hr 29 min and counting JU

KDE CI: Frameworks kpackage kf5-qt5 FreeBSDQt5.10 - Build # 1 - Unstable!

2018-05-01 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks kpackage kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:17 + Build duration: 7 hr 28 min and counting JUnit Tests

KDE CI: Frameworks kactivities kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

2018-05-01 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kactivities%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks kactivities kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:16 + Build duration: 7 hr 27 min and counting

KDE CI: Frameworks kbookmarks kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

2018-05-01 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kbookmarks%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks kbookmarks kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:17 + Build duration: 7 hr 27 min and counting JUnit Tests

KDE CI: Frameworks knotifications kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

2018-05-01 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20knotifications%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks knotifications kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:16 + Build duration: 7 hr 26 min and counting JUni

KDE CI: Frameworks sonnet kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

2018-05-01 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20sonnet%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks sonnet kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:17 + Build duration: 7 hr 26 min and counting JUnit Tests Na

KDE CI: Frameworks attica kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

2018-05-01 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20attica%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks attica kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:17 + Build duration: 7 hr 24 min and counting JUnit Tests Na

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.10 - Build # 1 - Unstable!

2018-05-01 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:17 + Build duration: 7 hr 24 min and counting JUnit Tes

KDE CI: Frameworks kmediaplayer kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

2018-05-01 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kmediaplayer%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks kmediaplayer kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:17 + Build duration: 7 hr 23 min and counting JUnit Te

KDE CI: Frameworks kconfigwidgets kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

2018-05-01 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kconfigwidgets%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks kconfigwidgets kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:16 + Build duration: 7 hr 22 min and counting JUni

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 245 - Still Unstable!

2018-05-01 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/245/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Tue, 01 May 2018 21:12:33 + Build duration: 6 min 46 sec and counting JUnit Tests Name: (roo

D12337: Give the file dialogs a "Sort by" menu button on the toolbar

2018-05-01 Thread Nathaniel Graham
ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12337 To: ngraham, #frameworks, #dolphin, #vdg, rkflx Cc: andreaska, markg, broulik, anemeth, michaelh, bruns

KDE CI: Frameworks kpeople kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

2018-05-01 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kpeople%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks kpeople kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:16 + Build duration: 7 hr 21 min and counting JUnit Tests

D12321: Hide file preview when icon is too small

2018-05-01 Thread Henrik Fehlauer
rkflx added a comment. In D12321#256797 , @anemeth wrote: > In D12321#256791 , @ngraham wrote: > > > Reverted. Alex, now that you have a fancy contributor account, you can land this yourself on 5/6/

KDE CI: Frameworks prison kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

2018-05-01 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20prison%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks prison kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:16 + Build duration: 7 hr 20 min and counting JUnit Tests Na

D12648: Update mount point after mount operations

2018-05-01 Thread David Edmundson
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. davidedmundson requested review of this revision. REVISION SUMMARY The order of udisks evaluation has changed

KDE CI: Frameworks kwidgetsaddons kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

2018-05-01 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks kwidgetsaddons kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:17 + Build duration: 7 hr 19 min and counting JUni

D12321: Hide file preview when icon is too small

2018-05-01 Thread Nathaniel Graham
ngraham added a comment. May 6th. REPOSITORY R241 KIO BRANCH conditional_preview (branched from master) REVISION DETAIL https://phabricator.kde.org/D12321 To: anemeth, #vdg, #frameworks, ngraham, rkflx, #dolphin, elvisangelaccio Cc: elvisangelaccio, markg, xyquadrat, sharvey, rkflx, n

KDE CI: Frameworks kcrash kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

2018-05-01 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kcrash%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks kcrash kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:17 + Build duration: 7 hr 19 min and counting JUnit Tests Na

D12321: Hide file preview when icon is too small

2018-05-01 Thread Alex Nemeth
anemeth added a comment. In D12321#256791 , @ngraham wrote: > Reverted. Alex, now that you have a fancy contributor account, you can land this yourself on 5/6/18, or else offer up a version of this without the tooltip change and petition to get

KDE CI: Frameworks kimageformats kf5-qt5 FreeBSDQt5.10 - Build # 1 - Unstable!

2018-05-01 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kimageformats%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks kimageformats kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:17 + Build duration: 7 hr 18 min and counting JUnit

D12321: Hide file preview when icon is too small

2018-05-01 Thread Henrik Fehlauer
rkflx added a comment. In D12321#256786 , @ngraham wrote: > Darn, my bad. Could we revert just the tooltip string change and land that for 5.47, or would you prefer to hold the whole feature until 5.47? Well, the tooltip was added for a r

KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

2018-05-01 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks kirigami kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:17 + Build duration: 7 hr 17 min and counting

D12337: Give the file dialogs a "Sort by" menu button on the toolbar

2018-05-01 Thread Nathaniel Graham
ngraham updated this revision to Diff 33459. ngraham added a comment. - Address review comments REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12337?vs=32533&id=33459 BRANCH arcpatch-D12337 REVISION DETAIL https://phabricator.kde.org/D12337 AFFECTED FILE

KDE CI: Frameworks kholidays kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

2018-05-01 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kholidays%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks kholidays kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:17 + Build duration: 7 hr 16 min and counting JUnit Tests

D12321: Hide file preview when icon is too small

2018-05-01 Thread Nathaniel Graham
ngraham reopened this revision. ngraham added a comment. This revision is now accepted and ready to land. Reverted. Alex, now that you have a fancy contributor account, you can land this yourself on 5/6/18, or else offer up a version of this without the tooltip change and petition to get that

KDE CI: Frameworks kiconthemes kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

2018-05-01 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kiconthemes%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks kiconthemes kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:16 + Build duration: 7 hr 16 min and counting JUnit Test

KDE CI: Frameworks ktextwidgets kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

2018-05-01 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20ktextwidgets%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks ktextwidgets kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:16 + Build duration: 7 hr 15 min and counting JUnit Te

KDE CI: Frameworks kdesignerplugin kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

2018-05-01 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kdesignerplugin%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks kdesignerplugin kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:16 + Build duration: 7 hr 14 min and counting JU

KDE CI: Frameworks kdnssd kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

2018-05-01 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kdnssd%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks kdnssd kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:16 + Build duration: 7 hr 14 min and counting

KDE CI: Frameworks extra-cmake-modules kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

2018-05-01 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20extra-cmake-modules%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks extra-cmake-modules kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:17 + Build duration: 7 hr 13 min and counting

D12321: Hide file preview when icon is too small

2018-05-01 Thread Nathaniel Graham
ngraham added a comment. Well, I'll revert and then we can discuss whether or not we can land a more limited version without the tooltip change. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12321 To: anemeth, #vdg, #frameworks, ngraham, rkflx, #dolphin, elvisangelacc

KDE CI: Frameworks frameworkintegration kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

2018-05-01 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20frameworkintegration%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks frameworkintegration kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:16 + Build duration: 7 hr 13 min and counting

KDE CI: Frameworks kservice kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

2018-05-01 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks kservice kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:16 + Build duration: 7 hr 12 min and counting JUnit Tests

KDE CI: Frameworks oxygen-icons5 kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

2018-05-01 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20oxygen-icons5%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks oxygen-icons5 kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:16 + Build duration: 7 hr 11 min and counting JUnit

KDE CI: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

2018-05-01 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:16 + Build duration: 7 hr 10 min and counting JUnit Te

KDE CI: Frameworks kemoticons kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

2018-05-01 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kemoticons%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks kemoticons kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:17 + Build duration: 7 hr 10 min and counting JUnit Tests

KDE CI: Frameworks kauth kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

2018-05-01 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kauth%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks kauth kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:17 + Build duration: 7 hr 8 min and counting JUnit Tests Name:

KDE CI: Frameworks kded kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

2018-05-01 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kded%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks kded kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:16 + Build duration: 7 hr 8 min and counting

KDE CI: Frameworks knewstuff kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

2018-05-01 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20knewstuff%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks knewstuff kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:16 + Build duration: 7 hr 7 min and counting JUnit Tests

D12321: Hide file preview when icon is too small

2018-05-01 Thread Nathaniel Graham
ngraham added a comment. Darn, my bad. Could we revert just the tooltip string change and land that for 5.47, or would you prefer to hold the whole feature until 5.47? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12321 To: anemeth, #vdg, #frameworks, ngraham, rkflx,

KDE CI: Frameworks qqc2-desktop-style kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

2018-05-01 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20qqc2-desktop-style%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks qqc2-desktop-style kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:16 + Build duration: 7 hr 7 min and counting

KDE CI: Frameworks kross kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

2018-05-01 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kross%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks kross kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:17 + Build duration: 7 hr 7 min and counting JUnit Tests Name:

KDE CI: Frameworks kglobalaccel kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

2018-05-01 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kglobalaccel%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks kglobalaccel kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:16 + Build duration: 7 hr 5 min and counting JUnit Tes

KDE CI: Frameworks kconfig kf5-qt5 FreeBSDQt5.10 - Build # 1 - Unstable!

2018-05-01 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kconfig%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks kconfig kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:17 + Build duration: 7 hr 5 min and counting JUnit Tests

D12641: Workaround Device Notifier showing an error despite volume being mounted correctly

2018-05-01 Thread Mariusz Libera
mlibera abandoned this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D12641 To: mlibera, #plasma, broulik, #frameworks Cc: anthonyfieroni, bruns, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

2018-05-01 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:16 + Build duration: 7 hr 4 min and counting JUnit Tests

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.10 - Build # 1 - Unstable!

2018-05-01 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:16 + Build duration: 7 hr 2 min and counting

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 92 - Still Unstable!

2018-05-01 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/92/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Tue, 01 May 2018 20:45:32 + Build duration: 14 min and counting JUnit Tests Name: (root) Failed

D12321: Hide file preview when icon is too small

2018-05-01 Thread Henrik Fehlauer
rkflx added a comment. In D12321#253903 , @rkflx wrote: > Cool, LGTM now. Due to the string change this will have to wait for 5.47 ...and I even added a warning :/ REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D1232

KDE CI: Frameworks kjsembed kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

2018-05-01 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kjsembed%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks kjsembed kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:17 + Build duration: 7 hr 3 min and counting

KDE CI: Frameworks kcmutils kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

2018-05-01 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kcmutils%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks kcmutils kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:17 + Build duration: 7 hr 0 min and counting

D12321: Hide file preview when icon is too small

2018-05-01 Thread Henrik Fehlauer
rkflx added a comment. This breaks the string freeze. Please revert. See https://community.kde.org/Schedules/Frameworks. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12321 To: anemeth, #vdg, #frameworks, ngraham, rkflx, #dolphin, elvisangelaccio Cc: elvisangelacc

KDE CI: Frameworks kidletime kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

2018-05-01 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kidletime%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks kidletime kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:17 + Build duration: 6 hr 59 min and counting

KDE CI: Frameworks kcompletion kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

2018-05-01 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kcompletion%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks kcompletion kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:17 + Build duration: 6 hr 58 min and counting JUnit Test

KDE CI: Frameworks kdbusaddons kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

2018-05-01 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kdbusaddons%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks kdbusaddons kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:16 + Build duration: 6 hr 58 min and counting JUnit Test

KDE CI: Frameworks kwallet kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

2018-05-01 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kwallet%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks kwallet kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:17 + Build duration: 6 hr 57 min and counting JUnit Tests

KDE CI: Frameworks kdeclarative kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

2018-05-01 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kdeclarative%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks kdeclarative kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:16 + Build duration: 6 hr 56 min and counting JUnit Te

D12388: Output device color curves correction

2018-05-01 Thread Roman Gilg
romangg marked an inline comment as done. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D12388 To: romangg, #frameworks Cc: davidedmundson, zzag, cfeck, michaelh, bruns

D12333: Put the open/save dialog's toolbar above all other widgets, like Dolphin does

2018-05-01 Thread Nathaniel Graham
ngraham abandoned this revision. ngraham added a comment. Oops, updated the wrong revision. This wasn't gonna get done anyway. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12333 To: ngraham, #frameworks, #dolphin, #vdg Cc: abetts, jtamate, broulik, anemeth, rkflx, mic

D12388: Output device color curves correction

2018-05-01 Thread Roman Gilg
romangg updated this revision to Diff 33453. romangg added a comment. - memcpy wl_array in colorcurvesCallback REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12388?vs=33397&id=33453 BRANCH outputColorCorrectionCurvesOnly REVISION DETAIL https://phabr

KDE CI: Frameworks kxmlrpcclient kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

2018-05-01 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kxmlrpcclient%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks kxmlrpcclient kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:17 + Build duration: 6 hr 55 min and counting JUnit

KDE CI: Frameworks knotifyconfig kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

2018-05-01 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20knotifyconfig%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks knotifyconfig kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:16 + Build duration: 6 hr 55 min and counting

KDE CI: Frameworks threadweaver kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

2018-05-01 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20threadweaver%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks threadweaver kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:16 + Build duration: 6 hr 54 min and counting JUnit Te

KDE CI: Frameworks purpose kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

2018-05-01 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks purpose kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:17 + Build duration: 6 hr 54 min and counting JUnit Tests

  1   2   >