D12592: KFileWidget: Prevent places panel width from growing 1px iteratively

rkflx added a comment. Sorry for the wait, writing the commit message for this one and the alignment patch meant going through a //lot// of notes. Who'd knew that after the off-by-one error in Spectacle which only happened in a VM there could be even more difficult problems :D REPOSITORY

D12591: KFileWidget: Provide faster access to the icon position setting

rkflx added a comment. If this gets approved, I'll do the same change to K3b for consistency, which was the only other app showing the submenu I could find on https://lxr.kde.org. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12591 To: rkflx, #frameworks Cc: michaelh,

D12592: KFileWidget: Prevent places panel width from growing 1px iteratively

rkflx added a dependent revision: D12594: KFileWidget: Perfectly align filename widget with icon view. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12592 To: rkflx, #frameworks Cc: michaelh, bruns

D12594: KFileWidget: Perfectly align filename widget with icon view

rkflx created this revision. rkflx added a reviewer: Frameworks. Restricted Application added a project: Frameworks. rkflx requested review of this revision. REVISION SUMMARY Since the redesign of the file dialog for KDE4, the left edges of the line edits below the icon view were supposed to b

D12592: KFileWidget: Prevent places panel width from growing 1px iteratively

rkflx added a dependent revision: D12593: KFileWidget: Save places panel width also after hiding panel. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12592 To: rkflx, #frameworks Cc: michaelh, bruns

D12593: KFileWidget: Save places panel width also after hiding panel

rkflx created this revision. rkflx added a reviewer: Frameworks. Restricted Application added a project: Frameworks. rkflx requested review of this revision. REVISION SUMMARY In certain situations the user-set width of the places panel was not remembered. As `placesViewWidth` is initializ

D12592: KFileWidget: Prevent places panel width from growing 1px iteratively

rkflx created this revision. rkflx added a reviewer: Frameworks. Restricted Application added a project: Frameworks. rkflx requested review of this revision. REVISION SUMMARY cc00bbb22010 tried to prevent the places pa

D12591: KFileWidget: Provide faster access to the icon position setting

rkflx created this revision. rkflx added a reviewer: Frameworks. Restricted Application added a project: Frameworks. rkflx requested review of this revision. REVISION SUMMARY The file dialog allows to move the file name labels from next to the icon to right under the icon for Short View. Howev

D12590: KFileWidget: Disable zoom buttons once reached minimum or maximum

rkflx created this revision. rkflx added a reviewer: Frameworks. Restricted Application added a project: Frameworks. rkflx requested review of this revision. REVISION SUMMARY In Gwenview the zoom buttons will be disabled when clicking on it would not result in any further change of zoom level,

D12588: KFileWidget: Set minimum size for zoom slider

rkflx created this revision. rkflx added a reviewer: Frameworks. Restricted Application added a project: Frameworks. rkflx requested review of this revision. REVISION SUMMARY When choosing a very narrow width for the file dialog, the zoom slider for the icon size would get squished so that onl

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.10 - Build # 36 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.10/36/ Project: Frameworks purpose kf5-qt5 SUSEQt5.10 Date of build: Sun, 29 Apr 2018 03:23:13 + Build duration: 23 min and counting JUnit Tests Name: (ro

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.9 - Build # 12 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.9/12/ Project: Frameworks purpose kf5-qt5 SUSEQt5.9 Date of build: Sun, 29 Apr 2018 03:23:13 + Build duration: 19 min and counting JUnit Tests Name: (root

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 122 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/122/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 Date of build: Sun, 29 Apr 2018 03:23:08 + Build duration: 9 min 32 sec and counting

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 147 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/147/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Sun, 29 Apr 2018 03:23:08 + Build duration: 8 min 49 sec and counting JU

D12538: Always prompt for overwrite on double-click in save dialog

rkflx added a comment. TBH, I don't get what the overwrite and release schedule discussion has to do with this patch. All it does is add an additional method to trigger `slotOk()`, i.e. instead of clicking on Save, users can simply double-click. The fact that either the dialog or the app

D12508: Make KMessageWidget match Kirigami inlineMessage's style

ngraham planned changes to this revision. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D12508 To: ngraham, hein, #plasma, #vdg, elvisangelaccio, cfeck Cc: broulik, anemeth, abetts, cfeck, mart, fabianr, elvisangelaccio, jnoack, #frameworks, michaelh, bruns

D12508: Make KMessageWidget match Kirigami inlineMessage's style

ngraham edited the summary of this revision. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D12508 To: ngraham, hein, #plasma, #vdg, elvisangelaccio, cfeck Cc: broulik, anemeth, abetts, cfeck, mart, fabianr, elvisangelaccio, jnoack, #frameworks, michaelh, bruns

D12508: Make KMessageWidget match Kirigami inlineMessage's style

ngraham updated this revision to Diff 33265. ngraham added a comment. Further improvements; always draw the theme background color under the KMessageWidget, which handles the case of the theme and active window defining different colors. One remaining issue: the KMessageWidget now has a

D12355: [API dox] New UI marker @info:placeholder

kossebau added a comment. Phabricator display of diff looks fine here, both in firefox (logged in) & chromium (not logged in). Can you specify "a bit weird"? :) REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D12355 To: kossebau, #localization, ilic Cc: #frameworks, mi

D12355: [API dox] New UI marker @info:placeholder

ilic added a comment. In D12355#255342 , @ilic wrote: > The diff is a bit weird, as if it is for the vallusuffix from D12353 . But looks good in the repository as committed. ...or, my browser did somet

D12355: [API dox] New UI marker @info:placeholder

ilic added a comment. The diff is a bit weird, as if it is for the vallusuffix from D12353 . But looks good in the repository as committed. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D12355 To: kossebau, #localization, ilic Cc:

D12355: [API dox] New UI marker @info:placeholder

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R249:449e6fd556ee: [API dox] New UI marker @info:placeholder (authored by kossebau). CHANGED PRIOR TO COMMIT https://phab

D12353: [API dox] New UI marker @item:valuesuffix

This revision was automatically updated to reflect the committed changes. Closed by commit R249:b88bb7e1b8d9: [API dox] New UI marker @item:valuesuffix (authored by kossebau). REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12353?vs=32605&id=33261 REVISION DETAI

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 237 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/237/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Sat, 28 Apr 2018 17:41:27 + Build duration: 16 min and counting JUnit Tests Name: (root) Fai

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 215 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/215/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 28 Apr 2018 17:41:26 + Build duration: 8 min 41 sec and counting JUnit Tests Name:

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 86 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/86/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Sat, 28 Apr 2018 17:41:27 + Build duration: 4 min 43 sec and counting JUnit Tests Name: (root)

D12490: concatPaths: process empty path1 correctly

This revision was automatically updated to reflect the committed changes. Closed by commit R241:47340d6a554c: concatPaths: process empty path1 correctly (authored by aleksejshilin). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12490?vs=32961&id=33260 REVISION D

D12587: Indentation script for R

devillemereuil created this revision. devillemereuil added reviewers: KTextEditor, RKWard. Restricted Application added projects: Kate, Frameworks. Restricted Application added a subscriber: Frameworks. devillemereuil requested review of this revision. REVISION SUMMARY This is a javascript inden

D11925: Add "SkipSwitcher" to API

sharvey added a dependent revision: D11926: Add "SkipSwitcher" to API. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D11925 To: sharvey, hein, graesslin Cc: lbeltrame, rikmills, davidedmundson, #plasma, graesslin, #frameworks, michaelh, bruns

D12578: fix some issues reported by clazy

bruns added inline comments. INLINE COMMENTS > CMakeLists.txt:4 > set(REQUIRED_QT_VERSION 5.8.0) > -set(KF5_VERSION "5.45.0") # handled by release scripts > -set(KF5_DEP_VERSION "5.45.0") # handled by release scripts > +set(KF5_VERSION "5.44.0") # handled by release scripts > +set(KF5_DEP_VERSIO

D12508: Make KMessageWidget match Kirigami inlineMessage's style

ngraham updated this revision to Diff 33254. ngraham added a comment. set autoFillBackground, which fixes most client use cases except for when the parent widget's palette's background color matches the theme's text color (as with a dark Konsole theme on Breeze light) REPOSITORY R236 KWidg

D12371: fix always reproducible crash

dfaure added a comment. "I'm redirected to fish://127.0.0.1/home/jtorres" is exactly what is supposed to happen. If that asserts nowadays, it means there's a regression in the redirect handling. Sounds like this has to be fixed first. QUrl::toString is slowish btw, it has to assemble th

D7415: kconfig: kcfg.xsd do not require a kcfgfile

winterz added a comment. ping. this is still relevant. some kconfigxt files don't set the kcfgfile element. to name a few: mailcommon/src/settings/mailcommon.kcfg kdepim-runtime/agents/newmailnotifier/newmailnotifieragentsettings.kcfg pim-data-exporter/gui/settings/pimsettingexpo

D12578: fix some issues reported by clazy

mgallien created this revision. mgallien added reviewers: Baloo, Frameworks. Restricted Application added projects: Frameworks, Baloo. mgallien requested review of this revision. REVISION SUMMARY fix some issues reported by clazy TEST PLAN tests are OK REPOSITORY R293 Baloo BRANCH maste

D12508: Make KMessageWidget match Kirigami inlineMessage's style

ngraham added a comment. I'm working on setting the background color within the KMessageWidget itself, which should make these implementation issues in individual apps non-blockers. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D12508 To: ngraham, hein, #pla

D4911: add Baloo DBus signals for moved or removed files

This revision was automatically updated to reflect the committed changes. Closed by commit R293:ef0e268c6577: add Baloo DBus signals for moved or removed files (authored by mgallien). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D4911?vs=14953&id=33246#toc REPOSITORY R293 Baloo CHANG

D12538: Always prompt for overwrite on double-click in save dialog

ngraham added a comment. It will always work properly, it's just a question of how users will be annoyed. :) FWIW right now with the status quo, Kate users are faced with two annoyances: - Double-clicking on a file doesn't trigger overwrite - Once the overwrite confirmation dialog appe

D12538: Always prompt for overwrite on double-click in save dialog

ltoscano added a comment. Whatever happens, just consider that it's always possible (and it will happen) for users to use a newer KIO with an older Kate; so regardless of the Kate patch, this case should work properly. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D125

D12538: Always prompt for overwrite on double-click in save dialog

ngraham added a comment. In D12538#255184 , @ltoscano wrote: > In D12538#255183 , @ngraham wrote: > > > In D12538#255101 , @ltoscano wrote: > > > > > D

D12538: Always prompt for overwrite on double-click in save dialog

ltoscano added a comment. In D12538#255183 , @ngraham wrote: > In D12538#255101 , @ltoscano wrote: > > > Does it work if a newer KIO is used with an older version of those applications? > > >

D12538: Always prompt for overwrite on double-click in save dialog

ngraham added a comment. In D12538#255101 , @ltoscano wrote: > In D12538#255048 , @ngraham wrote: > > > We still need to fix Kate's save dialog before we can land this, because right now it handles

D11925: Add "SkipSwitcher" to API

sharvey added a comment. In D11925#255082 , @lbeltrame wrote: > For now I reverted the commit in kwin to allow building. Once this review is merged, it can be re-instated. Thank you for reverting the commit. The one - and only - reason I

D12508: Make KMessageWidget match Kirigami inlineMessage's style

ngraham added a comment. In D12508#255158 , @jnoack wrote: > Imo KMessageWidget should not rely on being placed where there's enough contrast. The transparency just doesn't work in the case of Konsole. Hmm, I see your point. Let me see wh

D12371: fix always reproducible crash

jtamate updated this revision to Diff 33242. jtamate edited the summary of this revision. jtamate added a comment. If I use if (!u.path().isEmpty()) or if (!u.path().isEmpty() && !u.path().endsWith('/')), as soon as I enter the url fish://127.0.0.1 (without trailing /), I'm redirected to f

D12508: Make KMessageWidget match Kirigami inlineMessage's style

jnoack added a comment. Imo KMessageWidget should not rely on being placed where there's enough contrast. The transparency just doesn't work in the case of Konsole. Either Konsole needs to move the widget outside the terminal painting area which looks complicated to achieve or the message w

D11282: less expensive findByUrl in KCoreDirListerCache

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. This definitely needs a benchmark. (use Q_BENCHMARK in a qtestlib-based unittest) INLINE COMMENTS > mwolff wrote in kcoredirlister.cpp:852 > is it OK that you operate on a copy o

D11604: kdirlistertest doesn't fail at random

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. I'm all for making tests more stable, but changing what the test is testing, sounds dangerous to me (it might hide bugs in the cases that the test intended to be testing). Sometim

D12002: Check if group < LastGroup, as KIconEffect doesn't handle UserGroup anyway

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R302 KIconThemes BRANCH fixWarning REVISION DETAIL https://phabricator.kde.org/D12002 To: fabiank, mart, dfaure, mlaurent Cc: #frameworks, michaelh, bruns

D4911: add Baloo DBus signals for moved or removed files

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. My objections no longer apply, thanks for the redesign for more performance. REPOSITORY R293 Baloo BRANCH master REVISION DETAIL https://phabricator.kde.org/D4911 To: mgallien, vhan

D10363: [KIO] Add support for XDG_TEMPLATES_DIR in KNewFileMenu

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Hello, sorry for the delay in my review, I failed to react to the notification and then it scrolled out of view :/ INLINE COMMENTS > knewfilemenu.cpp:642 > QSet seenText

D12371: fix always reproducible crash

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kfilewidget.cpp:1523 > // append '/' if needed: url combo does not add it > // tokenize() expects it because uses KUrl::setFileName() > QUrl u(u

D7534: [KUrlNavigator] Emit tabRequested when path in path selector menu is middle-clicked

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. (even better would be to unittest this). REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7534 To: broulik, kde-frameworks-devel, dfaure Cc: #frameworks, michaelh, brun

D11511: [KPropertiesDialog] Support X-KDE-Protocols

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11511 To: broulik, #frameworks, dfaure Cc: michaelh, bruns

D12490: concatPaths: process empty path1 correctly

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. OK, so concatPaths returns absolute paths if path1 is absolute, and relative paths if path1 is relative. Makes sense, but should be documented. REPOSITORY R241 KIO BRANCH fix_concatPat

D12538: Always prompt for overwrite on double-click in save dialog

ltoscano added a comment. In D12538#255048 , @ngraham wrote: > We still need to fix Kate's save dialog before we can land this, because right now it handles the overwrite case itself rather than delegating to the dialog like most KDE apps do. An

D11925: Add "SkipSwitcher" to API

lbeltrame added a comment. For now I reverted the commit in kwin to allow building. Once this review is merged, it can be re-instated. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D11925 To: sharvey, hein, graesslin Cc: lbeltrame, rikmills, davidedmundson, #plasm