KDE CI: Frameworks kxmlgui kf5-qt5 SUSEQt5.10 - Build # 25 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kxmlgui%20kf5-qt5%20SUSEQt5.10/25/ Project: Frameworks kxmlgui kf5-qt5 SUSEQt5.10 Date of build: Fri, 13 Apr 2018 05:31:19 + Build duration: 6 min 27 sec and counting JUnit Tests Nam

KDE CI: Frameworks kxmlgui kf5-qt5 SUSEQt5.9 - Build # 8 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kxmlgui%20kf5-qt5%20SUSEQt5.9/8/ Project: Frameworks kxmlgui kf5-qt5 SUSEQt5.9 Date of build: Fri, 13 Apr 2018 05:31:19 + Build duration: 1 min 34 sec and counting JUnit Tests Name:

KDE CI: Frameworks ktextwidgets kf5-qt5 FreeBSDQt5.9 - Build # 14 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20ktextwidgets%20kf5-qt5%20FreeBSDQt5.9/14/ Project: Frameworks ktextwidgets kf5-qt5 FreeBSDQt5.9 Date of build: Fri, 13 Apr 2018 05:19:14 + Build duration: 1 min 22 sec and counting JUnit Te

D11452: sanitizer: Improve device listing

bruns added a dependent revision: D12165: Use QStorageInfo instead of a homegrown implementation. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11452 To: michaelh, #baloo, #frameworks, bruns Cc: ngraham, bruns, smithjd, ashaposhnikov, michaelh, astippich, spoorun, alex

D12165: Use QStorageInfo instead of a homegrown implementation

bruns added a dependency: D11452: sanitizer: Improve device listing. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12165 To: bruns, #baloo, michaelh Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, alexeymin

D11745: databasesanitizer: Use flags for filtering

bruns added a dependency: D12165: Use QStorageInfo instead of a homegrown implementation. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11745 To: michaelh, #baloo, #frameworks, bruns Cc: bruns, ngraham, smithjd, ashaposhnikov, michaelh, astippich, spoorun, alexeymin

D12165: Use QStorageInfo instead of a homegrown implementation

bruns added a dependent revision: D11745: databasesanitizer: Use flags for filtering. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12165 To: bruns, #baloo, michaelh Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, alexeymin

D11745: databasesanitizer: Use flags for filtering

bruns requested changes to this revision. bruns added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > databasesanitizer.cpp:193 > +} else { > +usedDevices.erase(it++); > +} this is definitely wrong, erasing invalidates ite

D12165: Use QStorageInfo instead of a homegrown implementation

bruns added a comment. Should probably land before D11745 REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12165 To: bruns, #baloo, michaelh Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, alexeymin

D12165: Use QStorageInfo instead of a homegrown implementation

bruns created this revision. bruns added reviewers: Baloo, michaelh. Restricted Application added projects: Frameworks, Baloo. Restricted Application added a subscriber: Frameworks. bruns requested review of this revision. REVISION SUMMARY The homegrown implementation only supports Linux TEST P

D12130: Use the more user-friendly string "File type" in the save dialogs

ngraham marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12130 To: ngraham, #frameworks, #vdg, bruns, alexeymin, rkflx Cc: ltoscano, cfeck, rkflx, alexeymin, abetts, bruns, michaelh, ngraham

D12130: Use the more user-friendly string "File type" in the save dialogs

ngraham retitled this revision from "Use the more user-friendly string "File format" in the save dialogs" to "Use the more user-friendly string "File type" in the save dialogs". ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R241 KIO RE

D12130: Use the more user-friendly string "File format" in the save dialogs

ngraham updated this revision to Diff 32030. ngraham added a comment. Use the more familiar and less technical string "File type" REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12130?vs=32018&id=32030 BRANCH file-format-label (branched from master) REVISION

D11452: sanitizer: Improve device listing

bruns added inline comments. INLINE COMMENTS > databasesanitizer.cpp:135 > +QMap result; > +const auto devices = FSUtils::attachedDevices(); > +for (const auto& dev : devices) { Completely overlooked this one - should have used `QStorageInfo::mountedVolumes()

D12130: Use the more user-friendly string "File format" in the save dialogs

ngraham marked an inline comment as done. ngraham added a comment. In D12130#245409 , @bruns wrote: > In D12130#245373 , @ngraham wrote: > > > Change the text only when saving (it really is a filter

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 214 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/214/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Fri, 13 Apr 2018 00:25:08 + Build duration: 18 min and counting JUnit Tests Name: (root) Fai

D12028: taglibextractortest: Add test for files with empty metadata

bruns accepted this revision. bruns added a comment. This revision is now accepted and ready to land. Ok, lets see Jenkins opinion ... REPOSITORY R286 KFileMetaData BRANCH nometa REVISION DETAIL https://phabricator.kde.org/D12028 To: michaelh, mgallien, #baloo, #frameworks, bruns Cc:

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 63 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/63/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Fri, 13 Apr 2018 00:25:08 + Build duration: 5 min 15 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 193 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/193/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Fri, 13 Apr 2018 00:25:08 + Build duration: 4 min 51 sec and counting JUnit Tests Name:

D12133: Correctly encode URL of thumbnails

This revision was automatically updated to reflect the committed changes. Closed by commit R241:371e523f5d7e: Correctly encode URL of thumbnails (authored by davidedmundson). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12133?vs=31940&id=32028 REVISION DETAIL

D12126: Invalidate property cache when an interface is removed

This revision was automatically updated to reflect the committed changes. Closed by commit R245:796dea6c0440: Invalidate property cache when an interface is removed (authored by bruns). REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12126?vs=31931&id=32027 REVI

D12124: Avoid creating duplicate property entries in the cache

This revision was automatically updated to reflect the committed changes. Closed by commit R245:15047128e56b: Avoid creating duplicate property entries in the cache (authored by bruns). REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12124?vs=31929&id=32026 REVI

D12123: [UDisks] Optimize several property checks

This revision was automatically updated to reflect the committed changes. Closed by commit R245:3c0f767f0337: [UDisks] Optimize several property checks (authored by bruns). REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12123?vs=31927&id=32025 REVISION DETAIL

D12150: Make it possible to build several apk out of a project

apol updated this revision to Diff 32022. apol added a comment. Fix path REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12150?vs=31977&id=32022 BRANCH master REVISION DETAIL https://phabricator.kde.org/D12150 AFFECTED FILES toolchain/An

D12130: Use the more user-friendly string "File format" in the save dialogs

ltoscano added a comment. In D12130#245409 , @bruns wrote: > In D12130#245373 , @ngraham wrote: > > > Change the text only when saving (it really is a filter bar in open mode) > > > Why not use

D12130: Use the more user-friendly string "File format" in the save dialogs

bruns added a comment. In D12130#245373 , @ngraham wrote: > Change the text only when saving (it really is a filter bar in open mode) Why not use "File formats" (plural) for the Open dialog? REPOSITORY R241 KIO REVISION DETAIL https:

D12130: Use the more user-friendly string "File format" in the save dialogs

bruns added inline comments. INLINE COMMENTS > ngraham wrote in kfilewidget.cpp:1338 > I've always said "save as." > > "Save that picture as a JPEG real fast, would ya?" "Use it to choose which format to use for saving"? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D121

D12130: Use the more user-friendly string "File format" in the save dialogs

ngraham marked 2 inline comments as done. ngraham added inline comments. INLINE COMMENTS > cfeck wrote in kfilewidget.cpp:1338 > Do you say "Save a file as a format" or "Save a file in a format"? I've always said "save as." "Save that picture as a JPEG real fast, would ya?" REPOSITORY R241 K

D12130: Use the more user-friendly string "File format" in the save dialogs

ngraham updated this revision to Diff 32018. ngraham marked 2 inline comments as done. ngraham added a comment. Improve the formatting, and move the label into its own function REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12130?vs=32015&id=32018 BRANCH fil

D12149: Improve grid spacing in icons-on-top mode for open/save dialogs

ngraham marked 2 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12149 To: ngraham, #frameworks, #vdg, rkflx Cc: cfeck, alexeymin, michaelh, ngraham, bruns

D12149: Improve grid spacing in icons-on-top mode for open/save dialogs

ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12149 To: ngraham, #frameworks, #vdg, rkflx Cc: cfeck, alexeymin, michaelh, ngraham, bruns

D12149: Improve grid spacing in icons-on-top mode for open/save dialogs

ngraham updated this revision to Diff 32017. ngraham added a comment. Take the font size into consideration with the minimum width REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12149?vs=31973&id=32017 BRANCH tighter-grid-in-icons-view (branched from master)

D12149: Improve grid spacing in icons-on-top mode for open/save dialogs

ngraham added inline comments. INLINE COMMENTS > cfeck wrote in kdiroperator.cpp:2590 > If you need a minimum width to accomodate a minimum number of characters, you > could use a value proportional to font size, e.g. "8 * metrics.height()" will > give you room for about 15 characters (they are

D12149: Improve grid spacing in icons-on-top mode for open/save dialogs

ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12149 To: ngraham, #frameworks, #vdg, rkflx Cc: cfeck, alexeymin, michaelh, ngraham, bruns

D12130: Use the more user-friendly string "File format" in the save dialogs

cfeck added inline comments. INLINE COMMENTS > kfilewidget.cpp:1334 > +QString filterWhatsThisText; > if (operationMode == KFileWidget::Saving) { > +locationWhatsThisText = "" + i18n("This is the name to save the > file as.") + I think with an empty line after the QString varia

D12130: Use the more user-friendly string "File format" in the save dialogs

ngraham retitled this revision from "Use the more user-friendly string "File format" in the open/save dialogs" to "Use the more user-friendly string "File format" in the save dialogs". ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R241

D12130: Use the more user-friendly string "File format" in the open/save dialogs

ngraham added a comment. It's not too hard to make the label and the "What's this?" text differ for open vs save mode, which I've done here. There's still the issue that the text doesn't quite fit in save mode, where there's a filter but it's somewhat useless. I wonder: what good is the

D11452: sanitizer: Improve device listing

michaelh added a comment. It's landed https://cgit.kde.org/baloo.git/commit/?id=07601590347f25ec1ec805e7df16e1f2d6badc9c Why is this not automatically closed? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11452 To: michaelh, #baloo, #frameworks, bruns Cc: ngraham,

D11452: sanitizer: Improve device listing

This revision was automatically updated to reflect the committed changes. Closed by commit R293:07601590347f: sanitizer: Improve device listing (authored by michaelh). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11452?vs=31996&id=32016 REVISION DETAIL http

D12130: Use the more user-friendly string "File format" in the open/save dialogs

ngraham updated this revision to Diff 32015. ngraham added a comment. Change the text only when saving (it really is a filter bar in open mode) REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12130?vs=31936&id=32015 BRANCH file-format-label (branched from mas

D12149: Improve grid spacing in icons-on-top mode for open/save dialogs

cfeck added inline comments. INLINE COMMENTS > kdiroperator.cpp:2590 > +// Set a minimum width to make enough room for a label when the > icons are tiny > +const QSize itemSize = QSize(qMax(120, width), height); > +view->setGridSize(itemSize); If you need a minimum width

D11753: baloodb: Add clean command

michaelh added a task: T8250: Sanitize the database. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11753 To: michaelh, #baloo, #frameworks Cc: bruns, cfeck, smithjd, ashaposhnikov, michaelh, astippich, spoorun, ngraham, alexeymin

D12044: baloodb: Improve interface

michaelh added a task: T8250: Sanitize the database. REPOSITORY R293 Baloo BRANCH sanitize-improve-ui (branched from master) REVISION DETAIL https://phabricator.kde.org/D12044 To: michaelh, #baloo, ngraham Cc: bruns, #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, alex

D11745: databasesanitizer: Use flags for filtering

michaelh added a task: T8250: Sanitize the database. REPOSITORY R293 Baloo BRANCH sanitize-enums (branched from master) REVISION DETAIL https://phabricator.kde.org/D11745 To: michaelh, #baloo, #frameworks, bruns Cc: bruns, ngraham, smithjd, ashaposhnikov, michaelh, astippich, spoorun, al

D11657: Do not export databasesanitizer by default

michaelh added a task: T8250: Sanitize the database. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11657 To: michaelh, #baloo, davidedmundson Cc: smithjd, #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, alexeymin

D11452: sanitizer: Improve device listing

michaelh added a task: T8250: Sanitize the database. REPOSITORY R293 Baloo BRANCH sanitize-devices (branched from master) REVISION DETAIL https://phabricator.kde.org/D11452 To: michaelh, #baloo, #frameworks, bruns Cc: ngraham, bruns, smithjd, ashaposhnikov, michaelh, astippich, spoorun,

D11392: sanitizer: Move implementation into Baloo namespace

michaelh added a task: T8250: Sanitize the database. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11392 To: michaelh, #baloo, #frameworks, kossebau Cc: kossebau, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, alexeymin

D11287: Introduce baloodb CLI tool

michaelh added a task: T8250: Sanitize the database. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11287 To: michaelh, #baloo, #frameworks, mlaurent Cc: mlaurent, ngraham, ashaposhnikov, michaelh, astippich, spoorun, bruns, alexeymin

D11285: Introduce sanitizer class

michaelh added a task: T8250: Sanitize the database. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11285 To: michaelh, #baloo, #frameworks, ngraham, mlaurent Cc: mlaurent, ngraham, smithjd, ashaposhnikov, michaelh, astippich, spoorun, bruns, alexeymin

D11745: databasesanitizer: Use flags for filtering

bruns accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH sanitize-enums (branched from master) REVISION DETAIL https://phabricator.kde.org/D11745 To: michaelh, #baloo, #frameworks, bruns Cc: bruns, ngraham, smithjd, ashaposhnikov, michael

D11745: databasesanitizer: Use flags for filtering

michaelh updated this revision to Diff 32014. michaelh added a comment. Single qDebug REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11745?vs=32005&id=32014 BRANCH sanitize-enums (branched from master) REVISION DETAIL https://phabricator.kde.org/D11745

D12164: Add overloads to Value/Unit::toString/toSymbolString taking a QLocale

kossebau created this revision. kossebau added a reviewer: ilic. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. kossebau requested review of this revision. REVISION SUMMARY The existing toString/toSymbolString methods use KLocalizedStri

D11745: databasesanitizer: Use flags for filtering

bruns added inline comments. INLINE COMMENTS > databasesanitizer.cpp:32 > #include > +#include > double QDebug REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11745 To: michaelh, #baloo, #frameworks Cc: bruns, ngraham, smithjd, ashaposhnikov, michaelh, astippich, s

D12028: taglibextractortest: Add test for files with empty metadata

michaelh updated this revision to Diff 32009. michaelh added a comment. - Optimize failure messages REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12028?vs=31989&id=32009 BRANCH nometa REVISION DETAIL https://phabricator.kde.org/D12028 AFFECTED

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 213 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/213/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Thu, 12 Apr 2018 19:43:18 + Build duration: 25 min and counting JUnit Tests Name: (root) Fai

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 62 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/62/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Thu, 12 Apr 2018 19:43:18 + Build duration: 14 min and counting JUnit Tests Name: (root) Failed

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 192 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/192/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 12 Apr 2018 19:43:18 + Build duration: 5 min 1 sec and counting JUnit Tests Name: (

D11745: databasesanitizer: Use flags for filtering

michaelh updated this revision to Diff 32005. michaelh added a comment. - Hopefully get the enum right this time - Use struct for summary REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11745?vs=31811&id=32005 BRANCH sanitize-enums (branched from master)

D11993: Tweak column widths in tree view of file open/save dialogs

ngraham closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11993 To: sharvey, ngraham, dfaure, #frameworks, broulik Cc: #dolphin, cfeck, fabiank, broulik, michaelh, ngraham, bruns

D12127: Do not query properties when no interfaces are left

bruns added a comment. In D12127#244859 , @broulik wrote: > Lgtm. > But do we remove the offending properties when the interface is removed? Not sure, is probably unrelated bug Yes, D12126 REPOSITO

D12135: Allow disabling of CoW to fail when not supported by filesystem

bruns requested review of this revision. bruns added a comment. Make it obvious this should have some more review ... REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12135 To: bruns, #baloo, adridg, #frameworks Cc: adridg, #freebsd, #frameworks, ashaposhnikov, michaelh

D11993: Tweak column widths in tree view of file open/save dialogs

ngraham accepted this revision. ngraham added a comment. Works, thanks! REPOSITORY R241 KIO BRANCH arcpatch-D11993 REVISION DETAIL https://phabricator.kde.org/D11993 To: sharvey, ngraham, dfaure, #frameworks, broulik Cc: #dolphin, cfeck, fabiank, broulik, michaelh, ngraham, bruns

D12028: taglibextractortest: Add test for files with empty metadata

bruns added inline comments. INLINE COMMENTS > taglibextractortest.cpp:300 > +} > +QCOMPARE(resultKeys, expectedKeys); > +} Unfortunately QCOMPARE does not do a deep compare if sizes mismatch. To get a better output in case the test fails, you can do something like: auto excessKeys()

D11993: Tweak column widths in tree view of file open/save dialogs

sharvey marked 2 inline comments as done. sharvey added a comment. Merge errors tracked down and eradicated. INLINE COMMENTS > ngraham wrote in kdiroperatordetailview.cpp:53 > Uh-oh :) What is that? (finding it and killing it) REPOSITORY R241 KIO BRANCH arcpatch-D11993 REVISION DETAIL

D11993: Tweak column widths in tree view of file open/save dialogs

sharvey updated this revision to Diff 32002. sharvey added a comment. - Repairing merge error REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11993?vs=31992&id=32002 BRANCH arcpatch-D11993 REVISION DETAIL https://phabricator.kde.org/D11993 AFFECTED FILES

D11452: sanitizer: Improve device listing

michaelh added inline comments. INLINE COMMENTS > databasesanitizer.cpp:144 > +devInfo.mounted = true && (dev.filesystem != > QLatin1String("tmpfs")); > +qDebug() << "filesystem" << dev.filesystem; > +result[id] = devInfo; Will be removed downstre

D11452: sanitizer: Improve device listing

michaelh added inline comments. INLINE COMMENTS > databasesanitizer.cpp:143 > +devInfo.fsInfo = dev; > +devInfo.mounted = true && (dev.filesystem != > QLatin1String("tmpfs")); > +qDebug() << "filesystem" << dev.filesystem; Better safe than sorry h

D12160: Rebase onto fresh master

sharvey abandoned this revision. sharvey added a comment. Created by mistake. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12160 To: sharvey Cc: ngraham, #frameworks, michaelh, bruns

D11452: sanitizer: Improve device listing

michaelh updated this revision to Diff 31996. michaelh added a comment. - Consider tmpfs as not mounted - Bring back major/minor print out REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11452?vs=31972&id=31996 BRANCH sanitize-devices (branched from maste

D12160: Rebase onto fresh master

ngraham added a comment. Join me in #plasma and we'll work this out. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12160 To: sharvey Cc: ngraham, #frameworks, michaelh, bruns

D12160: Rebase onto fresh master

sharvey added a comment. In D12160#245232 , @ngraham wrote: > Oops, did you mean to create a new revision? Let's just focus on the existing one. git and arc are hating me right now REPOSITORY R241 KIO REVISION DETAIL https://phabric

D12160: Rebase onto fresh master

sharvey created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. sharvey requested review of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12160 AFFECTED FILES src/filewidgets/kdirope

D12160: Rebase onto fresh master

ngraham added a comment. Oops, did you mean to create a new revision? Let's just focus on the existing one. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12160 To: sharvey Cc: ngraham, #frameworks, michaelh, bruns

D11452: sanitizer: Improve device listing

bruns accepted this revision. bruns added a comment. This revision is now accepted and ready to land. Yes, thats exactly what I meant - device ids are not stable ... But anyway, thats unrelated to this revision. REPOSITORY R293 Baloo BRANCH sanitize-devices (branched from master) REVIS

D11452: sanitizer: Improve device listing

michaelh added a comment. Arrgh these deviceIds! Just realized this: When logged in as root on tty1 $ baloodb devices Listing database contents... + device:43 indexed-items:3658 fstype:tmpfs fsname:tmpfs mount:/run/user/0 + device:2049 indexed-items:2 fstype:ext4 fsname:/d

D11993: Tweak column widths in tree view of file open/save dialogs

ngraham added inline comments. INLINE COMMENTS > kdiroperatordetailview.cpp:53 > > +<<< HEAD > void KDirOperatorDetailView::setModel(QAbstractItemModel *model) Uh-oh :) > kdiroperatordetailview.cpp:71 > +=== > +>>> Remove unneeded resize code; ensure other columns fill to content

D11993: Tweak column widths in tree view of file open/save dialogs

sharvey added a comment. Rebased (I think). Had to manually resolve a conflict. Hopefully it'll land now. REPOSITORY R241 KIO BRANCH arcpatch-D11993 REVISION DETAIL https://phabricator.kde.org/D11993 To: sharvey, ngraham, dfaure, #frameworks, broulik Cc: #dolphin, cfeck, fabiank, bro

D11993: Tweak column widths in tree view of file open/save dialogs

sharvey updated this revision to Diff 31992. sharvey marked an inline comment as done. sharvey added a comment. - Remove unneeded resize code; ensure other columns fill to contents - Remove leftover commented-out code; restore variable declaration REPOSITORY R241 KIO CHANGES SINCE LAST UP

D10719: Highlighting for OpenSCAD

julianstirling added a comment. Hi, This has been sitting idle for about 6 weeks. @dhaumann is everything OK with the current patch for integration Cheers Julian REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D10719 To: julianstirling, dhaumann Cc:

D12130: Use the more user-friendly string "File format" in the open/save dialogs

ngraham planned changes to this revision. ngraham added a comment. Let's see if I can make this patch more intelligent, because the root of the issue is that the same text field is used for different things in different modes. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.

D12130: Use the more user-friendly string "File format" in the open/save dialogs

ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12130 To: ngraham, #frameworks, #vdg, bruns, alexeymin, rkflx Cc: rkflx, alexeymin, abetts, bruns, michaelh, ngraham

D11452: sanitizer: Improve device listing

ngraham added a comment. I'm afraid you guys' code writing abilities have far surpassed my code review abilities at this point! REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11452 To: michaelh, #baloo, #frameworks Cc: ngraham, bruns, smithjd, ashaposhnikov, michaelh

D12028: taglibextractortest: Add test for files with empty metadata

michaelh requested review of this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12028 To: michaelh, mgallien, #baloo, #frameworks Cc: bruns, astippich, ashaposhnikov, michaelh, spoorun, ngraham, alexeymin

D12028: taglibextractortest: Add test for files with empty metadata

michaelh updated this revision to Diff 31989. michaelh added a comment. - Recreate sample files and adapt tests for mp3, m4a, ogg, opus, flac recreate files with `$ ffmpeg -f lavfi -i anullsrc=channel_layout=stereo:sample_rate=44100 -t 1 test.` for mpc with kid3-qt remove all tags and add '

D12125: Avoid inserting an invalid "Size" property from the Filesystem interface

bruns added a reviewer: Frameworks. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D12125 To: bruns, #frameworks Cc: broulik, #frameworks, michaelh, ngraham, bruns

D12125: Avoid inserting an invalid "Size" property from the Filesystem interface

bruns added inline comments. INLINE COMMENTS > broulik wrote in udisksdevicebackend.cpp:147 > So when size is unknown it will always query it as you will never have a Size > in the `m_propertyCache`? It uses the one from the Partition or Block Interface, see last paragraph from the Summary. It

D12028: taglibextractortest: Add test for files with empty metadata

michaelh reopened this revision. michaelh added a comment. This revision is now accepted and ready to land. Sample files are borked. https://build.kde.org/view/Frameworks/job/Frameworks%20kfilemetadata%20kf5-qt5%20SUSEQt5.10/lastBuild/ REPOSITORY R286 KFileMetaData REVISION DETAIL https:

D12156: implement reading of rating tag

astippich edited the summary of this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12156 To: astippich, mgallien, michaelh Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, alexeymin

D12124: Avoid creating duplicate property entries in the cache

bruns added a comment. In D12124#244924 , @broulik wrote: > Wouldn't make a big difference, would it? > > > If there are multiple items for key in the map, the value of the most recently inserted one is returned. > > It's not like we actu

D12156: implement reading of rating tag

astippich created this revision. astippich added reviewers: mgallien, michaelh. Restricted Application added projects: Frameworks, Baloo. Restricted Application added a subscriber: Frameworks. astippich requested review of this revision. REVISION SUMMARY allows to read the rating stored in the m

D11452: sanitizer: Improve device listing

bruns added a subscriber: ngraham. bruns added a comment. Looks good to me so far. If there are any issues, we can fix it up later IMHO. @ngraham as you reviewed other parts of the stack, can you do this one as well and accept? INLINE COMMENTS > databasesanitizer.cpp:257 > +<<

D12028: taglibextractortest: Add test for files with empty metadata

bruns added a comment. Untested, but looks good to me otherwise. INLINE COMMENTS > taglibextractortest.cpp:42 > > +const QStringList TagLibExtractorTest::propertyEnumNames(const > QList& keys) const > +{ Nitpick - needs some indentation REPOSITORY R286 KFileMetaData REVISION DETAIL

D12135: Allow disabling of CoW to fail when not supported by filesystem

bruns added a comment. May I have another accept/review (for the stack) from #Frameworks or #Baloo ? REPOSITORY R293 Baloo BRANCH accept_eopnotsupp_on_chattr REVISION DETAIL https://phabricator.kde

D12135: Allow disabling of CoW to fail when not supported by filesystem

bruns added a reviewer: Frameworks. REPOSITORY R293 Baloo BRANCH accept_eopnotsupp_on_chattr REVISION DETAIL https://phabricator.kde.org/D12135 To: bruns, #baloo, adridg, #frameworks Cc: adridg, #freebsd, #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, alexeymin

D12145: autotests: Do not use QScopedPointer for plugins

bruns added a comment. The first question is - why should we use pointers at all (raw, std::unique_ptr, QScopedPointer, ...) for objects **with local only scope**. The typical answer is Inheritance, see e.g. http://doc.qt.io/qt-5/qscopedpointer.html#details A `Base` pointer can be used

D12149: Improve grid spacing in icons-on-top mode for open/save dialogs

ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12149 To: ngraham, #frameworks, #vdg, rkflx Cc: alexeymin, michaelh, ngraham, bruns

D12149: Improve grid spacing in icons-on-top mode for open/save dialogs

ngraham added a comment. FWIW I wrestled with the issue prior to submitting the patch, but couldn't come up with anything better. The issue here that we really do need a minimum width of //at least// 110px or else there's simply never enough room for titles with small icons, but there's a la

D12150: Make it possible to build several apk out of a project

apol updated this revision to Diff 31977. apol added a comment. Polish REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12150?vs=31976&id=31977 BRANCH master REVISION DETAIL https://phabricator.kde.org/D12150 AFFECTED FILES toolchain/Andr

D12150: Make it possible to build several apk out of a project

apol created this revision. apol added reviewers: Frameworks, Build System. Restricted Application added projects: Frameworks, Build System. apol requested review of this revision. REVISION SUMMARY Refactor the apk-generating code into a separate function, in views of eventually even make it a

D5784: Add support for FreeBSD in FSUtils::getDirectoryFileSystem().

tcberner abandoned this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D5784 To: tcberner, #freebsd, poboiko, bruns Cc: bruns, adridg, kfunk, #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, alexeymin

  1   2   >