KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 190 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/190/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Thu, 29 Mar 2018 06:50:59 + Build duration: 7 min 35 sec and counting JUnit Tests Name: (roo

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 169 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/169/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 29 Mar 2018 06:50:59 + Build duration: 3 min 12 sec and counting CONSOLE OUTPUT [...

D11776: Make use of upstream CMake infrastructure to detect the compiler toolchain

vkrause accepted this revision. vkrause added a comment. This revision is now accepted and ready to land. Nice! Works fine in my setup too. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D11776 To: apol, #frameworks, #build_system, vkraus

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 39 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/39/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Thu, 29 Mar 2018 06:20:04 + Build duration: 11 min and counting JUnit Tests Name: (root) Failed

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 189 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/189/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Thu, 29 Mar 2018 06:20:04 + Build duration: 7 min 35 sec and counting JUnit Tests Name: (roo

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 168 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/168/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 29 Mar 2018 06:20:04 + Build duration: 3 min 31 sec and counting CONSOLE OUTPUT [...

D11734: Have KIO build for Android

apol added a comment. In D11734#235886 , @aacid wrote: > Would it make sense do document the classes/methods that won't work in Android? I was about to do that, but I feel a bit weird because it's as if the rest would work, which I canno

KDE CI: Frameworks syntax-highlighting kf5-qt5 FreeBSDQt5.9 - Build # 43 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20FreeBSDQt5.9/43/ Project: Frameworks syntax-highlighting kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 29 Mar 2018 02:06:04 + Build duration: 6 min 32 sec and counting

KDE CI: Frameworks syntax-highlighting kf5-qt5 SUSEQt5.9 - Build # 10 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20SUSEQt5.9/10/ Project: Frameworks syntax-highlighting kf5-qt5 SUSEQt5.9 Date of build: Thu, 29 Mar 2018 02:06:04 + Build duration: 5 min 49 sec and counting

KDE CI: Frameworks syntax-highlighting kf5-qt5 SUSEQt5.10 - Build # 69 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20SUSEQt5.10/69/ Project: Frameworks syntax-highlighting kf5-qt5 SUSEQt5.10 Date of build: Thu, 29 Mar 2018 02:06:04 + Build duration: 4 min 56 sec and counting

D11735: Make it possible to fully build the project when crosscompiling

This revision was automatically updated to reflect the committed changes. Closed by commit R216:683fc509a1ad: Make it possible to fully build the project when crosscompiling (authored by apol). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11735?v

D11776: Make use of upstream CMake infrastructure to detect the compiler toolchain

apol created this revision. apol added reviewers: Frameworks, Build System. Restricted Application added projects: Frameworks, Build System. apol requested review of this revision. REVISION SUMMARY Instead of having ad-hoc code for gcc, let CMake do its thing. It has a lot of logic that we may

D11461: rename 64 px icons added for elisa

andreask accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH icons_move REVISION DETAIL https://phabricator.kde.org/D11461 To: astippich, #breeze, #vdg, andreask Cc: #frameworks, michaelh, ngraham

D10292: change 32px icons for playlist shuffle and repeat

andreask accepted this revision. andreask added a comment. This revision is now accepted and ready to land. sorry for the late approve. REPOSITORY R266 Breeze Icons BRANCH playlist_shuffle_repeat REVISION DETAIL https://phabricator.kde.org/D10292 To: astippich, #breeze, #vdg, andreask

D11365: also test for value types in taglibextractortest and fix errors

astippich added inline comments. INLINE COMMENTS > mgallien wrote in taglibextractor.cpp:363 > Is it really needed to push directly a list ? > You are ignoring the fact that the original developer intended add to be > called once for each value. I would prefer to keep doing that until we can be

KDE CI: Frameworks syntax-highlighting kf5-qt5 SUSEQt5.9 - Build # 9 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20SUSEQt5.9/9/ Project: Frameworks syntax-highlighting kf5-qt5 SUSEQt5.9 Date of build: Wed, 28 Mar 2018 19:17:58 + Build duration: 5 min 53 sec and counting

KDE CI: Frameworks syntax-highlighting kf5-qt5 SUSEQt5.10 - Build # 68 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20SUSEQt5.10/68/ Project: Frameworks syntax-highlighting kf5-qt5 SUSEQt5.10 Date of build: Wed, 28 Mar 2018 19:17:58 + Build duration: 3 min 0 sec and counting

KDE CI: Frameworks syntax-highlighting kf5-qt5 FreeBSDQt5.9 - Build # 42 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20FreeBSDQt5.9/42/ Project: Frameworks syntax-highlighting kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 28 Mar 2018 19:17:58 + Build duration: 3 min 0 sec and counting

D11529: Balooctl: Deindex unfound files with check command.

smithjd added inline comments. INLINE COMMENTS > broulik wrote in fileindexerconfig.cpp:63 > Please create the `StorageDevices` object on demand, otherwise this penalizes > all users of that class that just want to know whether Baloo itself is > enabled, which was the main reason for doing D112

D11529: Balooctl: Deindex unfound files with check command.

smithjd updated this revision to Diff 30804. smithjd added a comment. - Optimize and make the loop actually work. - Change check command description. - Review changes. - Fix a threading issue. - Fix check operation order. - Use a single StorageDevices object. - Partially revert the

D11767: Remove Recently Saved This Month and Recently Saved Last Month entries by default

ngraham added a comment. We're not removing any features. This patch just removes Recently Saved > This Month and Recently Saved > Last Month from the default places panel. The feature is still available via the Find panel. I //would// like to rename the feature to just be "Recently used

D11649: Fix crash in the file slave

nicolasfella added a subscriber: KDE Connect. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11649 To: aacid, #frameworks, dfaure Cc: #kde_connect, michaelh, ngraham

D11643: Fix crash when device emits ready read after job is finished

nicolasfella added a subscriber: KDE Connect. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11643 To: aacid, #frameworks, dfaure Cc: #kde_connect, michaelh, ngraham

D11767: Remove Recently Saved This Month and Recently Saved Last Month entries by default

rizzitello added a comment. In D11767#235994 , @abetts wrote: > Can we just call all of those entries just "Recent" or "Recently Used" independent of when it happened? I feel that would be more clear without having to remove the feature.

D11767: Remove Recently Saved This Month and Recently Saved Last Month entries by default

abetts added a comment. Can we just call all of those entries just "Recent" or "Recently Used" independent of when it happened? I feel that would be more clear without having to remove the feature. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11767 To: ngraham, #dol

D11365: also test for value types in taglibextractortest and fix errors

mgallien requested changes to this revision. mgallien added a comment. This revision now requires changes to proceed. Please fix the issues. INLINE COMMENTS > taglibextractor.cpp:363 > +if (!genresList.isEmpty()) { > +result->add(Property::Genre, genresList); > }

D11768: Add Desktop and Downloads to the default list of Places

ngraham edited the test plan for this revision. ngraham set the repository for this revision to R241 KIO. Restricted Application added a project: Frameworks. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11768 To: ngraham, #dolphin, #gwenview, #frameworks, #vdg Cc: michael

D11767: Remove Recently Saved This Month and Recently Saved Last Month entries by default

ngraham added a comment. I think the two remaining entries are useful enough to warrant showing them both. `timeline:/` is too indirect, and requires at least one extra click to reach the "recently saved today" functionality. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.o

D11768: Add Desktop and Downloads to the default list of Places

ngraham edited the summary of this revision. ngraham added a dependency: D11767: Remove Recently Saved This Month and Recently Saved Last Month entries by default. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11768 To: ngraham, #dolphin, #gwenview, #frameworks, #vdg Cc:

D11767: Remove Recently Saved This Month and Recently Saved Last Month entries by default

ngraham added a dependent revision: D11768: Add Desktop and Downloads to the default list of Places. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11767 To: ngraham, #dolphin, #gwenview, #frameworks, #vdg Cc: rizzitello, michaelh, ngraham

D11768: Add Desktop and Downloads to the default list of Places

ngraham created this revision. ngraham added reviewers: Dolphin, Gwenview, Frameworks, VDG. ngraham requested review of this revision. REVISION SUMMARY Add Desktop and Downloads to the default list of places, for the following reasons: 1. The Desktop and Downloads folders are heavily used

D11767: Remove Recently Saved This Month and Recently Saved Last Month entries by default

rizzitello added a comment. Perhaps remove the yesterday entry and just show recently created with a link to timeline:/ ? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11767 To: ngraham, #dolphin, #gwenview, #frameworks, #vdg Cc: rizzitello, michaelh, ngraham

D11767: Remove Recently Saved This Month and Recently Saved Last Month entries by default

ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11767 To: ngraham, #dolphin, #gwenview, #frameworks, #vdg Cc: michaelh, ngraham

D11767: Remove Recently Saved This Month and Recently Saved Last Month entries by default

ngraham created this revision. ngraham added reviewers: Dolphin, Gwenview, Frameworks, VDG. Restricted Application added a project: Frameworks. ngraham requested review of this revision. REVISION SUMMARY Remove the Recently Saved > This Month and Recently Saved > Last Month entries from the Pla

D11716: Fix build on FreeBSD broken by d7cce9937d5e9af2753fadb82d11f308b58bb8fa

ngraham added a comment. @dfaure, is this good now? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11716 To: rominf, #dolphin, kossebau, dfaure Cc: ngraham, bcooksley, #frameworks, michaelh

D11685: Implement single click on line number to select line of text

rkron added a reviewer: cullmann. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D11685 To: rkron, #frameworks, #kate, #ktexteditor, ngraham, cullmann Cc: richardbowen, ngraham, #ktexteditor, #kate, #frameworks, michaelh, kevinapavew, demsking, cullmann, sars, dhauma

D11735: Make it possible to fully build the project when crosscompiling

apol updated this revision to Diff 30791. apol added a comment. Use the variable instead of hardcoding a path REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11735?vs=30677&id=30791 BRANCH master REVISION DETAIL https://phabricator.kde.org/

D11735: Make it possible to fully build the project when crosscompiling

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting BRANCH master REVISION DETAIL https://phabricator.kde.org/D11735 To: apol, #frameworks, vkrause, dhaumann Cc: michaelh, ngraham

D11735: Make it possible to fully build the project when crosscompiling

apol added a comment. In D11735#235888 , @vkrause wrote: > Clever idea, and should be safe for existing cross-compilation setups like Yocto. The only thing that looks suspicious to me is the hardcoded "/opt/nativetooling/" path. Is that really n

D11735: Make it possible to fully build the project when crosscompiling

vkrause added a comment. Clever idea, and should be safe for existing cross-compilation setups like Yocto. The only thing that looks suspicious to me is the hardcoded "/opt/nativetooling/" path. Is that really needed? REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricat

D11529: Balooctl: Deindex unfound files with check command.

broulik requested changes to this revision. broulik added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > fileindexerconfig.cpp:63 > , m_indexHidden(false) > -, m_devices(nullptr) > +, m_devices(new StorageDevices(this)) > , m_maxUncomittedFiles

D11734: Have KIO build for Android

aacid added a comment. Would it make sense do document the classes/methods that won't work in Android? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11734 To: apol, #frameworks Cc: aacid, michaelh, ngraham

KDE CI: Frameworks ki18n kf5-qt5 SUSEQt5.9 - Build # 10 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ki18n%20kf5-qt5%20SUSEQt5.9/10/ Project: Frameworks ki18n kf5-qt5 SUSEQt5.9 Date of build: Wed, 28 Mar 2018 10:24:51 + Build duration: 5 min 7 sec and counting JUnit Tests Name: (roo

KDE CI: Frameworks ki18n kf5-qt5 SUSEQt5.10 - Build # 24 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ki18n%20kf5-qt5%20SUSEQt5.10/24/ Project: Frameworks ki18n kf5-qt5 SUSEQt5.10 Date of build: Wed, 28 Mar 2018 10:24:51 + Build duration: 5 min 10 sec and counting JUnit Tests Name: (

KDE CI: Frameworks ki18n kf5-qt5 FreeBSDQt5.9 - Build # 20 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ki18n%20kf5-qt5%20FreeBSDQt5.9/20/ Project: Frameworks ki18n kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 28 Mar 2018 10:24:51 + Build duration: 1 min 58 sec and counting JUnit Tests Nam

D11176: Don't call PythonInterp.cmake in KF5I18NMacros.

cgiboudeaux added a comment. In D11176#235843 , @sitter wrote: > @cgiboudeaux @dfaure [...] > This is gonna cause trouble major trouble for the next release. No, it's a very minor issue that's already fixed. REPOSITORY R249 KI

D11716: Fix build on FreeBSD broken by d7cce9937d5e9af2753fadb82d11f308b58bb8fa

bcooksley added a comment. This change or an equivalent fix needs to be merged in relatively urgently as it is now creating a maintainability issue for the CI system. As a consequence of the breakage the Dependency Builds are failing and they need to complete a successful run in order to re

KDE CI: Frameworks kpackage kf5-qt5 SUSEQt5.10 - Build # 44 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.10/44/ Project: Frameworks kpackage kf5-qt5 SUSEQt5.10 Date of build: Wed, 28 Mar 2018 09:09:55 + Build duration: 6 min 18 sec and counting JUnit Tests N

KDE CI: Frameworks kpackage kf5-qt5 SUSEQt5.9 - Build # 21 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.9/21/ Project: Frameworks kpackage kf5-qt5 SUSEQt5.9 Date of build: Wed, 28 Mar 2018 09:09:55 + Build duration: 3 min 1 sec and counting JUnit Tests Name

KDE CI: Frameworks kpackage kf5-qt5 FreeBSDQt5.9 - Build # 38 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20FreeBSDQt5.9/38/ Project: Frameworks kpackage kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 28 Mar 2018 09:09:55 + Build duration: 1 min 52 sec and counting JUnit Tests

D11176: Don't call PythonInterp.cmake in KF5I18NMacros.

sitter added subscribers: dfaure, sitter. sitter added a comment. @cgiboudeaux @dfaure I am almost entirely certain this broke building of ki18n itself when *it* contains translations. Neon packs translations into git builds, so here's the failure: https://build.neon.kde.org/job/xenia