D10918: taglibextractor: Refactor for better readability

michaelh added a comment. In D10918#216439 , @astippich wrote: > If you don't mind, I will take this over when D10803 lands. That would be great. REPOSITORY R286 KFileMetaData REVISION DETAIL ht

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 56 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/56/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 01 Mar 2018 21:10:10 + Build duration: 2 hr 16 min and counting

D10956: Add syntax highlighting for MIB files

jkeuter created this revision. jkeuter added a reviewer: dhaumann. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. jkeuter requested review of this revision. REVISION SUMMARY Add a syntax file for MIBs, as well as a test mib. REPOSITORY

Fallback Icon Theme

Hi! We at Krusader would like to address a rather standard issue of applications - missing icons. And we would like an opinion of you as experts :). Starter discussion (which led in here) is on Krusader's phabricator: https://phabricator.kde.org/D10352 Krusader is using a lot of icons existing

D10654: [KUrlNavigatorPlacesSelector] Use KFilePlacesModel::convertedUrl

rkflx accepted this revision. rkflx added a comment. This revision is now accepted and ready to land. Tested this in several apps, works as it should. Code LGTM. I'd say we should get this patch in right now, we can always figure out a better solution later. After all, `KFilePlacesModel::

KDE CI: Frameworks kwayland kf5-qt5 FreeBSDQt5.9 - Build # 27 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20FreeBSDQt5.9/27/ Project: Frameworks kwayland kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 01 Mar 2018 19:14:03 + Build duration: 3 hr 3 min and counting JUnit Tests

D10937: Retouching of Screen Layout Selection OSD Icons

ngraham added a comment. In D10937#216512 , @abetts wrote: > Is there a way that we can add extra clarity by adding a label below the icons? A label that explains what the action is? I agree that the current symbolism can be hard to read but it

D10937: Retouching of Screen Layout Selection OSD Icons

abetts added a comment. Is there a way that we can add extra clarity by adding a label below the icons? A label that explains what the action is? I agree that the current symbolism can be hard to read but it is also very simple. If you make the connection to label, it will be even stronger i

D10937: Retouching of Screen Layout Selection OSD Icons

ngraham added a comment. This came up in the VDG telegram room: the rotate and flip icons are still rather unclear, just from the icon alone. We came up with a potential alternative: how about displaying a rotated or flipped image in the screen? It would have to be something with strong dire

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 80 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/80/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Thu, 01 Mar 2018 21:10:10 + Build duration: 13 min and counting JUnit Tes

D10937: Retouching of Screen Layout Selection OSD Icons

mart added a comment. they look awesome! one point tough: those are only going to work at a single size, as they are more vulnerable to become blurry when resized, so they would need other size versions as well (small sizes probably being like before) as they are part of the icon th

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.9 - Build # 2 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.9/2/ Project: Frameworks kwayland kf5-qt5 SUSEQt5.9 Date of build: Thu, 01 Mar 2018 19:14:03 + Build duration: 13 min and counting JUnit Tests Name: (roo

D10903: Preserve fragment when redirecting from http to https

guoci edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10903 To: guoci, #plasma Cc: michaelh, ngraham, #frameworks

D10937: Retouching of Screen Layout Selection OSD Icons

pstefan edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D10937 To: pstefan, #breeze Cc: ngraham, #frameworks, davidc, michaelh, crozbo, firef, alexeymin, skadinna, aaronhoneycutt, mbohlender

D10937: Retouching of Screen Layout Selection OSD Icons

pstefan added a comment. Some different versions. Personally, I think the first or last version is best, however, the last would probably only work in conjunction to the other icons and not as stand alones. F5735170: Screenshot from 2018-03-01 20:14:44.png

D10929: Implement releasing of client-freed output

This revision was automatically updated to reflect the committed changes. Closed by commit R127:08e7b23c54bd: Implement releasing of client-freed output (authored by Kanedias). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10929?vs=28292&id=28353 REVISION D

D10903: Preserve fragment when redirecting from http to https

guoci added a comment. In D10903#216407 , @michaelh wrote: > In D10903#216401 , @ngraham wrote: > > > Even without the patch, `kde-open5 http://en.wikipedia.org/wiki/URL#Syntax` opens my web browser

D10918: taglibextractor: Refactor for better readability

astippich added a comment. In D10918#216120 , @michaelh wrote: > In D10918#215909 , @mgallien wrote: > > > Thanks for your work. > > I would prefer to wait for D10803

D10803: handle more tags in taglibextractor

astippich added a comment. In D10803#216118 , @michaelh wrote: > With this many tags we need to be more considerate because it affects other applications which will need to adapt. > > 1. Plural or singular. E.g. If it was 'performers' the pro

D10937: Retouching of Screen Layout Selection OSD Icons

ngraham added a comment. That looks nearly perfect to me! One more minor issue: on the icons that depict spanning across two screens, the blue window has a vertical skew between screens that might make you think it's going to be buggy. Perhaps we should somehow make sure that the window is v

D10903: Preserve fragment when redirecting from http to https

michaelh added a comment. In D10903#216401 , @ngraham wrote: > Even without the patch, `kde-open5 http://en.wikipedia.org/wiki/URL#Syntax` opens my web browser with that URL with KDE Frameworks 5.43 and git master. What am I missing here?

D10937: Retouching of Screen Layout Selection OSD Icons

pstefan added a comment. In D10937#216270 , @ngraham wrote: > But I don't like how the window and X icons in the other icons are now much lighter and smaller. I feel like they need to be a bit bigger and/or have thicker line weights to ensure th

D10903: Preserve fragment when redirecting from http to https

ngraham added a comment. Even without the patch, `kde-open5 http://en.wikipedia.org/wiki/URL#Syntax` opens my web browser with that URL with KDE Frameworks 5.43 and git master. What am I missing here? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10903 To: guoci, #pl

D10903: Preserve fragment when redirecting from http to https

guoci edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10903 To: guoci, #plasma Cc: #frameworks, michaelh

D10929: Implement releasing of client-freed output

graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH kanedias/wip-wl-output REVISION DETAIL https://phabricator.kde.org/D10929 To: Kanedias, davidedmundson, graesslin Cc: jgrulich, #frameworks, michaelh

D10243: Improve visibility of disconnected Wi-Fi icons

sebas requested changes to this revision. sebas added a comment. This revision now requires changes to proceed. I second that the icon should be made red, this mitigates the visibility issue and makes it consistent with the disconnected ethernet icon. @andreask, can you make this change? REP

D10937: Retouching of Screen Layout Selection OSD Icons

ngraham added a comment. Thanks for this patch! I like that the laptop and projector screen icons look better with your versions and don't have line weights that are as thick, which returns the focus to the icons that they're displaying. And I like that the arrows now have appropriate h

D10551: autotest for crashing in KArchiveDirectory::addEntry

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Yeah but good practice is better applied everywhere, to avoid showing bad examples to others ;) Thanks. REVISION DETAIL https://phabricator.kde.org/D10551 To: sandsmark, dfaure, apo

KDE CI: Frameworks kirigami kf5-qt5 WindowsMSVCQt5.10 - Build # 5 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20WindowsMSVCQt5.10/5/ Project: Frameworks kirigami kf5-qt5 WindowsMSVCQt5.10 Date of build: Thu, 01 Mar 2018 11:28:31 + Build duration: 1 min 49 sec and counting

D10937: Retouching of Screen Layout Selection OSD Icons

pstefan created this revision. pstefan added a reviewer: Breeze. pstefan added a project: VDG. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. pstefan requested review of this revision. REVISION SUMMARY **Overview** The icons to be rep

D10918: taglibextractor: Refactor for better readability

michaelh added a comment. In D10918#215909 , @mgallien wrote: > Thanks for your work. > I would prefer to wait for D10803 to land before doing any big changes like that. I did this mostly for myself

KDE CI: Frameworks kfilemetadata kf5-qt5 FreeBSDQt5.9 - Build # 9 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kfilemetadata%20kf5-qt5%20FreeBSDQt5.9/9/ Project: Frameworks kfilemetadata kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 01 Mar 2018 10:36:47 + Build duration: 1 min 4 sec and counting JUnit Te

KDE CI: Frameworks kfilemetadata kf5-qt5 FreeBSDQt5.9 - Build # 8 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kfilemetadata%20kf5-qt5%20FreeBSDQt5.9/8/ Project: Frameworks kfilemetadata kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 01 Mar 2018 10:34:47 + Build duration: 39 sec and counting CONSOLE OUTPU

KDE CI: Frameworks kfilemetadata kf5-qt5 FreeBSDQt5.9 - Build # 7 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kfilemetadata%20kf5-qt5%20FreeBSDQt5.9/7/ Project: Frameworks kfilemetadata kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 01 Mar 2018 10:32:46 + Build duration: 37 sec and counting CONSOLE OUTPU

D10803: handle more tags in taglibextractor

michaelh added a reviewer: ngraham. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D10803 To: astippich, mgallien, ngraham Cc: vhanda, dfaure, michaelh, ngraham, #frameworks, ashaposhnikov, spoorun, nicolasfella, alexeymin

D10803: handle more tags in taglibextractor

michaelh added a comment. With this many tags we need to be more considerate because it affects other applications which will need to adapt. 1. Plural or singular. E.g. If it was 'performers' the property could reused by video files. (In KF6 the same should apply to 'Languages') 2. If

D10551: autotest for crashing in KArchiveDirectory::addEntry

sandsmark marked an inline comment as done. sandsmark added a comment. test file was from a customer, but it's from a public INLINE COMMENTS > dfaure wrote in karchivetest.cpp:1172 > This detaches the list, put it in a const local variable. > > (standard range-for trap with Qt containers) t

D10551: autotest for crashing in KArchiveDirectory::addEntry

sandsmark updated this revision to Diff 28314. sandsmark added a comment. use a local const copy of entries CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10551?vs=27666&id=28314 REVISION DETAIL https://phabricator.kde.org/D10551 AFFECTED FILES data/out.epub karchivetest.cpp

KDE CI: Frameworks knewstuff kf5-qt5 FreeBSDQt5.9 - Build # 34 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20knewstuff%20kf5-qt5%20FreeBSDQt5.9/34/ Project: Frameworks knewstuff kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 01 Mar 2018 09:02:36 + Build duration: 1 min 12 sec and counting CONSOLE OUTPUT

D10929: Implement releasing of client-freed output

jgrulich added a comment. I cannot comment code/wayland part, but I can verify that this works as expected and solve my problem in screen cast portal where I can now bind outputs to first get information about them and present them to users and once they select a screen I can bind the output

D10857: Change qSort to std::sort in simplifiedUrlList

jtamate planned changes to this revision. jtamate added a comment. I've run David test, it is not a CPU problem: g++ -fPIC -O2 qsort_performance.cpp -I /usr/include/qt5/QtCore -I/usr/include/qt5 -l Qt5Core ./a.out "qSort took: 3335 ms" "std::sort took: 3452 ms" "qSort took: 3285 m