bcooksley added subscribers: zimmerman, bcooksley.
bcooksley added a comment.
@rjvbb Please mind your language. From my perspective what you are asking of
@mwolff here is quite unreasonable - I can't see any reason why incremental
improvements, piece by piece would be unacceptable here.
REPO
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20FreeBSDQt5.9/1/
Project:
Frameworks purpose kf5-qt5 FreeBSDQt5.9
Date of build:
Thu, 18 Jan 2018 07:07:38 +
Build duration:
2 min 15 sec and counting
JUnit Tests
On Sun, Jan 14, 2018 at 7:05 AM, Shaheed Haque wrote:
> Thanks to some upstream fixes, I have the cppyy-based bindings for KF5 and
> also Qt5 (see below) showing signs of life. Notes:
Hi Shaheed,
>
> The packaging has advanced to the point where I think ECM-based
> framework-by-framework binding
Hi all,
I've been examining the dependencies for Purpose, and it appears that
it has build time dependencies on 'kaccounts-integration' and
'kdeconnect-kde'
This creates an effective dependency loop as these two projects are
dependent on Frameworks.
Any suggestions to fix this? If it is for a pl
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/91/
Project:
Frameworks kio kf5-qt5 SUSEQt5.7
Date of build:
Thu, 18 Jan 2018 06:30:26 +
Build duration:
8 min 38 sec and counting
JUnit Tests
Name: (root) F
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/90/
Project:
Frameworks kio kf5-qt5 SUSEQt5.7
Date of build:
Wed, 17 Jan 2018 03:59:57 +
Build duration:
1 day 2 hr and counting
CONSOLE OUTPUT
[...truncated
lbeltrame accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R293 Baloo
BRANCH
translated
REVISION DETAIL
https://phabricator.kde.org/D9712
To: michaelh, #frameworks, vhanda, smithjd, lueck, lbeltrame
Cc: ltoscano, lbeltrame, elvisangelaccio, lueck, dfaure
lueck added a comment.
i18n looks ok, thanks
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D9712
To: michaelh, #frameworks, vhanda, smithjd, lueck
Cc: ltoscano, lbeltrame, elvisangelaccio, lueck, dfaure, ngraham
apol accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D9950
To: broulik, #frameworks, davidedmundson, apol
Cc: ngraham
apol added a comment.
LGTM
INLINE COMMENTS
> kuserproxy.cpp:66
> +if (path == m_user.faceIconPath() || path == QDir::homePath() +
> QLatin1String("/.face.icon")
> +|| path == accountsServiceIconPath + QLatin1String("/") +
> m_user.loginName()) {
> // we need to forc
aacid accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D9793
To: wbauer, #frameworks, aacid
Cc: aacid, safaalfulaij, #build_system
broulik edited the test plan for this revision.
REPOSITORY
R296 KDeclarative
REVISION DETAIL
https://phabricator.kde.org/D9951
To: broulik, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
broulik edited the test plan for this revision.
REPOSITORY
R296 KDeclarative
REVISION DETAIL
https://phabricator.kde.org/D9951
To: broulik, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
broulik created this revision.
broulik added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
broulik requested review of this revision.
REVISION SUMMARY
The avatar can also lie in the accounts serv
broulik created this revision.
broulik added reviewers: Frameworks, davidedmundson.
Restricted Application added a project: Frameworks.
broulik requested review of this revision.
REVISION SUMMARY
Here `.face.icon` is a symlink to `.face` and when I remove my avatar in user
manager, the `.face`
michaelh retitled this revision from "balooctl status: produce parseable
output" to "balooctl status: translatable message".
michaelh edited the summary of this revision.
michaelh added a reviewer: lueck.
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D9712
To: michaelh,
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D9822
To: mwolff, dfaure
Cc: #frameworks
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D9928
To: rkron, #frameworks, davidedmundson
Cc: alexeymin, aacid, #frameworks
rkron updated this revision to Diff 25540.
rkron added a comment.
After reviewing the kio commit where similar changes were made, I changed
QFile::exists to QFileInfo::exists as was done in kio and have updated my
patch. I should have looked at kio before my first submission. Sorry.
REPOSITO
wbauer updated this revision to Diff 25536.
wbauer edited the summary of this revision.
wbauer edited the test plan for this revision.
wbauer added a comment.
Leave bcp47Name() in for compatibility, add const.
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
https://phabricat
romangg added a reviewer: romangg.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D1231
To: Kanedias, graesslin, davidedmundson, romangg
Cc: jgrulich, romangg, ngraham, alexeymin, #frameworks, davidedmundson,
plasma-devel, leezu, ZrenBot, progwolff, lesliezhai, ali-moh
wbauer marked an inline comment as done.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D9793
To: wbauer, #frameworks
Cc: aacid, safaalfulaij, #build_system
davidedmundson added a comment.
I handle scaling everyewhere except for Plasma which does it's own thing.
I'm not convinced by this patch:
If this was Qt's devicePixelRatio this would definitely 100% make sense as
there we write all UI code in logical sizes.
But in Pla
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/72/
Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
Date of build:
Wed, 17 Jan 2018 08:52:09 +
Build duration:
25 min and counting
JUnit Tests
Name: (root)
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:e0f3fac05287: [Uri Filter Search Provider] Avoid double
delete (authored by broulik).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9938?vs=25523&id=25524
REVISION DE
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.
Oops.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D9938
To: broulik, dfaure
Cc: #frameworks
broulik created this revision.
broulik added a reviewer: dfaure.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
broulik requested review of this revision.
REVISION SUMMARY
Since
https://phabricator.kde.org/R241:6246cc48067845208cf5acd8
broulik retitled this revision from "[ikws search provider] Avoid double
delete" to "[Uri Filter Search Provider] Avoid double delete".
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D9938
To: broulik, dfaure
Cc: #frameworks
alexeymin added a comment.
There was a similar fix commited somewhere (don't remember, in KIO?) related
to QFile in newer Qt complaining about empty filenames passed, so this is
probably fine too...
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D
hein added a reviewer: davidedmundson.
hein added a comment.
I think this needs David
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D9286
To: mart, #plasma, davidedmundson
Cc: hein, broulik, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezha
broulik added a comment.
Ping
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D9286
To: mart, #plasma
Cc: broulik, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
31 matches
Mail list logo
