D7968: Forward QComboBox signals instead of QComboBox lineedit signals

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Looks good, but aren't there unittests missing for the non-editable combo case? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7968 To: mwolff, apol, dfaur

D9175: Migrate some more QRegExps to QRegularExpression

cullmann added a comment. For the QLatin1String on the right side in some contructors: should it not be always QStringLiteral? Not that it will matter a lot. INLINE COMMENTS > dhaumann wrote in kateview.cpp:3595 > Now that's a good point: I don't completely. > It appends a leading and traili

D8371: Support for underscores in numeric literals (Python 3.6)

cullmann added a comment. Hi, I assume the regex are right ;=) For the patch: a) I think the version number must be increased b) an extended unit test would be nice, to really show that the regex are right. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricato

D9219: WIP: Extend Scripting API

cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. I think that extension idea is good. The functions won't really fit to document or view and an editor object could be used for other global things, too, without further pollu

D9257: MessageInterface: Add CenterInView as additional position

cullmann added a comment. For the "KateMessageWidget *m_topMessageWidget" and Co. members: Would it make sense to have just an array of pointers with index == the matching MessagePosition enum value? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D9257 To: dhaum

D9076: Have an application that can cross-check if the promised platforms are correct

bcooksley added a comment. The FreeBSD platform name was changed this week yes. I can't see any explicit handling for 'All' being specified as a platform in the metainfo file here though, unless one is always required to list the platforms explicitly? REPOSITORY R857 CI System Tooling REV

D9258: Disconnect shortcutedit slot on widget destruction

This revision was automatically updated to reflect the committed changes. Closed by commit R263:037a4ffa467d: Disconnect shortcutedit slot on widget destruction (authored by davidedmundson). REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9258?vs=23656&id=23660

D9258: Disconnect shortcutedit slot on widget destruction

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R263 KXmlGui BRANCH master REVISION DETAIL https://phabricator.kde.org/D9258 To: davidedmundson, #plasma, broulik Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensre

D9258: Disconnect shortcutedit slot on widget destruction

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY If the widget is destroyed the connect still exists with a dangling cap

D9257: MessageInterface: Add CenterInView as additional position

dhaumann created this revision. dhaumann added reviewers: cullmann, neundorf. Restricted Application added projects: Kate, Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY This patch extends the message interface to support CenterInView. This should be binary

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 26 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/26/ Project: Frameworks kio kf5-qt5 SUSEQt5.7 Date of build: Fri, 08 Dec 2017 13:58:18 + Build duration: 7 min 0 sec and counting JUnit Tests Name: (root) F

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 25 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/25/ Project: Frameworks kio kf5-qt5 SUSEQt5.7 Date of build: Fri, 08 Dec 2017 13:39:35 + Build duration: 18 min and counting JUnit Tests Name: (root) Failed:

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 26 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/26/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Fri, 08 Dec 2017 13:49:13 + Build duration: 7 min 4 sec and counting JUnit Tests Name: (root)

D9252: Created 'GroupHiddenRole' for KPlacesModel

mwolff added a comment. thanks lgtm REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9252 To: renatoo, mwolff Cc: #frameworks

D9252: Created 'GroupHiddenRole' for KPlacesModel

This revision was automatically updated to reflect the committed changes. Closed by commit R241:561210cd18c9: Created 'GroupHiddenRole' for KPlacesModel (authored by Renato Araujo Oliveira Filho ). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 25 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/25/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Fri, 08 Dec 2017 13:39:35 + Build duration: 9 min 16 sec and counting JUnit Tests Name: (root

D9249: forward socket error string to KTcpSocket

This revision was automatically updated to reflect the committed changes. Closed by commit R241:84f290a2659d: forward socket error string to KTcpSocket (authored by mkoller). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9249?vs=23638&id=23648 REVISION DETAIL

D9252: Created 'GroupHiddenRole' for KPlacesModel

renatoo marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9252 To: renatoo, mwolff Cc: #frameworks

D9252: Created 'GroupHiddenRole' for KPlacesModel

renatoo updated this revision to Diff 23647. renatoo added a comment. Refactored unit test REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9252?vs=23644&id=23647 REVISION DETAIL https://phabricator.kde.org/D9252 AFFECTED FILES autotests/kfileplacesmodeltes

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 24 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/24/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Fri, 08 Dec 2017 13:19:55 + Build duration: 14 min and counting JUnit Tests Name: (root) Fail

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 24 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/24/ Project: Frameworks kio kf5-qt5 SUSEQt5.7 Date of build: Fri, 08 Dec 2017 13:19:55 + Build duration: 12 min and counting JUnit Tests Name: (root) Failed

D9252: Created 'GroupHiddenRole' for KPlacesModel

mwolff accepted this revision. mwolff added a comment. This revision is now accepted and ready to land. you could reduce the code duplication by adding a loop. Note that you can even write something like this: for (auto type : {type1, type2, type3}) { } INLINE COMMENTS

D9252: Created 'GroupHiddenRole' for KPlacesModel

renatoo added a dependent revision: D9242: Implemented support for hide/show groups. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9252 To: renatoo, mwolff Cc: #frameworks

D9252: Created 'GroupHiddenRole' for KPlacesModel

renatoo edited the summary of this revision. renatoo added a reviewer: mwolff. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9252 To: renatoo, mwolff Cc: #frameworks

D9252: Created 'GroupHiddenRole' for KPlacesModel

renatoo created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Created new role for KPlacesModel TEST PLAN unit test REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9252 AFFECTE

D8619: Refactor and remove duplicate code in kfileplacesview

This revision was automatically updated to reflect the committed changes. Closed by commit R241:5f7e892cb79f: Refactor and remove duplicate code in kfileplacesview (authored by mlaurent). Restricted Application added a project: Frameworks. CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D86

D9249: forward socket error string to KTcpSocket

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9249 To: mkoller, dfaure Cc: #frameworks

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 23 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/23/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Fri, 08 Dec 2017 12:42:45 + Build duration: 19 min and counting JUnit Tests Name: (root) Fail

D8519: do not make the context menu a Window

mkoller retitled this revision from "do not make the context menu a Window; do not force raise a window" to "do not make the context menu a Window". mkoller edited the summary of this revision. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D8519 To: mkoller, dav

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 23 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/23/ Project: Frameworks kio kf5-qt5 SUSEQt5.7 Date of build: Fri, 08 Dec 2017 12:42:44 + Build duration: 7 min 28 sec and counting JUnit Tests Name: (root)

D9249: forward socket error string to KTcpSocket

mkoller created this revision. mkoller added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY KTcpSocket is a QIODevice, internally using a Qt socket - however it does not set the error string of itse

D9241: Emit 'groupHiddenChanged' signal.

This revision was automatically updated to reflect the committed changes. Closed by commit R241:f1185dc10acf: Emit 'groupHiddenChanged' signal. (authored by Renato Araujo Oliveira Filho ). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9241

D9241: Emit 'groupHiddenChanged' signal.

mwolff accepted this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9241 To: renatoo, franckarrecot, mwolff, mlaurent Cc: mwolff, #frameworks

D9123: reuse KPackage instance between PluginLoader and Applet

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH phab/kpackageinctor REVISION DETAIL https://phabricator.kde.org/D9123 To: mart, #plasma, davidedmundson Cc: davidedmundson, plasma-devel, #frameworks,

D9247: Extend Scripting API to allow executing commands

cullmann added a comment. > Well, the scripting commands are also available on the command line as commands, aren't they? So you could essentially call yourself. Yeah, that is true, but that is no difference to you are calling yourself indirectly in javascript itself. Perhaps a bit more

D9247: Extend Scripting API to allow executing commands

dhaumann added a comment. Well, the scripting commands are also available on the command line as commands, aren't they? So you could essentially call yourself. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D9247 To: dhaumann, cullmann, mwolff, kfunk Cc: #framewo

D9123: reuse KPackage instance between PluginLoader and Applet

mart added inline comments. INLINE COMMENTS > davidedmundson wrote in applet.cpp:98 > If anyone uses the old argument list syntax (where the first argument was a > string or a kpluginmetadata) this will break. > > Can we be sure that the PluginLoader was the only user? > It was a somewhat und

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 22 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/22/ Project: Frameworks kio kf5-qt5 SUSEQt5.7 Date of build: Fri, 08 Dec 2017 10:58:34 + Build duration: 18 min and counting JUnit Tests Name: (root) Failed

D9247: Extend Scripting API to allow executing commands

cullmann added a comment. How can we have infinite recursion? By calling a command that triggers again the script function we did call the command in? If that is the only problem, I see no issue, that can happen with normal function calls already, perhaps we could guard chained command calls

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 22 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/22/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Fri, 08 Dec 2017 10:58:34 + Build duration: 13 min and counting JUnit Tests Name: (root) Fail

D8450: User can now hide an entire places group from KFilePlacesView

This revision was automatically updated to reflect the committed changes. Closed by commit R241:b8bd61c3650c: User can now hide an entire places group from KFilePlacesView (authored by franckarrecot). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8450?vs=23630&id

D8367: Hidding place groups implementation in KFilePlacesModel

This revision was automatically updated to reflect the committed changes. Closed by commit R241:cd9856d14552: Hidding place groups implementation in KFilePlacesModel (authored by franckarrecot). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8367?vs=23629&id=23632

D9015: Refactoring the hidding/showing animation use within KFilePlacesView

This revision was automatically updated to reflect the committed changes. Closed by commit R241:2cd35636bbf9: Refactoring the hidding/showing animation use within KFilePlacesView (authored by franckarrecot). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9015?vs=2

D9015: Refactoring the hidding/showing animation use within KFilePlacesView

franckarrecot updated this revision to Diff 23631. franckarrecot added a comment. rebased REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9015?vs=23411&id=23631 REVISION DETAIL https://phabricator.kde.org/D9015 AFFECTED FILES src/filewidgets/kfileplacesvie

D8450: User can now hide an entire places group from KFilePlacesView

franckarrecot updated this revision to Diff 23630. franckarrecot added a comment. corrected and rebased REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8450?vs=23410&id=23630 REVISION DETAIL https://phabricator.kde.org/D8450 AFFECTED FILES autotests/kfilep

D8367: Hidding place groups implementation in KFilePlacesModel

franckarrecot updated this revision to Diff 23629. franckarrecot added a comment. rebase REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8367?vs=23409&id=23629 REVISION DETAIL https://phabricator.kde.org/D8367 AFFECTED FILES autotests/kfileplacesmodeltest.

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.7 - Build # 8 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.7/8/ Project: Frameworks baloo kf5-qt5 SUSEQt5.7 Date of build: Fri, 08 Dec 2017 10:45:24 + Build duration: 9 min 15 sec and counting JUnit Tests Name: (root

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.10 - Build # 8 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.10/8/ Project: Frameworks baloo kf5-qt5 SUSEQt5.10 Date of build: Fri, 08 Dec 2017 10:45:24 + Build duration: 6 min 43 sec and counting JUnit Tests Name: (r

D9247: Extend Scripting API to allow executing commands

dhaumann retitled this revision from "Extend Scripting API to allow executong commands" to "Extend Scripting API to allow executing commands". REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D9247 To: dhaumann, cullmann, mwolff, kfunk Cc: #frameworks, kevinapavew, ngr

D9247: Extend Scripting API to allow executing commands

dhaumann edited the summary of this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D9247 To: dhaumann, cullmann, mwolff, kfunk Cc: #frameworks, kevinapavew, ngraham, demsking, cullmann, sars, dhaumann

Re: Failing KTextEditor unit tests

On Fri, Dec 8, 2017 at 10:21 AM, Ben Cooksley wrote: > On Wed, Dec 6, 2017 at 9:24 PM, David Faure wrote: >> On lundi 4 décembre 2017 18:38:50 CET Ben Cooksley wrote: >>> If someone has a list of common font packages for SUSE then I can add >>> those to the image relatively easy, which will proba

D9247: Extend Scripting API to allow executong commands

dhaumann created this revision. dhaumann added reviewers: cullmann, mwolff, kfunk. Restricted Application added projects: Kate, Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY This patch adds the following JavaScript API: object view.executeCommand(String

KDE CI: Frameworks kpackage kf5-qt5 SUSEQt5.10 - Build # 6 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.10/6/ Project: Frameworks kpackage kf5-qt5 SUSEQt5.10 Date of build: Fri, 08 Dec 2017 10:22:29 + Build duration: 4 min 32 sec and counting JUnit Tests Na

KDE CI: Frameworks kpackage kf5-qt5 SUSEQt5.7 - Build # 6 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.7/6/ Project: Frameworks kpackage kf5-qt5 SUSEQt5.7 Date of build: Fri, 08 Dec 2017 10:22:29 + Build duration: 1 min 11 sec and counting JUnit Tests Name

D9076: Have an application that can cross-check if the promised platforms are correct

adridg added a comment. To understand the expected output better: suppose something says "platforms: All", like kcontacts. If there's no actual build configured in CI for that something, for FreeBSD, it will say "FreeBS is a disabled platform". The message can probably be improved, then. And

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.10 - Build # 7 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.10/7/ Project: Frameworks baloo kf5-qt5 SUSEQt5.10 Date of build: Fri, 08 Dec 2017 09:47:39 + Build duration: 6 min 42 sec and counting JUnit Tests Name: (ro

KDE CI: Frameworks baloo kf5-qt5 WindowsMSVCQt5.9 - Build # 28 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20WindowsMSVCQt5.9/28/ Project: Frameworks baloo kf5-qt5 WindowsMSVCQt5.9 Date of build: Fri, 08 Dec 2017 09:47:39 + Build duration: 3 min 2 sec and counting

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.7 - Build # 7 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.7/7/ Project: Frameworks baloo kf5-qt5 SUSEQt5.7 Date of build: Fri, 08 Dec 2017 09:47:39 + Build duration: 2 min 33 sec and counting JUnit Tests Name: (roo

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.10 - Build # 6 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.10/6/ Project: Frameworks baloo kf5-qt5 SUSEQt5.10 Date of build: Fri, 08 Dec 2017 09:41:54 + Build duration: 4 min 50 sec and counting CONSOLE OUTPUT [...tr

[baloo] /: Revert "Autogenerate debug file"

Git commit afc01f1c5048d294b0676403a18744dde0a53d3a by Ben Cooksley. Committed on 08/12/2017 at 09:46. Pushed by bcooksley into branch 'master'. Revert "Autogenerate debug file" I'm backing all of this out for now as fixing this properly is non-trivial and the build is broken on at least one plat

KDE CI: Frameworks baloo kf5-qt5 WindowsMSVCQt5.9 - Build # 27 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20WindowsMSVCQt5.9/27/ Project: Frameworks baloo kf5-qt5 WindowsMSVCQt5.9 Date of build: Fri, 08 Dec 2017 09:41:54 + Build duration: 3 min 10 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.7 - Build # 6 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.7/6/ Project: Frameworks baloo kf5-qt5 SUSEQt5.7 Date of build: Fri, 08 Dec 2017 09:41:54 + Build duration: 1 min 39 sec and counting CONSOLE OUTPUT [...trun

[baloo] src: Complete removal of references to baloodebug.cpp which was deleted in the previous commit

Git commit a7ebc07cad22e3c581960969e779940f992ba320 by Ben Cooksley. Committed on 08/12/2017 at 09:41. Pushed by bcooksley into branch 'master'. Complete removal of references to baloodebug.cpp which was deleted in the previous commit CCMAIL: mon...@kde.org CCMAIL: kde-frameworks-devel@kde.org

D9076: Have an application that can cross-check if the promised platforms are correct

bcooksley added a comment. In principle I think this code is doing the right thing as it's comparing what's enabled on CI vs. what's enabled in the Framework's own metadata files. Any comments in that regard David? REPOSITORY R857 CI System Tooling REVISION DETAIL https://phabricator.k

Re: Failing KTextEditor unit tests

On Wed, Dec 6, 2017 at 9:24 PM, David Faure wrote: > On lundi 4 décembre 2017 18:38:50 CET Ben Cooksley wrote: >> If someone has a list of common font packages for SUSE then I can add >> those to the image relatively easy, which will probably fix those >> tests. > > dejavu-fonts might be enough. >

D9241: Emit 'groupHiddenChanged' signal.

mlaurent accepted this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9241 To: renatoo, franckarrecot, mwolff, mlaurent Cc: mwolff, #frameworks