mlaurent updated this revision to Diff 23199.
mlaurent marked 3 inline comments as done.
mlaurent added a comment.
- Port to QByteArray. Add missing const. Fix error found by David
REPOSITORY
R263 KXmlGui
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9049?vs=23133&id=23199
BRANC
mlaurent retitled this revision from "Compile with:" to "Compile with stricter
compilation flags".
mlaurent edited the summary of this revision.
REPOSITORY
R263 KXmlGui
REVISION DETAIL
https://phabricator.kde.org/D9049
To: mlaurent, dfaure
Cc: apol, #frameworks
mwolff added a comment.
In https://phabricator.kde.org/D7966#148641, @dfaure wrote:
> Just to be sure, your unittest could also test the case of
setEditable(false).
What should it test then? if it's not editable, there is no line edit, and
thus no completion object?
REPOSITORY
This revision was automatically updated to reflect the committed changes.
Closed by commit R284:11cba47b8718: KComboBox: Return early when setting
editable to previous value (authored by mwolff).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D7967?vs=19858&id=23196#toc
REPOSITORY
R284
This revision was automatically updated to reflect the committed changes.
Closed by commit R284:cf2f5c72d9f3: KComboBox: Reuse the existing completion
object on new line edit (authored by mwolff).
REPOSITORY
R284 KCompletion
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7966?vs=1985
mwolff added a subscriber: dfaure.
mwolff added a comment.
right, but how do I unit test this properly? @dfaure?
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D7968
To: mwolff, apol
Cc: dfaure, broulik, apol, #frameworks
rjvbb added a comment.
> On the other hand, calling setBold(true) on a font called
"HandwriteCursive" _should_ select "HandwriteBoldCursive", even if the
styleName was intended to enforce a specific face. If Qt cannot fix this issue,
then we have to clear the styleName() at least for those f
Am 30.11.2017 um 21:21 schrieb Aleix Pol:
> Hi,
> Recently I put together some CI for Android, where some frameworks are
> being checked to _build_ for Android + ARM.
>
> Now there's many frameworks that can't be built at the moment, you can
> see them listed here:
> https://phabricator.kde.org/sou
christofg created this revision.
christofg added a project: KTextEditor.
Restricted Application added projects: Kate, Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
I have a little question related to migrating from QRegExp to
QRegularExpression in ktextedit
Hi,
Recently I put together some CI for Android, where some frameworks are
being checked to _build_ for Android + ARM.
Now there's many frameworks that can't be built at the moment, you can
see them listed here:
https://phabricator.kde.org/source/sysadmin-ci-tooling/browse/master/local-metadata/pr
apol created this revision.
apol added a reviewer: Frameworks.
REVISION SUMMARY
In KDE Frameworks projects (and some others) we have a metainfo.yaml file
that tells us which platforms it's supposed to work on. This is never
checked other than by maintainers.
This tool notifies us about a f
jtamate abandoned this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D9005
To: jtamate, #frameworks, dfaure
Cc: anthonyfieroni, elvisangelaccio
cfeck added a comment.
The patch also addresses the bug only for default fonts, but not
per-application fonts that write their settings to the appnamerc file.
REPOSITORY
R135 Integration for Qt applications in Plasma
REVISION DETAIL
https://phabricator.kde.org/D9070
To: rjvbb, #framewor
fvogt added a comment.
In https://phabricator.kde.org/D9070#173835, @rjvbb wrote:
> > IMO that's a feature though and is the expected behaviour. For
instance, if we change the default window title to be bold, users with
"windowTitle=Comic Sans" will also have a bold title.
>
> So h
cfeck added a reviewer: cfeck.
cfeck added a comment.
The config would work with removed styleName() for the cases where the
weight() and style() attributes are sufficient. The intention from Qt's side
was to uniquely identify fonts that cannot be selected by those two attributes.
Imagine a
rjvbb added a comment.
> IMO that's a feature though and is the expected behaviour. For instance,
if we change the default window title to be bold, users with "windowTitle=Comic
Sans" will also have a bold title.
So how would you "change the default window title to be bold" and more
i
anthonyfieroni added reviewers: Frameworks, davidedmundson, graesslin.
REPOSITORY
R135 Integration for Qt applications in Plasma
REVISION DETAIL
https://phabricator.kde.org/D9070
To: rjvbb, #frameworks, davidedmundson, graesslin
Cc: fvogt, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mo
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.7/8/
Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.7
Date of build:
Thu, 30 Nov 2017 18:37:33 +
Build duration:
7 min 6 sec and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/10/
Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.10
Date of build:
Thu, 30 Nov 2017 18:37:33 +
Build duration:
5 min 26 sec and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.7/70/
Project:
Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.7
Date of build:
Thu, 30 Nov 2017 18:37:33 +
Build duration:
3 min 4 sec and counting
JUnit Test
This revision was automatically updated to reflect the committed changes.
Closed by commit R244:5da7248517bc: Input validation of SubJobs (authored by
jtamate).
REPOSITORY
R244 KCoreAddons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9004?vs=23097&id=23183
REVISION DETAIL
https:
apol created this revision.
apol added reviewers: Plasma, Frameworks.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
In fact, if metadata.json is provided directly, that's all we need.
REPOSITORY
R290 KPacka
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.7/155/
Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7
Date of build:
Thu, 30 Nov 2017 15:52:02 +
Build duration:
16 min and counting
JUni
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/9/
Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
Date of build:
Thu, 30 Nov 2017 15:52:02 +
Build duration:
11 min and counting
JUnit Test
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.7/12/
Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.7
Date of build:
Thu, 30 Nov 2017 15:52:02 +
Build duration:
10 min and counting
JUnit Tests
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:fa3a3899258b: [AppletInterface] Emit change signals for
configurationRequired and -Reason (authored by broulik).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabri
mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D9066
To: broulik, #plasma, mart
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, a
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.7/154/
Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7
Date of build:
Thu, 30 Nov 2017 13:18:40 +
Build duration:
11 min and counting
JUni
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/8/
Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
Date of build:
Thu, 30 Nov 2017 13:18:41 +
Build duration:
10 min and counting
JUnit Test
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.7/11/
Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.7
Date of build:
Thu, 30 Nov 2017 13:18:41 +
Build duration:
9 min 45 sec and counting
JUnit
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.7/105/
Project:
Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7
Date of build:
Thu, 30 Nov 2017 13:10:02 +
Build duration:
15 min and counting
JUnit Tests
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:b6b81c67b310: Use setSize() instead of setProperty width
and height (authored by broulik).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9068?vs
broulik added a comment.
> I'm sure we'd done this already...
I replaced all method calls to `setWidth()` and `setHeight()` but not
instances where we went through `setProperty`
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D9068
To: broulik, #plasma,
davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.
I'm sure we'd done this already...
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D9068
To: broulik, #plasma, davidedmundson
Cc: davidedmu
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.7/6/
Project:
Frameworks ktexteditor kf5-qt5 SUSEQt5.7
Date of build:
Thu, 30 Nov 2017 13:05:17 +
Build duration:
11 min and counting
JUnit Tests
Name
broulik updated this revision to Diff 23173.
broulik added a comment.
- Restore accidentally removed comment
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9068?vs=23171&id=23173
REVISION DETAIL
https://phabricator.kde.org/D9068
AFFECTED FILES
broulik created this revision.
broulik added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
We know we have a `QQuickItem` so we can just use its methods directly and
then also u
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kconfig%20kf5-qt5%20FreeBSDQt5.7/40/
Project:
Frameworks kconfig kf5-qt5 FreeBSDQt5.7
Date of build:
Thu, 30 Nov 2017 12:36:35 +
Build duration:
35 min and counting
JUnit Tests
Name:
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.7/104/
Project:
Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7
Date of build:
Thu, 30 Nov 2017 12:36:00 +
Build duration:
33 min and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.7/5/
Project:
Frameworks ktexteditor kf5-qt5 SUSEQt5.7
Date of build:
Thu, 30 Nov 2017 12:36:00 +
Build duration:
29 min and counting
JUnit Tests
Name
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.10/5/
Project:
Frameworks ktexteditor kf5-qt5 SUSEQt5.10
Date of build:
Thu, 30 Nov 2017 12:36:00 +
Build duration:
18 min and counting
JUnit Tests
Na
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kconfig%20kf5-qt5%20SUSEQt5.7/3/
Project:
Frameworks kconfig kf5-qt5 SUSEQt5.7
Date of build:
Thu, 30 Nov 2017 12:36:35 +
Build duration:
10 min and counting
JUnit Tests
Name: (root)
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kconfig%20kf5-qt5%20SUSEQt5.10/4/
Project:
Frameworks kconfig kf5-qt5 SUSEQt5.10
Date of build:
Thu, 30 Nov 2017 12:36:35 +
Build duration:
8 min 35 sec and counting
JUnit Tests
Name
broulik created this revision.
broulik added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
TEST PLAN
I now can react on that from the containment and show/hide a configure button
REPOSITORY
R2
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/14/
Project:
Frameworks kio kf5-qt5 SUSEQt5.7
Date of build:
Thu, 30 Nov 2017 10:10:45 +
Build duration:
10 min and counting
JUnit Tests
Name: (root) Failed
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/14/
Project:
Frameworks kio kf5-qt5 SUSEQt5.10
Date of build:
Thu, 30 Nov 2017 10:10:45 +
Build duration:
8 min 33 sec and counting
JUnit Tests
Name: (root
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.7/154/
Project:
Frameworks kio kf5-qt5 FreeBSDQt5.7
Date of build:
Thu, 30 Nov 2017 10:10:45 +
Build duration:
7 min 55 sec and counting
JUnit Tests
Name:
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:0bc40d7c8b71: [CopyJob] Don't start all over after
having removed a file (authored by broulik).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9054?vs=23143&id=23166
R
davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.
Concept is good.
INLINE COMMENTS
> colorscope.cpp:127
> }
> +m_lastGroup = m_group;
> return m_group;
It's weird to be caching in a public getter.
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20SUSEQt5.10/6/
Project:
Frameworks krunner kf5-qt5 SUSEQt5.10
Date of build:
Thu, 30 Nov 2017 08:09:34 +
Build duration:
3 min 34 sec and counting
JUnit Tests
Name
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20SUSEQt5.7/6/
Project:
Frameworks krunner kf5-qt5 SUSEQt5.7
Date of build:
Thu, 30 Nov 2017 08:09:34 +
Build duration:
2 min 30 sec and counting
JUnit Tests
Name:
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20FreeBSDQt5.7/39/
Project:
Frameworks krunner kf5-qt5 FreeBSDQt5.7
Date of build:
Thu, 30 Nov 2017 08:09:34 +
Build duration:
1 min 58 sec and counting
JUnit Tests
52 matches
Mail list logo
