D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

fabianr added a comment. Not really on topic, but could you change the label for the "Advanced options" to something more meaningful, eg "Terminal options" ? The HIG recommends not to use the label "Advanced options", but " Use a descriptive label so that it reflects the functionality. " RE

D8461: Remove unused config.h.cmake entries

davidk updated this revision to Diff 21277. davidk added a comment. Fix commit message. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8461?vs=21276&id=21277 BRANCH cleanup REVISION DETAIL https://phabricator.kde.org/D8461 AFFECTED FILES ConfigureChe

D8461: Remove unused config.h.cmake entries

davidk created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY I'm not sure why they were introduced, but they aren't used anywhere in the code. TEST PLAN - "grep -r HAVE_MALLOC_H baloo" - "grep

D7828: createKMessageBox tries to focus a default button when available

ngraham added a comment. In https://phabricator.kde.org/D7828#159556, @abetts wrote: > If you have two highlights, how do you know what's going to be activated when hitting enter? My thoughts exactly. REVISION DETAIL https://phabricator.kde.org/D7828 To: emateli, #frameworks,

D7194: Detach before setting the d pointer

kossebau added subscribers: whiting, kossebau. kossebau added a comment. @apol @whiting @leinir This change might have broken quite some things: EntryInternal has been an explicitly shared data object for some years (cmp. `QExplicitlySharedDataPointer d;`), and quite some logic seems to dep

D7828: createKMessageBox tries to focus a default button when available

abetts added a comment. I am leaning toward implementing the change. The reason being that the user gets a duplicate indication of focus when likely they might feel confused, I have been at times too, by not knowing clearly where the highlight is. If you have two highlights, how do you know

D7828: createKMessageBox tries to focus a default button when available

subdiff added a comment. Hi Emirald, first let me tell you that I totally get where you're coming from. To be honest the selected checkbox in this specific dialog of Dolphin has annoyed me already for a long time. So thank you for looking into this. But we have to dissect the situat

D8457: Don't build the kconfig_compiler tests when crosscompiling

apol created this revision. apol added a reviewer: Frameworks. Restricted Application added a project: Frameworks. REVISION SUMMARY We will be using an external version of it in practice REPOSITORY R237 KConfig BRANCH master REVISION DETAIL https://phabricator.kde.org/D8457 AFFECTED FI

D7828: createKMessageBox tries to focus a default button when available

ngraham added a comment. In https://phabricator.kde.org/D7828#159511, @aacid wrote: > > Without this patch, the *actual* default button is virtually indistinguishable from other buttons when it doesn't have focus. It looks like this, with only a slightly lighter background than the other

D8427: Allow cross compiling resource file

apol added a comment. Hey @vpinon. What's special about qrcAlias is that it's not installed. Usually this kind of tooling (thinking kconfigcompiler) is installed, then there's an easy way to pull it in. I'd say that the ideal way to treat this is by rewriting the tool in cmake scripts (

D7828: createKMessageBox tries to focus a default button when available

aacid added a comment. > You can't interact with the list so it is ruled out for being focused. The check box acts as a confirmation and thus is a secondary element which you also do not want to toggle by mistake, so it rests upon the buttons to have it. This makes some sense, but aren't

D7828: createKMessageBox tries to focus a default button when available

aacid added a comment. > Without this patch, the *actual* default button is virtually indistinguishable from other buttons when it doesn't have focus. It looks like this, with only a slightly lighter background than the other buttons: This is a bug of the breeze style, go fix it there.

D8437: KWidgetsAddons : more compact password dialog

kfunk requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D8437 To: rjvbb, #frameworks, kfunk Cc: cfeck, ngraham

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

simgunz added a comment. Ok. Now it should work properly. I've also added a tooltip to the search box to explain the down arrow feature so that it is not hidden. The current text is: "Type some text to filter the application tree.\nPress down arrow to navigate the results tree." REPOS

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

simgunz updated this revision to Diff 21261. simgunz added a comment. - Automatically select first match of the filter - ArrowDown on lineEdit pass focus to QTreeView - Add tooltip to explain how to use the search filter REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricato

D8427: Allow cross compiling resource file

vpinon added a comment. Note: if you want to see the rest of frameworks cross-building for Kdenlive: https://github.com/vpinon/mxe/tree/master/plugins/kdeframeworks REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D8427 To: vpinon, apol, kfunk Cc: #frameworks, b

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

simgunz added a comment. Here is a picture: F5448036: openwith_filter.png REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8056 To: simgunz, dfaure, #frameworks, #vdg, ngraham Cc: abetts, ngraham, alexeymin, #frameworks

D8427: Allow cross compiling resource file

vpinon added a comment. Thank you Aleix, You're right! //Before// launching cmake for cross compiling, I build the tool for host (this requires to have Qt5 dev files on build host): I haven't found a way to access the host compiler & libs //within// cmake (which has a toolchain file to

D8451: JavaScript: include standard mime types

ChALkeR edited the summary of this revision. ChALkeR added a reviewer: Framework: Syntax Highlighting. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D8451 To: ChALkeR, #framework_syntax_highlighting Cc: #frameworks

D8451: JavaScript: include standard mime types

ChALkeR created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Add application/javascript and text/javascript mimetypes to javascript.xml application/javascript is the main one used in shared-mime-

D8434: Created 'shared' section

mlaurent added a comment. +1 for me :) But I am not the maintainer :) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8434 To: renatoo, ngraham, #frameworks, #dolphin Cc: mlaurent, #frameworks

D8367: Hidding place groups implementation in KFilePlacesModel

renatoo added a comment. Pleas unit test "hiddenCount" when groups are invisible, it is used by the view in https://phabricator.kde.org/D8450 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8367 To: franckarrecot, renatoo, mlaurent, ngraham Cc: ngraham, mlaurent, #frame

D8367: Hidding place groups implementation in KFilePlacesModel

renatoo added inline comments. INLINE COMMENTS > kfileplacesmodel.cpp:257 > > bool KFilePlacesModel::isHidden(const QModelIndex &index) const > { should this check if the group which the index belongs is hider or not? Something like: return (data(index, HiddenRole).toBool() || isPlaceGro

D8450: WIP: User can now hide an entire places group

franckarrecot updated this revision to Diff 21244. franckarrecot added a comment. - REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8450?vs=21242&id=21244 REVISION DETAIL https://phabricator.kde.org/D8450 AFFECTED FILES src/filewidgets/kfileplacesmodel.cpp

D8367: Hidding place groups implementation in KFilePlacesModel

franckarrecot updated this revision to Diff 21243. franckarrecot added a comment. adding more services from model usefull to views REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8367?vs=21177&id=21243 REVISION DETAIL https://phabricator.kde.org/D8367 AFFECT

D8450: WIP: User can now hide an entire places group

franckarrecot created this revision. franckarrecot added reviewers: ngraham, renatoo, mlaurent. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Through the ui the user can now right click on a place group and request t

D8437: KWidgetsAddons : more compact password dialog

ngraham added a comment. Couple more changes, if you please: - Add the before-and-after screenshots to the Test Plan section so everyone who comes here sees them - Add "BUG: 381231" on its own line in the Summary section, which will make that bug get automatically closed once this is l

D8437: KWidgetsAddons : more compact password dialog

ngraham added a comment. Yeah, could you remove that and any other uynnecessary lines, so we have the bare minimum set of changes necessary to improve this? REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D8437 To: rjvbb, #frameworks Cc: cfeck, ngraham

D7828: createKMessageBox tries to focus a default button when available

ngraham added a reviewer: VDG. REVISION DETAIL https://phabricator.kde.org/D7828 To: emateli, #frameworks, ngraham, aacid, #vdg Cc: ngraham, aacid, #frameworks

D8445: [PlasmaComponents Menu] Add ungrabMouseHack

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. I was under the impression this hack was only needed when used on a window that doesn't take focus. (https://bugreports.qt.io/browse/QTBUG-59044?focusedCommentId=354424&p

D8434: Created 'shared' section

renatoo marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8434 To: renatoo, ngraham, #frameworks, #dolphin Cc: mlaurent, #frameworks

D8434: Created 'shared' section

renatoo updated this revision to Diff 21238. renatoo added a comment. Used QLatin1String for static strings REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8434?vs=21229&id=21238 REVISION DETAIL https://phabricator.kde.org/D8434 AFFECTED FILES autotests/kf

D8434: Created 'shared' section

mlaurent added inline comments. INLINE COMMENTS > kfileplacesitem.cpp:168 > +if (protocol == QLatin1String("remote") || > +KProtocolInfo::protocolClass(protocol) != ":local") { > +return NetworkType; != QLatin1String(":local") REPOSITORY R241 KIO REVISION DETA

D8445: [PlasmaComponents Menu] Add ungrabMouseHack

broulik created this revision. broulik added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY Ensures the PlasmaComponents.Menu doesn't confuse MouseArea states. TEST PLAN Put a

Re: Python bindings using cppyy (was: An update on Python bindings)

Hi all, I have a preliminary version of the Cppyy bindings generator CMake support available here: https://bitbucket.org/wlav/cppyy-backend/pull-requests/6/an-interim-experimental-version-of-a/diff There are some TODOs yet to be addressed, but I would appreciate feedback on how easy it woul

D8243: Implement support for categories on KfilesPlacesView

renatoo marked 2 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8243 To: renatoo, #frameworks, dfaure, ervin, #vdg Cc: markg, ngraham, mlaurent, ervin, anthonyfieroni, cfeck, #frameworks

D8434: Created 'shared' section

renatoo updated this revision to Diff 21229. renatoo added a comment. Updated parent branch REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8434?vs=21176&id=21229 REVISION DETAIL https://phabricator.kde.org/D8434 AFFECTED FILES autotests/kfileplacesmodelte

D8332: Added baloo urls into places model

renatoo updated this revision to Diff 21227. renatoo added a comment. Upated parent branch REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8332?vs=20952&id=21227 REVISION DETAIL https://phabricator.kde.org/D8332 AFFECTED FILES autotests/kfileplacesmodeltes

D8348: Add a section for removable devices

renatoo updated this revision to Diff 21228. renatoo added a comment. Updated parent branch REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8348?vs=21003&id=21228 REVISION DETAIL https://phabricator.kde.org/D8348 AFFECTED FILES autotests/kfileplacesmodelte

D8243: Implement support for categories on KfilesPlacesView

renatoo updated this revision to Diff 21226. renatoo added a comment. Fixed typo REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8243?vs=20951&id=21226 REVISION DETAIL https://phabricator.kde.org/D8243 AFFECTED FILES autotests/kfileplacesmodeltest.cpp sr

D8436: use a single QML engine

mart edited the test plan for this revision. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D8436 To: mart, #plasma Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8436: use a single QML engine

mart added a comment. In https://phabricator.kde.org/D8436#159212, @davidedmundson wrote: > Given the fallout we had when we made the similar change in Plasma, please don't merge until the start of the next release cycle. after november first week release? ok > Can you expand

D8436: use a single QML engine

davidedmundson added a comment. Given the fallout we had when we made the similar change in Plasma, please don't merge until the start of the next release cycle. Can you expand your "normal system settings seems unaffected" into something more thorough with a list of the relevant KCMs.

D8436: use a single QML engine

mart added inline comments. INLINE COMMENTS > davidedmundson wrote in configmodule.cpp:106 > !! this version now should work, as the context is used now: the way the static attached property function finds it is quite an heuristic, but should be 100% reliable REPOSITOR

D8436: use a single QML engine

mart updated this revision to Diff 21223. mart added a comment. - use the qmlobject's rootcontext instead of the engine as is now shared REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8436?vs=21184&id=21223 BRANCH arcpatch-D8436 REVISION DETAIL h

D8436: use a single QML engine

mart updated this revision to Diff 21224. mart added a comment. - use the qmlobject's rootcontext instead of the engine as is now shared REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8436?vs=21223&id=21224 BRANCH arcpatch-D8436 REVISION DETAIL h

D8402: Support "domain-suffix-match" in Security8021xSetting

Martchus added a task: T7232: Allow specifying domain in plasma-nm Wi-Fi security settings. REPOSITORY R282 NetworkManagerQt REVISION DETAIL https://phabricator.kde.org/D8402 To: Martchus, #plasma, jgrulich Cc: jgrulich, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohame

D8402: Support "domain-suffix-match" in Security8021xSetting

This revision was automatically updated to reflect the committed changes. Closed by commit R282:7491ed93c8cb: Support "domain-suffix-match" in Security8021xSetting (authored by jgrulich). REPOSITORY R282 NetworkManagerQt CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8402?vs=21153&id

D8402: Support "domain-suffix-match" in Security8021xSetting

Martchus added a comment. I don't have commit access so somebody needs to merge this for me. REPOSITORY R282 NetworkManagerQt REVISION DETAIL https://phabricator.kde.org/D8402 To: Martchus, #plasma, jgrulich Cc: jgrulich, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mo

D7828: createKMessageBox tries to focus a default button when available

emateli added a comment. @aacid the issue at hand is that in this particular scenario the default button more or less equals to the one that has focus. There are only 3 types of widgets that can be created here: buttons, a list or a check box. You can't interact with the list so it

KDE CI: Frameworks kwindowsystem kf5-qt5 WindowsMSVCQt5.9 - Build # 12 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20WindowsMSVCQt5.9/12/ Project: Frameworks kwindowsystem kf5-qt5 WindowsMSVCQt5.9 Date of build: Tue, 24 Oct 2017 07:45:17 + Build duration: 1 hr 9 min and counting

D7401: Solid/Mac : fleshing out the skeleton IOKit backend (WIP)

kfunk requested changes to this revision. kfunk added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > iokitdevice.cpp:307 > +default: > +vendor = QString(); > +break; Why not `return` here as well? For consistency. You can end the function w

KDE CI: Frameworks kglobalaccel kf5-qt5 WindowsMSVCQt5.9 - Build # 10 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kglobalaccel%20kf5-qt5%20WindowsMSVCQt5.9/10/ Project: Frameworks kglobalaccel kf5-qt5 WindowsMSVCQt5.9 Date of build: Tue, 24 Oct 2017 05:34:12 + Build duration: 3 hr 14 min and counting C

D8243: Implement support for categories on KfilesPlacesView

dfaure added inline comments. INLINE COMMENTS > kfileplacesview.cpp:1146 > + > +const int totlaItemsHeight = (fm.height() / 2) * rowCount; > +const int totoalSectionsHeight = delegate->sectionHeaderHeight() * > sectionsCount(); typo (total) > kfileplacesview.cpp:1147 > +const int t

KDE CI: Frameworks kwindowsystem kf5-qt5 XenialQt5.7 - Build # 36 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20XenialQt5.7/36/ Project: Frameworks kwindowsystem kf5-qt5 XenialQt5.7 Date of build: Tue, 24 Oct 2017 07:45:17 + Build duration: 8 min 16 sec and counting JUnit T

D7829: KKeyServer: fix handling of Meta+Shift+Print, Alt+Shift+arrowkey etc.

This revision was automatically updated to reflect the committed changes. Closed by commit R278:1a3b8539d3b5: KKeyServer: fix handling of Meta+Shift+Print, Alt+Shift+arrowkey etc. (authored by dfaure). REPOSITORY R278 KWindowSystem CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7829?

D8330: Open files in TagLib extractor readonly

davidk added reviewers: vhanda, cgiboudeaux, dfaure. davidk added a comment. Adding some devs who worked on kfilemetadata in the past. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D8330 To: davidk, #frameworks, vhanda, cgiboudeaux, dfaure Cc: mgallien, ngraha