turbov added a comment.
In https://phabricator.kde.org/D7245#146719, @dhaumann wrote:
> @turbov ping
pong...
I wanted to make some improvements...
And it would be nice to have some hint about how to add the mentioned tests...
REVISION DETAIL
https://phabricator.kde.org/D7245
ltoscano created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Definitely not needed. A bit less clutter before switching to
categorized logging.
TEST PLAN
Still compiles, and the debug output does
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20qqc2-desktop-style%20kf5-qt5%20XenialQt5.7/1/
Project:
Frameworks qqc2-desktop-style kf5-qt5 XenialQt5.7
Date of build:
Mon, 18 Sep 2017 19:12:02 +
Build duration:
1 min 29 sec and counting
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20qqc2-desktop-style%20kf5-qt5%20WindowsMSVCQt5.9/1/
Project:
Frameworks qqc2-desktop-style kf5-qt5 WindowsMSVCQt5.9
Date of build:
Mon, 18 Sep 2017 19:12:00 +
Build duration:
1 min 15 sec and count
graesslin added inline comments.
INLINE COMMENTS
> anthonyfieroni wrote in blur_interface.cpp:49
> I don't get that. So your patch is quite enough, treat this note as a noise :)
The cast method here is only called from callbacks. Wayland works by having a
global callback table where one just ge
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20qqc2-desktop-style%20kf5-qt5%20FreeBSDQt5.7/1/
Project:
Frameworks qqc2-desktop-style kf5-qt5 FreeBSDQt5.7
Date of build:
Mon, 18 Sep 2017 19:11:59 +
Build duration:
30 sec and counting
anthonyfieroni added inline comments.
INLINE COMMENTS
> davidedmundson wrote in blur_interface.cpp:49
> I'm not going to get a callback on a resource if the resource doesn't exist.
> (Libwayland would have already crashed if that happens)
>
> That's not what we're guarding against here.
I don'
graesslin accepted this revision.
graesslin added a comment.
This revision is now accepted and ready to land.
What surprises me is that BlurManager recreates for Output changes. That
sounds like a bug in KWin (or an area which could be improved).
REPOSITORY
R127 KWayland
BRANCH
globalref
davidedmundson marked 2 inline comments as done.
davidedmundson added inline comments.
INLINE COMMENTS
> anthonyfieroni wrote in blur_interface.cpp:49
> QPointer itself can determine that resource is deleted but QPointer* acts
> like every normal pointer e.g. it can be dangling. So if unbind is
anthonyfieroni added inline comments.
INLINE COMMENTS
> blur_interface.cpp:49
> static Private *cast(wl_resource *r) {
> -return reinterpret_cast(wl_resource_get_user_data(r));
> +auto blurManager =
> reinterpret_cast*>(wl_resource_get_user_data(r))->data();
> +if (b
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:aafd891ada94: Let qmake highlighting win over Prolog for
.pro files (authored by dhaumann).
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7872?vs=19647
vkrause accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D7872
To: dhaumann, vkrause
Cc: #frameworks
dhaumann created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
See bug: https://bugs.kde.org/show_bug.cgi?id=383349
TEST PLAN
make test
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https:
dhaumann requested changes to this revision.
dhaumann added a comment.
This revision now requires changes to proceed.
I think the patch makes sense, but I would prefer using a Qt function
qPopulationCount to count the bits instead of doing own bitmask magic. Could
you provide an updated patch
davidedmundson updated this revision to Diff 19645.
davidedmundson added a comment.
Restricted Application edited projects, added Plasma; removed Plasma on Wayland.
Mem leak in test
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7870?vs=19644&id=19645
BRA
dhaumann requested changes to this revision.
dhaumann added a comment.
This revision now requires changes to proceed.
I think one further revision would be helpful, then the patch should be good
to go in.
INLINE COMMENTS
> navigationconfigwidget.ui:138
> +
> + When selected,
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added projects: Plasma on Wayland, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
There is a race condition in the following situation:
- S
dhaumann added a comment.
@turbov ping
REVISION DETAIL
https://phabricator.kde.org/D7245
To: turbov, #kate, #framework_syntax_highlighting, dhaumann
Cc: cullmann, dhaumann, #frameworks
dhaumann added a comment.
@koichia For me, the unit tests pass. And it's also green on
https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20XenialQt5.7/97/
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D7861
To: koichia, dhaumann
Cc: d
dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.
Thanks, closed with
https://cgit.kde.org/syntax-highlighting.git/commit/?id=2d5ee5629eb9638a56bae56e9210d5757fb7bafe
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://pha
dhaumann closed this revision.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D7861
To: koichia, dhaumann
Cc: dhaumann, #frameworks, cullmann, vkrause
Git commit 62b8e461f2e5979180e1753651cc34dc5f3eb3b7 by Luca Beltrame.
Committed on 18/09/2017 at 13:39.
Pushed by lbeltrame into branch 'master'.
Relicense to LGPL2.1+ (part 2)
Permission granted by the author (Martin Klapetek)
CCMAIL: martin.klape...@gmail.com
CCMAIL: kde-frameworks-devel@kde.o
In data lunedì 18 settembre 2017 15:32:16 CEST, Martin Klapetek ha scritto:
> Absolutely, I hereby give you the permission to relicense those files to
> LGPL2.1+.
> CC'ing frameworks devel to retain a public record of that.
Thanks a lot!
--
Luca Beltrame - KDE Forums team
KDE Science supporter
Hey Luca,
On Mon, Sep 18, 2017 at 9:09 AM, Luca Beltrame wrote:
> Hello Martin,
>
> In kdeclarative, there are 3 files which bear your authorship:
>
> kdeclarative/src/calendarevents/calendareventsplugin.cpp
> kdeclarative/src/calendarevents/calendareventsplugin.h
> kdeclarative/src/
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20XenialQt5.7/108/
Project:
Frameworks plasma-framework kf5-qt5 XenialQt5.7
Date of build:
Mon, 18 Sep 2017 13:14:14 +
Build duration:
9 min 28 sec and counting
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.7/112/
Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7
Date of build:
Mon, 18 Sep 2017 13:14:14 +
Build duration:
5 min 19 sec and counting
Git commit db3bc821814117d765acec2d773ca6a1a40fddcd by Luca Beltrame.
Committed on 18/09/2017 at 13:03.
Pushed by lbeltrame into branch 'master'.
Relicense some files to LGPL2.1+
This has been done with approval from the original authors (including
myself).
Some are still GPL-2.0. I will contact
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/82/
Project:
Frameworks kirigami kf5-qt5 XenialQt5.7
Date of build:
Mon, 18 Sep 2017 11:41:32 +
Build duration:
4 min 29 sec and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/78/
Project:
Frameworks kirigami kf5-qt5 FreeBSDQt5.7
Date of build:
Mon, 18 Sep 2017 11:41:32 +
Build duration:
1 min 55 sec and counting
JUnit Tests
koichia updated this revision to Diff 19632.
koichia added a comment.
Hi,
I updated the patch.
However, some errors happen in clojure's test.
These errors also happened in the previous revision.
Start 1: appstreamtest
1/9 Test #1: appstreamtest
mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7819
To: davidedmundson, #plasma, #vdg, mart
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, a
gszymaszek updated this revision to Diff 19631.
gszymaszek added a comment.
- Removed JavaScript code blocks in Markdown support since it didn’t work
- Added test cases for new code blocks in Markdown
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.
32 matches
Mail list logo
