D6376: Fix double delete crash during shutdown

cullmann abandoned this revision. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D6376 To: cullmann, #frameworks Cc: aacid, mpyne, rjvbb

D6376: Fix double delete crash during shutdown

cullmann added a comment. Hi, if you can arrive twice for the same mediaobject in finishNotification e.g. via close and onAudioFinished you might insert it twice and delete it twice. If not, this change helps nothing. Unfortunately I have no way to reproduce. We can just disca

D6376: Fix double delete crash during shutdown

aacid added a comment. I've had a look at the code and honestly i don't see how this can fix anything. Do you have a reproduceable testcase for the crash? REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D6376 To: cullmann, #frameworks Cc: aacid, mpyne, rj

D6331: Make sure that the tsfiles target is generated

aacid requested changes to this revision. aacid added a comment. This revision now requires changes to proceed. In https://phabricator.kde.org/D6331#118513, @lueck wrote: > locale fr or uk build now, but without the script files beeing installed. > Looks like ./scripts/autogen.sh needs

D6376: Fix double delete crash during shutdown

cullmann added a comment. I don't speak about threading races. The whole class is not thread-safe, if threading occurs, all is lost. But I see the chance, that you arrive twice at the m_reusablePhonons.insert(m); line, as there are multiple ways into the function doing that, one e.g. vi

D6197: Add basic KAuth support to file ioslave

chinmoyr added a dependent revision: D6383: Add KAuth support to KIO's symlink operation. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D6197 To: chinmoyr, elvisangelaccio, #frameworks Cc: eliasp, aacid

D6198: Add KAuth support to delete operation

chinmoyr added a dependent revision: D6383: Add KAuth support to KIO's symlink operation. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D6198 To: chinmoyr, elvisangelaccio, #frameworks Cc: davidedmundson

D6383: Add KAuth support to KIO's symlink operation

chinmoyr edited the summary of this revision. chinmoyr added dependencies: D6198: Add KAuth support to delete operation, D6197: Add basic KAuth support to file ioslave. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D6383 To: chinmoyr, elvisangelaccio Cc: #frameworks

D6383: Add KAuth support to KIO's symlink operation

chinmoyr created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY This patch adds KAuth support to KIO's symlink operation TEST PLAN Tested using 'kioslavetest' in 'kio/tests'. REPOSITORY R241 KIO RE

D6376: Fix double delete crash during shutdown

rjvbb added a comment. In https://phabricator.kde.org/D6376#119376, @cullmann wrote: > Next try ;=) > Question is, can really such a race happen, that finishNotification triggers duplicate insertion? Do you see any other explanation why a crash could occur under qDeleteAll, on

D6381: Add KAuth support to rename file operation.

chinmoyr removed a reviewer: elvisangelaccio. chinmoyr added a subscriber: elvisangelaccio. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D6381 To: chinmoyr Cc: elvisangelaccio, #frameworks

D6381: Add KAuth support to rename file operation.

chinmoyr created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY This patch adds KAuth support to the 'rename' method in KIO's file ioslave. TEST PLAN 'kioslavetest' can be used to test this change. RE

D6277: Emit errors when keditbookmarks is missing

This revision was automatically updated to reflect the committed changes. Closed by commit R294:8fb63b082cdd: Emit errors when keditbookmarks is missing (authored by valeriymalov, committed by aacid). REPOSITORY R294 KBookmarks CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6277?vs=1

D6376: Fix double delete crash during shutdown

mpyne added a comment. In https://phabricator.kde.org/D6376#119359, @rjvbb wrote: > But what's the official stance on deleting objects (widgets) that have a parent and are thus capable of auto-cleanup? AFAIK one can still delete them explicitly, and if they're reparented during that proc

D6233: KKeyServer: fix handling of KeypadModifier.

dfaure added a comment. ping? REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D6233 To: dfaure, graesslin Cc: graesslin, #frameworks

D6376: Fix double delete crash during shutdown

cullmann added a comment. Next try ;=) Question is, can really such a race happen, that finishNotification triggers duplicate insertion? At least with a hash set, this won't lead to later issues. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D6376 To: cu

D6376: Fix double delete crash during shutdown

cullmann updated this revision to Diff 15850. cullmann edited the summary of this revision. REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6376?vs=15844&id=15850 REVISION DETAIL https://phabricator.kde.org/D6376 AFFECTED FILES src/notifybyaudio.cpp

D6376: Fix double delete crash during shutdown

cullmann added a comment. > Hmm, not really, I again just missed that the auto-delete will anyways only happen after the execution of ~NotifyByAudio, my patch just removes the earlier cleanup :/ REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D6376 To: cullma

D6376: Fix double delete crash during shutdown

rjvbb added a comment. > Hmm, not really Not really what? REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D6376 To: cullmann, #frameworks Cc: rjvbb

D6376: Fix double delete crash during shutdown

cullmann abandoned this revision. cullmann added a comment. Hmm, not really, I again just missed that the auto-delete will anyways only happen after the execution of ~NotifyByAudio, my patch just removes the earlier cleanup :/ REPOSITORY R289 KNotifications REVISION DETAIL https://phabr

D6376: Fix double delete crash during shutdown

rjvbb added a comment. A priori this should be fine, and it might even address the long standing bug by leaving more time for Phonon objects to "do their thing". It might be an idea though to include a `qCDebug()` probe that outputs the number of items left for auto-cleanup in `m_reusablePho

D6076: Do not depend on bash uncessarily, and do not validate icons by default.

This revision was automatically updated to reflect the committed changes. Closed by commit R266:c6a290a2e154: Do not depend on bash uncessarily, and do not validate icons by default. (authored by tcberner, committed by adridg). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D6076?vs=15820&

D6376: Fix double delete crash during shutdown

cullmann created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY See: https://bugs.kde.org/show_bug.cgi?id=380114 #6 0x028c3780 in ?? () #7 0x7fabbd75a4f6 in qDeleteAll::const_iterator> (end=..., begin=...) at /opt/local/include/qt5