apol created this revision.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
The path is the content, so it basically will set the same content as
filename. This change it to default to "data" in a case where I
identified it to be a problem, it could possibly be useful in
apol created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Ported away some classes, removes many unneeded casts that happen when
starting.
TEST PLAN
Tests still pass, plasma starts properly
thiago added a comment.
In https://phabricator.kde.org/D5972#112994, @rjvbb wrote:
> Yes, here too, haven't had time to read back up on and go through the whole
Qt code review process. What branch should I target, anyway?
5.9, with a possible backport to 5.6. There's still time fo
rjvbb added a comment.
In https://phabricator.kde.org/D5972#112975, @thiago wrote:
> Makes sense to work around older versions of Qt without the fix.
>
> But it needs a fix. That is still pending.
Yes, here too, haven't had time to read back up on and go through the whole
Qt c
thiago added a comment.
Makes sense to work around older versions of Qt without the fix.
But it needs a fix. That is still pending.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D5972
To: rjvbb, #build_system, #frameworks, kfunk
Cc: thiago, #framewo
On Tue, May 30, 2017 at 4:10 PM, Luigi Toscano wrote:
> On Tuesday, 30 May 2017 16:06:56 CEST Harald Sitter wrote:
>> Is there a reason ECM's project is placed in kdesupport rather than
>> frameworks?
>>
>> https://cgit.kde.org/sysadmin/repo-metadata.git/tree/projects/kdesupport/ext
>> ra-cmake-mo
On Tuesday, 30 May 2017 16:06:56 CEST Harald Sitter wrote:
> Is there a reason ECM's project is placed in kdesupport rather than
> frameworks?
>
> https://cgit.kde.org/sysadmin/repo-metadata.git/tree/projects/kdesupport/ext
> ra-cmake-modules
>
> Seems a bit fishy at best and practically means th
Is there a reason ECM's project is placed in kdesupport rather than frameworks?
https://cgit.kde.org/sysadmin/repo-metadata.git/tree/projects/kdesupport/extra-cmake-modules
Seems a bit fishy at best and practically means that if ECM ever were
to get translations it wouldn't inherit the translatio
rjvbb edited the summary of this revision.
rjvbb edited the test plan for this revision.
rjvbb set the repository for this revision to R240 Extra CMake Modules.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D5865
To: rjvbb, #frameworks, #build_system, cgille
rjvbb updated this revision to Diff 14971.
rjvbb added a comment.
Updated as requested.
GIven the controversy I thought it might be useful to add at least a
target-specific enabler macro (which may need some polishing or simplification
- using generator expressions may not be required he
kfunk added a comment.
In https://phabricator.kde.org/D5865#112766, @rjvbb wrote:
> KDE is FOSS not bound to Microsoft by any corporate buy-in or whatever,
right?
What non-sense is this? Please stay on topic. There's a benefit we make sure
KDE software is compiling under MSVC giv
rjvbb edited the summary of this revision.
rjvbb added a reviewer: kfunk.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D5972
To: rjvbb, #build_system, #frameworks, kfunk
Cc: #frameworks, #build_system
rjvbb added a comment.
KDE is FOSS not bound to Microsoft by any corporate buy-in or whatever, right?
If there's a bug to report it's the lack of standard compliance in MSVC - how
have MS reacted to such reports?
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricato
BUILD UNSTABLE
Build URL
https://build-sandbox.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20XenialQt5.7/13/
Project:
Frameworks kcoreaddons kf5-qt5 XenialQt5.7
Date of build:
Tue, 30 May 2017 07:07:14 +
Build duration:
3 min 17 sec and counting
JUn
14 matches
Mail list logo
