D4799: Delay notifications until desktop session has loaded

This revision was automatically updated to reflect the committed changes. Closed by commit R289:2d40672b0c85: Do not remove queued notifications when the fd.o service starts. Also start the… (authored by vpilo). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde

D5136: Introduce fetch-translations build command

apol abandoned this revision. apol added a comment. On ECM https://phabricator.kde.org/D5143 REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D5136 To: apol, #frameworks, #build_system, sitter, kfunk, aacid Cc: ltoscano

D5143: Introduce fetch-translations build command

apol created this revision. Restricted Application added projects: Frameworks, Build System. REVISION SUMMARY Makes it possible to fetch translations when building the project. To do so it fetches kde:releaseme and uses the new fetchpo.rb program to download the translations into the build d

D5136: Introduce fetch-translations build command

ltoscano added a comment. I agree that it should go to ECM, and there are modules (for various reasons) with translations not handled by KI18n. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D5136 To: apol, #frameworks, #build_system, sitter, kfunk, aacid Cc: ltoscano

D5136: Introduce fetch-translations build command

apol added a comment. In https://phabricator.kde.org/D5136#96878, @aacid wrote: > I'm not sure addign a dependency for releaseme in ki18n is a good idea to be honest. > > This very "only works for KDE-based applications", a third-party using k18n has no interest in this at all. >

D5136: Introduce fetch-translations build command

kfunk added a comment. In https://phabricator.kde.org/D5136#96878, @aacid wrote: > I'm not sure addign a dependency for releaseme in ki18n is a good idea to be honest. > > This very "only works for KDE-based applications", a third-party using k18n has no interest in this at all. >

D5136: Introduce fetch-translations build command

aacid added a comment. I'm not sure addign a dependency for releaseme in ki18n is a good idea to be honest. This very "only works for KDE-based applications", a third-party using k18n has no interest in this at all. Maybe it would make more sense in some of the *KDE* files ECM has?

D5136: Introduce fetch-translations build command

apol updated this revision to Diff 12705. apol added a comment. Address some issues REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5136?vs=12698&id=12705 BRANCH master REVISION DETAIL https://phabricator.kde.org/D5136 AFFECTED FILES KF5I18nConfig.cma

D5136: Introduce fetch-translations build command

apol marked 2 inline comments as done. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D5136 To: apol, #frameworks, #build_system, aacid, sitter, kfunk

D5138: Fill UDS_CREATION_TIME with the value of st_birthtime on FreeBSD

tcberner added a comment. F3114620: dolphin2.png REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D5138 To: tcberner, adridg, arrowdodger, rakuco, dfaure Cc: #frameworks

D5138: Fill UDS_CREATION_TIME with the value of st_birthtime on FreeBSD

tcberner added reviewers: rakuco, dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D5138 To: tcberner, adridg, arrowdodger, rakuco, dfaure Cc: #frameworks

D5138: Fill UDS_CREATION_TIME with the value of st_birthtime on FreeBSD

tcberner created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY It seems UDS_CREATION_TIME is never filled at all (as far as I could find in the short time I invested :D ). From the manpage:

D5138: Fill UDS_CREATION_TIME with the value of st_birthtime on FreeBSD

tcberner added reviewers: adridg, arrowdodger. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D5138 To: tcberner, adridg, arrowdodger Cc: #frameworks

D5134: Don't exit if $DISPLAY is not set

graesslin requested changes to this revision. graesslin added a comment. This revision now requires changes to proceed. As I stumbled over that years ago: sorry I don't think that this is the proper solution. This is basically https://phabricator.kde.org/T4431 which is not yet implemented. Wh

D5136: Introduce fetch-translations build command

kfunk added inline comments. INLINE COMMENTS > KF5I18nConfig.cmake.in:12 > + > +execute_process(COMMAND git config --get remote.origin.url > +OUTPUT_VARIABLE reponame Can you delay that git invocation to when the custom target is executed? Otherwise we also pay for this whenever `KF5I18nCon

D5136: Introduce fetch-translations build command

kfunk requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D5136 To: apol, #frameworks, #build_system, aacid, sitter, kfunk

D5133: Introduce fetchpo.rb

This revision was automatically updated to reflect the committed changes. Closed by commit R572:474c8704ce76: Introduce fetchpo.rb (authored by apol). REPOSITORY R572 releaseme CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5133?vs=12696&id=12699 REVISION DETAIL https://phabricator

D5136: Introduce fetch-translations build command

apol added a dependency: D5133: Introduce fetchpo.rb. apol added a comment. FWIW, depends on https://phabricator.kde.org/D5133 REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D5136 To: apol, #frameworks, #build_system, aacid, sitter, kfunk

D5133: Introduce fetchpo.rb

sitter accepted this revision. This revision is now accepted and ready to land. REPOSITORY R572 releaseme BRANCH master REVISION DETAIL https://phabricator.kde.org/D5133 To: apol, #frameworks, sitter

D5133: Introduce fetchpo.rb

apol added a dependent revision: D5136: Introduce fetch-translations build command. REPOSITORY R572 releaseme BRANCH master REVISION DETAIL https://phabricator.kde.org/D5133 To: apol, #frameworks, sitter

D5136: Introduce fetch-translations build command

apol created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY Makes it possible to fetch translations when building the project. To do so it fetches kde:releaseme and uses the new fetchpo.rb program to download the translations into the build directory.

D5133: Introduce fetchpo.rb

apol updated this revision to Diff 12696. apol added a comment. Address issue, use git.kde.org repo name as identifier REPOSITORY R572 releaseme CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5133?vs=12695&id=12696 BRANCH master REVISION DETAIL https://phabricator.kde.org/D5

D5133: Introduce fetchpo.rb

sitter requested changes to this revision. sitter added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > l10n.rb:217 > > -def get(srcdir) > - # FIXME: this is later used as destination for the weirdest of > reasons... > - target = "#{srcdir}/po/"

D5133: Introduce fetchpo.rb

apol updated this revision to Diff 12695. apol added a comment. Address sitter concerns REPOSITORY R572 releaseme CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5133?vs=12693&id=12695 BRANCH master REVISION DETAIL https://phabricator.kde.org/D5133 AFFECTED FILES fetchpo.r

Re: Review Request 129983: [RFC] PoC patch for polkit support in kio.

> On March 22, 2017, 10:08 a.m., Elvis Angelaccio wrote: > > src/ioslaves/file/kauth/file.actions, lines 1-5 > > > > > > I don't see the advantage of using a single kauth action. This way you > > are generating on

D5133: Introduce fetchpo.rb

sitter requested changes to this revision. sitter added a comment. This revision now requires changes to proceed. I really think this should have a simple test case. In particular, the allow_edit behavior should be asserted somewhere. Also some style nitpicks. INLINE COMMENTS > fetchpo.rb:52

D5134: Don't exit if $DISPLAY is not set

aacid created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY The fact that kinit was build with X11 doesn't mean it will be using X11 at runtime REPOSITORY R303 KInit BRANCH master REVISION DETAIL

D5133: Introduce fetchpo.rb

apol created this revision. REVISION SUMMARY Adds an executable that will allow to retrieve translations for a checked out project. TEST PLAN tests still pass REPOSITORY R572 releaseme BRANCH master REVISION DETAIL https://phabricator.kde.org/D5133 AFFECTED FILES fetchpo.rb li

D4799: Delay notifications until desktop session has loaded

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D4799 To: vpilo, #plasma, #plasma_workspaces, davidedmundson, dfaure, broulik, graesslin, mck182 Cc: plasma-devel, davidedmundso

D4799: Delay notifications until desktop session has loaded

vpilo added a comment. Ping [my excuses if it's not good practice to do so] REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D4799 To: vpilo, #plasma, #plasma_workspaces, davidedmundson, dfaure, broulik, graesslin, mck182 Cc: plasma-devel, davidedmundson,

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 380 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/380/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Wed, 22 Mar 2017 13:12:01 + Build duration: 2 min 25 sec CHANGE SET Revision

D4921: [Menu] Harmonize openRelative placement

This revision was automatically updated to reflect the committed changes. Closed by commit R242:28ad7879d3e6: [Menu] Harmonize openRelative placement (authored by subdiff). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4921?vs=12126&id=1268

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 379 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/379/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Wed, 22 Mar 2017 10:21:51 + Build duration: 3 min 3 sec CHANGE SET Revision 28

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 379 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/379/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Wed, 22 Mar 2017 10:21:51 + Build duration: 3 min 3 sec CHANGE SET Revision 28

Re: Review Request 129983: [RFC] PoC patch for polkit support in kio.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129983/#review102932 --- src/ioslaves/file/kauth/file.actions (lines 1 - 5)